Re: getcwd infinite recursion

2007-10-15 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > Applying the appended patch and proposing this additional patch. > Paul, Jim, what do you think of this? Thanks for doing that. It looks good to me.

Re: stdint generation

2007-10-15 Thread Benoit SIGOURE
On Oct 15, 2007, at 10:28 PM, Bruno Haible wrote: Sam Steingold wrote: gnulib-tool --import --source-base=src/gllib --m4-base=src/glm4 \ --aux-dir=src/build-aux --no-changelog \ stdint stdbool ... This will create a Makefile.am in src/gllib; there

Re: getcwd infinite recursion

2007-10-15 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Colin Watson wrote: >> I was trying to prepare a test case for you, but I find that now I >> cannot reproduce the problem, either with VPATH or non-VPATH builds! It >> seems there must have been some junk lying around in my tree after all, > ... >> >> ht

Re: incompatible licenses

2007-10-15 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > I propose to change the license terms of individual modules as follows: > - absolute-header: LGPL -> LGPLv2+ > - malloc-posix, realloc-posix: LGPL -> LGPLv2+ > - intprops: GPL -> LGPL Yes, those are all fine with me.

Re: 0 vs. NULL

2007-10-15 Thread Micah Cowan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Paul Eggert wrote: > Bruno Haible <[EMAIL PROTECTED]> writes: > >> Compilers such as Sun C++ really define NULL to 0 >> (in both C and C++ mode!), and misinterpret NULL in varargs and sizeof. > > The problem with varargs is one that has bitten me p

Re: 0 vs. NULL

2007-10-15 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > Compilers such as Sun C++ really define NULL to 0 > (in both C and C++ mode!), and misinterpret NULL in varargs and sizeof. The problem with varargs is one that has bitten me personally. Ouch! But "sizeof (NULL)" is a new one on me. As near as I can m

Re: new module iconv_open-utf

2007-10-15 Thread Ludovic Courtès
Hi, Bruno Haible <[EMAIL PROTECTED]> writes: > Yes, it is clear what you mean. But adding a new API for a thing that > mem_cd_iconveh should be able to do, just because there is a portability > problem, is against gnulib's general approach. In gnulib we solve this > by fixing the portability prob

Re: getcwd infinite recursion

2007-10-15 Thread Bruno Haible
Ralf Wildenhues wrote: > > To me, it looks like AM_CPPFLAGS is empty by default. Automake's default > > includes are in a separate variable called DEFAULT_INCLUDES. > > Only if you've used nostdinc (`info Automake "Program variables"'): > > | `AM_CPPFLAGS' Then the doc of AM_CPPFLAGS is misunde

Re: getcwd infinite recursion

2007-10-15 Thread Bruno Haible
Colin Watson wrote: > I was trying to prepare a test case for you, but I find that now I > cannot reproduce the problem, either with VPATH or non-VPATH builds! It > seems there must have been some junk lying around in my tree after all, ... > > http://people.debian.org/~cjwatson/tmp/man-db-gnuli

Re: stdint generation

2007-10-15 Thread Bruno Haible
Sam Steingold wrote: > > gnulib-tool --import --source-base=src/gllib --m4-base=src/glm4 \ > >--aux-dir=src/build-aux --no-changelog \ > >stdint stdbool ... > > do I need to do this before each release? It's a good idea to do it, say, two weeks be

Re: stdint generation

2007-10-15 Thread Bruno Haible
Sam Steingold wrote: > gnulib/gnulib/m4/stdint offers a multi-line sed rule for generating > stdint.h from stdint_.h, > why do I need to maintain the sed command by hand? > why can't this be done by config.status? Two answers: Regarding the integration in GNU clisp: Since 2004, when gnulib took

Re: fix cache variable name in iconv_open

2007-10-15 Thread Ralf Wildenhues
* Bruno Haible wrote on Mon, Oct 15, 2007 at 08:16:39PM CEST: > Ralf, > > > OK to apply? > > Yes, please apply. Thanks, done. I also updated the #serial. > > Autoconf 2.62 will warn for this omission. > > Is this the only warning that appears when you run "gnulib-tool > --create-testdir"? Y

incompatible licenses

2007-10-15 Thread Bruno Haible
Hi, When doing a "gnulib-tool --create-testdir" of all modules, I get these warnings: warning: module argp depends on a module with an incompatible license: dirname warning: module argp depends on a module with an incompatible license: exit warning: module argp depends on a module with an incomp

Re: Test for getaddrinfo() broken on Tru64 UNIX 5.1

2007-10-15 Thread Bruno Haible
Ben Pfaff wrote: > For what it's worth, is a smaller header that also > defines NULL. You're right. Better use . 2007-10-15 Bruno Haible <[EMAIL PROTECTED]> * m4/getaddrinfo.m4 (gl_GETADDRINFO, gl_PREREQ_GETADDRINFO): Use instead of since we only need NULL. Reported

Re: fix cache variable name in iconv_open

2007-10-15 Thread Bruno Haible
Ralf, > OK to apply? Yes, please apply. > Autoconf 2.62 will warn for this omission. Is this the only warning that appears when you run "gnulib-tool --create-testdir"? Bruno

Re: gplv3 files and updates

2007-10-15 Thread Bruno Haible
Brett, > an LGPLed project was using gnulib files > without changing the license headers, and so this person was concerned that > they might be bound by the GPL instead Is this project using gnulib-tool? If yes, did they pass the option --lgpl to gnulib-tool? Bruno

fix cache variable name in iconv_open

2007-10-15 Thread Ralf Wildenhues
Hello Bruno, all, OK to apply? Autoconf 2.62 will warn for this omission. Cheers, Ralf * m4/iconv_open (gl_FUNC_ICONV_OPEN_UTF): Fix cache variable name. diff --git a/m4/iconv_open.m4 b/m4/iconv_open.m4 index 4bfcd41..189047a 100644 --- a/m4/iconv_open.m4 +++ b/m4/iconv_open.m4 @@ -56,7 +5

gnulib as a git submodule [Re: gplv3 files and updates

2007-10-15 Thread Jim Meyering
Brett Smith <[EMAIL PROTECTED]> wrote: ... > If the solution has already been implemented and the problem this user > stumbled upon is historical cruft, then that's great; I just wanted to > check. [Brett, this doesn't address the copyright issue. I'm hoping the "License" section in README is su

Re: gplv3 files and updates

2007-10-15 Thread Paul Eggert
Brett Smith <[EMAIL PROTECTED]> writes: > there wasn't any gnulib documentation or other information in the > project tarball to suggest otherwise, after all. The gnulib README file says the following. If this isn't clear enough, perhaps you or your correspondent could suggest a clearer wording?

Re: LIBOBJS warning in documentation no longer required?

2007-10-15 Thread Ralf Wildenhues
While typo-fixing... * Benoit SIGOURE wrote on Mon, Oct 15, 2007 at 06:03:03PM CEST: >> --- 239,252 >> @samp{_GNU_SOURCE} may be ineffective, or may have only a limited >> effect, if defined after the first system header file is included. >> >> ! Finally, note that you can not use @code{A

Re: LIBOBJS warning in documentation no longer required?

2007-10-15 Thread Benoit SIGOURE
On Oct 15, 2007, at 3:52 PM, Bruno Haible wrote: Colin Watson wrote: Should this paragraph be removed from the documentation, and perhaps be replaced Yes, this is old doc. I'm replacing it like this: 2007-10-15 Bruno Haible <[EMAIL PROTECTED]> * doc/gnulib-tool.texi (Initial imp

stdint generation

2007-10-15 Thread Sam Steingold
gnulib/gnulib/m4/stdint offers a multi-line sed rule for generating stdint.h from stdint_.h, why do I need to maintain the sed command by hand? why can't this be done by config.status? the same issue with stdbool...

Re: gplv3 files and updates

2007-10-15 Thread Brett Smith
On Mon, Jul 16, 2007 at 09:00:32AM +0200, Jim Meyering wrote: > > importing gnulib), see [1]. Look at the variable 'gnulib_version': If you > > set > > it to a date in the past, you eliminate this sort of trouble. And if you > > set it to 'HEAD', you track all changes like you currently do. If the

Re: Test for getaddrinfo() broken on Tru64 UNIX 5.1

2007-10-15 Thread Ben Pfaff
Bruno Haible <[EMAIL PROTECTED]> writes: > Hmm. How about making sure that NULL is actually defined, before using it? > Proposed patch: [...] > + #include For what it's worth, is a smaller header that also defines NULL. -- "J'avais trouv'e ma religion : rien ne me parut plus important qu'un l

Re: LIBOBJS warning in documentation no longer required?

2007-10-15 Thread Bruno Haible
Colin Watson wrote: > Should this paragraph be removed from the documentation, and perhaps be > replaced Yes, this is old doc. I'm replacing it like this: 2007-10-15 Bruno Haible <[EMAIL PROTECTED]> * doc/gnulib-tool.texi (Initial import): Swap order of -I directives. Replace p

Compiler warning in glob

2007-10-15 Thread Colin Watson
gcc -DHAVE_CONFIG_H -I. -I../.. -g -O2 -Wall -W -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wshadow -MT glob.o -MD -MP -MF .deps/glob.Tpo -c -o glob.o glob.c glob.c: In function ‘glob_in_dir’: glob.c:1244: warning: declaration of ‘save’ shadows a previous local glob.c:1041: w

LIBOBJS warning in documentation no longer required?

2007-10-15 Thread Colin Watson
gnulib-tool.texi says: A final word of warning: Gnulib currently assumes it will be responsible for @emph{all} functions that end up in the Autoconf @code{@@LIBOBJS@@} variables (and/or @code{@@LTLIBOBJS@@} if using Libtool), e.g., those specified in @code{AC_REPLACE_FUNCS} in your @file

Re: Test for getaddrinfo() broken on Tru64 UNIX 5.1

2007-10-15 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon, > >> > So, the above should be fixed as well. >> >> Fixed, thanks. > > Hmm. How about making sure that NULL is actually defined, before using it? Thanks, please commit. /Simon

Re: Test for getaddrinfo() broken on Tru64 UNIX 5.1

2007-10-15 Thread Bruno Haible
Simon, > > So, the above should be fixed as well. > > Fixed, thanks. Hmm. How about making sure that NULL is actually defined, before using it? Proposed patch: *** m4/getaddrinfo.m4.orig 2007-10-15 12:33:54.0 +0200 --- m4/getaddrinfo.m4 2007-10-15 12:30:25.0 +0200 ***

Re: Conditional inclusion

2007-10-15 Thread Bruno Haible
Ralf Wildenhues wrote: > > if ENABLE_LIBWCRYPT > > SUBDIR_wcrypt = wcrypt > > else > > SUBDIR_wcrypt = > > endif > > SUBDIRS = gl $(SUBDIR_wcrypt) src doc po ... > > What's the problem with "make dist" here? It will recurse into wcrypt: > it uses $(D

Re: Test for getaddrinfo() broken on Tru64 UNIX 5.1

2007-10-15 Thread Simon Josefsson
Albert Chin <[EMAIL PROTECTED]> writes: > On Wed, Oct 13, 2007 at 16:25:21PM +0200, Bruno Haible wrote: >> I'm applying your patch, with modifications: >> ... >> 4) Don't use 0 to designate null pointers. That doesn't sit well with >> C++ compilers. > > I only used 0 because further down in

Re: Conditional inclusion

2007-10-15 Thread Simon Josefsson
Micah Cowan <[EMAIL PROTECTED]> writes: > If I've --import'ed md5, is there a means for me to specify in > configure.ac that it should not be included in certain circumstances? > > I'm in the process of converting portions of Wget to gnulib. We had > GNU's MD5 code in there, but only used it when

Re: getcwd infinite recursion

2007-10-15 Thread Colin Watson
On Sun, Oct 14, 2007 at 11:07:28PM +0200, Bruno Haible wrote: > Colin Watson wrote: > > I made this change and it now works correctly. > > Thanks for checking. That's important to know. > > How exactly did you invoke gnulib-tool? With or without a --makefile-name > option? Without. Also, I'm ins