Re: [bug-gnulib] Re: mmapping of /dev/zero always fails on darwin

2005-09-13 Thread Peter O'Gorman
Peter O'Gorman wrote: Looks like the cvs folks need to update their gnulib. Of course, they have done this, and I feel silly. Peter ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib

Re: [bug-gnulib] Re: mmapping of /dev/zero always fails on darwin

2005-09-13 Thread Peter O'Gorman
Bruno Haible wrote: Are you sure that this is what gnulib does? Darwin's defines MAP_ANON, then gnulib's m4/mmap-anon.m4 macro ought to add #define MAP_ANONYMOUS MAP_ANON #define HAVE_MAP_ANONYMOUS 1 to config.h, and then lib/pagealign_alloc.c should be doing mmap (NULL, 4096, PROT_READ |

Re: config.h inclusion

2005-09-13 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Would you accept a patch to change all of these to use > #ifdef HAVE_CONFIG_H > # include > #endif > > uniformly? That makes sense to me, yes. We should be consistent, and that's the majority usage. Also, no .h file should include config.h. This i

Re: AC_LIBSOURCES considered harmful

2005-09-13 Thread Gary V. Vaughan
Salut Alexandre! Alexandre Duret-Lutz wrote: "BH" == Bruno Haible <[EMAIL PROTECTED]> writes: > BH> Also, do you have an idea about the release date of automake-1.10? > > CVS Automake depends on CVS Autoconf. (No it doesn't depend on > CVS Libtool nor CVS M4.) So it could be released as so

Re: AC_LIBSOURCES considered harmful

2005-09-13 Thread Alexandre Duret-Lutz
>>> "BH" == Bruno Haible <[EMAIL PROTECTED]> writes: BH> Hi Jim, >> The problem you describe was more of an automake limitation, and >> it has been resolved by automake's addition of AC_CONFIG_LIBOBJ_DIR. BH> Interesting. But AC_CONFIG_LIBOBJ_DIR is documented just between BH> AC_CONFIG_AUX_

Re: gnulib update (Tue Sep 13 09:03:01 EDT 2005)

2005-09-13 Thread Jim Meyering
Derek Price <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >>Personally, I've found it useful enough to have consistently cpp-indented > > I like it too, but I was willing to go with the flow on GNULIB. :) > >>sources that I wrote cppi, and to use it in a commit-hook for the coreutils. > > I don

Re: gnulib update (Tue Sep 13 09:03:01 EDT 2005)

2005-09-13 Thread Derek Price
Jim Meyering wrote: >Personally, I've found it useful enough to have consistently cpp-indented > > I like it too, but I was willing to go with the flow on GNULIB. :) >sources that I wrote cppi, and to use it in a commit-hook for the coreutils. > > I don't know when it became an option, but

Re: gnulib update (Tue Sep 13 09:03:01 EDT 2005)

2005-09-13 Thread Jim Meyering
Derek Price <[EMAIL PROTECTED]> wrote: > Jim, all, > > Is there a GNULIB standard for this yet? Paul Eggert just went through > my glob_.h and tweaked the cpp spacing in the other direction. I > assumed at the time this meant that double-include protection should be > ignored for the purposes of

Preprocessor directives formatting

2005-09-13 Thread Stepan Kasal
Hello, On Tue, Sep 13, 2005 at 10:23:32AM -0400, Derek Price wrote: > [...] double-include protection should be ignored for the purposes of > indenting compiler directives in headers, ... > I would note that GNU indent doesn't currently support Paul's style. It > supports intentation of cpp direc

Re: config.h inclusion

2005-09-13 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Tue, Sep 13, 2005 at 03:55:33PM CEST: > > Right now, roughly 230 files in gnulib/lib include config.h. > 210 of those #include , the rest "config.h". > 10 of all of them are not guarded by HAVE_CONFIG_H, about half of the > others by `#ifdef HAVE_CONFIG_H', and half by `

Re: gnulib update (Tue Sep 13 09:03:01 EDT 2005)

2005-09-13 Thread Derek Price
Jim, all, Is there a GNULIB standard for this yet? Paul Eggert just went through my glob_.h and tweaked the cpp spacing in the other direction. I assumed at the time this meant that double-include protection should be ignored for the purposes of indenting compiler directives in headers, but Jim

config.h inclusion

2005-09-13 Thread Ralf Wildenhues
Hi there, Right now, roughly 230 files in gnulib/lib include config.h. 210 of those #include , the rest "config.h". 10 of all of them are not guarded by HAVE_CONFIG_H, about half of the others by `#ifdef HAVE_CONFIG_H', and half by `#if HAVE_CONFIG_H'. Would you accept a patch to change all of th

Re: [bug-gnulib] Re: mmapping of /dev/zero always fails on darwin

2005-09-13 Thread Derek Price
Peter O'Gorman wrote: > Peter O'Gorman wrote: > >> Looks like the cvs folks need to update their gnulib. > > > Of course, they have done this, and I feel silly. Yes, they have. :) That fix should be released with 1.12.13, which shouldn't be very far away. Regards, Derek -- Derek R. Price C

Re: canon-host errors

2005-09-13 Thread Derek Price
Jim Meyering wrote: >Derek Price <[EMAIL PROTECTED]> wrote: > > >>I've installed the attached patch. It is almost identical to my >>previous one, with a few extra portability and typo fixes. >> >>2005-09-12 Derek Price <[EMAIL PROTECTED]> >> >>* modules/canon-host: Add canon-host.h. Depe

gnulib-tool: don't ever forget to set $dry again

2005-09-13 Thread Ralf Wildenhues
This patch makes $dry_run obsolete in favor of using $dry only. This way, the repeated and error-prone setting of the latter is eliminated. No, I don't have assignment for gnulib yet, but I guess I'll make some papers ready soon. I do believe this is a rather trivial patch, though. If you disagr

Re: [bug-gnulib] Re: mmapping of /dev/zero always fails on darwin

2005-09-13 Thread Bruno Haible
Peter O'Gorman wrote: > Just doing the same thing as gnulib does will show the failure: > > int main(){ > void * address = NULL; > static int fd =-1; > int ret = 0; > fd = open ("/dev/zero",O_RDONLY,666); > ret = mmap (NULL, 4096, PROT_READ | PROT_WRITE,

Re: [bug-gnulib] mmapping of /dev/zero always fails on darwin

2005-09-13 Thread Bruno Haible
Peter O'Gorman wrote: > As you can see from this little snippet of gcc configure, you can't mmap > /dev/zero on darwin. > > AC_CACHE_CHECK([whether mmap from /dev/zero works], >gcc_cv_func_mmap_dev_zero, >[# Add a system to this blacklist if it has mmap() but /dev/zero > # does no

Re: canon-host errors

2005-09-13 Thread Jim Meyering
Derek Price <[EMAIL PROTECTED]> wrote: > I've installed the attached patch. It is almost identical to my > previous one, with a few extra portability and typo fixes. > > 2005-09-12 Derek Price <[EMAIL PROTECTED]> > > * modules/canon-host: Add canon-host.h. Depend on getaddrinfo. Make >

Re: small improvement to base64

2005-09-13 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Hi Simon, > > Please apply the tiny patch below to the base64 module to fix a typo and > to put the long constant string in the initialized data section. This > avoids reinitialization of the string upon function invocation and > should thus generally