>From 82f2b062c0e21d9a0d64f9ceab363d2a79f5a6eb Mon Sep 17 00:00:00 2001
From: Cojocaru Alexandru
Date: Thu, 6 Dec 2012 03:03:41 +0100
Subject: [PATCH] cut: fix memory leak
* src/cut.c (set_fields): don't allocate memory for
`printable_field' if there are no finite ranges.
The bug w
anges (n_rp) if yes,
allocate memory for `printable_field'. Then check if `printable_field'
has been allocated memory, if yes access it.
Anyway both are good solutions.
Best regards,
Cojocaru Alexandru
>From 678c2ecfebbf7a278c14b7e6fcb815e87569cd20 Mon Sep 17 00:00:00 2001
From: Cojocaru Alexandru
Date: Sun, 9 Dec 2012 10:43:10 +0100
Subject: [PATCH] cut: use only one data structure
The current implementation of cut, uses a bit array,
an array of `struct range_pair's, and (when
bash$ yes $(for i in $(seq 1 10); do echo -n a; done) | dd of=big-lines
ibs=11 count=1
9884+116 records in
1950011+1 records out
*998405915* bytes (998 MB) copied, 25.2695 s, 39.5 MB/s
WTF?!
Best regards,
Cojocaru Alexandru
c48beadf.
cut-split was compiled after applying the `split-print_kth' patch to commit
ec48beadf.
The main advantages cames from splitting `print_kth' into two
separate functions, so now `print_kth' does fewer checks.
Best regards,
Cojocaru Alexandru
OS: Parabola GNU/
I am trying to compile from the git master and I am getting the following error:
make[2]: *** No rule to make target `doc/perm.texi', needed by
`doc/coreutils.info'. Stop.
How to fix it?
Best regards,
Cojocaru Alexandru
Best regards,
Cojocaru Alexandru
Hi,
a while ago I've sent a patch. Could it be applied now?
You can find it here:
http://lists.gnu.org/archive/html/bug-coreutils/2012-12/msg00032.html
PS: I've already assigned the copyright to the FSF.
Best regards,
Cojocaru Alexandru
at's a common trend in these mem adjustment patches.
> I.E. Find a point to switch from the more CPU efficient method,
> to one which is more memory efficient.
>
> thanks,
> Pádraig.
Please could you re-run the benchmarks after applying the patch?
Could you also try with a bigger file (for example 100MB)? So as
to make the difference among the various patches more clear.
Unfortunately I'm under an emulator and the benchmarks aren't very
faithful.
Best regards,
Cojocaru Alexandru
On Sun, 28 Apr 2013 15:04:31 +0100
Pádraig Brady wrote:
> On 04/28/2013 12:44 PM, Cojocaru Alexandru wrote:
> > Another problem may be the merging and the call to `xrealloc' that
> > we do at the end of `set_fields'.
>
> That's only called at startup so I
set_fields'.
Best regards,
Cojocaru Alexandru
cut.patch
Description: Binary data
11 matches
Mail list logo
