Re: Bug#505927: just use the date(1) -d library instead of your own poorer date parser

2009-08-31 Thread jidanni
>> >> However to get at to accept such a date, one needs: >> >> $ at -v $(date --rfc-3339=date -d 'now + 5 years + 11 months') >> >> Fri Oct 17 03:56:00 2014 >> >> warning: commands will be executed using /bin/sh B'B> How do you like these: B'B> at-ng/build% ./at now + 5 years + 11 months B'B> Job

Re: "-T" option help text

2009-08-31 Thread Philip Rowlands
On Sun, 30 Aug 2009, James R. Van Zandt wrote: For the help text, here are some alternatives: if DEST is a directory, then delete it first This isn't what -T does. If DEST is an empty directory then it's overwritten with the rename(2) system call. Otherwise mv will fail e.g. if SOURCE is

new "rc" used-uninitialized warning in exclude.c

2009-08-31 Thread Jim Meyering
Hi Sergey, In exclude.c, we have this: bool excluded_file_name (struct exclude const *ex, char const *f) { ... switch (seg->type) { case exclude_pattern: rc = excluded_file_pattern_p (seg, f); break; case

broken link

2009-08-31 Thread Anarkia Komunismo
Hi there, You have a broken link on the page http://www.gnu.org/software/coreutils/ http://www.expita.com/nomime.html is expired and leads nowhere. Please check it out. Thanks.

Re: broken link

2009-08-31 Thread Jim Meyering
Anarkia Komunismo wrote: > You have a broken link on the page http://www.gnu.org/software/coreutils/ > > http://www.expita.com/nomime.html is expired and leads nowhere. Please > check it out. Thank you. Can anyone suggest a replacement?

Re: broken link

2009-08-31 Thread Jim Meyering
Jim Meyering wrote: > Anarkia Komunismo wrote: >> You have a broken link on the page http://www.gnu.org/software/coreutils/ >> >> http://www.expita.com/nomime.html is expired and leads nowhere. Please >> check it out. > > Thank you. > Can anyone suggest a replacement? Here's the latest archived co

Re: broken link

2009-08-31 Thread Philip Rowlands
On Mon, 31 Aug 2009, Jim Meyering wrote: Can anyone suggest a replacement? This is the same content, and references the expita.com URL as the source: http://stagecraft.theprices.net/nomime.html Cheers, Phil

Re: [PATCH] ls -i: print consistent inode numbers also for mount points

2009-08-31 Thread Ondřej Vašík
Jim Meyering wrote: > Following up on a long thread from a year ago, here's a patch > to fix the 3.5-year-old readdir-vs-mountpoint-inode bug in ls -i. Checked on my system and works fine... > It's a shame to have to pessimize ls -i performance, even by this > small amount on linux-based kernels,

Re: Bug#505927: just use the date(1) -d library instead of your own poorer date parser

2009-08-31 Thread Bernd Siggy Brentrup
Hi jidanni, I'm extremely angry about you forwarding my findings to the Debian BTS. Debian decided not to give me a vote again without passing a full NM procedure which I don't accept, hence: *I don't fix their bugs without having a vote*. @ Debian's at maintainer, I hereby declare: *You are not

Re: [PATCH] ls -i: print consistent inode numbers also for mount points

2009-08-31 Thread Jim Meyering
Ondřej Vašík wrote: > Jim Meyering wrote: >> Following up on a long thread from a year ago, here's a patch >> to fix the 3.5-year-old readdir-vs-mountpoint-inode bug in ls -i. > > Checked on my system and works fine... > >> It's a shame to have to pessimize ls -i performance, even by this >> small

Re: [PATCH] ls -i: print consistent inode numbers also for mount points

2009-08-31 Thread Pádraig Brady
Ondřej Vašík wrote: > Jim Meyering wrote: >> Following up on a long thread from a year ago, here's a patch >> to fix the 3.5-year-old readdir-vs-mountpoint-inode bug in ls -i. > > Checked on my system and works fine... > >> It's a shame to have to pessimize ls -i performance, even by this >> smal

Re: Bug#505927: just use the date(1) -d library instead of your own poorer date parser

2009-08-31 Thread jidanni
> "BSB" == Bernd Siggy Brentrup writes: BSB> Hi jidanni, BSB> I'm extremely angry about you forwarding my findings to the BSB> Debian BTS. Sorry. I just try to increase people's networking, and assumed the bug number, which I saw in the Subject, had fallen off the CC list and needed to be p

Re: [PATCH] ls -i: print consistent inode numbers also for mount points

2009-08-31 Thread Ondřej Vašík
Pádraig Brady wrote: > So there was a lot more disk access with the new binary. > but the NEWS suggests that should only be the case for > "systems with dysfunctional readdir". > > What was your system? Quite ancient system... I checked this on my old Fedora Core 6... Anyway could check with some

Re: [PATCH] ls -i: print consistent inode numbers also for mount points

2009-08-31 Thread Pádraig Brady
Ondřej Vašík wrote: > Pádraig Brady wrote: >> So there was a lot more disk access with the new binary. >> but the NEWS suggests that should only be the case for >> "systems with dysfunctional readdir". >> >> What was your system? > > Quite ancient system... I checked this on my old Fedora Core 6..

Re: [PATCH] ls -i: print consistent inode numbers also for mount points

2009-08-31 Thread Jim Meyering
Pádraig Brady wrote: ... >> Yep, it has some performance impact... >> checked `time ./ls -i1R /home /dev /usr /var /lib >myinodes with >> approximate number of 31k dirs, 450k files on ext3 >> >> and results are >> old binary without the patch: >> real2m5.631s >> user0m3.012s >> sys 0m4.

[PATCH] maint: mbsalign.c: remove unnecessary assignment

2009-08-31 Thread Jim Meyering
FYI, clang found an unnecessary assignment. This removes it, >From c6cc0321f3a07d4828e1043c21a468d45941850a Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 31 Aug 2009 16:37:36 +0200 Subject: [PATCH] maint: mbsalign.c: remove unnecessary assignment * gl/lib/mbsalign.c (mbsalign): Remove a

timeout.c warning about returning undefined value

2009-08-31 Thread Jim Meyering
Hi Pádraig, clang reports this: timeout.c:330:9: warning: Uninitialized or undefined value returned to caller. return status; ^ Even if it really can't happen (which the comment suggests), please initialize "status" or ensure that we get a diagnostic and exit nonzero if/whe

Re: timeout.c warning about returning undefined value

2009-08-31 Thread Pádraig Brady
Jim Meyering wrote: > Hi Pádraig, > > clang reports this: > > timeout.c:330:9: warning: Uninitialized or undefined value returned to > caller. > return status; > ^ > > Even if it really can't happen (which the comment suggests), please > initialize "status" or ensure that

cp(1) extended attributes bug

2009-08-31 Thread Ernest N. Mamikonyan
Cp(1) doesn't correctly copy extended attributes for read-only files: touch foo setfattr -n user.key -v value foo chmod a-w foo cp --preserve=xattr foo bar cp: setting attribute `user.key' for `user.key': Permission denied If one uses "cp -a" instead, it simply strips the metadata and doesn't

Re: timeout.c warning about returning undefined value

2009-08-31 Thread Pádraig Brady
I'll check in the attached later on today unless there are objections. cheers, Pádraig. >From 9fd105fed6c317d12c949a1f8b66b0c0aacc77b3 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?P=C3=A1draig=20Brady?= Date: Mon, 31 Aug 2009 19:18:27 +0100 Subject: [PATCH] timeout: defensive handling of all wait() e

Re: timeout.c warning about returning undefined value

2009-08-31 Thread Jim Meyering
Pádraig Brady wrote: > I'll check in the attached later on today > unless there are objections. ... > Subject: [PATCH] timeout: defensive handling of all wait() errors > > * src/timeout.c (main): Handle all possible cases of unexpected > failures from wait(). This was prompted by the clang tool re

Re: cp(1) extended attributes bug

2009-08-31 Thread Ondřej Vašík
Hi, thanks for report... Ernest N. Mamikonyan wrote: > Cp(1) doesn't correctly copy extended attributes for read-only files: > > touch foo > setfattr -n user.key -v value foo > chmod a-w foo > cp --preserve=xattr foo bar > cp: setting attribute `user.key' for `user.key': Permission denied This e

Re: [PATCH] ls -i: print consistent inode numbers also for mount points

2009-08-31 Thread Jim Meyering
Jim Meyering wrote: > Following up on a long thread from a year ago, here's a patch > to fix the 3.5-year-old readdir-vs-mountpoint-inode bug in ls -i. ... > http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/14020 ... > It's a shame to have to pessimize ls -i performance, even by this > small a