Jim Meyering wrote: > Following up on a long thread from a year ago, here's a patch > to fix the 3.5-year-old readdir-vs-mountpoint-inode bug in ls -i.
Checked on my system and works fine...
> It's a shame to have to pessimize ls -i performance, even by this
> small amount on linux-based kernels, but correctness definitely
> trumps performance, here.
Yep, it has some performance impact...
checked `time ./ls -i1R /home /dev /usr /var /lib >myinodes with
approximate number of 31k dirs, 450k files on ext3
and results are
old binary without the patch:
real 2m5.631s
user 0m3.012s
sys 0m4.815s
new binary:
real 6m8.560s
user 0m3.947s
sys 0m30.572s
But correctness should be preferred as this is not so common usecase...
> Review appreciated.
Looks ok from my point of view.
Greetings,
Ondřej Vašík
signature.asc
Description: Toto je digitálně podepsaná část zprávy
