Re: coreutils-7.0 beta test runs

2008-10-10 Thread Jim Meyering
HggdH <[EMAIL PROTECTED]> wrote: > On Thu, 2008-10-09 at 16:37 +0200, Jim Meyering wrote: >> > I have run the tests both as root and as a normal user. I have >> failures >> > on both runs. >> > >> > I ran the tests as 'make tests', which I *think* was what was >> required. >> >> Thanks for testing.

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-10 Thread Pádraig Brady
Giuseppe Scrivano wrote: > Hi Pádraig, > > I think that the only problem can raise when the sent signal is received > by the monitor process after the handler is reinstalled. In that case > the signal will be dispatched again to the process group. This can > repeat again and again until it is fi

Re: coreutils-7.0 beta test runs

2008-10-10 Thread HggdH
On Fri, 2008-10-10 at 09:38 +0200, Jim Meyering wrote: > Thanks. > Those "failures" show merely that you built with profiling > in such a way that every binary drops a gmon.out file in the > current directory. Then, any test that expects certain files > to be present finds an anomaly: the unexpect

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-10 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > According to Giuseppe Scrivano on 10/6/2008 3:33 PM: >> + sigaction (sig, NULL, &sa); >> + handler = sa.sa_handler; >> + sa.sa_handler = SIG_IGN; > > This is not necessarily safe, if SA_SIGINFO is set (sa.handler and > sa_siginfo are not required to occupy

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Giuseppe Scrivano on 10/6/2008 3:33 PM: > + sigaction (sig, NULL, &sa); > + handler = sa.sa_handler; > + sa.sa_handler = SIG_IGN; This is not necessarily safe, if SA_SIGINFO is set (sa.handler and sa_siginfo are not required to occupy

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-10 Thread Giuseppe Scrivano
Hi Pádraig, I think that the only problem can raise when the sent signal is received by the monitor process after the handler is reinstalled. In that case the signal will be dispatched again to the process group. This can repeat again and again until it is finally ignored by the monitor process.

Bug

2008-10-10 Thread cathy
Bonjour, suite a des problemes de resolution d'ecran, j'ai "bidouille" dans le terminal. Le probleme de resolution reglee reste en memoire une fois sur deux quand j'eteins et dpuis, c'est mon clavier qui ne reconnait plus les lettes avec accent ou cedille!! A l'allumage, j'ai un message qui me

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-10 Thread Giuseppe Scrivano
Hello, do you have suggestions on this patch? It replaces any `signal' with `sigaction'. Regards, Giuseppe Scrivano Jim Meyering <[EMAIL PROTECTED]> writes: > Good idea. > I've wanted to get rid of "signal" uses for ages. > Are you interested in doing it? diff --git a/src/csplit.c b/src/cspl

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 10/10/2008 6:44 AM: >> On the other hand, POSIX is explicit that mixing signal and sigaction is >> not portable. For that matter, now that gnulib provides a guaranteed >> sigaction, why don't we just change all of coreutil

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-10 Thread Pádraig Brady
Eric Blake wrote: > On the other hand, POSIX is explicit that mixing signal and sigaction is > not portable. For that matter, now that gnulib provides a guaranteed > sigaction, why don't we just change all of coreutils to use it? Affected > are: csplit, dd, install, ls, nohup, sort, tee, and time

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-10 Thread Pádraig Brady
Giuseppe Scrivano wrote: > Hello, > > do you have suggestions on this patch? It replaces any `signal' with > `sigaction'. [snip] > diff --git a/src/timeout.c b/src/timeout.c > index 8b506f0..6ef7218 100644 > --- a/src/timeout.c > +++ b/src/timeout.c > @@ -278,8 +278,6 @@ main (int argc, char **

Re: Patch to check for required programs when building from source checkout

2008-10-10 Thread Ed Avis
Jim Meyering meyering.net> writes: >>A few tools are required to build coreutils from a git checkout, but >>not checked in a friendly way. >The newer automake-1.10a is actually required. Ah, ok, it could do with a comment because at first it appears that 1.10.1 should be newer than 1.10a. [ch

FAIL: df/total-awk.log

2008-10-10 Thread Ed Avis
With current coreutils source from git, one test fails on my machine. It is a Fedora 9 box with a few Windows filesystems mounted. Here is the tests/test- suite.log. === GNU coreutils 7.0.5-42df6-dirty: tests/test-suite.log =

Re: Bug

2008-10-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to cathy on 10/10/2008 10:00 AM: > Bonjour, > suite a des problemes de resolution d'ecran, j'ai "bidouille" dans le > terminal. Le probleme de resolution reglee reste en memoire une fois sur > deux quand j'eteins et dpuis, c'est mon clavier q

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Giuseppe Scrivano on 10/10/2008 2:34 PM: > Hello, > > do you have suggestions on this patch? It replaces any `signal' with > `sigaction'. The size of this patch is not trivial; are you willing to assign copyright to FSF? If so, I can g