Re: [PATCH] df: add `--total' option

2008-01-11 Thread Jim Meyering
Steven Schubiger <[EMAIL PROTECTED]> wrote: > Given that the attached patch works, except that the SIZE argument > specified to -B/--block-size parameter doesn't currently make it > into the totals, I'd like to hear some opinions how you would make it > happen (I have some ideas, but I'd certainly

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Jim Meyering
Steven Schubiger <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> wrote: >> Thanks for the patch. However, I haven't even looked at it because >> there's another that's already gone through some review: >> >> Some people from Fujitsu revived a patch by Denis Smit, here: This is the l

Re: [PATCH] Fix preserve_mode when destination directory partially exists

2008-01-11 Thread Jan Blunck
On Tue, Jan 08, Paul Eggert wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > > > 2008-01-07 Jan Blunck <[EMAIL PROTECTED]> > > > > cp --parents: don't use uninitialized memory when restoring permissions > > In reviewing that patch I noticed that the bug of using uninitialized > memory s

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Steven Schubiger
Jim Meyering <[EMAIL PROTECTED]> wrote: > Thanks for the patch. However, I haven't even looked at it because > there's another that's already gone through some review: > > Some people from Fujitsu revived a patch by Denis Smit, here: > > http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/11

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Steven Schubiger
Jim Meyering <[EMAIL PROTECTED]> wrote: > This is the link I meant to provide: > > http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/11965 >From a first glance, this looks far more complete than my approach. Would it be worthwhile to mention such unapplied, yet stalled patches within the TO

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Jim Meyering
Steven Schubiger <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> wrote: >> This is the link I meant to provide: >> >> http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/11965 > >>From a first glance, this looks far more complete than my approach. > Would it be worthwhile to menti

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Steven Schubiger
Jim Meyering <[EMAIL PROTECTED]> wrote: > Thanks for the patch. FTR (for the record), a second version which does some "magic" to obtain the block-size argument and append it to the output. I don't think, it'll be of much use now, but archiving doesn't hurt. Steven Schubiger diff --git a/src/df

Re: [PATCH] Fix preserve_mode when destination directory partially exists

2008-01-11 Thread Jim Meyering
Jan Blunck <[EMAIL PROTECTED]> wrote: > On Tue, Jan 08, Paul Eggert wrote: > >> Jim Meyering <[EMAIL PROTECTED]> writes: >> >> > 2008-01-07 Jan Blunck <[EMAIL PROTECTED]> >> > >> >cp --parents: don't use uninitialized memory when restoring permissions >> >> In reviewing that patch I noticed t

[RFC] shred: --verbose output to stdout

2008-01-11 Thread Steven Schubiger
After skimming through a bit of code from shred, I was eager to see how easy it would be to change the corresponding calls of error() that are relevant to verbosity output to call some "equivalent" function, which outputs to stdout, i.e. static void output (const char const *fmt, ...) { va_l

[PATCH] Add svg to the dircolors list

2008-01-11 Thread Mike Frysinger
Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> --- src/dircolors.hin |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/dircolors.hin b/src/dircolors.hin index 3c171f9..14ba451 100644 --- a/src/dircolors.hin +++ b/src/dircolors.hin @@ -138,6 +138,7 @@ EXEC 01;32 .tif