Re: misalignment in ls -l in fr_FR locale

Pádraig Brady wrote: > Sorry about all the iterations. Nothing to apologize for. I've been reviewing only relatively small parts at a time. Thanks for persevering. > +/* FIXME: move this function to gnulib as it's missing on: > + OpenBSD 3.8, IRIX 5.3, Solaris 2.5.1, mingw, BeOS */ > + > +stat

Re: misalignment in ls -l in fr_FR locale

2009/3/27 Pádraig Brady : > Sorry about all the iterations. > Hopefully this version is complete. I've already tested your first version and it works great with the French locale. Thank you for your work. Stéphane ___ Bug-coreutils mailing list Bug-co

Re: misalignment in ls -l in fr_FR locale

Sorry about all the iterations. Hopefully this version is complete. cheers, Pádraig. >From 55d1c2e2ea14f0713d7604323b4f43a83237897b Mon Sep 17 00:00:00 2001 From: =?utf-8?q?P=C3=A1draig=20Brady?= Date: Tue, 24 Mar 2009 14:29:21 + Subject: [PATCH] ls: Fix alignment when month names have varyin

Re: misalignment in ls -l in fr_FR locale

Pádraig Brady wrote: ... > +/* In the unlikely event that the abmon[] storage is not big enough > + an error message will be displayed, and we revert to using > + unmodified abbreviated month names from the locale database. */ > +static char abmon[12][MAX_MON_WIDTH * 2 * MB_LEN_MAX + 1]; > +/*

Re: misalignment in ls -l in fr_FR locale

Pádraig Brady wrote: > Jim Meyering wrote: >>> + the trailing NUL). A value >= dest_size means there wasn't enough >>> space. >>> + The width parameter both specifies the width to align/pad/truncate to, >>> + and is updated to return the width used before padding. */ >> >> Would "desired_w

Re: misalignment in ls -l in fr_FR locale

Jim Meyering wrote: >> + the trailing NUL). A value >= dest_size means there wasn't enough space. >> + The width parameter both specifies the width to align/pad/truncate to, >> + and is updated to return the width used before padding. */ > > Would "desired_width" be a better parameter name

Re: misalignment in ls -l in fr_FR locale

Pádraig Brady wrote: > I expect to push the attached updated patch soon. Hi Pádraig, Thanks for working on this, but please hold off until after 7.2. I'm trying to stabilize for a bug-fix(was "-only") release. > Subject: [PATCH] ls: Fix alignment when month names have varying widths ... > diff -

Re: misalignment in ls -l in fr_FR locale

Pádraig Brady wrote: > I expect to push the attached updated patch soon. Hi Pádraig, Thanks for working on this, but please hold off until after 7.2. I'm trying to stabilize for a bug-fix(was "-only") release. > Subject: [PATCH] ls: Fix alignment when month names have varying widths ... > diff

Re: misalignment in ls -l in fr_FR locale

I expect to push the attached updated patch soon. cheers, Pádraig. >From f687f88bef0589b5fe1c2a73e7ea9ee475db81b8 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?P=C3=A1draig=20Brady?= Date: Tue, 24 Mar 2009 14:29:21 + Subject: [PATCH] ls: Fix alignment when month names have varying widths * NEWS:

Re: misalignment in ls -l in fr_FR locale

Pádraig Brady wrote: > Updated patch attached. > > Note caching the abbreviated months like this speeds `ls -l` > up by around 10% which is nice, though not that important > as ls output is mainly for processing by humans. eep, previous patch had a few buglets... diff --git a/src/ls.c b/src/ls.c

Re: misalignment in ls -l in fr_FR locale

Updated patch attached. Note caching the abbreviated months like this speeds `ls -l` up by around 10% which is nice, though not that important as ls output is mainly for processing by humans. cheers, Pádraig. >From dec4db2e8e07f90845f66858de21b0446c591746 Mon Sep 17 00:00:00 2001 From: =?utf-8?q

Re: misalignment in ls -l in fr_FR locale

Pádraig Brady wrote: > Oh right: > http://sourceware.org/bugzilla/show_bug.cgi?id=9859 > http://sourceware.org/cgi-bin/cvsweb.cgi/libc/localedata/locales/fr_FR.diff?r1=1.14&r2=1.15&cvsroot=glibc&f=h > > Wow misaligned names are surprisingly unreadable: > $ LANG=ga_IE.utf8 TIME_STYLE=+"%b %e %H:%M"

Re: misalignment in ls -l in fr_FR locale

Samuel Thibault wrote: > Pádraig Brady, le Fri 20 Mar 2009 12:23:29 +, a écrit : >> >> Note that I get shorter abmon values, and also the alignment is fine? > > That's because it's an old glibc. You can try using some other locale > that has variable sized-abmon, like possibly ar_JO, ar_LB, ar

Re: misalignment in ls -l in fr_FR locale

Pádraig Brady, le Fri 20 Mar 2009 12:23:29 +, a écrit : > Samuel Thibault wrote: > > $ ls -l > > drwxr-xr-x 5 samy samy 4,0K mars 17 22:33 tmp/ > > drwx-- 5 samy samy 4,0K févr. 12 18:20 u/ > > > > Because in the fr_FR locale abmon does not have a constant width, the > > content of ls -l

Re: misalignment in ls -l in fr_FR locale

Samuel Thibault wrote: > Hello, > > $ ls -l > drwxr-xr-x 5 samy samy 4,0K mars 17 22:33 tmp/ > drwx-- 5 samy samy 4,0K févr. 12 18:20 u/ > > Because in the fr_FR locale abmon does not have a constant width, the > content of ls -l is misaligned. Locale standards require abday to have > a co

Re: misalignment in ls -l in fr_FR locale

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Samuel Thibault on 3/17/2009 3:36 PM: > Hello, > > $ ls -l > drwxr-xr-x 5 samy samy 4,0K mars 17 22:33 tmp/ > drwx-- 5 samy samy 4,0K févr. 12 18:20 u/ > > Because in the fr_FR locale abmon does not have a constant width, the > con

misalignment in ls -l in fr_FR locale

Hello, $ ls -l drwxr-xr-x 5 samy samy 4,0K mars 17 22:33 tmp/ drwx-- 5 samy samy 4,0K févr. 12 18:20 u/ Because in the fr_FR locale abmon does not have a constant width, the content of ls -l is misaligned. Locale standards require abday to have a constant width, but that does not apply to