Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-22 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Martin Knapp-Cordes on 10/22/2008 12:17 PM: > This means that the MATLAB startup shell script is indeed > not Open Group compliant. Obviously, no change will be > necessary to the script if the proposed fixes are approved, > as they appear

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-22 Thread Martin Knapp-Cordes
Hello, Eric Blake is correct. I glossed over a short paragraph in the Open Group standard doc page for 'expr' at the end of the 'Application Usage' section where there is a statement that permits something like '-1' to look like an option not the integer, '-1'. This means that the MATLAB startup

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-21 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Martin Knapp-Cordes on 10/21/2008 8:31 AM: > Hello, > > I would like to respond to any earlier claim made that > there is a "long-standing bug in matlab startup script". > We at the MathWorks disagree. Unfortunately, your disagreement is

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-21 Thread Martin Knapp-Cordes
Hello, I would like to respond to any earlier claim made that there is a "long-standing bug in matlab startup script". We at the MathWorks disagree. Please observe the following by reading carefully the online documentation for the Open Group Standard, UNIX Version 3, expr command. The POSIX sta

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-17 Thread Jim Meyering
Pádraig Brady <[EMAIL PROTECTED]> wrote: ... > I've attached a patch to standardize the format of the > AUTHORS define to that used in other utils with multiple authors. > I've also added you to the list since you basically rewrote > expr with this patch. Good changes. Please push that at your lei

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-16 Thread Pádraig Brady
Excellent stuff. You got a net reduction of 366 lines, and another 91 lines are not used in the common case where GMP is available. I'm a bit worried by signed overflow checking in the following. I know gcc won't do it's ignore undefined signed overflow code shenanigans with this, but does this as

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-15 Thread Jim Meyering
Pádraig Brady <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> For reference, here's a small patch I just wrote that solves >> at least some of the problems reported here, while retaining >> the ability to use MP at run time. > > I'd essentially done the same thing, so I think that will solve >

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-15 Thread Pádraig Brady
Jim Meyering wrote: > For reference, here's a small patch I just wrote that solves > at least some of the problems reported here, while retaining > the ability to use MP at run time. I'd essentially done the same thing, so I think that will solve most of the backwards compat issues. Note if leavi

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-15 Thread Jim Meyering
Paul Eggert <[EMAIL PROTECTED]> wrote: ... > Here's a proposed patch to do that. This change is a bit larger than > it has to be compared to 7.0, because (to be conservative) when in doubt > it does things the pre-7.0 way rather than the 7.0 way. For example, it > uses the same diagnostics as pre

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-14 Thread Jim Meyering
Paul Eggert <[EMAIL PROTECTED]> wrote: > Thanks for reporting that. Clearly it's a matlab bug. But just as > clearly, many scripts out there assume that "expr -1 + 1" evaluates to > zero. We shouldn't break them unnecessarily. > > I looked at expr.c and have a somewhat radical suggestion. Let's

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-14 Thread Paul Eggert
Thanks for reporting that. Clearly it's a matlab bug. But just as clearly, many scripts out there assume that "expr -1 + 1" evaluates to zero. We shouldn't break them unnecessarily. I looked at expr.c and have a somewhat radical suggestion. Let's remove the --bignum and --no-bignum options, an

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-14 Thread Nelson H. F. Beebe
>> > > if [ ! " $lscmd" ]; then >> That expression can never be true due to the additional space. Thanks. We too caught that overzealous edit on my part shortly after my posting to the bug-coreutils@gnu.org list, and fixed it locally, using the -z test instead, just as you suggested. -

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-14 Thread Pádraig Brady
Eric Blake wrote: > According to Pádraig Brady on 10/14/2008 3:47 AM: >>> With native versions of expr, and expr from GNU coreutils prior to >>> version 7.0, the expansion of lscmd usually begins "-rw-r--r--", but >>> the leading hyphen does not cause the word to be treated as an option. >> I think

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-14 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Pádraig Brady on 10/14/2008 3:47 AM: >> With native versions of expr, and expr from GNU coreutils prior to >> version 7.0, the expansion of lscmd usually begins "-rw-r--r--", but >> the leading hyphen does not cause the word to be treated

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-14 Thread Pádraig Brady
Nelson H. F. Beebe wrote: > I've just filed a bug report with The Mathworks, vendor of the > widely-used Matlab matrix algebra system. Their bin/matlab startup > script (all versions up to current) contains code like this: > > if [ `expr "$lscmd" : '.*->.*'` -ne 0 ]; then > > With native v

Re: [coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-13 Thread Bob Proulx
Nelson H. F. Beebe wrote: > < if [ ! "$lscmd" ]; then > --- > > if [ ! " $lscmd" ]; then That expression can never be true due to the additional space. I suggest using the -z operator instead. if [ -z "$lscmd" ]; then Bob ___ Bug-coreut

[coreutils] coreutils-7.0 expr exposes long-standing bug in matlab startup script

2008-10-13 Thread Nelson H. F. Beebe
I've just filed a bug report with The Mathworks, vendor of the widely-used Matlab matrix algebra system. Their bin/matlab startup script (all versions up to current) contains code like this: if [ `expr "$lscmd" : '.*->.*'` -ne 0 ]; then With native versions of expr, and expr from GNU cor