Re: rm: don't waste time preprocessing on tmpfs or nfs

2008-10-01 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > According to Jim Meyering on 10/1/2008 2:42 PM: >>> Since we've already applied 58aaf71 to silence other functions when d_type >>> is >>> unavailable (and sorting is useless), it seems like that needs to be >>> repeated >>> here. The constants from "fs.h"

Re: [PATCH] tests: use our new timeout program

2008-10-01 Thread Jim Meyering
Pádraig Brady <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> I suspended a 'make check' run, and when I resumed it I was not >> surprised to see this particular test fail. >> Then I kicked myself for not thinking to use coreutils' own >> new timeout program before this. > > I presume you mean

Re: rm: don't waste time preprocessing on tmpfs or nfs

2008-10-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 10/1/2008 2:42 PM: >> Since we've already applied 58aaf71 to silence other functions when d_type is >> unavailable (and sorting is useless), it seems like that needs to be repeated >> here. The constants from "fs.h" are no

Re: Shred and symbolic links. People use it like a safer "rm" and get...

2008-10-01 Thread Antonio
I finally found the "wipe" program (http://abaababa.ouvaton.org/wipe/ , available in the Ubuntu/Kubuntu packages) that does what a normal user needs. By default: "wipe" will never follow symlinks and it has parameters like: -r recurse into subdirectories Will allow the removal

Re: [PATCH] tests: use our new timeout program

2008-10-01 Thread Pádraig Brady
Jim Meyering wrote: > I suspended a 'make check' run, and when I resumed it I was not > surprised to see this particular test fail. > Then I kicked myself for not thinking to use coreutils' own > new timeout program before this. I presume you mean suspended the machine here, rather than suspended

Re: rm: don't waste time preprocessing on tmpfs or nfs

2008-10-01 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > Jim Meyering meyering.net> writes: > >> >> I'll probably be using this change: >> >> From ebb424314a577c0b8ccaf3ef79c3c9a3379b31a5 Mon Sep 17 00:00:00 2001 >> From: Jim Meyering redhat.com> >> Date: Wed, 1 Oct 2008 12:21:58 +0200 >> Subject: [PATCH] remove

Re: rm: don't waste time preprocessing on tmpfs or nfs

2008-10-01 Thread Eric Blake
Jim Meyering meyering.net> writes: > > I'll probably be using this change: > > From ebb424314a577c0b8ccaf3ef79c3c9a3379b31a5 Mon Sep 17 00:00:00 2001 > From: Jim Meyering redhat.com> > Date: Wed, 1 Oct 2008 12:21:58 +0200 > Subject: [PATCH] remove.c: combine two helper functions, to avoid sign

Re: rm: don't waste time preprocessing on tmpfs or nfs

2008-10-01 Thread Jim Meyering
Andreas Schwab <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: >> diff --git a/src/remove.c b/src/remove.c >> index ea52843..6c1eaea 100644 >> --- a/src/remove.c >> +++ b/src/remove.c >> @@ -1277,6 +1277,45 @@ dirent_count (struct stat const *st) >> } >> #endif /* HAVE_STRUC

Re: rm: don't waste time preprocessing on tmpfs or nfs

2008-10-01 Thread Andreas Schwab
Jim Meyering <[EMAIL PROTECTED]> writes: > diff --git a/src/remove.c b/src/remove.c > index ea52843..6c1eaea 100644 > --- a/src/remove.c > +++ b/src/remove.c > @@ -1277,6 +1277,45 @@ dirent_count (struct stat const *st) > } > #endif /* HAVE_STRUCT_DIRENT_D_TYPE */ > > +#if defined HAVE_SYS_VFS_H

rm: don't waste time preprocessing on tmpfs or nfs

2008-10-01 Thread Jim Meyering
I noticed that the newly-added preprocessing code added ~1 second to the usual 5-second run time required to remove a 2M-entry directory on a tmpfs file system. This change removes that penalty. I'll sync the functions in gnulib's fts.c to be like these separately. And eventually, I expect to pull