Eric Blake <[EMAIL PROTECTED]> wrote: > According to Jim Meyering on 10/1/2008 2:42 PM: >>> Since we've already applied 58aaf71 to silence other functions when d_type >>> is >>> unavailable (and sorting is useless), it seems like that needs to be >>> repeated >>> here. The constants from "fs.h" are not defined, since that file is valid >>> only >>> for Linux and Hurd, but commenting out the entire function bypasses that >>> problem. >> >> Hi Eric, >> >> Thanks for reporting that. >> >> In looking into it, I spotted a minor problem: >> the code was including sys/statfs.h, yet testing-for/guarding-with >> sys/vfs.h (as is documented for fstatfs on gnu/linux). >> I've fixed that and removed an unnecessary "defined". >> >> To address your immediate problem, I've copied the constants for now, >> and will sync up fts.c tomorrow. Or get tired enough of this >> duplication and make a module out of it. Eventually I'll make >> it more portable (like for the Hurd). > > I was thinking something more like the following (plus a .gitignore update): > > $ git fetch git://repo.or.cz/coreutils/ericb.git master
Thanks. I prefer that (better for the Hurd), so applied it. _______________________________________________ Bug-coreutils mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-coreutils
