Re: rebased patches?

Bo Borgerson <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> This brings up another (as yet unwritten) guideline: >> Don't change translatable strings if you can avoid it. >> If you must rearrange lines, extract and create new strings, rather than >> extracting and moving into existing bl

Re: recent const churn

Eric Blake <[EMAIL PROTECTED]> wrote: > According to Jim Meyering on 6/16/2008 9:49 AM: > |> Sounds like an updated maintainer rule to check for redundant const > might be > |> useful? > | > | Thanks for keeping watch! > | Anything to protect me from myself ;-) > | If you feel like it, a patch wou

Re: recent const churn

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 6/16/2008 9:49 AM: |> Sounds like an updated maintainer rule to check for redundant const might be |> useful? | | Thanks for keeping watch! | Anything to protect me from myself ;-) | If you feel like it, a patch would be m

Re: Multi-threading in sort(or core-utils)

Paul Eggert wrote: >>> [EMAIL PROTECTED] wrote: I think it is good idea to make option(or by default) for sorting in threads to increase performance on systems that might execute more than one thread in parallel. Klimentov Konstantin. > > I agree. That's been on my to-do li

Re: [PATCH] Improve memory management in join

"Bo Borgerson" <[EMAIL PROTECTED]> wrote: > This improves the performance of `join' by reducing memory management > overhead and eliminating unnecessary copies for order checking: > > $ valgrind src/join.master ja jb > ==23744== malloc/free: 4,571,152 allocs, 4,571,152 frees, 255,971,774 > bytes al

Re: rebased patches?

Jim Meyering wrote: > This brings up another (as yet unwritten) guideline: > Don't change translatable strings if you can avoid it. > If you must rearrange lines, extract and create new strings, rather than > extracting and moving into existing blocks. This avoids making unnecessary > work

Re: Multi-threading in sort(or core-utils)

>> [EMAIL PROTECTED] wrote: >>> I think it is good idea to make option(or by default) for sorting >>> in threads to increase performance on systems that might execute >>> more than one thread in parallel. >>>Klimentov Konstantin. I agree. That's been on my to-do list for years. (It shouldn't

Re: Command line parsing of ls with genparse: inline code

[EMAIL PROTECTED] (Michael Geng) wrote: ... > I think emitting into a .h file would be a good solution. But wouldn't > it then be better to directly add a genparse file (e.g. ls.gp) instead of > extracting it from ls.c? ls.c would no longer have to be modified then. The disadvantage is that there

Re: Command line parsing of ls with genparse: inline code

On Sat, Jun 14, 2008 at 06:17:30PM +0200, Jim Meyering wrote: > [EMAIL PROTECTED] (Michael Geng) wrote: > > when I posted a patch around Christmas which showed how genparse > > could generate the parser code for the ping command of the inetutils > > Alfred Szmidt replied that in that example there

[bug #1212] wishlist: ls sort case insensitive option

Follow-up Comment #6, bug #1212 (project coreutils): http://www.fotolog.com/bondagevid1/about http://www.fotolog.com/bondagefetisvid/about http://www.fotolog.com/bondageteenvid/about http://www.fotolog.com/bondagefreevideo/about http://www.fotolog.com/bondagesexfree/about ___

Re: coreutils.texi: Drop leading blanks.

Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > this patch removes a couple of ugly extra spaces from the info file > (script to find them posted here: > ). Thanks for spotting that! And for the script pointer. For reference, the offending inf

coreutils.texi: Drop leading blanks.

Hi Jim, this patch removes a couple of ugly extra spaces from the info file (script to find them posted here: ). Cheers, Ralf 2008-06-16 Ralf Wildenhues <[EMAIL PROTECTED]> * doc/coreutils.texi (join invocation): Drop leading bl

Re: recent const churn

Eric Blake <[EMAIL PROTECTED]> wrote: > After the recent churn in const-qualification in coreutils.git, there are > still > a couple of redundant qualifiers, as found by: > > $ git grep '\bconst\b[^*]*\bconst\b' -- '*.[ch]' > src/ls.c:static const char const *long_time_format[2] = > src/ls.c:stat

recent const churn

After the recent churn in const-qualification in coreutils.git, there are still a couple of redundant qualifiers, as found by: $ git grep '\bconst\b[^*]*\bconst\b' -- '*.[ch]' src/ls.c:static const char const *long_time_format[2] = src/ls.c:static const qsortFunc const sort_functions[][2][2][2] =

Re: [PATCH] chcon: correct --verbose output to include newlines

Jim Meyering <[EMAIL PROTECTED]> wrote: > I've just made this change: ... > Subject: [PATCH] chcon: correct --verbose output to include newlines Actually I added a test and updated NEWS, too: >From 3de15598304c141bdac5a3545874bab035536d88 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTEC

[PATCH] chcon: correct --verbose output to include newlines

I've just made this change: >From 30bf4beed36950fb9beaa75e9ca19e79c76a65eb Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Mon, 16 Jun 2008 13:03:07 +0200 Subject: [PATCH] chcon: correct --verbose output to include newlines * src/chcon.c (process_file): Append "\n" to --verb