Re: [EXTERNAL] [blink-dev] Intent to Ship: Web Speech API contextual biasing

2025-07-14 Thread Dan Clark
Thanks for these updates! I think it's kind of borderline whether there's enough complexity here to merit a TAG review. My preference is to go ahead and request one in case they do have feedback. -- Dan On Thursday, July 10, 2025 at 12:59:03 PM UTC-7 Evan Liu wrote: > Hi Dan, > > Thank you fo

Re: [blink-dev] Re: Intent to Prototype: document.caretPositionFromPoint API

2024-01-23 Thread 'Dan Clark' via blink-dev
For the shadow DOM scenario, have we started the spec conversation about what behavior we want to end up at? I find the Gecko behavior a bit suspicious since it's piercing into potentially-closed shadow trees without having a prior reference to them. Maybe caretPositionFromPoint should not pier

Re: [blink-dev] Intent to Deprecate non-standard declarative shadow DOM serialization

2024-01-23 Thread 'Dan Clark' via blink-dev
I guess a theoretical risk is that someone feature-checks for HTMLTemplateElement.shadowRootMode and then assumes the existence of getInnerHTML() based on that check. But given the lack of usage in the top sites I agree that this seems to not be an issue in practice. I saw that there's a suppor

[blink-dev] Re: Intent to Ship: CSSImportRule.styleSheet

2024-02-23 Thread 'Dan Clark' via blink-dev
An interesting data point: Firefox still crashes when inspecting the property for a styleSheet in this state (test ). I guess that's good motivation on their end to make this update and remain interoperable. -- Dan On Friday, February 23, 2024 at

[blink-dev] Re: Intent to Ship: Standard-compliant pseudo-element argument for getComputedStyle & KeyframeEffect

2024-03-08 Thread 'Dan Clark' via blink-dev
ke to make. On the other hand the fact that WebKit (and I guess Gecko) already did it is an encouraging signal. -- Dan Clark On Friday, March 8, 2024 at 8:46:28 AM UTC-8 nrose...@chromium.org wrote: > Contact emailsnrose...@chromium.org > > ExplainerNone > > Specifi

[blink-dev] Re: Intent to Ship: CSS Anchor Positioning

2024-04-11 Thread 'Dan Clark' via blink-dev
I'm really excited to see this move forward! For the TAG review , it's not clear to me that they've had a chance to re-review yet since the last substantial updates. I'm not suggesting that we delay shipping at this stage, but maybe worth sen

Re: [blink-dev] Intent to Ship: PointerEvent.deviceId for Mult-Pen Inking

2024-05-08 Thread 'Dan Clark' via blink-dev
A non-blocking comment: now that the syntax has been changed I think it would be great if you could update the Explainer and the Mozilla and WebKit requests-for-position to reduce potential for confusion. Also, is there a reason the spec PR is still in Draft status? Could it be published so tha

Re: [blink-dev] Intent to Ship: Element Reflection

2025-02-05 Thread 'Dan Clark' via blink-dev
. It would be great to clarify what the plan is for ariaOwnsElements as it's not yet clear to me that that one is ready. -- Dan Clark On Tuesday, February 4, 2025 at 3:10:04 AM UTC-8 Daniel Bratell wrote: > LGTM1 > > /Daniel > On 2025-02-04 06:40, Alice Boxhall wrote: > &g

Re: [blink-dev] Re: Intent to Ship: CSS if() function

2025-04-09 Thread 'Dan Clark' via blink-dev
LGTM2 On Wednesday, April 9, 2025 at 8:09:13 AM UTC-7 sligh...@chromium.org wrote: > LGTM1 > > On Friday, April 4, 2025 at 4:15:14 AM UTC-7 moo...@google.com wrote: > >> Does our implementation match these new edits? >> >> >> Generally yes, there are some thing that are not implemented yet, like

[blink-dev] Re: Intent to Ship: Call stacks in crash reports from unresponsive web pages

2025-03-17 Thread 'Dan Clark' via blink-dev
LGTM1 On Monday, March 17, 2025 at 11:24:06 AM UTC-7 sligh...@chromium.org wrote: > I'm recused on this one, but would like to see it move forward quickly. > Great work. > > On Friday, March 14, 2025 at 1:32:38 PM UTC-7 Chromestatus wrote: > >> Contact emails issac...@microsoft.com, seth.b...@mi

[blink-dev] Re: Intent to Extend Experiment: Interest Invokers

2025-04-22 Thread 'Dan Clark' via blink-dev
Thanks Mason! LGTM to continue experimenting in M138-M140 inclusive. -- Dan On Tuesday, April 22, 2025 at 12:52:14 PM UTC-7 mas...@chromium.org wrote: > Hi Dan, sure: > > On Monday, April 21, 2025 at 11:26:33 AM UTC-7 dan...@microsoft.com wrote: > > >- Draft spec (early draft is ok, but must

Re: [blink-dev] Intent to Implement and Ship: Integrity Policy for scripts

2025-04-23 Thread 'Dan Clark' via blink-dev
LGTM3 On Wednesday, April 23, 2025 at 8:34:55 AM UTC-7 Chris Harrelson wrote: > LGTM2, assuming the spec lands before the feature ships. > > On Wed, Apr 23, 2025 at 4:07 AM Mike Taylor wrote: > >> LGTM1 >> On 4/23/25 5:12 AM, Yoav Weiss (@Shopify) wrote: >> >> Contact emails yoav...@chromium.org

[blink-dev] Re: Intent to Ship: Viewport Segments Enumeration API

2025-04-30 Thread 'Dan Clark' via blink-dev
Looking at the linked WPTs, just 1 out of 3 is passing in Chrome Canary with experimental features enabled: https://wpt.fyi/results/viewport-segments?label=master&label=experimental&aligned Is that the expected result? Thanks, Dan On Wednesday, April 30, 2025 at 8:33:13 AM UTC-7 yoav...@chromiu

Re: [blink-dev] Re: Intent to Ship: Viewport Segments Enumeration API

2025-05-05 Thread 'Dan Clark' via blink-dev
LGTM3 On Monday, May 5, 2025 at 11:12:09 AM UTC-7 Chris Harrelson wrote: > LGTM2 > > On Mon, May 5, 2025 at 11:08 AM Alex Russell > wrote: > >> Thanks for all these updates. LGTM1. >> >> On Friday, May 2, 2025 at 5:41:23 AM UTC-7 alexis...@intel.com wrote: >> >>> Hi, >>> >>> All WPT tests are n

Re: [EXTERNAL] Re: [blink-dev] Re: Intent to Ship: System accent color for accent-color property.

2025-05-02 Thread 'Dan Clark' via blink-dev
LGTM3 It turns out from the WebKit position thread that this is already shipped there as well. Request to use platform accent color for accent-color property as default option · Issue #485 · WebKit/standards-positions -- Dan On Wedne

[blink-dev] Re: Intent to Ship: Document-Isolation-Policy

2025-04-21 Thread 'Dan Clark' via blink-dev
LGTM2 On Wednesday, April 16, 2025 at 8:11:46 AM UTC-7 sligh...@chromium.org wrote: > LGTM1. We're excited to see this move forward. > > On Wednesday, April 16, 2025 at 6:22:26 AM UTC-7 Chromestatus wrote: > >> Contact emails cl...@google.com >> >> Explainer >> https://github.com/WICG/document

[blink-dev] Re: Intent to Ship: Allow to reference an external document's root element by omitting the fragment.

2025-04-21 Thread 'Dan Clark' via blink-dev
LGTM2 On Monday, April 21, 2025 at 11:13:39 AM UTC-7 sligh...@chromium.org wrote: > LGTM1 > > On Wednesday, April 16, 2025 at 9:47:50 AM UTC-7 dma...@microsoft.com > wrote: > >> *Contact emails* >> >> dma...@microsoft.com >> >> *Explainer* >> >> >> https://github.com/MicrosoftEdge/MSEdgeExplaine

[blink-dev] Re: Intent to Extend Experiment: Interest Invokers

2025-04-21 Thread 'Dan Clark' via blink-dev
Hi Mason, Can you outline any progress made on the areas listed in https://www.chromium.org/blink/launching-features/#origin-trials? I know that the spec discussions are ongoing, and the TAG review is in progress, but I'm less up-to-date with what's going on in the other areas. - Draft spec

Re: [EXTERNAL] Re: [blink-dev] Intent to Ship: On-device Web Speech API

2025-04-21 Thread 'Dan Clark' via blink-dev
Thanks Evan for the follow-up. The response to the TAG feedback mentions a few changes that would be web-facing: - Removing "cloud-only" - Changing installOnDevice to support multiple langs in a single call, including the consideration of a more expressive return value type. - Adding an AbortSi

[blink-dev] Re: Intent to Ship: Nested view transitions

2025-02-28 Thread 'Dan Clark' via blink-dev
Something about the WPT results was surprising to me. It looks like Firefox is passing all of them, even in stable ( https://wpt.fyi/results/css/css-view-transitions/nested?label=master&label=stable&aligned), despite not having shipped view transitions more generally yet: https://wpt.fyi/result

Re: [EXTERNAL] [blink-dev] Intent to Ship: CSS anchor positioning remembered scroll offset

2025-03-10 Thread 'Dan Clark' via blink-dev
Thanks! LGTM1. On Wednesday, March 5, 2025 at 11:47:20 PM UTC-8 mste...@chromium.org wrote: > Daniel Clark writes: > > > Can you remind me what the current behavior is without the remembered > > scroll offset? I am wondering if there’s any scenario where changing > > this could break existing an

Re: [blink-dev] Intent to Ship: Link rel=payment to support push payments

2025-02-26 Thread 'Dan Clark' via blink-dev
I see that most of the review gates were requested but the enterprise one is still missing, can you please request that one too? -- Dan On Monday, February 24, 2025 at 6:53:40 AM UTC-8 mike...@chromium.org wrote: > Hi there - would you mind requesting the various review gates (privacy, > secu

Re: [blink-dev] Intent to Ship: Update ProgressEvent to use double type for 'loaded' and 'total'

2025-02-26 Thread 'Dan Clark' via blink-dev
The spec PR thread has a Gecko bug linked ( https://bugzilla.mozilla.org/show_bug.cgi?id=1943649), but I don't see a WebKit bug. Can you please file one to ensure we don't lost track of WebKit aligning to the proposed change? -- Dan On Wednesday, February 19, 2025 at 8:15:40 PM UTC-8 Mingyu Lei

Re: [blink-dev] Intent to Ship: ::scroll-marker and ::scroll-marker-group for Carousel, ::column pseudo element for Carousel and ::scroll-button() pseudo elements

2025-02-26 Thread 'Dan Clark' via blink-dev
LGTM3 On Wednesday, February 26, 2025 at 8:12:24 AM UTC-8 mike...@chromium.org wrote: > LGTM2 > On 2/25/25 4:22 PM, Rick Byers wrote: > > > > On Tue, Feb 25, 2025 at 1:00 PM Robert Flack wrote: > >> >> On Fri, Feb 21, 2025 at 5:19 PM Rick Byers wrote: >> >>> I'm excited to see this ship! >>>

Re: [EXTERNAL] Re: [blink-dev] Intent to Ship: Interpolation progress functional notations: CSS *progress() functions

2025-02-25 Thread 'Dan Clark' via blink-dev
LGTM3, seconding the request to remove Issue 3 or move/update it so it's clear which parts it still covers. On Tuesday, February 25, 2025 at 7:43:36 AM UTC-8 mike...@chromium.org wrote: > LGTM2, but can you remove inline issue 3 from the spec if it's no longer > relevant? It's confusing otherw

Re: [blink-dev] Intent to Ship: CSS reading-flow, reading-order properties

2025-04-02 Thread 'Dan Clark' via blink-dev
LGTM3 On Wednesday, April 2, 2025 at 8:28:54 AM UTC-7 sligh...@chromium.org wrote: > LGTM2 > > On Wednesday, April 2, 2025 at 6:57:22 AM UTC-7 Daniel Bratell wrote: > >> LGTM1 >> >> /Daniel >> On 2025-04-01 00:11, Di Zhang wrote: >> >> Contact emails >> >> dizh...@chromium.org >> >> Explainer >

[blink-dev] Re: Intent to Ship: Update QuotaExceededError to a DOMException derived interface

2025-05-06 Thread 'Dan Clark' via blink-dev
Can you please request the other review bits in ChromeStatus (privacy, security, etc)? -- Dan On Tuesday, May 6, 2025 at 3:42:02 PM UTC-7 ay...@chromium.org wrote: > Contact emails > > ay...@chromium.org, dom...@chromium.org > > Explainer > > https://github.com/whatwg/webidl/pull/1465 > > Spec

Re: [blink-dev] Intent to Ship: Pass 'Sec-Purpose: prefetch' header with

2025-05-13 Thread 'Dan Clark' via blink-dev
LGTM1 On Monday, May 12, 2025 at 3:00:13 PM UTC-7 stev...@microsoft.com wrote: > Yes, thanks for the reminder. This is my first Intent to Ship so will note > this for future ones! > > On Monday, May 12, 2025 at 2:32:23 PM UTC-7 mike...@chromium.org wrote: > >> Before continuing the review, coul

Re: [EXTERNAL] Re: [blink-dev] Intent to Ship: Fire error event instead of throwing for CSP blocked worker

2025-05-21 Thread 'Dan Clark' via blink-dev
LGTM2 On Wednesday, May 21, 2025 at 11:29:13 AM UTC-7 mike...@chromium.org wrote: > Sounds good - thanks for the explanation. > > LGTM1 > On 5/21/25 12:35 PM, Liang Zhao (REDMOND) wrote: > > Most exception handlers just eat the exception, some output some not > supported message. A few try to fa

[blink-dev] Re: Intent to Ship: Web app scope extensions

2025-06-02 Thread 'Dan Clark' via blink-dev
> Is this feature fully tested by web-platform-tests ? > No I assume lack of WPTs is due to limitations of testing web app functionality in web-platform-tests. In the past it looks like manual WPTs have be

Re: [EXTERNAL] [blink-dev] Intent to Ship: Web Speech API contextual biasing

2025-07-14 Thread 'Dan Clark' via blink-dev
(re-sending from the correct account) Thanks for these updates! I think it's kind of borderline whether there's enough complexity here to merit a TAG review. My preference is to go ahead and request one in case they do have feedback. -- Dan On Thursday, July 10, 2025 at 12:59:03 PM UTC-7 ev..

[blink-dev] Re: Intent to Ship: Support restrictOwnAudio

2025-07-21 Thread 'Dan Clark' via blink-dev
*> Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, ChromeOS, Android, and Android WebView)?* > No My understanding is that this has to be "No" because getDisplayMedia is not supported on all platforms, but can you confirm it will ship everywhere that getDisplayMe

[blink-dev] Re: Intent to Ship: ToggleEvent source attribute

2025-07-21 Thread 'Dan Clark' via blink-dev
LGTM1 On Monday, July 21, 2025 at 1:04:01 PM UTC-7 jar...@chromium.org wrote: > Contact emailsjar...@chromium.org > > ExplainerNone > > Specification > https://html.spec.whatwg.org/multipage/interaction.html#the-toggleevent-interface > https://github.com/whatwg/html/pull/11186 > > Summary > > The

Re: [blink-dev] Re: Intent to Ship: CSS find-in-page highlight pseudos

2025-07-23 Thread 'Dan Clark' via blink-dev
The API Owners discussed this today and had some concerns that the motivation is not as clear as it could be. We'd like to better understand the developer need for styling these highlights. Looking at the Motivation section

Re: [EXTERNAL] [blink-dev] Intent to Ship: ServiceWorkerAutoPreload

2025-07-28 Thread 'Dan Clark' via blink-dev
Thanks for getting the spec PR landed, and for the clarifications on when the preload will be triggered. LGTM1. -- Dan On Sunday, July 27, 2025 at 10:06:56 PM UTC-7 yyana...@chromium.org wrote: > > > 2025年7月28日(月) 13:05 Shunya Shishido : > >> >> >> On Fri, Jul 25, 2025 at 2:37 PM Yoshisato Yana