Re: [blink-dev] Intent to remove: navigator.xr.supportsSession

2025-02-19 Thread Daniel Bratell
LGTM3 /Daniel On 2025-02-13 11:40, Philip Jägenstedt wrote: https://chromestatus.com/metrics/feature/timeline/popularity/2416 on its own makes the risk look very tolerable, and together with the outreach to WebXR frameworks it seems like a safe move. LGTM2 with the reviews requested, as Domi

Re: [blink-dev] Intent to Ship: Interpolation progress functional notations: CSS *progress() functions

2025-02-19 Thread Daniil Sakhapov
I imagine the use case example would be using e.g. container-progress inside color(), so that you can change the color, based on some ancestor parent's size - 'color: rgb(container-progress(width of my-container, var(--container-min-size), var(--container-max-size)), ..., ...);' Ah, for some re

Re: [blink-dev] Intent to Ship: CSS Sign-Related Functions: abs(), sign()

2025-02-19 Thread Daniil Sakhapov
The first 3 tests are for image-resolution property, which we (and others?) don't support. The last 3 tests are for grid-template-rows, which requires also display: grid, and some elements inside the grid, but the person who added the test didn't change HTML, so the test is wrongly expects a val

Re: [blink-dev] Intent to Ship: Create service worker client and inherit service worker controller for srcdoc iframe

2025-02-19 Thread Yoav Weiss (@Shopify)
On Thursday, February 13, 2025 at 5:50:24 AM UTC+1 Domenic Denicola wrote: I'll refrain from giving formal LGTM to let more discussion settle, but I want to provide my API owner perspective that we should approve this without requiring the specification work to finish up. Specifying this is u

Re: [blink-dev] Intent to Ship: Update ProgressEvent to use double type for 'loaded' and 'total'

2025-02-19 Thread Yoav Weiss (@Shopify)
Can you please request reviews for privacy, security, enterprise, debuggability and testing? On Monday, February 17, 2025 at 6:07:07 PM UTC+1 Mingyu Lei wrote: > These two fields are used to indicate the loaded and total progress, it > will be very surprised to see some sites passing in a negat

[blink-dev] Re: Intent to Ship: Invoker Commands; the command and commandfor attributes

2025-02-19 Thread Yoav Weiss (@Shopify)
LGTM1 conditional on landing the PR On Monday, February 17, 2025 at 11:25:03 PM UTC+1 Chromestatus wrote: Contact emails chrom...@keithcirkel.co.uk, lwar...@igalia.com Explainer https://open-ui.org/components/invokers.explainer This is exciting!! Specification https://github.com/whatwg/h

Re: [blink-dev] Intent to Ship: highlightsFromPoint API

2025-02-19 Thread Robert Flack
Ah, I put together a test page with some examples and I see that in fact we only return the highlights if they were not obscured. This wasn't clear to me from the spec, especially as the analogous API elementsFromPoint returns all elements, even those obscure

Re: [blink-dev] Intent to Ship: Interpolation progress functional notations: CSS *progress() functions

2025-02-19 Thread Daniel Bratell
I also find it a bit hard to understand what it is meant to accomplish and how it does so. I might be missing some basic knowledge block here, but ... why? Maybe when the tests are updated I can look at those, but if you were to explain this to someone like ... I don't know, a manager, how wou

Re: [blink-dev] Intent to Ship: highlightsFromPoint API

2025-02-19 Thread Robert Flack
When you add a click handler to get the highlights from a given point and interact with the highlight, how can you tell whether the returned highlight is topmost and should be handled? E.g. how can you tell that there's not a dialog element or some other absolute positioned element painted over

Re: [blink-dev] Intent to Ship: Partitioning :visited links history

2025-02-19 Thread Yoav Weiss (@Shopify)
On Tuesday, February 18, 2025 at 6:36:45 PM UTC+1 jacka...@gmail.com wrote: On Sun, Feb 16, 2025 at 5:43 PM Domenic Denicola wrote: Very exciting to see progress on this longstanding problem! +100 On Sat, Feb 15, 2025 at 3:35 AM Kyra Seevers wrote: Contact emails kyraseev...@chr

Re: [blink-dev] Intent to Ship: CSS Sign-Related Functions: abs(), sign()

2025-02-19 Thread Yoav Weiss (@Shopify)
Thanks for catching us up here! On Wednesday, February 19, 2025 at 11:29:12 AM UTC+1 Daniil Sakhapov wrote: The first 3 tests are for image-resolution property, which we (and others?) don't support. Why not? The last 3 tests are for grid-template-rows, which requires also display: grid, an

Re: [blink-dev] Intent To Ship: Allow SameSite=None Cookies in First-Party Sandboxed Contexts

2025-02-19 Thread Vladimir Levin
LGTM3 On Wednesday, February 19, 2025 at 11:29:50 AM UTC-5 Chris Harrelson wrote: > LGTM2 > > On Wed, Feb 19, 2025 at 8:28 AM Alex Russell > wrote: > >> LGTM1; thanks for making sure to follow up on the spec PRs. >> >> On Thursday, February 13, 2025 at 6:44:27 AM UTC-8 joha...@google.com >> wr

Re: [EXTERNAL] Re: [blink-dev] Intent to Ship: Service Worker client URL ignore history.pushState changes

2025-02-19 Thread Chris Harrelson
LGTM3 On Thu, Feb 13, 2025 at 10:41 AM 'Dave Risney' via blink-dev < blink-dev@chromium.org> wrote: > Thanks everyone! > >- FWIW, it takes some digging to understand how this matchAll test >failure is realted to Client.url. Do we plan to add a more explicit test >that reads client.url

Re: [blink-dev] Intent To Ship: Allow SameSite=None Cookies in First-Party Sandboxed Contexts

2025-02-19 Thread Chris Harrelson
LGTM2 On Wed, Feb 19, 2025 at 8:28 AM Alex Russell wrote: > LGTM1; thanks for making sure to follow up on the spec PRs. > > On Thursday, February 13, 2025 at 6:44:27 AM UTC-8 joha...@google.com > wrote: > >> > The spec PR for this is still marked as a draft, and as such hasn't >> received signif

Re: [blink-dev] Intent To Ship: Allow SameSite=None Cookies in First-Party Sandboxed Contexts

2025-02-19 Thread Alex Russell
LGTM1; thanks for making sure to follow up on the spec PRs. On Thursday, February 13, 2025 at 6:44:27 AM UTC-8 joha...@google.com wrote: > > The spec PR for this is still marked as a draft, and as such hasn't > received significant editor review. Can you say more about what's blocking > it from

Re: [blink-dev] Intent to Ship: Partitioning :visited links history

2025-02-19 Thread Alex Russell
I'm also super excited about this. Has been a long time coming. Thank you for making it happen, Kyra! On compat, can we allay the concerns here with a fractional rollout (e.g., ~10% for a couple of releases) and a checkin at some point(s) before we go to 100%? Best, Alex On Wednesday, Februa

Re: [blink-dev] Intent to Ship: CSS Sign-Related Functions: abs(), sign()

2025-02-19 Thread Daniil Sakhapov
I don't know why we don't support image-resolution property, it seems like noone does. It would make most sense to remove those tests for image-resolution, and move the tests to a separate file for grid-template-rows. среда, 19 февраля 2025 г. в 13:39:36 UTC+1, Yoav Weiss: > Thanks for catchi

Re: [blink-dev] Re: Intent to Ship: Invoker Commands; the command and commandfor attributes

2025-02-19 Thread Vladimir Levin
LGTM3 On Wednesday, February 19, 2025 at 11:09:57 AM UTC-5 Chris Harrelson wrote: > LGTM2 > > On Wed, Feb 19, 2025 at 4:33 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> LGTM1 conditional on landing the PR >> >> >> >> On Monday, February 17, 2025 at 11:25:03 PM UTC+1 Chromestatu

Re: [blink-dev] Re: Intent to Ship: H26x Codec support updates for MediaRecorder

2025-02-19 Thread Philip Jägenstedt
Hi, The API owners (Dan, Alex, Vlad, Yoav, Mike, Chris, Daniel, me) discussed this today. We'd like to understand a bit better where HEVC is already supported and what contexts don't yet support it. As mentioned, HEVC (encode and decode) is already supported in WebCodecs. The tests on wpt.fyi are

Re: [blink-dev] Intent to Ship: CSS Sign-Related Functions: abs(), sign()

2025-02-19 Thread obr...@igalia.com
The last 3 tests are for grid-template-rows, which requires also display: grid, and some elements inside the grid, but the person who added the test didn't change HTML, so the test is wrongly expects a value, but in always will be 'none'. You don't need `display: grid` in order to compute `g

Re: [blink-dev] Intent to Ship: Interpolation progress functional notations: CSS *progress() functions

2025-02-19 Thread 'Penelope McLachlan' via blink-dev
Some other example use cases: - Trigger layout changes as the user scrolls for storytelling or creative direction e.g. Create gradients that smoothly shift colors or positions based on scroll progress or container size, or apply filter effects like blur or saturation based on scroll position or co

Re: [blink-dev] Intent to Ship: Update ProgressEvent to use double type for 'loaded' and 'total'

2025-02-19 Thread Mingyu Lei
Sorry I misunderstood the process before and I have just requested for those reviews. On Wednesday, February 19, 2025 at 8:40:54 PM UTC+9 Yoav Weiss wrote: > Can you please request reviews for privacy, security, enterprise, > debuggability and testing? > > On Monday, February 17, 2025 at 6:07:

Re: [blink-dev] Intent to Ship: Partitioning :visited links history

2025-02-19 Thread Yoav Weiss (@Shopify)
One point worth clarifying - this intent doesn't relax the current restrictions on visited styling, right? Are there plans to follow up with that? That seems like something designers would be happy with.. On Wednesday, February 19, 2025 at 9:55:13 PM UTC+1 Kyra Seevers wrote: Hi all - thanks fo

Re: [blink-dev] Intent to Remove: SwiftShader Fallback

2025-02-19 Thread 'David Adrian' via blink-dev
> I wrote about this previously but I'm still concerned this is a major breaking change for existing published WebGL content on the web. If the figure of 2.7% comes from my previous citing of Web3DSurvey It does, not it comes from Chrome's metrics system. > Does Google have their own internal d

RE: [EXTERNAL] Re: [blink-dev] Intent to Ship: Interpolation progress functional notations: CSS *progress() functions

2025-02-19 Thread 'Daniel Clark' via blink-dev
The spec section https://drafts.csswg.org/css-values-5/#progress still has this warning at the top: “This section is an exploratory draft, and not yet approved by the CSSWG [Issue #6245]”. Scanning through the linked issue I’m unclear on whether t

Re: [blink-dev] Intent to Ship: Partitioning :visited links history

2025-02-19 Thread Kyra Seevers
Hi all - thanks for your review! > Couldn't this be tested with reftests ? I'm happy to work on a reftest to add the benefit of test automation, but in the meantime, I have landed a manual test

Re: [blink-dev] Intent to Ship: Partitioning :visited links history

2025-02-19 Thread Tab Atkins Jr.
On Wed, Feb 19, 2025 at 3:44 AM Yoav Weiss (@Shopify) wrote: > Could the relevant spec language live in a PR? Having such language would > make it easier to evaluate the gap between the current CSS spec and the > ability to specify this behavior in an interoperable way. The current appendix sho

Re: [blink-dev] Re: Intent to Ship: H26x Codec support updates for MediaRecorder

2025-02-19 Thread 'Markus Handell' via blink-dev
I'll need to defer definitive answers regarding and MSE questions to Dale. But selecting video/mp4;codecs=hvc1.1.6.L186.B0,opus as format on https://webrtc.github.io/samples/src/content/getusermedia/record/ with MediaRecorderHEVCSupport enabled yields a video that plays back in the same window. >

Re: [blink-dev] Intent to Ship: Create service worker client and inherit service worker controller for srcdoc iframe

2025-02-19 Thread 'Liang Zhao' via blink-dev
On Wednesday, February 19, 2025 at 3:34:23 AM UTC-8 Yoav Weiss (@Shopify) wrote: On Thursday, February 13, 2025 at 5:50:24 AM UTC+1 Domenic Denicola wrote: I'll refrain from giving formal LGTM to let more discussion settle, but I want to provide my API owner perspective that we should approve

Re: [blink-dev] Re: Intent to Ship: Invoker Commands; the command and commandfor attributes

2025-02-19 Thread Chris Harrelson
LGTM2 On Wed, Feb 19, 2025 at 4:33 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM1 conditional on landing the PR > > > > On Monday, February 17, 2025 at 11:25:03 PM UTC+1 Chromestatus wrote: > > Contact emails chrom...@keithcirkel.co.uk, lwar...@igalia.com > > Explainer https://