LGTM3

/Daniel

On 2025-02-13 11:40, Philip Jägenstedt wrote:
https://chromestatus.com/metrics/feature/timeline/popularity/2416 on its own makes the risk look very tolerable, and together with the outreach to WebXR frameworks it seems like a safe move.

LGTM2 with the reviews requested, as Dominik suggested.

On Thu, Feb 13, 2025 at 5:01 AM Domenic Denicola <dome...@chromium.org> wrote:

    Can you request the various review gates in ChromeStatus?

    On Thursday, February 13, 2025 at 3:55:58 AM UTC+9 Rick Byers wrote:

        A barely used WebXR-specific method that's been deprecated for
        5+ years seems very low risk to me. LGTM1 to remove.

        Rick

        On Wed, Feb 12, 2025 at 1:52 PM Brandon Jones
        <bajo...@chromium.org> wrote:

            Primary eng (and PM) emails

            bajo...@chromium.org


            Summary

            navigator.xr.supportsSession was replaced in the WebXR
            spec by the navigator.xr.isSessionSupported method in
            September of 2019 after receiving feedback on the API
            shape from the TAG. It has been marked as deprecated in
            Chromium since then, producing a console warning
            redirecting developers to the updated API.


            Motivation

            The API has been marked as deprecated for over 5 years.
            The function that replaced it provides identical
            functionality with better ergonomics. There is no need to
            retain the deprecated method.


            Interoperability and Compatibility Risk

            Extremely low. WebXR usage is low overall, and usage of
            this specific call is lower still, as shown here
            <https://chromestatus.com/metrics/feature/timeline/popularity/2416>.
            Additionally, all major frameworks that are used to build
            WebXR content have been confirmed to have been updated to
            use the newer call, and all pages with WebXR content that
            were checked are using the newer method.


            Edge: Supported the API change when originally made
            <https://github.com/immersive-web/webxr/pull/841>

            Firefox: Never implemented

            Safari: Never implemented


            Alternative implementation suggestion for web developers

            navigator.xr.isSessionSupported is a full replacement for
            this method.


            Usage information from UseCounter
            
<https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/page/UseCounter.h&sq=package:chromium&type=cs&q=file:UseCounter.h%20Feature&l=39>

            https://chromestatus.com/metrics/feature/timeline/popularity/2416


            Entry on the feature dashboard <https://www.chromestatus.com/>

            https://chromestatus.com/feature/5114816316047360

-- You received this message because you are subscribed to
            the Google Groups "blink-dev" group.
            To unsubscribe from this group and stop receiving emails
            from it, send an email to blink-dev+unsubscr...@chromium.org.
            To view this discussion visit
            
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEGwwi2A6D5qauaU4nQHBB6%3D6H6eo6WMEv9tFS8%3DKk4hYu%3D9rg%40mail.gmail.com
            
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEGwwi2A6D5qauaU4nQHBB6%3D6H6eo6WMEv9tFS8%3DKk4hYu%3D9rg%40mail.gmail.com?utm_medium=email&utm_source=footer>.

-- You received this message because you are subscribed to the Google
    Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to blink-dev+unsubscr...@chromium.org.
    To view this discussion visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b39bd741-be84-4730-9293-f45e4def4631n%40chromium.org
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b39bd741-be84-4730-9293-f45e4def4631n%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYchpNM8d36OpjcVO6QVznzJ4gEgnQKqZbKub4%2BXTLNZ2Q%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYchpNM8d36OpjcVO6QVznzJ4gEgnQKqZbKub4%2BXTLNZ2Q%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/0c3d962e-058b-4aa5-bba7-716f00161106%40sarasas.se.

Reply via email to