Re: [Bioc-devel] helper function arguments: best practice

2021-04-19 Thread Manders-2, F.M.
ne for the lapply (or the helper function itself) that the locale environment of the main function should be used, but this is at least a workable solution. But many thanks for your suggestion nonetheless :) Best Severin On 19.04.21 11:14, Manders-2, F.M. wrote: &g

Re: [Bioc-devel] helper function arguments: best practice

2021-04-19 Thread Manders-2, F.M.
Hi Severin, I'm not sure what the best practice is, but since your anonymous function is defined inside your main function, you don't need to supply it with all those arguments. This should also work, because R has lexical scoping: main_function <- function(alot, of, paramters) { var01 <- foo

Re: [Bioc-devel] Orchid ID invalid according to BiocCheck

2020-10-19 Thread Manders-2, F.M.
Yes, I’ll create a PR. From: Vincent Carey Date: Monday, 19 October 2020 at 12:36 To: "Manders-2, F.M." , bioc-devel Subject: Fwd: [Bioc-devel] Orchid ID invalid according to BiocCheck forwarding to bioc-devel -- Forwarded message - From: Vincent Carey

Re: [Bioc-devel] Orchid ID invalid according to BiocCheck

2020-10-19 Thread Manders-2, F.M.
It seems to be a valid ID: https://support.orcid.org/hc/en-us/articles/360053289173-Why-does-my-ORCID-iD-have-an-X- Maybe BiocCheck doesn’t realize the ID can end with an X? From: Vincent Carey Date: Monday, 19 October 2020 at 12:20 To: "Manders-2, F.M." Cc: Alessandro Lussana via

Re: [Bioc-devel] Orchid ID invalid according to BiocCheck

2020-10-19 Thread Manders-2, F.M.
Yes, the X is correct (https://orcid.org/-0001-6197-347X). I don’t know why I have an X there and not a number. From: Vincent Carey Date: Monday, 19 October 2020 at 12:20 To: "Manders-2, F.M." Cc: Alessandro Lussana via Bioc-devel Subject: Re: [Bioc-devel] Orchid ID invalid ac

[Bioc-devel] Orchid ID invalid according to BiocCheck

2020-10-19 Thread Manders-2, F.M.
Hi all, BiocCheck is giving me a note that my ORCID ID is invalid ("Invalid ORCID ID for Freek Manders"). However, I see nothing wrong with the ID. It also seems to work well on the dev page of my package (MutationalPatterns) Clicking on the green ID circle, sends me to my page just fine. Is the

Re: [Bioc-devel] Vignette examples

2020-09-10 Thread Manders-2, F.M.
Hi Emilie, There are two possible problems I could think of. Did you remember to load your package in the vignette? Are your functions exported in the NAMESPACE of your package? With kind regards, Freek Manders On 10/09/2020, 16:38, "Bioc-devel on behalf of Emilie Secherre" wrote: Hello,

Re: [Bioc-devel] Bioconductor Package Submission - Removing git pack objects

2020-08-14 Thread Manders-2, F.M.
Hi Joseph, When you run 'R CMD build' you should get a release tarball, which shouldn't contain this .git folder. If you perform the 'R CMD check' on the tarball, you shouldn't get this warning. If you still get the warning, or have other files that generate this warning, then you could try to

[Bioc-devel] Author/maintainer field no longer accepted.

2020-08-10 Thread Manders-2, F.M.
Hi All, R BiocCheck no longer seems to accept a Author/Maintainer field. (https://github.com/Bioconductor/BiocCheck/commit/e0176f6591c771774f6cb05d4ff8bc1b145ad10e) * Checking for valid maintainer... * ERROR: Remove Maintainer field. Use Authors@R [cre] designation. However, the package gui

Re: [Bioc-devel] VariantAnnotation::readVcf() sets the wrong seqlevelsStyle in devel

2020-08-07 Thread Manders-2, F.M.
Hi Herve, The performance of seqlevelStyle when the genome of a GRanges object has been set, still seems strange to me. Here is some example code I ran in the Bioconductor:devel docker: gr <- GRanges(rep(c("chr2", "chr3", "chrM"), 2), IRanges(1:6, 10)) genome(gr) <- "hg19" seqlevelsStyle(gr) <- "

[Bioc-devel] ccfindR install fails

2020-07-06 Thread Manders-2, F.M.
Hi all, I’m trying to install the devel version of the ccfindR package to test my package (MutationalPatterns). It passed the nightly build tests, so I thought it should work. I used the development docker container to try and install the package, but it fails because its dependency “Rmpi” fails