Yes, I’ll create a PR. From: Vincent Carey <st...@channing.harvard.edu> Date: Monday, 19 October 2020 at 12:36 To: "Manders-2, F.M." <f.m.mand...@prinsesmaximacentrum.nl>, bioc-devel <bioc-devel@r-project.org> Subject: Fwd: [Bioc-devel] Orchid ID invalid according to BiocCheck
forwarding to bioc-devel ---------- Forwarded message --------- From: Vincent Carey <st...@channing.harvard.edu<mailto:st...@channing.harvard.edu>> Date: Mon, Oct 19, 2020 at 6:33 AM Subject: Re: [Bioc-devel] Orchid ID invalid according to BiocCheck To: Manders-2, F.M. <f.m.mand...@prinsesmaximacentrum.nl<mailto:f.m.mand...@prinsesmaximacentrum.nl>> Cc: Alessandro Lussana via Bioc-devel <Bioc-devel@r-project.org<mailto:Bioc-devel@r-project.org>> looks like BiocCheck/checks.R: validID <- grepl("[0-9]{4}-[0-9]{4}-[0-9]{4}-[0-9]{4}", orcid) has to change -- do you have time to determine the correct regex for this and file a PR? On Mon, Oct 19, 2020 at 6:31 AM Manders-2, F.M. <f.m.mand...@prinsesmaximacentrum.nl<mailto:f.m.mand...@prinsesmaximacentrum.nl>> wrote: Yes, the X is correct (https://orcid.org/0000-0001-6197-347X). I don’t know why I have an X there and not a number. From: Vincent Carey <st...@channing.harvard.edu<mailto:st...@channing.harvard.edu>> Date: Monday, 19 October 2020 at 12:20 To: "Manders-2, F.M." <f.m.mand...@prinsesmaximacentrum.nl<mailto:f.m.mand...@prinsesmaximacentrum.nl>> Cc: Alessandro Lussana via Bioc-devel <Bioc-devel@r-project.org<mailto:Bioc-devel@r-project.org>> Subject: Re: [Bioc-devel] Orchid ID invalid according to BiocCheck person("Freek", "Manders", email = "f.m.mand...@prinsesmaximacentrum.nl<mailto:f.m.mand...@prinsesmaximacentrum.nl>", role = c("aut"), comment = c(ORCID = "0000-0001-6197-347X")), is what I see in a current checkout. is "X" at the end correct? maybe there is an encoding issue? On Mon, Oct 19, 2020 at 6:14 AM Manders-2, F.M. <f.m.mand...@prinsesmaximacentrum.nl<mailto:f.m.mand...@prinsesmaximacentrum.nl>> wrote: Hi all, BiocCheck is giving me a note that my ORCID ID is invalid ("Invalid ORCID ID for Freek Manders"). However, I see nothing wrong with the ID. It also seems to work well on the dev page of my package (MutationalPatterns) Clicking on the green ID circle, sends me to my page just fine. Is there a mistake in BiocCheck? Should I just ignore this? With kind regards, Freek Manders [[alternative HTML version deleted]] _______________________________________________ Bioc-devel@r-project.org<mailto:Bioc-devel@r-project.org> mailing list https://stat.ethz.ch/mailman/listinfo/bioc-devel The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail. The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail. [[alternative HTML version deleted]] _______________________________________________ Bioc-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/bioc-devel
