RE: Form.pm (next instalment of code review)

2002-07-15 Thread Michael Dreksler
Guys, Can I just say I am getting a lot out of reading your discussion here. Definitely to be encouraged :-) Michael -- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Form.pm (next installment of code review)

2002-07-08 Thread Ovid
--- [EMAIL PROTECTED] wrote: > Curtis, > Thank you for your observations and compliments (first paragraph). No your >right, I haven't > been using taint (*I hang my head in shame*). Actually, you may not *want* to use taint checking in your code samples. The end user should control that a

Re: Form.pm (next installment of code review)

2002-07-08 Thread perl-dvd
that the system may be using because on a windows server this is different than on a Linux box. I will check how CGI.pm does it to get some other ideas. Thanks, David - Original Message - From: "Ovid" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]

Re: Form.pm (next installment of code review)

2002-07-05 Thread Ovid
Hi David, While I raise quite a few issues here, I have to say that I've rarely seen anyone present a CGI.pm alternative that supports uploads. I'm quite impressed, so keep that in mind while I pick it apart :) I'll ignore anything I may have covered in my discussion about the previous subrout

Re: Form.pm

2002-07-03 Thread perl-dvd
t; <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]>; "Todd Wade" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Wednesday, July 03, 2002 2:38 PM Subject: Re: Form.pm --- [EMAIL PROTECTED] wrote: > I would be happy to take a look at, but I am uncertain how to access this

Re: Form.pm

2002-07-03 Thread Ovid
--- [EMAIL PROTECTED] wrote: > I would be happy to take a look at, but I am uncertain how to access this >archive. I remove > the > emails I get from mailing lists each day, and don't have past records other than >emails I have > sent. > Perhaps you could reply with the proper solution, or

Re: Form.pm

2002-07-03 Thread perl-dvd
To: <[EMAIL PROTECTED]> Sent: Wednesday, July 03, 2002 4:35 PM Subject: Re: Form.pm <[EMAIL PROTECTED]> wrote in message 00d301c222b6$440166d0$d381f6cc@david">news:00d301c222b6$440166d0$d381f6cc@david... > > I appreciate your feedback. The reason I was frustrated

Re: Form.pm

2002-07-03 Thread Todd Wade
<[EMAIL PROTECTED]> wrote in message 00d301c222b6$440166d0$d381f6cc@david">news:00d301c222b6$440166d0$d381f6cc@david... > > I appreciate your feedback. The reason I was frustrated with Todd is because it was strictly > criticism. Basically the tone was "Your wrong, and you shouldn't be mak

Re: Form.pm

2002-07-03 Thread perl-dvd
<[EMAIL PROTECTED]> Sent: Wednesday, July 03, 2002 11:46 AM Subject: Re: Form.pm perl-dvd wrote at Wed, 03 Jul 2002 19:22:49 +0200: > > Yes, my lines of code are long. For this I apologize. I work on 1600x1200 with >Homesite > which > doesn't

Re: Form.pm

2002-07-03 Thread perl-dvd
L PROTECTED]> Sent: Wednesday, July 03, 2002 12:28 PM Subject: Re: Form.pm On Wed, Jul 03, 2002 at 11:22:49AM -0600, [EMAIL PROTECTED] wrote: >I do handle POST, I guess I didn't make that clear before. Read through the >attached lib and >you will see that is true. That is

Re: Form.pm

2002-07-03 Thread Niko Gunadi
On Wed, Jul 03, 2002 at 11:22:49AM -0600, [EMAIL PROTECTED] wrote: >I do handle POST, I guess I didn't make that clear before. Read through the >attached lib and >you will see that is true. That is what parse_mform_input is about. Ok ... maybe this is a stupid question (i'm juz a newbie =p

Re: Form.pm

2002-07-03 Thread perl-dvd
at keeps eluding me, but anyway, that's the jist of it. Thanks, David - Original Message - From: "Ovid" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Wednesday, July 03, 2002 9:35 AM Subject: Re: Form.pm Hi David, I hope you don

Re: Form.pm

2002-07-03 Thread Ovid
--- [EMAIL PROTECTED] wrote: > Todd, > Oh you mean like this: > > my(@pairs) = split('&',$tosplit); > First, the above code is strait out of CGI.pm sir. So if you feel that its wrong, >you might try > telling that to the creator of CGI.pm David, You ha

Re: Form.pm

2002-07-03 Thread Ovid
Hi David, I hope you don't take this stuff personally. A code critique is a critique, after all :) I'll skip the lines of code that I'm not commenting on. my $input = shift; my @variables = split(/\&/, $input); First, we know that the split is incorrect. A semi-colon is the new, pre

Re: Form.pm

2002-07-03 Thread perl-dvd
Curtis, Thank you for the compliment. Please do inform me of what should be modified. Thanks, David - Original Message - From: "Ovid" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Tuesday, July 02, 2002 6:18 PM Subject: Re: For

Re: Form.pm

2002-07-03 Thread perl-dvd
From: "Todd Wade" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Tuesday, July 02, 2002 6:13 PM Subject: Re: Form.pm [EMAIL PROTECTED] wrote: > sub parse_form_input($){ > my $input = shift; I told you already. > my @variables = split(/\&/, $input); this i

Re: Form.pm

2002-07-02 Thread Todd Wade
"Ovid" <[EMAIL PROTECTED]> wrote in message [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... > --- Todd Wade <[EMAIL PROTECTED]> wrote: > > [EMAIL PROTECTED] wrote: > > > > > sub parse_form_input($){ > > > my $input = shift; > > > > I told you already. > > > my @variables = split(/\&/, $input); >

Re: Form.pm

2002-07-02 Thread Ovid
--- Todd Wade <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > > sub parse_form_input($){ > > my $input = shift; > > I told you already. > > my @variables = split(/\&/, $input); > this is wrong!!! > > Todd W. Yes, it's wrong, but we should say that with a smile on our face :) I'v

Re: Form.pm

2002-07-02 Thread Todd Wade
[EMAIL PROTECTED] wrote: > sub parse_form_input($){ > my $input = shift; I told you already. > my @variables = split(/\&/, $input); this is wrong!!! Todd W. -- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]