[PATCH v2] drm/amd/display: Avoid disabling GCC specific flag with clang for snprintf_count()

being disabled by this pragma is GCC specific. Guard its use with CONFIG_CC_IS_GCC so that it is not used with clang to clear up the error. Cc: Hamza Mahfooz Cc: Rodrigo Siqueira Cc: Harry Wentland Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- v2: - Alternate Solution 2: for

[PATCH] drm/amd/display: Fix up dcn30_fpu.c kdoc

u.c:688: warning: Function parameter or member 'pipe_cnt' not described in 'dcn30_find_dummy_latency_index_for_fw_based_mclk_switch' display/dc/dml/dcn30/dcn30_fpu.c:688: warning: Function parameter or member 'vlevel' not described in 'dcn30_find_dummy_latency_index_for_fw_based_mclk_switch' Cc: Rod

[PATCH] drm/amd/display: Fix dc/dcn20/dcn20_optc.c kdoc

-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * There are (MAX_OPTC+1)/2 gsl groups available for use. Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Harry Wentland Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/dc/dcn20/dcn20_optc.c | 17 - 1 fi

[PATCH v2] drm/amd/display: Address kdoc warnings in dcn30_fpu.c

u.c:688: warning: Function parameter or member 'pipe_cnt' not described in 'dcn30_find_dummy_latency_index_for_fw_based_mclk_switch' display/dc/dml/dcn30/dcn30_fpu.c:688: warning: Function parameter or member 'vlevel' not described in 'dcn30_find_dummy_latency_index_for_fw_based_mclk_switch' Cc: Rodri

[PATCH] drm/amdgpu: Mark 'kgd_gfx_aldebaran_clear_address_watch' & 'kgd_gfx_v11_clear_address_watch' functions as static

tch(struct amdgpu_device *adev, uint32_t watch_id) CHECK: Alignment should match open parenthesis +static uint32_t kgd_gfx_v11_clear_address_watch(struct amdgpu_device *adev, uint32_t watch_id) Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drive

[PATCH] drm/amd/display: Provide function name for 'optc32_enable_crtc()'

indo Pillai Cc: Harry Wentland Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_optc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_optc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn

[PATCH] drm/amdgpu: Add missing function parameter 'optc' & 'enable' to kdoc in optc3_set_timing_double_buffer()

unction parameter or member 'enable' not described in 'optc3_set_timing_double_buffer' Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 3 +++ 1 file changed, 3 inserti

[PATCH] drm/amd/display: Correct kdoc formats in dcn10_opp.c

ay/dc/dcn10/dcn10_opp.c:183: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Set Clamping Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Harry Wentland Signed-off-by: Srinivasan Shanmugam --- .../gp

[PATCH] drm/amd/display: Fix unused variable ‘should_lock_all_pipes’

Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/core/dc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 172bae983425..5e18fc0c79d6 100644 --- a/d

[PATCH] drm/amd/display: Fix guarding of 'if (dc->debug.visual_confirm)'

mdgpu/../display/dc/core/dc.c:3538:2: note: previous statement is here if (dc->debug.visual_confirm) ^ 'Fixes: 25e1a6115fc2e ("drm/amd/display: Refactor fast update to use new HWSS build sequence")' Cc: Stylon Wang Cc: Alvin Lee Cc: Jun Lei Cc: Rodr

[PATCH v2] drm/amd/display: Fix guarding of 'if (dc->debug.visual_confirm)'

:2: note: previous statement is here if (dc->debug.visual_confirm) ^ 'Fixes: 25e1a6115fc2e ("drm/amd/display: Refactor fast update to use new HWSS build sequence")' Suggested-by: Alvin Lee Cc: Stylon Wang Cc: Alvin Lee Cc: Jun Lei Cc: Rodrigo Siqueira

[PATCH] drm/amdgpu: Fix memcpy() in sienna_cichlid_append_powerplay_table function.

es: 7077b19a38240 ("drm/amd/pm: use macro to get pptable members")' Cc: Chengming Gui Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v2] drm/amdgpu: Fix memcpy() in sienna_cichlid_append_powerplay_table function.

n König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: - turned to the way used for nv1x (Evan) .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c| 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichli

[PATCH] drm/amdgpu: Fix kdoc warning

m.c:98: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * EEPROM Table structrue v2.1 Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom

[PATCH] drm/amd/display: Correct and remove excess function parameter names in kdoc

: Cannot understand * Cc: Stylon Wang Cc: Hamza Mahfooz Cc: Rodrigo Siqueira Cc: Harry Wentland Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 14 +- 1 file changed

[PATCH] drm/radeon: Fix missing prototypes in radeon_atpx_handler.c

radeon_atpx_validate_functions(). Prototype was for radeon_atpx_validate() instead Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/radeon/radeon_acpi.h | 9 + drivers/gpu/drm/radeon/radeon_atpx_handler.c | 2 +- 2 files changed, 10 insertions

[PATCH] drm/amd/display: Clean up dcn10_optc.c kdoc

nt. Refer Documentation/doc-guide/kernel-doc.rst * Enable CRTC display/dc/dcn10/dcn10_optc.c:895: warning: Cannot understand * on line 895 - I thought it was a doc line Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Harry Wentland Signed-off-by: Srinivasan

[PATCH] drm/amd/display: Correct kdoc formats in dcn32_resource_helpers.c

32/dcn32_resource_helpers.c:676: warning: Cannot understand * * Cc: Alvin Lee Cc: Stylon Wang Cc: Hamza Mahfooz Cc: Rodrigo Siqueira Cc: Harry Wentland Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam Reviewed-by: Rodrigo Siqueira --- .../display/dc/dcn32/dcn32_resource_helpe

[PATCH] drm/amd/display: Convert to kdoc formats in dc/core/dc.c

* *** Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/core/dc.c | 34 +++- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a

[PATCH] drm/amd/display: Fix errors & warnings in amdgpu_dm.c

not generally useful WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 133 ++

[PATCH] drm/amd/display: Remove else after return statement in 'dm_update_plane_state'

: Bhawanpreet Lakha Cc: Qingqing Zhuo Cc: Nicholas Kazlauskas Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH] drm/amd/display: Remove else after return in 'dm_crtc_get_scanoutpos()'

e, return from function occurs. Therefore, there is no need in 'else', and it has been removed. Cc: Alex Deucher Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 +-- 1 file

[PATCH v2] drm/amd/display: Remove else after return in 'dm_crtc_get_scanoutpos()'

e, return from function occurs. Therefore, there is no need in 'else', and it has been removed. Cc: Alex Deucher Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 +-- 1 file

[PATCH] drm/amd/display: Use seq_puts() in 'amdgpu_current_colorspace_show()' & 'edp_ilr_show()'

Replace seq_printf with seq_puts when there is no argument list. Fix the checkpatch warning: WARNING: Prefer seq_puts to seq_printf Cc: Wayne Lin Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../drm/amd/display/amdgpu_dm

[PATCH] drm/amd/display: Remove redundant braces in 'amdgpu_dm_crtc_notify_ta_to_read()'

Adhere to Linux kernel coding style. Reported by checkpatch: WARNING: braces {} are not necessary for single statement blocks Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 6 ++ 1 file changed, 2

[PATCH] drm/amd/display: Remove redundant braces in 'amdgpu_dm_crtc_notify_ta_to_read()'

Adhere to Linux kernel coding style. Reported by checkpatch: WARNING: braces {} are not necessary for single statement blocks Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 6 ++ 1 file changed, 2

[PATCH] drm/amd/display: Remove spaces before tabs in amdgpu_dm_hdcp.c

Conform to Linux kernel coding style. Reported by checkpatch: WARNING: please, no space before tabs Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 40 +-- 1 file changed, 20 insertions(+), 20

[PATCH] drm/amd/display: Clean up style problems in amdgpu_dm_irq.c

nsigned int' to bare use of 'unsigned' Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 42 +++ 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/drivers

[PATCH v2] drm/amd/display: Remove spaces before tabs in amdgpu_dm_hdcp.c

Conform to Linux kernel coding style. Reported by checkpatch: WARNING: please, no space before tabs And promote sysfs entry for set/get srm to kdoc Suggested-by: Rodrigo Siqueira Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- v2: - Promote sysfs entry

[PATCH] drm/amd/display: Clean up warnings in amdgpu_dm _mst_types, _plane, _psr.c

Fix the following warnings reported by checkpatch: WARNING: Missing a blank line after declarations WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/a

[PATCH] drm/amd/display: Eliminate warnings in amdgpu_dm_helpers.c

using '"%s...", __func__' to using 'apply_synaptics_fifo_reset_wa', this function's name, in a string WARNING: braces {} are not necessary for single statement blocks Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/amdg

[PATCH] drm/amd/display: Remove unnecessary casts in amdgpu_dm_helpers.c

Fixes the following category of checkpatch complaints: WARNING: unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- 1

[PATCH] drm/amd/display: Fix warning about msleep in amdgpu_dm_helpers.c

Fixes the following category of checkpatch warning: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst + msleep(10); Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu

[PATCH] drm/amd/display: Clean up warnings in amdgpu_dm_pp_smu.c

ARIS10) && [...] + return true; Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/dis

[PATCH v2] drm/amd/display: Remove unnecessary casts in amdgpu_dm_helpers.c

Fixes the following category of checkpatch complaints: WARNING: unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html + char *buf = (char *)kvcalloc(total, sizeof(char), GFP_KERNEL); Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan

[PATCH v2] drm/amd/display: Clean up warnings in amdgpu_dm_pp_smu.c

ARIS10) && [...] + return true; Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- v2: - Corrected the indentdation for if statement. .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 11 ++- 1 file changed, 6 insertions(+), 5 dele

[PATCH v3] drm/amd/display: Remove unnecessary casts in amdgpu_dm_helpers.c

Fixes the following category of checkpatch complaints: WARNING: unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html + char *buf = (char *)kvcalloc(total, sizeof(char), GFP_KERNEL); Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan

[PATCH 2/6] drm/amd/display: Remove spaces before tabs in amdgpu_dm_hdcp.c

Conform to Linux kernel coding style. Reported by checkpatch: WARNING: please, no space before tabs And promote sysfs entry for set/get srm to kdoc Suggested-by: Rodrigo Siqueira Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/amdgpu_dm

Clean up patches in display/amdgpu_dm code

dgpu_dm_pp_smu.c -> fixed code indentation in v2. Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Fangzhi Zuo Srinivasan Shanmugam (6): drm/amd/display: Remove unnecessary casts in amdgpu_dm_helpers.c drm/amd/display: Remove spaces before tabs in amdgpu_dm_hdcp.c drm/

[PATCH 1/6] drm/amd/display: Remove unnecessary casts in amdgpu_dm_helpers.c

Fixes the following category of checkpatch complaints: WARNING: unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html + char *buf = (char *)kvcalloc(total, sizeof(char), GFP_KERNEL); Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan

[PATCH 3/6] drm/amd/display: Clean up warnings in amdgpu_dm_pp_smu.c

ARIS10) && [...] + return true; Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/dis

[PATCH 4/6] drm/amd/display: Fix warning about msleep in amdgpu_dm_helpers.c

Fixes the following category of checkpatch warning: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst + msleep(10); Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu

[PATCH 5/6] drm/amd/display: Clean up warnings in amdgpu_dm _mst_types, _plane, _psr.c

Fix the following warnings reported by checkpatch: WARNING: Missing a blank line after declarations WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/a

[PATCH 6/6] drm/amd/display: Eliminate warnings in amdgpu_dm_helpers.c

using '"%s...", __func__' to using 'apply_synaptics_fifo_reset_wa', this function's name, in a string WARNING: braces {} are not necessary for single statement blocks Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/amdg

Clean up patches in display/amdgpu_dm code

dgpu_dm_pp_smu.c -> fixed code indentation in v2. Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Fangzhi Zuo Srinivasan Shanmugam (6): drm/amd/display: Remove unnecessary casts in amdgpu_dm_helpers.c drm/amd/display: Remove spaces before tabs in amdgpu_dm_hdcp.c drm/

[PATCH 3/6] drm/amd/display: Clean up warnings in amdgpu_dm_pp_smu.c

ARIS10) && [...] + return true; Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/dis

[PATCH 4/6] drm/amd/display: Fix warning about msleep in amdgpu_dm_helpers.c

Fixes the following category of checkpatch warning: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst + msleep(10); Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu

[PATCH 2/6] drm/amd/display: Remove spaces before tabs in amdgpu_dm_hdcp.c

Conform to Linux kernel coding style. Reported by checkpatch: WARNING: please, no space before tabs And promote sysfs entry for set/get srm to kdoc Suggested-by: Rodrigo Siqueira Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/amdgpu_dm

[PATCH 1/6] drm/amd/display: Remove unnecessary casts in amdgpu_dm_helpers.c

Fixes the following category of checkpatch complaints: WARNING: unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html + char *buf = (char *)kvcalloc(total, sizeof(char), GFP_KERNEL); Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan

[PATCH 5/6] drm/amd/display: Clean up warnings in amdgpu_dm _mst_types, _plane, _psr.c

Fix the following warnings reported by checkpatch: WARNING: Missing a blank line after declarations WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/a

[PATCH 6/6] drm/amd/display: Eliminate warnings in amdgpu_dm_helpers.c

using '"%s...", __func__' to using 'apply_synaptics_fifo_reset_wa', this function's name, in a string WARNING: braces {} are not necessary for single statement blocks Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/amdg

drm/amdgpu: Clean up patches in gfxhub_* & gfx_v10_0.c

Srinivasan Shanmugam (6): drm/amdgpu: Fix warnings in gfxhub_ v1_0, v1_2.c drm/amdgpu: Fix warnings in gfxhub_v2_0.c drm/amdgpu: Fix warnings in gfxhub_v2_1.c drm/amdgpu: Fix warnings in gfxhub_ v3_0, v3_0_3.c drm/amdgpu: Fix errors & warnings in gfx_v10_0.c drm/amdgpu: Remove

[PATCH 1/6] drm/amdgpu: Fix warnings in gfxhub_ v1_0, v1_2.c

comments should align the * on each line + /* + * Raven2 has a HW issue that it is unable to use the WARNING: Prefer 'unsigned int' to bare use of 'unsigned' + unsigned num_level, block_size; Cc: Christian König Cc: Alex Deucher Signed-o

[PATCH 2/6] drm/amdgpu: Fix warnings in gfxhub_v2_0.c

e after declarations + u32 tmp; + tmp = RREG32_SOC15(GC, 0, mmGCVM_L2_PROTECTION_FAULT_CNTL); Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 3/6] drm/amdgpu: Fix warnings in gfxhub_v2_1.c

t blocks + if (!time) { + DRM_WARN("failed to wait for GRBM(EA) idle\n"); + } Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) dif

[PATCH 4/6] drm/amdgpu: Fix warnings in gfxhub_ v3_0, v3_0_3.c

y should probably be static const char * const +static const char *gfxhub_client_ids[] = { WARNING: Prefer 'unsigned int' to bare use of 'unsigned' + unsigned i; Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfxhu

[PATCH 5/6] drm/amdgpu: Fix errors & warnings in gfx_v10_0.c

t lines WARNING: braces {} are not necessary for any arm of this statement WARNING: Missing a blank line after declarations Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 173 + 1 file changed, 90

[PATCH 6/6] drm/amdgpu: Remove else after return statement in 'gfx_v10_0_check_grbm_cam_remapping'

König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index 157dd33ec43a..19db20e24761

[PATCH 0/6] Clean up patches in amdgpu/gmc_*.c

Srinivasan Shanmugam (6): drm/amdgpu: Fix warnings in gmc_v10_0.c drm/amdgpu: Fix warnings in gmc_v11_0.c drm/amdgpu: Fix errors & warnings in gmc_ v6_0, v7_0.c drm/amdgpu: Fix error & warnings in gmc_v8_0.c drm/amdgpu: Remove else after return statement in 'gmc_v8_0_che

[PATCH 1/6] drm/amdgpu: Fix warnings in gmc_v10_0.c

Fix below checkpatch warnings: WARNING: Consider removing the code enclosed by this #if 0 and its #endif WARNING: Prefer 'unsigned int' to bare use of 'unsigned' WARNING: quoted string split across lines Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmug

[PATCH 3/6] drm/amdgpu: Fix errors & warnings in gmc_ v6_0, v7_0.c

ment WARNING: Block comments use * on subsequent lines WARNING: Missing a blank line after declarations WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/am

[PATCH 2/6] drm/amdgpu: Fix warnings in gmc_v11_0.c

tian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 30 -- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c index c68ecb

[PATCH 4/6] drm/amdgpu: Fix error & warnings in gmc_v8_0.c

each line Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 78 --- 1 file changed, 33 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_

[PATCH 5/6] drm/amdgpu: Remove else after return statement in 'gmc_v8_0_check_soft_reset'

Fix below checkpatch warnings: WARNING: else is not generally useful after a break or return + return true; + } else { Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 8 +--- 1 file changed, 5

[PATCH 6/6] drm/amdgpu: Fix error & warnings in gmc_v9_0.c

Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 37 --- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c i

[PATCH] drm/amd/amdgpu: Fix an uninitialized variable

t;, ucode_prefix, i); ^ drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:207:16: note: initialize the variable 'i' to silence this warning int err = 0, i; ^ = 0 Initialize the variable &

[PATCH v2] drm/amd/amdgpu: Fix an uninitialized variable

instance number. Remove setting err to 0 as well. This is considered very bad coding style. Cc: Christian König Cc: Mario Limonciello Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Change-Id: I2f1180af4f37bf1efd4d47e7bf64425b0b3809fb --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 4 ++--

[PATCH] drm/amdgpu: Prefer dev_warn over printk

Fix the below warning: WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 2 +- drivers/gpu

[PATCH] drm/amdkfd: Fix stack size in 'amdgpu_amdkfd_unmap_hiq'

: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 26 ++ 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd

[PATCH v2] drm/amdkfd: Fix stack size in 'amdgpu_amdkfd_unmap_hiq'

: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd

[PATCH v3] drm/amdkfd: Fix stack size in 'amdgpu_amdkfd_unmap_hiq'

=] Suggested-by: Guchun Chen Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v3: - free ring_funcs before 'return -ENOMEM' (Guchun). - keep the check of ' kiq->pmf' and 'kiq->pmf->kiq_unmap_queues' ahead of

[PATCH] drm/amdgpu: Avoid possiblity of kernel crash in 'gmc_v8_0, gmc_v7_0_init_microcode()'

r variants 'Fixes: 1104113b37210 ("drm/amdgpu: Fix error & warnings in gmc_v8_0.c")' 'Fixes: d68f1d641eba0 ("drm/amdgpu: Fix errors & warnings in gmc_ v6_0, v7_0.c")' Suggested-by: Alex Deucher Cc: Christian König Cc: Alex Deucher Signed-off

[PATCH] drm/radeon: Avoid externs & do not initialize globals to 0 in radeon_drv.c

Fixes the following: - WARNING: externs should be avoided in .c files - ERROR: do not initialise globals to 0 - WARNING: Missing a blank line after declarations Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/radeon/radeon_drv.c | 51

[PATCH] drm/radeon: Fix style issues in radeon _encoders.c & _gart.c

; WARNING: braces {} are not necessary for single statement blocks Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/radeon/radeon_encoders.c | 22 +++-- drivers/gpu/drm/radeon/radeon_gart.c | 39 2 files changed, 32

[PATCH 0/2] Some more Cleanup fixes in radeon & amdgpu/amdgpu_display.c

Srinivasan Shanmugam (2): drm/amd/display: Convert macros to functions in amdgpu_display.c & amdgpu_display.h drm/radeon: Prefer dev_warn over printk drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 118 --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.h |

[PATCH 2/2] drm/radeon: Prefer dev_warn over printk

From: Srinivasan Shanmugam Fixes the following checkpatch.pl: WARNING: printk() should include KERN_ facility level Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/radeon/radeon_atpx_handler.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 1/2] drm/amd/display: Convert macros to functions in amdgpu_display.c & amdgpu_display.h

are not necessary for single statement blocks Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 118 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 46 ++-- 2 files changed, 136 insertions(+), 28 delet

[PATCH] drm/amdgpu: Fix unused variable ‘idx’ in ‘amdgpu_atom_parse’

drivers/gpu/drm/amd/amdgpu/atom.c: In function ‘amdgpu_atom_parse’: drivers/gpu/drm/amd/amdgpu/atom.c:1468:6: warning: unused variable ‘idx’ [-Wunused-variable] 1468 | u16 idx; | ^~~ Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd

[PATCH v2] drm/amd/amdgpu: Fix warnings in amdgpu/amdgpu_display.c

König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 42 - 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index

[PATCH v2] drm/radeon: Prefer dev_* variant over printk

Changed from pr_err/info to dev_* variants so that we get better debug info when there are multiple GPUs in the system. 'Fixes: 8e2503972912c ("drm/radeon: Prefer pr_err/_info over printk")' Suggested-by: Alex Deucher Cc: Christian König Cc: Alex Deucher Signed-off-by:

[PATCH] drm/amdgpu: Prefer #if IS_ENABLED over #if defined in amdgpu_drv.c

(CONFIG_DRM_RADEON_MODULE) Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index

[PATCH] drm/amdgpu: Fix do not add new typedefs in amdgpu_fw_attestation.c

ions '0400'. + S_IRUSR, ERROR: "(foo*)" should be "(foo *)" WARNING: please, no space before tabs Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- .../drm/amd/amdgpu/amdgpu_fw_attestation.c| 38 +-- 1 file

[PATCH] drm/amdgpu: Fix style issues in amdgpu_gem.c

NG: %LX is non-standard C, use %llX Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/d

[PATCH] drm/amdgpu: Return -ENOMEM when there is no memory in 'amdgpu_gfx_mqd_sw_init'

Return -ENOMEM, when there is no sufficient dynamically allocated memory to create MQD backup for ring Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff

[PATCH] drm/amdgpu: Fix ENOSYS means 'invalid syscall nr' in amdgpu_device.c

Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 60 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 4 +- 2 files changed, 33 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/am

[PATCH] drm/amdgpu: Remove else after return in 'is_fru_eeprom_supported'

n removed. Fixes the following: WARNING: else is not generally useful after a break or return + return false; + } else { Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_fru_ee

[PATCH] drm/amdgpu: Use seq_puts() instead of seq_printf()

hould align the * on each line Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/driver

[PATCH] drm/amdgpu: Update min() to min_t() in 'amdgpu_info_ioctl'

line after declarations Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/a

[PATCH] drm/amd/display: Remove else after return in 'dm_vblank_get_counter' & 'amdgpu_dm_backlight_get_level'

been removed. Fixes the following: WARNING: else is not generally useful after a break or return + return 0; + else { WARNING: else is not generally useful after a break or return + return convert_brightness_to_user(&caps, avg); + } else { Cc: Rodrigo

[PATCH] drm/amdgpu: Add -ENOMEM error handling when there is no memory

Return -ENOMEM, when there is no sufficient dynamically allocated memory Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 + drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 4 +++- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 4

[PATCH v2] drm/amdgpu: Add -ENOMEM error handling when there is no memory

Return -ENOMEM, when there is no sufficient dynamically allocated memory Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: - Added -ENOMEM - when it failed to create MQD backup, while creating MQD for each KCQ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 17

[PATCH] drm/amdgpu: Fix unused variable 'domain' in 'amdgpu_bo_print_info'

Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index 5ac7544cc068..3f98174fb764 100644 --- a/drivers/gpu/drm/amd

[PATCH] drm/amdgpu: Remove volatile from 'wb' & from 'ptr' in amdgpu.h

+ volatile uint32_t *ptr; 'wb' field from 'amdgpu_wb' struct & 'ptr' field from 'amdgpu_mem_scratch', is not used to access h/w directly, neither they are shared variables, so volatile is not necessary Cc: Christian König Cc: Alex Deucher Signe

[PATCH] drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c

-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 28 + 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index

[PATCH v2] drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c

blocks Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: - Updated commit message - Added "ERROR: do not initialise globals to 0" drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 28 +-

[PATCH] drm/amdgpu: Fix no new typedefs for enum _AMDGPU_DOORBELL_*

Fixes the following: WARNING: do not add new typedefs Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h | 27 ++-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amdgpu: Prefer dev_* variant over printk in amdgpu_atpx_handler.c

König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 35 --- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handl

[PATCH v2] drm/amdgpu: Fix ENOSYS means 'invalid syscall nr' in amdgpu_device.c

single statement blocks Cc: Lijo Lazar Cc: Kent Russell Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Guchun Chen --- v2: * Updated the following in the commit message (Kent) WARNING: Symbolic permissions 'S_IRUGO' are not

[PATCH] drm/amdgpu: Fix unnecessary else after return in 'amdgpu_eeprom_xfer'

Fixes the following: WARNING: else is not generally useful after a break or return + return -EINVAL; + } else { Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_eeprom.c | 39

[PATCH] drm/amdgpu: Fix non-standard format specifiers in 'amdgpu_show_fdinfo'

hun Chen Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c index c57

<    1   2   3   4   5   6   7   >