Fix below checkpatch warnings:

WARNING: else is not generally useful after a break or return
+                       return true;
+               } else {

WARNING: else is not generally useful after a break or return
+                       return true;
+               } else {

Cc: Christian König <christian.koe...@amd.com>
Cc: Alex Deucher <alexander.deuc...@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmu...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 157dd33ec43a..19db20e24761 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -6940,10 +6940,9 @@ static bool gfx_v10_0_check_grbm_cam_remapping(struct 
amdgpu_device *adev)
                if (RREG32_SOC15(GC, 0, mmVGT_ESGS_RING_SIZE_Sienna_Cichlid) == 
pattern) {
                        WREG32_SOC15(GC, 0, mmVGT_ESGS_RING_SIZE_UMD, data);
                        return true;
-               } else {
-                       WREG32_SOC15(GC, 0, 
mmVGT_ESGS_RING_SIZE_Sienna_Cichlid, data);
-                       return false;
                }
+
+               WREG32_SOC15(GC, 0, mmVGT_ESGS_RING_SIZE_Sienna_Cichlid, data);
                break;
        case IP_VERSION(10, 3, 1):
        case IP_VERSION(10, 3, 3):
@@ -6958,12 +6957,13 @@ static bool gfx_v10_0_check_grbm_cam_remapping(struct 
amdgpu_device *adev)
                if (RREG32_SOC15(GC, 0, mmVGT_ESGS_RING_SIZE) == pattern) {
                        WREG32_SOC15(GC, 0, mmVGT_ESGS_RING_SIZE_UMD, data);
                        return true;
-               } else {
-                       WREG32_SOC15(GC, 0, mmVGT_ESGS_RING_SIZE, data);
-                       return false;
                }
+
+               WREG32_SOC15(GC, 0, mmVGT_ESGS_RING_SIZE, data);
                break;
        }
+
+       return false;
 }
 
 static void gfx_v10_0_setup_grbm_cam_remapping(struct amdgpu_device *adev)
-- 
2.25.1

Reply via email to