[PATCH v2 04/12] drm/amd/display: Copy DC context in the commit streams

2022-10-18 Thread Rodrigo Siqueira
also changes the function signature to expect streams instead of a context. Signed-off-by: Rodrigo Siqueira Co-developed-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 41 +++- drivers/gpu/drm/amd/display/dc/dc.h | 4

[PATCH v2 05/12] drm/amd/display: Include surface of unaffected streams

2022-10-18 Thread Rodrigo Siqueira
-off-by: Rodrigo Siqueira Co-developed-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 12 +++- drivers/gpu/drm/amd/display/dc/dc.h| 15 +-- drivers/gpu/drm/amd/display/dc/dc_stream.h | 4 3 files changed, 28

[PATCH v2 06/12] drm/amd/display: Handle virtual hardware detect

2022-10-18 Thread Rodrigo Siqueira
If virtual hardware is detected, there is no reason to run the full dc_commit_streams process, and DC can return true immediately. Signed-off-by: Rodrigo Siqueira Co-developed-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 3 +++ 1 file

[PATCH v2 07/12] drm/amd/display: Add function for validate and update new stream

2022-10-18 Thread Rodrigo Siqueira
commit introduces a function dedicated to manipulating stream changes and invokes the state validation function after that. Signed-off-by: Rodrigo Siqueira Co-developed-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 16 +- .../gpu/drm/amd

[PATCH v2 08/12] drm/amd/display: Handle seamless boot stream

2022-10-18 Thread Rodrigo Siqueira
) to ensure that the pipe context matches. Signed-off-by: Rodrigo Siqueira Co-developed-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc

[PATCH v2 09/12] drm/amd/display: Update OTG instance in the commit stream

2022-10-18 Thread Rodrigo Siqueira
programming. Signed-off-by: Rodrigo Siqueira Co-developed-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH v2 10/12] drm/amd/display: Avoid ABM when ODM combine is enabled for eDP

2022-10-18 Thread Rodrigo Siqueira
ODM to combine on the eDP panel with ABM causes the color difference to the panel since the ABM module only sets one pipe. Hence, this commit blocks ABM in case of ODM combined on eDP. Signed-off-by: Rodrigo Siqueira Co-developed-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai

[PATCH v2 11/12] drm/amd/display: Use update plane and stream routine for DCN32x

2022-10-18 Thread Rodrigo Siqueira
dc_commit_updates_for_stream for all ASICs since it does most of the tasks executed by dc_commit_updates_for_stream with other extra operations, but we need to run tests before making this change. Signed-off-by: Rodrigo Siqueira Co-developed-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu

[PATCH v2 12/12] drm/amd/display: Move dc_state copy in commit_tail after dc_commit_state

2022-10-18 Thread Rodrigo Siqueira
From: Aurabindo Pillai The SubVP feature introduces a new mechanism named phantom streams, which can be summed up as a fake stream used to calculate the required parameters for handing the cache request and cache reading for a small portion of the framebuffer used in the sub-viewport. With the ne

[PATCH] drm/amd/display: Rework comments on dc file

2022-10-18 Thread Rodrigo Siqueira
The file dc.c has multiple comments that do not follow the kernel-doc or are made in a distracting way. This commit alleviates part of this issue by reorganizing some comments inside the dc file. Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 161

[PATCH 00/33] DC Patches October 20th, 2022

2022-10-20 Thread Rodrigo Siqueira
Ma Hanghong (1): drm/amd/display: Wrong colorimetry workaround Max Tseng (1): drm/amd/display: cursor update command incomplete Rodrigo Siqueira (8): drm/amd/display: Remove FPU guards from the DML folder drm/amd/display: Convert documentation to a kernel-doc drm/amd/display: Add events

[PATCH 01/33] drm/amd/display: Add UHBR135 and UHBR20 into debugfs

2022-10-20 Thread Rodrigo Siqueira
From: Fangzhi Zuo Add support to manually force link rate to UHBR135 (0x546) and UHBR20 (0x7d0). Reviewed-by: Roman Li Acked-by: Rodrigo Siqueira Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH 02/33] drm/amd/display: Remove FPU guards from the DML folder

2022-10-20 Thread Rodrigo Siqueira
Siqueira Signed-off-by: Rodrigo Siqueira --- .../drm/amd/display/dc/dml/dcn30/dcn30_fpu.c| 2 -- .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c| 17 + 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/dcn30_fpu.c b

[PATCH 07/33] drm/amd/display: Refactor eDP PSR codes

2022-10-20 Thread Rodrigo Siqueira
From: Ian Chen We split out PSR config from "global" to "per-panel" config settings. Reviewed-by: Robin Chen Acked-by: Rodrigo Siqueira Signed-off-by: Ian Chen --- drivers/gpu/drm/amd/display/dc/dc.h | 1 - drivers/gpu/drm/amd/display/dc/dc_

[PATCH 05/33] drm/amd/display: remove audio mute control in hpo dp

2022-10-20 Thread Rodrigo Siqueira
e for simplicity. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c | 11 --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.h | 4 .../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c

[PATCH 08/33] drm/amd/display: Convert documentation to a kernel-doc

2022-10-20 Thread Rodrigo Siqueira
The dc_dmub_srv file has a lot of documentation associated with SubVP that could be converted to a kernel-doc. This commit just changes the comment style to a kernel-doc. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display

[PATCH 04/33] drm/amd/display: move stream encoder audio setup to link_hwss

2022-10-20 Thread Rodrigo Siqueira
From: Wenjing Liu Unify stream encoder audio setup interface. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Wenjing Liu --- .../display/dc/dce110/dce110_hw_sequencer.c | 22 +-- .../gpu/drm/amd/display/dc/inc/link_hwss.h| 3 +++ .../drm/amd

[PATCH 11/33] drm/amd/display: Update DSC capabilitie for DCN314

2022-10-20 Thread Rodrigo Siqueira
From: Leo Chen dcn314 has 4 DSC - conflicted hardware document updated and confirmed. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Leo Chen --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 12/33] drm/amd/display: Ignore Cable ID Feature

2022-10-20 Thread Rodrigo Siqueira
From: Fangzhi Zuo Disable for DP2 receivers that does not support the feature. Reviewed-by: Roman Li Acked-by: Rodrigo Siqueira Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display

[PATCH 09/33] drm/amd/display: Add events log to trace OPTC lock and unlock

2022-10-20 Thread Rodrigo Siqueira
As an attempt to offer more DCN debug tools for cases where the OPTC can hang, this commit introduces a trace event responsible for showing OPTC status when it requests lock and unlock. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../amd

[PATCH 10/33] drm/amd/display: refine wake up aux in retrieve link caps

2022-10-20 Thread Rodrigo Siqueira
. Reviewed-by: Wenjing Liu Acked-by: Rodrigo Siqueira Signed-off-by: Lewis Huang --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 148 +- .../gpu/drm/amd/display/dc/inc/dc_link_dp.h | 2 +- 2 files changed, 41 insertions(+), 109 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 06/33] drm/amd/display: correctly populate dcn315 clock table

2022-10-20 Thread Rodrigo Siqueira
From: Dmytro Laktyushkin Fix incorrect pstate read order as well as min and max state logic. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Dmytro Laktyushkin --- .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 71 ++- 1 file changed, 23 insertions

[PATCH 14/33] drm/amd/display: Drop struct crc_region and reuse struct rect

2022-10-20 Thread Rodrigo Siqueira
Lin Acked-by: Rodrigo Siqueira Signed-off-by: Alan Liu --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 20 ++- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.h | 7 +-- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 16 +++ drivers/gpu/drm/amd/display/dc/core

[PATCH 16/33] drm/amd/display: Document part of the DMUB cmd

2022-10-20 Thread Rodrigo Siqueira
From: Anthony Koo Add a simple documentation in the dmub_cmd. Reviewed-by: Aric Cyr Acked-by: Rodrigo Siqueira Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd

[PATCH 15/33] drm/amd/display: Limit dcn32 to 1950Mhz display clock

2022-10-20 Thread Rodrigo Siqueira
From: Jun Lei [why] Hardware team recommends we limit dispclock to 1950Mhz for all DCN3.2.x [how] Limit to 1950 when initializing clocks. Reviewed-by: Alvin Lee Acked-by: Rodrigo Siqueira Signed-off-by: Jun Lei --- .../gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 8 1

[PATCH 17/33] drm/amd/display: 3.2.208

2022-10-20 Thread Rodrigo Siqueira
From: Aric Cyr DC version 3.2.208 brings along the following: * Add more kernel doc * Enable secure display on DCN21 * Limit dcn32 to 1950Mhz display clock * PSR code refactor * Rework audio stream sequence * Generic bug fixes Acked-by: Rodrigo Siqueira Signed-off-by: Aric Cyr --- drivers

[PATCH 13/33] drm/amd/display: Implement secure display on DCN21

2022-10-20 Thread Rodrigo Siqueira
amdgpu_dm_crtc_handle_crc_window_irq() - disable PSR before activating secure_display on a crtc - check if secure_display is activated before enabling psr - only work for single display for now. Reviewed-by: Wayne Lin Acked-by: Rodrigo Siqueira Signed-off-by: Alan Liu --- .../gpu/drm/amd/display

[PATCH 18/33] drm/amd/display: Update latencies on DCN321

2022-10-20 Thread Rodrigo Siqueira
From: Dillon Varone Update DF related latencies based on new measurements. Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira Signed-off-by: Dillon Varone --- drivers/gpu/drm/amd/display/dc/dml/dcn321/dcn321_fpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[PATCH 03/33] drm/amd/display: refactor enable/disable audio stream hw sequence

2022-10-20 Thread Rodrigo Siqueira
el to unify stream encoder programming interface. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 14 +- .../display/dc/dce110/dce110_hw_sequencer.c

[PATCH 21/33] drm/amd/display: Fix HDCP 1.X 1A-04 failing

2022-10-20 Thread Rodrigo Siqueira
econds. From testing it seems like 0 Seconds can pass 1.x and 2.x compliances Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH 20/33] drm/amd/display: Remove optimization for VRR updates

2022-10-20 Thread Rodrigo Siqueira
From: Alvin Lee Optimization caused unexpected regression, so remove for now. Reviewed-by: Aric Cyr Acked-by: Rodrigo Siqueira Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/core/dc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH 19/33] drm/amd/display: Set memclk levels to be at least 1 for dcn32

2022-10-20 Thread Rodrigo Siqueira
From: Dillon Varone [Why] Cannot report 0 memclk levels even when SMU does not provide any. [How] When memclk levels reported by SMU is 0, set levels to 1. Reviewed-by: Martin Leung Acked-by: Rodrigo Siqueira Signed-off-by: Dillon Varone --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32

[PATCH 22/33] drm/amd/display: Enable timing sync on DCN32

2022-10-20 Thread Rodrigo Siqueira
From: Alvin Lee Missed enabling timing sync on DCN32 because DCN32 has a different DML param. Reviewed-by: Martin Leung Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 1 + 1 file changed, 1 insertion

[PATCH 24/33] drm/amd/display: Fix SDR visual confirm

2022-10-20 Thread Rodrigo Siqueira
From: Aric Cyr Apply SDR visual confirm to RGB10 and FP16 formats as well when needed. Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira Signed-off-by: Aric Cyr --- .../gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff

[PATCH 23/33] drm/amd/display: cursor update command incomplete

2022-10-20 Thread Rodrigo Siqueira
From: Max Tseng Missing send cursor_rect width & Height into DMUB. PSR-SU would use these information. But missing these assignment in last refactor commit Reviewed-by: Anthony Koo Acked-by: Rodrigo Siqueira Signed-off-by: Max Tseng --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c

[PATCH 30/33] drm/amd/display: Add basic ODM description

2022-10-20 Thread Rodrigo Siqueira
Add kernel-doc to some of the ODM-related functions. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../drm/amd/display/dc/dcn20/dcn20_resource.c| 16 .../drm/amd/display/dc/inc/hw/stream_encoder.h | 3 +++ .../drm/amd

[PATCH 28/33] drm/amd/display: Expand kernel doc for DC

2022-10-20 Thread Rodrigo Siqueira
This commit adds extra documentation for elements related to FAMs. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dc.h | 19 +++--- drivers/gpu/drm/amd/display/dc/dc_stream.h| 11

[PATCH 26/33] drm/amd/display: skip commit minimal transition state

2022-10-20 Thread Rodrigo Siqueira
audio. [HOW] Just do the minimal transition when all of pipes are in use, otherwise return true to skip. Reviewed-by: Dillon Varone Acked-by: Rodrigo Siqueira Signed-off-by: zhikzhai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 22 ++ 1 file changed, 22 insertions(+) diff

[PATCH 25/33] drm/amd/display: wait for vblank during pipe programming

2022-10-20 Thread Rodrigo Siqueira
pipe programming") Reviewed-by: Martin Leung Acked-by: Rodrigo Siqueira Signed-off-by: Haiyi Zhou --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/a

[PATCH 29/33] drm/amd/display: Add DEC/CRB basic doc

2022-10-20 Thread Rodrigo Siqueira
Add a kernel-doc to the DE-Tile function hook. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.c | 4 drivers/gpu/drm/amd/display/dc/inc/hw/dchubbub.h | 15 +++ 2 files changed, 19

[PATCH 32/33] drm/amd/display: Add kernel doc for commit sequence

2022-10-20 Thread Rodrigo Siqueira
Add basic kernel-doc that describes some of the struct and functions that are part of the DC commit sequence.. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 63 --- .../gpu/drm/amd

[PATCH 27/33] drm/amd/display: Wrong colorimetry workaround

2022-10-20 Thread Rodrigo Siqueira
Acked-by: Rodrigo Siqueira Signed-off-by: Ma Hanghong --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 - drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 6 ++ drivers/gpu/drm/amd/display/modules/inc/mod_info_packet.h | 3 ++- .../gpu/drm/amd/display

[PATCH 33/33] drm/amd/display: 3.2.209

2022-10-20 Thread Rodrigo Siqueira
From: Aric Cyr DC version 3.2.209 brings along the following: * Improve color manipulation * Add corrections to DML and some flag configuration * Updates for DCN32x * Expand kernel-doc Acked-by: Rodrigo Siqueira Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file

[PATCH 31/33] drm/amd/display: Add kernel doc to some of the dc fields

2022-10-20 Thread Rodrigo Siqueira
Add kernel-doc to some important elements from DC struct that might help to understand DC sequence. Reviewed-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 5 ++- drivers/gpu/drm/amd/display/dc/dc_link.h

Re: [PATCH RESEND] drm/amd/display: move remaining FPU code to dml folder

2022-10-25 Thread Rodrigo Siqueira
Hi Ao, First of all, thanks a lot for this patch. On 10/20/22 20:31, Ao Zhong wrote: Move remaining FPU code to dml folder in preparation for enabling aarch64 support. I guess you found some of the issues here after you tried enabling the arm64 compilation, right? If so, could you expand the

Re: [PATCH] drm/amd/display: add DCN support for ARM64

2022-10-25 Thread Rodrigo Siqueira
On 10/21/22 00:31, Ao Zhong wrote: After moving all FPU code to the DML folder, we can enable DCN support for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG form the code in the DML folder that needs to use hardware FPU, and add a control mechanism for ARM Neon. Signed-off-by: Ao Zh

Re: [PATCH v3 2/2] drm/amd/display: move remaining FPU code to dml folder

2022-10-26 Thread Rodrigo Siqueira
ms); +void dcn32_zero_pipe_dcc_fraction(display_e2e_pipe_params_st *pipes, + int pipe_cnt); + #endif Hi Ao, First of all, thanks a lot for your patchset. For both patches: Reviewed-by: Rodrigo Siqueira And I also applied them to amd-staging-drm-next. Btw, if you

Re: [RESEND PATCH] drm/amd/display: prevent memory leak

2022-10-26 Thread Rodrigo Siqueira
&pool->base; + kfree(pool); BREAK_TO_DEBUGGER(); return NULL; } LGTM, Reviewed-by: Rodrigo Siqueira Applied to amd-staging-drm-next. Thanks Siqueira

Re: [PATCH RESEND 1/1] drm/amd/display: add DCN support for ARM64

2022-10-27 Thread Rodrigo Siqueira
Hi Ao/Arnd/Stephen/Nathan, Ao, Thanks a lot for this new patch. Since you have an ARM64 + AMD GPU, could you also run a couple of tests in your setup? If so, this is a good set of tests imho: 1. Check plug and unplug displays (let says 5x) 2. Change resolutions 3. (most wanted test) Could yo

Re: [PATCH RESEND 1/1] drm/amd/display: add DCN support for ARM64

2022-10-27 Thread Rodrigo Siqueira
On 10/27/22 11:22, Nathan Chancellor wrote: Hi Rodrigo, On Thu, Oct 27, 2022 at 10:29:33AM -0400, Rodrigo Siqueira wrote: Nathan/Stephen, Maybe I'm wrong, but I think you have access to some sort of CI that tests multiple builds with different compiles and configs, right? Is it possib

Re: [PATCH] drm/amd/display: don't print messages that contain %f in dml

2022-10-27 Thread Rodrigo Siqueira
On 10/24/22 06:04, Christian König wrote: Am 21.10.22 um 18:34 schrieb Hamza Mahfooz: Unfortunately, printk() doesn't currently support the printing of %f entries. So, print statements that contain "%f" should be removed. However, since DC is used on other OSes that can still benefit from the

Re: [PATCH v3 2/2] drm/amd/display: move remaining FPU code to dml folder

2022-10-27 Thread Rodrigo Siqueira
d2d621d08dab7977866%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638024158436988558%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Iyq4tWJL%2FfXuKB9xAUaVTQQmJQ0GRZ2rH%2F%2BXPTT%2F2tc%3D&reserved=0 Ao Am 26.10.22 um 18:12 schrieb Rodrigo Siqueira:

[PATCH] Revert "drm/amd/display: Pass HostVM enable flag into DCN3.1 DML"

2022-04-12 Thread Rodrigo Siqueira
issue. We are investigating why this patch introduced this regression, but we need to revert it for now. Cc: Harry Wentland Cc: Mark Broadworth Cc: Michael Strauss Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v2] Revert "drm/amd/display: Pass HostVM enable flag into DCN3.1 DML"

2022-04-12 Thread Rodrigo Siqueira
Cc: Mark Broadworth Cc: Michael Strauss Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c

[PATCH 0/4] Fix compilation issues when using i386

2022-06-30 Thread Rodrigo Siqueira
. If you still see compilation issues, please, report: - GCC version - Config file - Branch Thanks Siqueira Rodrigo Siqueira (4): drm/amd/display: Fix __umoddi3 undefined for 32 bit compilation drm/amd/display: Fix __floatunsidf undefined for 32 bit compilation drm/amd/display: Fix __muld

[PATCH 1/4] drm/amd/display: Fix __umoddi3 undefined for 32 bit compilation

2022-06-30 Thread Rodrigo Siqueira
Cc: Randy Dunlap Fixes: 9b0e0d433f74 ("drm/amd/display: Add dependant changes for DCN32/321") Reported-by: Stephen Rothwell Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

[PATCH 3/4] drm/amd/display: Fix __muldf3 undefined for 32 bit compilation

2022-06-30 Thread Rodrigo Siqueira
Randy Dunlap Fixes: 9b79abf79c414 ("drm/amd/display: add CLKMGR changes for DCN32/321") Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/cl

[PATCH 4/4] drm/amd/display: Fix __nedf2 undefined for 32 bit compilation

2022-06-30 Thread Rodrigo Siqueira
y Wentland Cc: Alex Deucher Cc: Randy Dunlap Fixes: 9b79abf79c414 ("drm/amd/display: add CLKMGR changes for DCN32/321") Signed-off-by: Rodrigo Siqueira --- .../drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --g

[PATCH 2/4] drm/amd/display: Fix __floatunsidf undefined for 32 bit compilation

2022-06-30 Thread Rodrigo Siqueira
chitecture. This issue can be fixed by changing the value type. Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Alex Deucher Cc: Randy Dunlap Fixes: 9b79abf79c414 ("drm/amd/display: add CLKMGR changes for DCN32/321") Reported-by: Stephen Rothwell Signed-off-by: Rodrigo Siqueira ---

[PATCH 00/40] DC Patches Jun 30, 2022

2022-06-30 Thread Rodrigo Siqueira
against ddc_pin being NULL for AUX drm/amd/display: Remove incorrect ASSERT check for link_enc drm/amd/display: Guard against NULL link encoder in log hw state Rodrigo Siqueira (6): drm/amd/display: Add missing registers for ACP drm/amd/display: Use two pixel per container for k1/k2 div

[PATCH 01/40] drm/amd/display: Add missing registers for ACP

2022-06-30 Thread Rodrigo Siqueira
We are missing some ACP registers/mask value for some specific ASICs. This commit includes it to those ASICs that support it. Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h | 2 ++ drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_1_sh_mask.h | 2

[PATCH 05/40] drm/amd/display: Apply ODM 2:1 policy for single display configuration

2022-06-30 Thread Rodrigo Siqueira
PIXEL_RATE_DIVK2 - DP_PIXEL_PER_CYCLE_PROCESSING_MODE - DIG_FIFO_OUTPUT_PIXEL_MODE - DP_VID_N_MUL Acked-by: Rodrigo Siqueira Signed-off-by: Samson Tam --- drivers/gpu/drm/amd/display/dc/dc.h | 2 + .../drm/amd/display/dc/dcn20/dcn20_resource.c | 7 +++ .../dc/dcn32/dcn32_dio_stream_encoder.c

[PATCH 06/40] drm/amd/display: Use two pixel per container for k1/k2 div

2022-06-30 Thread Rodrigo Siqueira
Currently, we check if pixel_encoding is equal to PIXEL_ENCODING_YCBCR422 to get the k1/k2 div parameters. This commit changes this logic slightly by checking if two pixels per container are used. Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 8

[PATCH 04/40] drm/amd/display: Add function to set pixels per cycle

2022-06-30 Thread Rodrigo Siqueira
From: Eric Bernstein Add function to set pixels per cycle in DIG stream encoder Acked-by: Rodrigo Siqueira Signed-off-by: Eric Bernstein --- .../amd/display/dc/dcn10/dcn10_stream_encoder.h | 1 + .../gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 5 ++--- .../display/dc/dcn32

[PATCH 12/40] drm/amd/display: Fix stream->link_enc unassigned during stream removal

2022-06-30 Thread Rodrigo Siqueira
From: Nicholas Kazlauskas [Why] Found when running igt@kms_atomic. Userspace attempts to do a TEST_COMMIT when 0 streams which calls dc_remove_stream_from_ctx. This in turn calls link_enc_unassign which ends up modifying stream->link = NULL directly, causing the global link_enc to be removed pre

[PATCH 03/40] drm/amd/display: Prepare for new interfaces

2022-06-30 Thread Rodrigo Siqueira
From: Martin Leung [WHY]: Lut pipeline will be hooked up differently in some asics need to add new interfaces and missing registers. [HOW]: Add missing registers and hook up programming from DPP for pre-blend lut. Acked-by: Rodrigo Siqueira Signed-off-by: Martin Leung --- .../gpu/drm/amd

[PATCH 10/40] drm/amd/display: Make OPTC3 function accessible to other DCN

2022-06-30 Thread Rodrigo Siqueira
From: Alvin Lee [Why] Newer DCN should use optc3 [How] Declare optc3 vmin/vmax function in header. Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dc.h | 1 + drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 5 + drivers/gpu/drm/amd/display/dc/dcn32/dcn32_init

[PATCH 07/40] drm/amd/display: Change DET policy for MPO cases

2022-06-30 Thread Rodrigo Siqueira
From: Alvin Lee For MPO we want to allocate less than maximum DET for MPO pipes because we need enogh buffer to move DET back to toher pipes when removing an MPO plane. Also update regular DET allocation to use DET override (DCN32 has an internal policy which driver does not want to use) Signed-

[PATCH 08/40] drm/amd/display: Switch to correct DTO on HDMI

2022-06-30 Thread Rodrigo Siqueira
From: Chris Park [Why] For Pixel Rate control, when on HDMI, HDMI DTO should be selected instead of DP DTO. [How] Pass HDMI parameter for HDMI stream, and select correct DTO. Signed-off-by: Chris Park --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 ++ drivers/gpu/drm/amd

[PATCH 11/40] drm/amd/display: Add basic infrastructure for enabling FAMS

2022-06-30 Thread Rodrigo Siqueira
We want to enable Firmware Assisted Memory (FAMS) Switching, but first, we need to add the required code infrastructure in DC before allowing it in amdgpu_dm. Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 8 + drivers/gpu/drm/amd/display/dc/dc.h

[PATCH 09/40] drm/amd/display: Update gpuvm_max_page_table_levels IP param

2022-06-30 Thread Rodrigo Siqueira
From: Eric Bernstein After some experimental tests, we noticed that we need to set gpuvm_max_page_table_levels to '4' to meet the hardware requirements. Signed-off-by: Eric Bernstein --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn321/dcn32

[PATCH 13/40] drm/amd/display: Add SubVP control lock

2022-06-30 Thread Rodrigo Siqueira
Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index db02f071c949..05c2e178ca99 100644 --- a/drivers

[PATCH 14/40] drm/amd/display: Add minimal pipe split transition state

2022-06-30 Thread Rodrigo Siqueira
-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 277 + drivers/gpu/drm/amd/display/dc/dc_stream.h | 18 ++ 2 files changed, 295 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index

[PATCH 15/40] drm/amd/display: disable timing sync b/w odm halves

2022-06-30 Thread Rodrigo Siqueira
From: Dmytro Laktyushkin Fix for a bug where we would try to timing sync 2 odm halves. Acked-by: Rodrigo Siqueira Signed-off-by: Dmytro Laktyushkin --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display

[PATCH 16/40] drm/amd/display: guard for virtual calling destroy_link_encoders

2022-06-30 Thread Rodrigo Siqueira
From: Martin Leung [Why]: On power down, virtual dal may try to delete link_encoders by referencing uninitialized res_pool. [How]: Added guard against empty res_pool. Acked-by: Rodrigo Siqueira Signed-off-by: Martin Leung --- drivers/gpu/drm/amd/display/dc/core/dc.c | 10 -- 1 file

[PATCH 17/40] drm/amd/display: Maintain consistent mode of operation during encoder assignment

2022-06-30 Thread Rodrigo Siqueira
mode of operation of the link encoder assignment module. - Add additional checks for encoder assignment defects. - Explicitly reset the mode of operation if application of state to hardware ends prematurely. Acked-by: Rodrigo Siqueira Signed-off-by: Jimmy Kizito --- drivers/gpu/drm/amd/display/dc

[PATCH 18/40] drm/amd/display: Extend soc BB capabilitiy

2022-06-30 Thread Rodrigo Siqueira
From: Jun Lei [why] Some parts are consuming dangerously close to maximum number of states supported when updating the BB (i.e. 8). [how] Change maximum stages from 9 to 20. Acked-by: Rodrigo Siqueira Signed-off-by: Jun Lei --- .../drm/amd/display/dc/dcn32/dcn32_resource.c | 508

[PATCH 23/40] drm/amd/display: Remove incorrect ASSERT check for link_enc

2022-06-30 Thread Rodrigo Siqueira
How] Remove the ASSERTION. We already guard against NULL link_enc. Reviewed-by: Michael Strauss Acked-by: Rodrigo Siqueira Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 33/40] drm/amd/display: Move all linux includes into OS types

2022-06-30 Thread Rodrigo Siqueira
From: Harry Wentland Move all linux includes into OS types. Acked-by: Alan Liu Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/basics/vector.c | 2 -- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 -- drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH 26/40] drm/amd/display: disable otg toggle w/a on boot

2022-06-30 Thread Rodrigo Siqueira
From: Dmytro Laktyushkin This w/a has a bad interaction with seamless boot toggling an active stream. Most panels recover, however some fail leading to display corruption. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Dmytro Laktyushkin --- .../gpu/drm/amd/display/dc

[PATCH 22/40] drm/amd/display: Guard against ddc_pin being NULL for AUX

2022-06-30 Thread Rodrigo Siqueira
r aux engine acquire. Reviewed-by: Michael Strauss Acked-by: Rodrigo Siqueira Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/d

[PATCH 20/40] drm/amd/display: add an option to skip wait for HPD when powering on eDP panel

2022-06-30 Thread Rodrigo Siqueira
From: Evgenii Krasnikov [HOW/WHY] Add an option to skip edp_wait_for_hpd_ready when necessary Reviewed-by: Jayendran Ramani Acked-by: Rodrigo Siqueira Signed-off-by: Evgenii Krasnikov --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 5 +++-- drivers/gpu/drm/amd/display/dc/inc

[PATCH 29/40] drm/amd/display: Fix refresh rate issue on Club 3D

2022-06-30 Thread Rodrigo Siqueira
ut bw check") Reviewed-by: Hersen Wu Acked-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/a

[PATCH 25/40] drm/amd/display: Fix dmub soft hang for PSR 1

2022-06-30 Thread Rodrigo Siqueira
Jayamohanan Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH 31/40] drm/amd/display: Add flag to modify MST delay

2022-06-30 Thread Rodrigo Siqueira
From: Duncan Ma [Why] Some panels may require more MST delay on discovery [How] Add panel patch and debug mst delay flag Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-off-by: Duncan Ma --- drivers/gpu/drm/amd/display/dc/dc.h | 3 ++- drivers/gpu/drm/amd/display/dc

[PATCH 27/40] drm/amd/display: Indicate stream change on ODM change

2022-06-30 Thread Rodrigo Siqueira
ODM. [How] Set ODM flag in stream and commit stream when change in ODM has been detected due to policy change. Reviewed-by: Samson Tam Acked-by: Rodrigo Siqueira Signed-off-by: Chris Park --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 3 +++ drivers/gpu/drm/amd/display/dc/dc_stream.h

[PATCH 34/40] drm/amd/display: Fix uninitialized variable.

2022-06-30 Thread Rodrigo Siqueira
From: Jimmy Kizito [Why] Uninitialized variable causes diag compilation build failure. [How] - Ensure that variable in question is always initialized before being used. - The variable in question is the USB4 DP training pattern. In case an unsupported training pattern has been requested, update

[PATCH 21/40] drm/amd/display: Program ACP related register

2022-06-30 Thread Rodrigo Siqueira
From: Alan Liu - Setup the shift and mask of HDMI_ACP_SEND register - Program the register in hdmi stream encoder - Also update ACP register in azalia configuration Reviewed-by: Harry Wentland Acked-by: Rodrigo Siqueira Signed-off-by: Alan Liu --- drivers/gpu/drm/amd/display/dc/dce

[PATCH 32/40] drm/amd/display: Fix null timing generator resource

2022-06-30 Thread Rodrigo Siqueira
From: Eric Bernstein [Why] For some customer blending transition cases, the available pipe for second stream is a pipe index that is greater than the number of timing generators, which can cause a problem in acquire_first_free_pipe since it assumes same index for pipe and timing generator [How]

[PATCH 28/40] drm/amd/display: Remove configuration option for dpia hpd delay

2022-06-30 Thread Rodrigo Siqueira
From: Meenakshikumar Somasundaram [Why] DC debug option to configure dpia hpd processing delay is not required. [How] Remove dc debug option for dpia hpd delay and also added log for querying dpia hpd state. Reviewed-by: Mustapha Ghaddar Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira

[PATCH 19/40] drm/amd/display: Don't set dram clock change requirement for SubVP

2022-06-30 Thread Rodrigo Siqueira
From: Alvin Lee [Description] In general cases we want to keep the dram clock change requirement (we prefer configs that support MCLK switch). Only override to false for SubVP. Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dml

[PATCH 24/40] drm/amd/display: Guard against NULL link encoder in log hw state

2022-06-30 Thread Rodrigo Siqueira
From: Nicholas Kazlauskas [Why & How] Check lenc is not NULL since dynamic link encoder assignment could end up assigning a NULL link encoder. Reviewed-by: Michael Strauss Acked-by: Rodrigo Siqueira Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/d

[PATCH 30/40] drm/amd/display: Disable TBT3 DSC work around by default.

2022-06-30 Thread Rodrigo Siqueira
From: Jimmy Kizito [Why] Some TBT3 docks have DPOAs which report USB4 capability and are expected to support USB4 DPOA features such as FEC/DSC. [How] By default, do not override FEC/DSC capabilities reported by TBT3 docks. Reviewed-by: Meenakshikumar Somasundaram Acked-by: Rodrigo Siqueira

[PATCH 37/40] drm/amd/display: enable PCON SST support for newer ASICs

2022-06-30 Thread Rodrigo Siqueira
From: Hamza Mahfooz Generic PCON SST support already exists and works for newer ASICs. So, enable it by default. Acked-by: Rodrigo Siqueira Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dc/dcn315/dcn315_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn316/dcn316_resource.c

[PATCH 38/40] drm/amd/display: rename hdmi_frl_pcon_support

2022-06-30 Thread Rodrigo Siqueira
From: Hamza Mahfooz hdmi_frl_pcon_support has been the source of confusion. So, rename it to dp_hdmi21_pcon_support. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c| 2 +- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/

[PATCH 39/40] drm/amd/display: Maintain old audio programming sequence

2022-06-30 Thread Rodrigo Siqueira
From: Alvin Lee [Description] Program audio DTO before wall dto for audio Reviewed-by: Martin Leung Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- .../gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drive

[PATCH 35/40] drm/amd/display: Initialize lt_settings on instantiation

2022-06-30 Thread Rodrigo Siqueira
From: Michael Strauss [WHY] lt_settings' pointers remain uninitialized but nonzero if display fails to light up with no DPCD/EDID info populated, leading to a hang on access Reviewed-by: Nicholas Kazlauskas Acked-by: Alan Liu Signed-off-by: Michael Strauss --- drivers/gpu/drm/amd/display/dc/

[PATCH 36/40] drm/amd/display: OVT Update on InfoFrame and Mode Management

2022-06-30 Thread Rodrigo Siqueira
From: Chris Park [Why] Integrate OVT timing from DM to DC logic to update info frame and mode management to report the resolution to the OS. [How] Reflect RID and Frame Rate to AVI InfoFrame Version 5. Define new Timing Standard for OVT timing. Reviewed-by: Charlene Liu Acked-by: Alan Liu Sig

[PATCH 40/40] drm/amd/display: 3.2.192

2022-06-30 Thread Rodrigo Siqueira
: Rodrigo Siqueira Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index a9c59669dd1d..02bbc90a2c80 100644 --- a/drivers/gpu/drm/amd/display/dc

[PATCH] drm/amd/display: Add missing header

2022-07-06 Thread Rodrigo Siqueira
Kernel test robot reported this GCC error: warning: no previous prototype for 'dc_reset_state' [-Wmissing-prototypes] 2720 | void dc_reset_state(struct dc *dc, struct dc_state *context) This commit adds the missing prototype. Reported-by: kernel test robot Signed-off-by: Rodrig

<    3   4   5   6   7   8   9   10   11   12   >