From: Mario Limonciello
If the dGPU is off, then reading the sysfs files with a sensor monitoring
application will wake it. Change the behavior to return an error when the
dGPU is in D3cold.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 90
On 8/9/24 15:42, Hamza Mahfooz wrote:
We don't actually need to request that the compositor does a full
modeset to modify the panel power savings level, we can instead
just make a request to DMUB, to set the new level dynamically.
Cc: Harry Wentland
Cc: Leo Li
Cc: Mario Limonciell
.
9d8c094ddab05db88d183ba82e23be807848cad8 is the first bad commit
commit 9d8c094ddab05db88d183ba82e23be807848cad8
Author: Mario Limonciello
Date: Wed Jul 3 00:17:22 2024 -0500
drm/amd: Add power_saving_policy drm property to eDP connectors
When the `power_saving_policy` property is set to bit mask
"Re
On 8/18/2024 01:56, Thomas Weißschuh wrote:
The value of "min_input_signal" returned from ATIF on a Framework AMD 13
is "12". This leads to a fairly bright minimum display backlight.
Introduce a quirk to override "min_input_signal" to "0" which leads to a
much lower minimum brightness, which is
.
Reviewed-by: Mario Limonciello
---
Documentation/gpu/drm-kms-helpers.rst| 3 ++
drivers/gpu/drm/Kconfig | 4 ++
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/drm_panel_backlight_quirks.c | 70
include/drm
abilities where necessary.
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
The code looks fine to me but please wait for an ack from someone on the
AMD display team.
Also, I would like to see comments about the testing with panel power
savings enabled to avoid a conflict.
Rev
much lower minimum brightness, which is still visible.
Tested on a Framework AMD 13 BIOS 3.05 with the matte panel.
Link: https://community.frame.work/t/25711/9
Link: https://community.frame.work/t/47036
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
Reviewed-by: Mario Limon
ur own S-o-b as
well. Please add that for v6. Otherwise:
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/drm_panel_backlight_quirks.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c
b/drivers/gpu/drm/drm_panel_backlight
On 8/22/2024 01:12, Thomas Weißschuh wrote:
On 2024-08-21 15:51:17+, Mario Limonciello wrote:
On 8/18/2024 01:56, Thomas Weißschuh wrote:
Panels using a PWM-controlled backlight source do not have a standard
way to communicate their valid PWM ranges.
On x86 the ranges are read from ACPI
On 8/22/2024 01:14, Thomas Weißschuh wrote:
On 2024-08-21 15:54:14+, Mario Limonciello wrote:
On 8/18/2024 01:56, Thomas Weißschuh wrote:
Not all platforms provide correct PWM backlight capabilities through ATIF.
I don't think correct is an accurate term here. How about
On 7/23/2024 04:42, Lu Yao wrote:
[Why]
When running kdump test on a machine with R7340 card, a hang is caused due
to the failure of 'amdgpu_device_ip_init()', error message as follows:
'[drm:amdgpu_device_ip_init [amdgpu]] *ERROR* hw_init of IP block
failed -22'
'[drm:uvd_v3_1_hw_init [
On 8/23/2024 08:44, Hamza Mahfooz wrote:
On 8/19/24 22:04, Mario Limonciello wrote:
From: Mario Limonciello
If the dGPU is off, then reading the sysfs files with a sensor monitoring
application will wake it. Change the behavior to return an error when the
dGPU is in D3cold.
Signed-off-by
On 8/23/2024 09:09, Alex Deucher wrote:
On Mon, Aug 19, 2024 at 10:30 PM Mario Limonciello wrote:
From: Mario Limonciello
If the dGPU is off, then reading the sysfs files with a sensor monitoring
application will wake it. Change the behavior to return an error when the
dGPU is in D3cold
On 8/23/2024 09:31, Alex Deucher wrote:
On Fri, Aug 23, 2024 at 10:13 AM Mario Limonciello
wrote:
On 8/23/2024 09:09, Alex Deucher wrote:
On Mon, Aug 19, 2024 at 10:30 PM Mario Limonciello wrote:
From: Mario Limonciello
If the dGPU is off, then reading the sysfs files with a sensor
All accesses to attributes have a check for reset/suspend/runpm. Move this
code into dedicated functions. No intended functional changes.
Signed-off-by: Mario Limonciello
---
v1->v2:
* Split out to two patches to reduce boilerplate with common functions
* Different behavior for sysfs
If the dGPU is off, then reading the sysfs files with a sensor monitoring
application will wake it. Change the behavior to return an error when the
dGPU is in runtime PM. Leave the behavior the same for debugfs files.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8
On 8/25/24 15:40, Luna Nova wrote:
Raised this as an issue a while back on the bug tracker and it got closed as
WONTFIX. https://gitlab.freedesktop.org/drm/amd/-/issues/2229
Been running a patched kernel with a similar patch locally ever since because
even figuring out everything on the syst
wonder if we need to internally turn off panel
power savings in display code when brightness falls a threshold (12 IIRC
was the real "minimum" advertised in the table?).
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
Reviewed-by: Mario Limonciello
---
driver
On 8/28/2024 05:59, WangYuli wrote:
From: wenlunpeng
The quirk is for reboot-stability.
A device reboot stress test has been observed to cause
random system hangs when amdgpu_dpm is enabled.
Disabling amdgpu_dpm can fix this.
However, a boot-param can still overwrite it to enable
amdgpu_dpm.
On 8/28/2024 11:14, Alex Deucher wrote:
On Wed, Aug 28, 2024 at 11:47 AM WangYuli wrote:
On 2024/8/28 23:30, Alex Deucher wrote:
On Wed, Aug 28, 2024 at 7:28 AM WangYuli wrote:
This will disable dpm on all devices that you might install on this
platform. If this is specific to a particula
From: Mario Limonciello
This is the successor of Melissa's v5 series that was posted [1] as well
as my series that was posted [2].
Melissa's patches are mostly unmodified from v5, but modified to apply on
top of v6.11-rc7 instead.
The same limitations she called out with amd-stagin
From: Melissa Wen
Connectors have source physical address available in display
info. Use drm_dp_cec_attach() to use it instead of parsing the EDID
again.
Signed-off-by: Melissa Wen
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
1 file
From: Melissa Wen
Replace raw edid handling (struct edid) with the opaque EDID type
(struct drm_edid) on amdgpu_dm_connector for consistency. It may also
prevent mismatch of approaches in different parts of the driver code.
Signed-off-by: Melissa Wen
Co-developed-by: Mario Limonciello
Signed
From: Melissa Wen
Update connector caps with drm_edid data before parsing info for
freesync.
Signed-off-by: Melissa Wen
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
From: Melissa Wen
When updating connector under drm_edid infrastructure, many calculations
and validations are already done and become redundant inside AMD driver.
Remove those driver-specific code in favor of the DRM common code.
Signed-off-by: Melissa Wen
Co-developed-by: Mario Limonciello
From: Melissa Wen
Since [1], we can use drm_edid_product_id to get debug info from
drm_edid instead of directly parsing EDID.
Link:
https://lore.kernel.org/dri-devel/cover.1712655867.git.jani.nik...@intel.com/
[1]
Signed-off-by: Melissa Wen
Co-developed-by: Mario Limonciello
Signed-off-by
-by: Melissa Wen
Signed-off-by: Mario Limonciello
---
v6:
- Move changelog to below cutlist
v5:
- squash with `don't give initial values for sad/b_count` (Alex H)
- add more informative commit description (Alex H)
---
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 20 +--
1
From: Melissa Wen
We don't need to parse dc_edid to get the display name since it's
already set in drm_eld which in turn had it values updated when updating
connector with the opaque drm_edid.
Signed-off-by: Melissa Wen
Signed-off-by: Mario Limonciello
---
.../gpu/drm/amd/display
From: Melissa Wen
We can parse edid caps from drm_edid and drm_eld and any calls of
dm_helpers_parse_edid_caps is made in a state that we have drm_edid set
to amdgpu connector.
Signed-off-by: Melissa Wen
Co-developed-by: Mario Limonciello
Signed-off-by: Mario Limonciello
---
v6:
- Move
Wen
Signed-off-by: Mario Limonciello
---
v6: Move changelog below cutlist
v5: add more informative commit description (Alex H)
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/display
From: Mario Limonciello
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops.
Attempt to fetch this EDID if it exists and prefer it over the EDID
that is provided by the panel. If a user prefers to use the EDID from
the panel, offer a DC
From: Mario Limonciello
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops.
Attempt to fetch this EDID if it exists and prefer it over the EDID
that is provided by the panel. If a user prefers to use the EDID from
the panel, offer a DC
pread is at least half of the
values that amdgpu would use if no ACPI table was found and if not
use the amdgpu defaults.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3020
Signed-off-by: Mario Limonciello
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 16
1
On 9/13/2024 13:47, Harry Wentland wrote:
On 2024-09-13 14:00, Mario Limonciello wrote:
Currently amdgpu takes backlight caps provided by the ACPI tables
on systems as is. If the firmware sets maximums that are too low
this means that users don't get a good experience.
To avoid havi
On 9/13/2024 15:36, Alex Deucher wrote:
On Fri, Sep 13, 2024 at 2:51 PM Mario Limonciello
wrote:
On 9/13/2024 13:47, Harry Wentland wrote:
On 2024-09-13 14:00, Mario Limonciello wrote:
Currently amdgpu takes backlight caps provided by the ACPI tables
on systems as is. If the firmware
From: Mario Limonciello
The issue with panel power savings compatibility below
`AMDGPU_DM_DEFAULT_MIN_BACKLIGHT` happens at
`AMDGPU_DM_DEFAULT_MIN_BACKLIGHT` as well.
That issue will be fixed separately, so don't prevent the backlight
brightness from going that low.
Cc: Harry Wentlan
more involved
amdgpu display driver work that will come separately as part of follow-ups
to: https://lore.kernel.org/amd-gfx/20240126163429.56714-1-m...@igalia.com/
Mario Limonciello (4):
ACPI: video: Handle fetching EDID that is longer than 256 bytes
drm: Add drm_get_acpi_edid() helper
drm
than necessary. Decrease from info to debug.
Link:
https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/Apx_B_Video_Extensions/output-device-specific-methods.html#ddc-return-the-edid-for-this-device
Signed-off-by: Mario Limonciello
---
v1->v2:
* Use for loop for acpi_video_get_edid()
* Use one of
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method.
Signed-off-by: Mario Limonciello
---
v1->v2:
* Split code from previous amdgpu
Rather than inventing a wrapper to acpi_video_get_edid() use the
one provided by drm. This fixes two problems:
1. A memory leak that the memory provided by the ACPI call was
never freed.
2. Validation of the BIOS provided blob.
Signed-off-by: Mario Limonciello
---
v1->v2:
* New pa
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops.
Attempt to fetch this EDID if it exists and prefer it over the EDID
that is provided by the panel.
Signed-off-by: Mario Limonciello
---
v2:
* Use drm helper which will run more
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops.
Attempt to fetch this EDID if it exists and prefer it over the EDID
that is provided by the panel.
Signed-off-by: Mario Limonciello
---
v2:
* Use drm helper which will run more
than necessary. Decrease from info to debug.
Link:
https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/Apx_B_Video_Extensions/output-device-specific-methods.html#ddc-return-the-edid-for-this-device
Signed-off-by: Mario Limonciello
---
v1->v2:
* Use for loop for acpi_video_get_edid()
* Use one of
Rather than inventing a wrapper to acpi_video_get_edid() use the
one provided by drm. This fixes two problems:
1. A memory leak that the memory provided by the ACPI call was
never freed.
2. Validation of the BIOS provided blob.
Signed-off-by: Mario Limonciello
---
v1->v2:
* New pa
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method.
Signed-off-by: Mario Limonciello
---
v1->v2:
* Split code from previous amdgpu
All of the selects on ACPI_VIDEO are unnecessary when DRM does the
select for ACPI_VIDEO as it provides a helper for acpi based EDID.
Signed-off-by: Mario Limonciello
---
v2->v3:
* new patch
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 7 ---
drivers/gpu/drm/gma500/Kconfig
O' from the DRM drivers
Mario Limonciello (5):
ACPI: video: Handle fetching EDID that is longer than 256 bytes
drm: Add drm_get_acpi_edid() helper
drm/amd: Fetch the EDID from _DDC if available for eDP
drm/nouveau: Use drm_get_acpi_edid() helper
drm: Drop unneeded selects in DRM dr
On 2/2/2024 04:29, Jani Nikula wrote:
On Thu, 01 Feb 2024, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method.
On 2/2/2024 10:07, Rafael J. Wysocki wrote:
On Thu, Feb 1, 2024 at 11:11 PM Mario Limonciello
wrote:
The ACPI specification allows for an EDID to be up to 512 bytes but
the _DDC EDID fetching code will only try up to 256 bytes.
Modify the code to instead start at 512 bytes and work it'
a new "panel_power_savings" sysfs attribute.
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
Reviewed-by: Mario Limonciello
Tested-by: Mario Limonciello
---
v2: hide ABM_LEVEL_IMMEDIATE_DISABLE in the read case, force an atomic
commit when setting the value, call sysfs_re
When dc_state_destruct() was refactored the new phantom_stream_count
and phantom_plane_count members weren't cleared.
Fixes: 012a04b1d6af ("drm/amd/display: Refactor phantom resource allocation")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/dc/core/dc_state.c
The 38-ec-11 TCON contained in some AUO panels will hang when used
with PSR-SU and changing the brightness.
Forcing a full frame update works around the issue, so add a quirk
for this panel to do just that.
Reported-by: aaron...@canonical.com
Signed-off-by: Mario Limonciello
---
Cc: hamza.mahf
/drm/amd/uploads/8f13ff3b00963c833e23e68aa8116959/output.log
[2]
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2645
Signed-off-by: Mario Limonciello
---
---
drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd
lleter
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3132#note_2271038
Fixes: 5095d5418193 ("drm/amd: Evict resources during PM ops prepare()
callback")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 14 --
1 file changed, 4 insertions(+), 10 deletio
On 2/6/2024 16:00, Deucher, Alexander wrote:
[AMD Official Use Only - General]
-Original Message-
From: amd-gfx On Behalf Of Mario
Limonciello
Sent: Tuesday, February 6, 2024 4:32 PM
To: amd-gfx@lists.freedesktop.org
Cc: Limonciello, Mario ; Jürg Billeter
Subject: [PATCH] drm/amd
s prepare()
callback")
Signed-off-by: Mario Limonciello
---
v1->v2:
* Add and use new in_prepare member
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 46 --
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 21 ++
3
Users report that by using GNOME to suspend the lockscreen trigger will
cause SDMA traffic and the system can deadlock.
This reverts commit 0dee726395333fea833eaaf838bc80962df886c8.
Fixes: ab4750332dbe ("drm/amdgpu/sdma5.2: add begin/end_use ring callbacks")
Signed-off-by: Mario Limonci
On 2/7/2024 16:34, Alex Deucher wrote:
On Wed, Feb 7, 2024 at 3:48 PM Mario Limonciello
wrote:
commit 5095d5418193 ("drm/amd: Evict resources during PM ops prepare()
callback")
intentionally moved the eviction of resources to earlier in the suspend
process, but this introduce
drm_edid. There will be a follow up
patch to amdgpu after Melissa Wen finishes that effort [2].
https://lore.kernel.org/dri-devel/20240201221119.42564-1-mario.limoncie...@amd.com/
[1]
https://lore.kernel.org/amd-gfx/20240126163429.56714-1-m...@igalia.com/ [2]
Mario Limonciello (3):
drm: Add
drm_edid at the same time.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/nouveau/nouveau_acpi.c | 27 -
drivers/gpu/drm/nouveau/nouveau_acpi.h | 2 --
drivers/gpu/drm/nouveau/nouveau_connector.c | 20 +++
3 files changed, 9 insertions(+), 40
All of the selects on ACPI_VIDEO are unnecessary when DRM does the
select for ACPI_VIDEO as it provides a helper for acpi based EDID.
Reviewed-by: Pranjal Ramajor Asha Kanojiya
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 7 ---
drivers/gpu/drm/gma500/Kconfig
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/Kconfig| 5 +++
drivers/gp
Users report that by using GNOME to suspend the lockscreen trigger will
cause SDMA traffic and the system can deadlock.
This reverts commit 0dee726395333fea833eaaf838bc80962df886c8.
Acked-by: Alex Deucher
Fixes: ab4750332dbe ("drm/amdgpu/sdma5.2: add begin/end_use ring callbacks")
Si
amdgpu_acpi_is_s0ix_active() and amdgpu_acpi_is_s0ix_active() aren't
needed to be checked multiple times in a suspend cycle. Checking and
setting up policy one time in the prepare() callback is sufficient.
Signed-off-by: Mario Limonciello
---
v4: New patch
---
drivers/gpu/drm/amd/a
t resources during PM ops prepare()
callback")
Signed-off-by: Mario Limonciello
---
v3->v4:
* New function to set s0ix/s3 and explicitly unset in cleanup
v2->v3:
* Whitespace
v1->v2:
* Add and use new in_prepare member
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h
https://gitlab.freedesktop.org/drm/amd/-/issues/3097
Syntax should be "Closes: $URL"
Fixes: 0a1844bf0b53 ("drm/buddy: Improve contiguous memory allocation")
Signed-off-by: Arunpravin Paneer Selvam
Tested-by: Mario Limonciello
Acked-by: Christian König
CC: stable.. ?
I will
On 2/8/2024 00:54, Christian König wrote:
Am 08.02.24 um 06:52 schrieb Mario Limonciello:
amdgpu_acpi_is_s0ix_active() and amdgpu_acpi_is_s0ix_active() aren't
needed to be checked multiple times in a suspend cycle. Checking and
setting up policy one time in the prepare() callback is suffi
On 2/8/2024 08:31, Jani Nikula wrote:
On Thu, 08 Feb 2024, Maxime Ripard wrote:
On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote:
On Wed, 07 Feb 2024, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on
for PSR-SU displays.
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
I think this with this patch in place you could also revert
571c2fa26aa6 ("drm/amd/display: Disable PSR-SU on Parade 0803 TCON again")
One minor nit below otherwise LGTM.
Reviewed-by: Mario Limonciello
---
On 2/9/2024 05:07, Daniel Vetter wrote:
On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote:
On Wed, 07 Feb 2024, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper to
level that they want to use. So,
prevent user space from changing the ABM level if the module parameter
is set to a non-auto value.
Signed-off-by: Hamza Mahfooz
Reviewed-by: Mario Limonciello
Tested-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
drive
On 2/9/2024 12:57, Daniel Vetter wrote:
On Fri, Feb 09, 2024 at 09:34:13AM -0600, Mario Limonciello wrote:
On 2/9/2024 05:07, Daniel Vetter wrote:
On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote:
On Wed, 07 Feb 2024, Mario Limonciello wrote:
Some manufacturers have intentionally
This series adds the ability to fetch the EDID through ACPI for laptop
panels. Drivers need to opt into the behavior.
In this series it's enabled by default for all eDP or LVDS panels with
AMDGPU and certain panels for Nouveau.
Mario Limonciello (3):
drm: Add support to get EDID from
disable this.
Signed-off-by: Mario Limonciello
---
v4->v5:
* rebase on v5 changes
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c| 3 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8
driv
drm_edid at the same time.
Signed-off-by: Mario Limonciello
---
v1->v2:
* New patch
v3->v4:
* Rebase on v4 changes
v4->v5:
* Rebase on v5 changes
---
drivers/gpu/drm/nouveau/nouveau_acpi.c | 27
drivers/gpu/drm/nouveau/nouveau_acpi.h | 2 --
drivers/gpu/dr
ff-by: Mario Limonciello
---
v1->v2:
* Split code from previous amdgpu specific helper to generic drm helper.
v2->v3:
* Add an extra select to fix a variety of randconfig errors found from
LKP robot.
v3->v4:
* Return struct drm_edid
v4->v5:
* Rename to drm_edid_read_acp
On 2/10/2024 23:50, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers that prefer to
fetch this EDID can set a bit on the drm_connector to indicate that
the DRM EDID helpers should try to fetch it and
On 2/12/2024 10:31, Mario Limonciello wrote:
On 2/10/2024 23:50, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers that prefer to
fetch this EDID can set a bit on the drm_connector to indicate that
This series adds the ability to fetch the EDID through ACPI for laptop
panels. Drivers need to opt into the behavior.
In this series it's enabled by default for all eDP or LVDS panels with
AMDGPU and certain panels for Nouveau.
Mario Limonciello (5):
drm: Stop using `select ACPI_VIDEO` i
Many DRM drivers (ab)use `select ACPI_VIDEO` and to avoid problems
will then select all the dependencies for ACPI_VIDEO. This creates
a soft dependency, but makes it very hard to use ACPI_VIDEO in DRM
core. Switch everything else over to use `depends on ACPI_VIDEO`
instead.
Signed-off-by: Mario
ff-by: Mario Limonciello
---
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu/drm/drm_edid.c | 109 +---
include/drm/drm_connector.h | 6 ++
include/drm/drm_edid.h | 1 +
4 files changed, 109 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/Kcon
drm_edid at the same time.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/nouveau/nouveau_acpi.c | 27
drivers/gpu/drm/nouveau/nouveau_acpi.h | 2 --
drivers/gpu/drm/nouveau/nouveau_connector.c | 35 +
3 files changed, 14 insertions(+), 50
Many drivers ab(use) `select BACKLIGHT_CLASS_DEVICE` to avoid
dependency problems. This however makes it impossible for DRM
core to be able to add a dependency on ACPI_VIDEO. Switch users
of `select BACKLIGHT_CLASS_DEVICE` to `depends on BACKLIGHT_CLASS_DEVICE`.
Signed-off-by: Mario Limonciello
disable this.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c| 3 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8
drivers/gpu/drm/amd/display/amdgpu_dm
On 2/15/2024 08:01, Jani Nikula wrote:
On Sat, 10 Feb 2024, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers that prefer to
fetch this EDID can set a bit on the drm_connector to indicate that
the
On 2/15/2024 11:54, Harry Wentland wrote:
On 2024-02-02 11:20, Mario Limonciello wrote:
On 2/2/2024 09:28, Hamza Mahfooz wrote:
We want programs besides the compositor to be able to enable or disable
panel power saving features. However, since they are currently only
configurable through DRM
On 2/14/2024 17:13, Ville Syrjälä wrote:
On Wed, Feb 14, 2024 at 03:57:54PM -0600, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers that prefer to
fetch this EDID can set a bit on the drm_connector
On 2/15/2024 12:47, Ville Syrjälä wrote:
On Thu, Feb 15, 2024 at 12:20:56PM -0600, Mario Limonciello wrote:
On 2/14/2024 17:13, Ville Syrjälä wrote:
On Wed, Feb 14, 2024 at 03:57:54PM -0600, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID
peg: add support for jpeg DPG mode")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c
b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c
index 3602738874ee..
Also introduce a Kconfig option that allows distributions to choose
the default policy that is appropriate for them.
Fixes: f97e4303da16 ("drm/amd/display: add panel_power_savings sysfs entry to
eDP connectors")
Signed-off-by: Mario Limonciello
---
Cc: Hamza Mahfooz
Cc: Harry Wentlan
On 2/16/2024 08:38, Christian König wrote:
Am 16.02.24 um 15:07 schrieb Mario Limonciello:
By exporting ABM to sysfs it's possible that DRM master and software
controlling the sysfs file fight over the value programmed for ABM.
Adjust the module parameter behavior to control who contro
On 2/16/2024 09:05, Harry Wentland wrote:
On 2024-02-16 09:47, Christian König wrote:
Am 16.02.24 um 15:42 schrieb Mario Limonciello:
On 2/16/2024 08:38, Christian König wrote:
Am 16.02.24 um 15:07 schrieb Mario Limonciello:
By exporting ABM to sysfs it's possible that DRM maste
On 2/16/2024 09:41, Christian König wrote:
Am 16.02.24 um 16:12 schrieb Mario Limonciello:
On 2/16/2024 09:05, Harry Wentland wrote:
On 2024-02-16 09:47, Christian König wrote:
Am 16.02.24 um 15:42 schrieb Mario Limonciello:
On 2/16/2024 08:38, Christian König wrote:
Am 16.02.24 um 15:07
ggested-by: Harry Wentland
Signed-off-by: Mario Limonciello
--
Cc: Hamza Mahfooz
Cc: Sun peng (Leo) Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 8
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 --
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ---
On 2/16/2024 10:13, Harry Wentland wrote:
On 2024-02-16 11:11, Harry Wentland wrote:
On 2024-02-16 10:42, Pekka Paalanen wrote:
On Fri, 16 Feb 2024 09:33:47 -0500
Harry Wentland wrote:
On 2024-02-16 03:19, Pekka Paalanen wrote:
On Fri, 2 Feb 2024 10:28:35 -0500
Hamza Mahfooz wrote:
On 2/21/2024 03:35, Ma Jun wrote:
Don't set power state flag when system enter runtime suspend,
or it may cause runtime resume failure issue.
Signed-off-by: Ma Jun
Reviewed-by: Mario Limonciello
Please add a fixes tag for 3a9626c816db901def438dc2513622e281186d39 when
commi
xpect the function to be called for APU.
Perhaps, should we be making the same change for other APUs?
It seems a few others call dcn10_power_down_on_boot() for the callback.
Cc: Mario Limonciello
Cc: Alex Deucher
Cc: sta...@vger.kernel.org
Reviewed-by: Nicholas Kazlauskas
Acked-by: Alex
work_16_on/
Closes:
https://www.reddit.com/r/framework/comments/1b6vzcy/framework_16_variable_refresh_rate/
Closes:
https://community.frame.work/t/resolved-no-vrr-freesync-with-amd-version/42338
Link: https://gist.github.com/superm1/e8fbacfa4d0f53150231d3a3e0a13faf [1]
Signed-off-by: Mario L
On 3/6/2024 11:08, Xaver Hugl wrote:
Like already mentioned in the power profiles daemon repository, I don't think
this makes sense. This is a display setting, which compositors have interest
in controlling, for example to:
- disable it in a bright environment, because afaiu it reduces the maximu
On 3/6/2024 12:00, Xaver Hugl wrote:
Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello
:
So the idea being if the compositor isn't using it we let
power-profiles-daemon (or any other software) take control via sysfs and
if the compositor does want to control it then it then it w
1 - 100 of 1088 matches
Mail list logo
