From: Melissa Wen <m...@igalia.com>

drm_edid_connector_update() updates display info, filling ELD with
speaker allocation data in the last step of update_dislay_info(). Our
goal is stopping using raw edid, so we can extract SADB from drm_eld
instead of access raw edid to get audio caps.

Signed-off-by: Melissa Wen <m...@igalia.com>
Signed-off-by: Mario Limonciello <mario.limoncie...@amd.com>
---
v6: Move changelog below cutlist
v5: add more informative commit description (Alex H)
---
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index 1bc9c12ab120..72ea78ff2c5b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
@@ -98,9 +98,8 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
        const struct drm_edid *drm_edid = aconnector->drm_edid;
        struct drm_edid_product_id product_id;
        struct edid *edid_buf = edid ? (struct edid *) edid->raw_edid : NULL;
-       int sad_count, sadb_count;
+       int sad_count;
        int i = 0;
-       uint8_t *sadb = NULL;
 
        enum dc_edid_status result = EDID_OK;
 
@@ -144,20 +143,12 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
                edid_caps->audio_modes[i].sample_size = sad.byte2;
        }
 
-       sadb_count = drm_edid_to_speaker_allocation((struct edid *) 
edid->raw_edid, &sadb);
 
-       if (sadb_count < 0) {
-               DRM_ERROR("Couldn't read Speaker Allocation Data Block: %d\n", 
sadb_count);
-               sadb_count = 0;
-       }
-
-       if (sadb_count)
-               edid_caps->speaker_flags = sadb[0];
+       if (connector->eld[DRM_ELD_SPEAKER])
+               edid_caps->speaker_flags = connector->eld[DRM_ELD_SPEAKER];
        else
                edid_caps->speaker_flags = DEFAULT_SPEAKER_LOCATION;
 
-       kfree(sadb);
-
        return result;
 }
 
-- 
2.43.0

Reply via email to