Re: [PATCH 17/28] net: realtek: r8169: Use PCI_IRQ_INTX

2024-03-26 Thread Heiner Kallweit
t rtl_alloc_irq(struct rtl8169_private *tp) > rtl_lock_config_regs(tp); > fallthrough; > case RTL_GIGA_MAC_VER_07 ... RTL_GIGA_MAC_VER_17: > - flags = PCI_IRQ_LEGACY; > + flags = PCI_IRQ_INTX; > break; > defaul

[PATCH] drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2

2024-05-09 Thread Heiner Kallweit
Support for I2C_CLASS_SPD is currently being removed from the kernel. Only remaining step is to remove the definition of I2C_CLASS_SPD. Setting I2C_CLASS_SPD in a driver is a no-op meanwhile, so remove it here. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/pm/swsmu/smu14

Re: [PATCH] r8169: fix ASPM-related issues on a number of systems with NIC version from RTL8168h

2023-11-08 Thread Heiner Kallweit
On 08.11.2023 08:05, Greg KH wrote: > On Wed, Nov 08, 2023 at 11:34:00AM +0800, Li Ma wrote: >> From: Heiner Kallweit >> >> This effectively reverts 4b5f82f6aaef. On a number of systems ASPM L1 >> causes tx timeouts with RTL8168h, see referenced bug report. >&g

[PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support

2023-11-14 Thread Heiner Kallweit
. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 1 - drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 1 - drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13

Re: [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support

2023-11-14 Thread Heiner Kallweit
>> be used in new code. So we can remove this class completely now. >> >> Preferably this series should be applied via the i2c tree. >> >> Signed-off-by: Heiner Kallweit >> >> --- >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - >>

Re: [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-14 Thread Heiner Kallweit
On 13.11.2023 18:49, Wolfram Sang wrote: > >> Preferably this series should be applied via the i2c tree. > > Are we in a hurry here, i.e. does it block further development of the > i801 smbus driver? My gut feeling says the patches should rather go via > drm and fbdev trees, but I may be convince

Re: [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support

2023-11-14 Thread Heiner Kallweit
On 13.11.2023 12:37, Heiner Kallweit wrote: > I2C_CLASS_SPD was used to expose the EEPROM content to user space, > via the legacy eeprom driver. Now that this driver has been removed, > we can remove I2C_CLASS_SPD support. at24 driver with explicit > instantiation should be used inst

[PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support

2023-11-14 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index

[PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-14 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - drivers/gpu/drm/ast/ast_i2c.c |1 - drivers/gpu/drm/bridge/synopsys

[PATCH 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support

2023-11-14 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/radeon/radeon_i2c.c |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/

[PATCH v3 03/20] drm/amd/display: remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/a

[PATCH v3 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/radeon/radeon_i2c.c |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c

[PATCH v2 03/20] drm/amd/display: remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/a

[PATCH v2 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/radeon/radeon_i2c.c |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c

[PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - drivers/gpu/drm/ast/ast_i2c.c |1 - drivers/gpu/drm/bridge/synopsys

[PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. v2: - change tag in commit subject of patch 03 - add ack tags v3: - fix a compile error in patch 5 Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_d

[PATCH v3 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/radeon/radeon_i2c.c |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c

[PATCH v3 03/20] drm/amd/display: remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/a

[PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - drivers/gpu/drm/ast/ast_i2c.c |1 - drivers/gpu/drm/bridge/synopsys

Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
On 19.11.2023 21:28, Helge Deller wrote: > On 11/19/23 12:28, Heiner Kallweit wrote: >> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >> Class-based device auto-detection

Re: [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
On 19.11.2023 21:48, Heiner Kallweit wrote: > On 19.11.2023 21:28, Helge Deller wrote: >> On 11/19/23 12:28, Heiner Kallweit wrote: >>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >>> olpc_dcon there's no i2c client driver left supportin

[PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. v2: - change tag in commit subject of patch 03 - add ack tags v3: - fix a compile error in patch 5 v4: - more ack and review tags Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/a

[PATCH v4 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/radeon/radeon_i2c.c |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c

[PATCH v4 03/20] drm/amd/display: remove I2C_CLASS_DDC support

2023-11-20 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/a

Re: [Intel-gfx] [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-21 Thread Heiner Kallweit
On 21.11.2023 09:58, Jani Nikula wrote: > On Mon, 20 Nov 2023, Heiner Kallweit wrote: >> v4: >> - more ack and review tags > > Please do not send new versions just to record the acks and > reviews. They should be added while applying the patches. > Right, typically al

Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
On 23.11.2023 07:56, Thomas Zimmermann wrote: > Hi > > Am 20.11.23 um 22:46 schrieb Heiner Kallweit: >> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >> Class-based d

Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Heiner Kallweit
On 23.11.2023 09:19, Thomas Zimmermann wrote: > Hi > > Am 23.11.23 um 08:16 schrieb Heiner Kallweit: >> On 23.11.2023 07:56, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 20.11.23 um 22:46 schrieb Heiner Kallweit: >>>> After removal of

[PATCH v5 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support

2023-11-24 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Alex Deucher Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drivers/gpu/drm/radeon/radeon_i2c.c |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/g

[PATCH v5 03/20] drm/amd/display: remove I2C_CLASS_DDC support

2023-11-24 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |1 - 1 file changed, 1 deletion(-) di

[PATCH v5 00/20] remove I2C_CLASS_DDC support

2023-11-24 Thread Heiner Kallweit
rably this series should be applied via the i2c tree. v2: - change tag in commit subject of patch 03 - add ack tags v3: - fix a compile error in patch 5 v4: - more ack and review tags v5: - more acks Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |1 - drive

[PATCH v2 4/9] powerpc/powernv/npu: use helper pci_dev_id

2019-04-24 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- arch/powerpc/platforms/powernv/npu-dma.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/platforms/powernv/npu-dma.c b/arch/powerpc/platforms/powernv/npu-dma.c

[PATCH v2 0/9] PCI: add help pci_dev_id

2019-04-24 Thread Heiner Kallweit
In several places in the kernel we find PCI_DEVID used like this: PCI_DEVID(dev->bus->number, dev->devfn) Therefore create a helper for it. v2: - apply the change to all affected places in the kernel Heiner Kallweit (9): PCI: add helper pci_dev_id PCI: use helper pci_dev_id r8169

[PATCH v2 8/9] stmmac: pci: use helper pci_dev_id

2019-04-24 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac

[PATCH v2 5/9] drm/amdkfd: use helper pci_dev_id

2019-04-24 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c index

[PATCH v2 9/9] platform/chrome: chromeos_laptop: use helper pci_dev_id

2019-04-24 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/platform/chrome/chromeos_laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c index

[PATCH v2 2/9] PCI: use helper pci_dev_id

2019-04-24 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/pci/msi.c| 6 +++--- drivers/pci/search.c | 10 +++--- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 73986825d..e039b740f 100644

[PATCH v2 3/9] r8169: use new helper pci_dev_id

2019-04-24 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index efaea1a0a..ae476fe8d

[PATCH v2 7/9] iommu/vt-d: use helper pci_dev_id

2019-04-24 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/iommu/intel-iommu.c | 2 +- drivers/iommu/intel_irq_remapping.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c

[PATCH v2 6/9] iommu/amd: use helper pci_dev_id

2019-04-24 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/iommu/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index f467cc4b4..5cb201422 100644 --- a/drivers/iommu

[PATCH v2 1/9] PCI: add helper pci_dev_id

2019-04-24 Thread Heiner Kallweit
In several places in the kernel we find PCI_DEVID used like this: PCI_DEVID(dev->bus->number, dev->devfn) Therefore create a helper for it. Signed-off-by: Heiner Kallweit --- include/linux/pci.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/pci.h b/include/li

Wrong LTR-related check in nbif_v6_3_1_program_ltr()

2025-02-24 Thread Heiner Kallweit
In nbif_v6_3_1_program_ltr() (and maybe other functions as well) you have the following: pcie_capability_read_word(adev->pdev, PCI_EXP_DEVCTL2, &devctl2); if (adev->pdev->ltr_path == (devctl2 & PCI_EXP_DEVCTL2_LTR_EN)) return; if (adev->pdev->ltr_path) pcie_capability_set_word(ad