esume case.
Regards,
Guchun
-Original Message-
From: Koenig, Christian
Sent: Thursday, July 29, 2021 7:11 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Gao,
Likun ; Zhang, Hawking ; Deucher,
Alexander
Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3
König
Sent: Thursday, July 29, 2021 8:50 PM
To: Chen, Guchun ; Koenig, Christian
; amd-gfx@lists.freedesktop.org; Gao, Likun
; Zhang, Hawking ; Deucher, Alexander
Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3
test
Hi Guchun,
see below.
Am 29.07.21 um 14:39
[Public]
/* number of umc channel instance with memory map register access */
-#define UMC_V6_7_CHANNEL_INSTANCE_NUM 4
+#define UMC_V6_7_UMC_INSTANCE_NUM 4
/* number of umc instance with memory map register access */
-#define UMC_V6_7_UMC_INSTANCE_NUM 8
+#define
[Public]
Hi Lothian,
Thanks for your report. I have a following fix for this problem, will send it
out soon for review.
Regards,
Guchun
From: amd-gfx On Behalf Of Mike Lothian
Sent: Sunday, August 1, 2021 7:57 PM
To: Gao, Likun
Cc: amd-gfx list ; Zhang, Hawking
Subject: Re: [PATCH] drm/amd
[Public]
Thank you, Christian.
Regarding fence_drv.initialized, it looks to a bit redundant, anyway let me
look into this more.
Regards,
Guchun
-Original Message-
From: Christian König
Sent: Monday, August 2, 2021 2:56 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Gao,
Likun
[Public]
Hi Alex,
I submitted the patch before your message, I will take care of this next time.
Regards,
Guchun
-Original Message-
From: Alex Deucher
Sent: Monday, August 2, 2021 9:35 PM
To: Chen, Guchun
Cc: Christian König ;
amd-gfx@lists.freedesktop.org; Gao, Likun ; Koenig
[Public]
+if (psp->asd_fw) {
+ release_firmware(psp->asd_fw);
adev->psp.asd_fw = NULL;
}
Use "psp->asd_fw = NULL" should be more simple?
Regards,
Guchun
From: amd-gfx On Behalf Of Li, Candice
Sent: Tuesday, August 3
[Public]
In psp_cmd_submit_buf, it has psp->mutex to guard this, so it should be fine.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Lazar, Lijo
Sent: Tuesday, August 3, 2021 2:30 PM
To: Li, Candice ; amd-gfx@lists.freedesktop.org
Cc: Clements, John
Subject: Re: [PATCH]
[Public]
Yeah, you are right, Lijo. @Li, Candice @Clements, John please address this
before submitting this patch.
Regards,
Guchun
-Original Message-
From: Lazar, Lijo
Sent: Tuesday, August 3, 2021 4:16 PM
To: Chen, Guchun ; Li, Candice ;
amd-gfx@lists.freedesktop.org
Cc: Clements
op.org
Cc: Zhang, Hawking ; Li, Candice ;
Lazar, Lijo ; Chen, Guchun
Subject: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access
[AMD Official Use Only]
Submitting patch to synchronize access to psp cmd submission memory to resolve
potential race conditions.
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, August 4, 2021 3:39 AM
To: amd-gfx@lists.freedesktop.org
Cc: Gui, Jack ; Deucher, Alexander
Subject: [PATCH] drm/amdgpu: add DID for beige goby
From: Chengmin
[Public]
Thanks John. As in the same context, it's meaningless that two mutex target
almost the same thing.
Regards,
Guchun
From: Clements, John
Sent: Wednesday, August 4, 2021 11:34 AM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Li, Candice ;
Lazar, Lijo
Su
[Public]
Sorry for missing RB.
This patch is:
Reviewed-by: Guchun Chen
Regards,
Guchun
From: amd-gfx On Behalf Of Chen, Guchun
Sent: Wednesday, August 4, 2021 11:40 AM
To: Clements, John ; amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Li, Candice ;
Lazar, Lijo
Subject: RE: [PATCH] drm
[Public]
+/*
+ * Helper function to query RAS EEPROM address
+ *
+ * @adev: amdgpu_device pointer
+ *
+ * Return true if vbios supports ras rom address reporting
As you have documented the first argument of function
amdgpu_atomfirmware_ras_rom_addr, the other one "uint8_t* i2c_address" should
b
[Public]
A spelling typo in commit body.
There may be multiple instances an only one is harvested.
s/an/and
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Tuesday, August 10, 2021 10:05 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhu
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Tuesday, August 10, 2021 11:03 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhu, James
Subject: [PATCH] drm/amdgpu: handle VCN instances when harvesting
[Public]
Thanks for your patch.
I suggest moving the check of function pointer dc->clk_mgr->funcs->get_clock
earlier, and return early if it's NULL, as if it's NULL, it's meaningless to
continue the clock setting.
if (!dc->clk_mgr || !dc->clk_mgr->funcs->get_clock)
return DC_FAIL_
[Public]
Hi Jingwen,
Your patch has caused amdgpu driver load failure on all ASICs. Please revert it
first and come up with a proper fix.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Andrey
Grodzovsky
Sent: Wednesday, August 11, 2021 12:41 AM
To: Chen, JingWen ; amd-
thread+0x117/0x130
[ 99.537071] ? kthread_park+0x90/0x9
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Chen, Guchun
Sent: Wednesday, August 11, 2021 5:24 PM
To: Grodzovsky, Andrey ; Chen, JingWen
; amd-gfx@lists.freedesktop.org
Cc: Liu, Monk ; Koenig, Christian ;
Jack
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Quan, Evan
Sent: Friday, August 13, 2021 4:10 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Chen, Guchun
; Quan, Evan
Subject: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12
[Public]
+Leo and James to review as well.
This patch is:
Acked-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Quan, Evan
Sent: Thursday, August 19, 2021 11:09 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Chen, Guchun
; Lazar, Lijo ; Quan, Evan
; Pan
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Quan, Evan
Sent: Friday, August 20, 2021 5:01 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Chen, Guchun
; Teng, Rui ; Quan, Evan
Subject: [PATCH] drm/amd/pm: a quick fix for "divid
ly we still need to call drm_sched_fini
first in hw_fini to stop job submission first.
@Koenig, Christian what's your opinion?
Regards,
Guchun
-Original Message-
From: Alex Deucher
Sent: Friday, August 20, 2021 2:13 AM
To: Mike Lothian
Cc: Grodzovsky, Andrey ; Chen, Guchun
; am
PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Chen, Guchun
; Lazar, Lijo ; Zhu, James
; Liu, Leo ; Quan, Evan
; Pan, Xinhui
Subject: [PATCH V2 1/3] drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE
on suspend
Perform proper cleanups on UVD/VCE suspend: powergate
: Grodzovsky, Andrey
Sent: Monday, August 23, 2021 10:42 PM
To: Christian König ; Chen, Guchun
; Alex Deucher ; Mike Lothian
; Koenig, Christian
Cc: amd-gfx list ; Gao, Likun
; Zhang, Hawking ; Deucher, Alexander
Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3
test (v2
[Public]
Hi Andrey and Christian,
Thanks for your comment, I will send out a new patch set later on after I
verify it.
Regards,
Guchun
-Original Message-
From: Grodzovsky, Andrey
Sent: Saturday, August 28, 2021 2:28 AM
To: Koenig, Christian ; Chen, Guchun
; amd-gfx
[Public]
Move PCIe atomic detection from kgf2kfd_probe into kgf2kfd_device_init because
the MEC firmware is not loaded yet at the probe stage
A spelling typo, s/kgf2kfd_device_init/ kgd2kfd_device_init
With above fixed, the patch is: Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Mes
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Evan Quan
Sent: Friday, September 10, 2021 11:18 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Lazar, Lijo
; Quan, Evan ; Pelloux-prayer,
Pierre-eric
Subject: [PATCH] drm/
From: Koenig, Christian
Sent: Friday, September 10, 2021 2:37 PM
To: Pan, Xinhui ; amd-gfx@lists.freedesktop.org;
dri-de...@lists.freedesktop.org; Deucher, Alexander
; Chen, Guchun
Cc: Shi, Leslie
Subject: Re: [PATCH] drm/ttm: add a BUG_ON in ttm_set_driver_manager when array
bounds
Yeah
[Public]
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
old mode 100644
new mode 100755
Please don't modify the file mode.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of shaoyunl
Sent: Friday, September 10, 2021 10:2
[Public]
Thanks for your suggestion, Robin. Do you agree with this as well, Christian
and Xinhui?
Regards,
Guchun
-Original Message-
From: Robin Murphy
Sent: Saturday, September 11, 2021 2:25 AM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org;
dri-de...@lists.freedesktop.org
[Public]
Ping...
Regards,
Guchun
-Original Message-
From: Chen, Guchun
Sent: Saturday, September 18, 2021 2:09 PM
To: amd-gfx@lists.freedesktop.org; Koenig, Christian
; Pan, Xinhui ; Deucher,
Alexander ; Grodzovsky, Andrey
; Liu, Monk
Cc: Chen, Guchun ; Shi, Leslie
Subject
[Public]
> + switch (adev->ip_versions[SDMA0_HWIP]) {
> + case IP_VERSION(5, 2, 0):
> adev->sdma.num_instances = 4;
> break;
Isn't the instance count also expected from discovery table?
This will be addressed in patch 54 of the series.
Regards,
Guchun
-Or
for case of pci_channel_io_normal as well?
Regards,
Guchun
-Original Message-
From: Grodzovsky, Andrey
Sent: Friday, October 1, 2021 10:22 AM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Koenig,
Christian ; Pan, Xinhui ;
Deucher, Alexander
Subject: Re: [PATCH] drm/amdgpu: add
[Public]
Got your point. Will send a new patch to address this.
Regards,
Guchun
-Original Message-
From: Grodzovsky, Andrey
Sent: Friday, October 1, 2021 10:29 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Koenig,
Christian ; Pan, Xinhui ;
Deucher, Alexander
Subject: Re
[Public]
Hi Andrey,
A new patch with subject "drm/amdgpu: handle the case of pci_channel_io_frozen
only in amdgpu_pci_resume" has been sent, pls review it. Thanks.
Regards,
Guchun
-Original Message-----
From: Chen, Guchun
Sent: Friday, October 1, 2021 11:21 PM
To: Grodzovs
[Public]
Thanks Andrey, I will update the name to be " pci_channel_state " when
submitting.
Regards,
Guchun
-Original Message-
From: Grodzovsky, Andrey
Sent: Tuesday, October 5, 2021 12:04 AM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Koenig,
Christian ; P
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Thursday, October 7, 2021 10:06 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/discovery: add missing case for SMU 11.0.5
Was mi
[Public]
Global variable to carry the sclk value looks a bit over-killed. Is it possible
that move all into cyan_skillfish_od_edit_dpm_table, like querying sclk first
and setting it to cyan_skillfish_user_settings.sclk?
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Laz
ds,
Guchun
-Original Message-
From: Lazar, Lijo
Sent: Thursday, October 21, 2021 5:45 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Koenig,
Christian ; Pan, Xinhui ;
Deucher, Alexander ; Liu, Leo
Subject: Re: [PATCH] drm/amdgpu: limit VCN instance number to 1 for
NAVY_FLOUNDER
From: Lazar, Lijo
Sent: Thursday, October 21, 2021 8:56 PM
To: Chen, Guchun ; Koenig, Christian
; Pan, Xinhui ; Deucher,
Alexander ; Liu, Leo ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: limit VCN instance number to 1 for
NAVY_FLOUNDER
On 10/21/2021 6:10 PM, Chen, Guchun
ase. Perhaps we need to check with VBIOS/SMU guys.
Regards,
Guchun
-Original Message-
From: Alex Deucher
Sent: Thursday, October 21, 2021 9:06 PM
To: Chen, Guchun
Cc: amd-gfx list ; Koenig, Christian
; Pan, Xinhui ; Deucher,
Alexander ; Liu, Leo
Subject: Re: [PATCH] drm/amdgpu: limit
sage-----
From: Chen, Guchun
Sent: Thursday, October 21, 2021 9:14 PM
To: Alex Deucher
Cc: amd-gfx list ; Koenig, Christian
; Pan, Xinhui ; Deucher,
Alexander ; Liu, Leo
Subject: RE: [PATCH] drm/amdgpu: limit VCN instance number to 1 for
NAVY_FLOUNDER
Hi Alex,
No, it does not help.
adev->vcn.
>asic_type == CHIP_NAVY_FLOUNDER)
+ adev->vcn.harvest_config |= AMDGPU_VCN_HARVEST_VCN1;
Regards,
Guchun
-Original Message-
From: Alex Deucher
Sent: Thursday, October 21, 2021 10:02 PM
To: Chen, Guchun
Cc: amd-gfx list ; Koenig, Christian
; Pan, Xinhui ; Deucher,
Alexander ; L
[Public]
I will try it.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Friday, October 22, 2021 5:52 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 1/2] drm/amdgpu: Workaround harvesting info for some navy
flounder boards
[Public]
This series are: Reviewed-and-tested-by: Guchun Chen , on
top of "drm/amdgpu/vcn3.0: handle harvesting in firmware setup".
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Chen, Guchun
Sent: Friday, October 22, 2021 8:21 AM
To: Deucher, Alexander
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Friday, October 22, 2021 11:19 AM
To: Deucher, Alexander
Cc: amd-gfx list
Subject: Re: [PATCH] drm/amdgpu/smu11.0: add missing IP version check
Ping?
On Tue, Oct 19, 2
[Public]
This patch caused ring test of SDMA failure on Vega20.
Oct 12 00:18:24 vega20-ebd-11 kernel: [ 11.900968] IPv6:
ADDRCONF(NETDEV_CHANGE): eno1: link becomes ready
Oct 12 00:18:39 vega20-ebd-11 kernel: [ 27.007480] AMD-Vi: AMD IOMMUv2 driver
by Joerg Roedel
Oct 12 00:18:39 vega20-eb
[Public]
Reviewed-and-tested-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Friday, October 22, 2021 12:30 PM
To: Deucher, Alexander
Cc: amd-gfx list
Subject: Re: [PATCH] drm/amdgpu/nbio7.4: use original HDP_FLUSH bits for navi1x
On
[Public]
Acked-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Evan Quan
Sent: Thursday, November 4, 2021 2:20 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Quan, Evan
Subject: [PATCH] drm/amdgpu: correctly toggle gfx on/off around RLC_SP
[Public]
You need to add a Fix tag in the commit message, and pls document the null
pointer calltrace as well.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Asher Song
Sent: Friday, November 5, 2021 12:13 PM
To: amd-gfx@lists.freedesktop.org
Cc: Song, Asher
Subject: [P
[Public]
Acked-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Asher Song
Sent: Friday, November 5, 2021 5:41 PM
To: amd-gfx@lists.freedesktop.org
Cc: Song, Asher
Subject: [PATCH] drm/amdgpu: assign dpms for amdgpu_vkms_crtc_helper_funcs
In drm_helper_di
[Public]
Thanks Lijo and Christian for your review, this patch has been pushed with
Alex's RB:(
Regards,
Guchun
-Original Message-
From: Lazar, Lijo
Sent: Thursday, November 11, 2021 3:22 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Deucher,
Alexander ; Koenig, Chri
[Public]
A coding style problem.
A {} is needed for the path after if (smu_version < 0x00440700).
if (smu_version < 0x00440700)
> + ret = smu_cmn_send_smc_msg(smu, SMU_MSG_Mode1Reset, NULL);
> + else {
> + /* fatal error triggered by ras, PMFW supports the flag
> +
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Evan Quan
Sent: Thursday, November 18, 2021 4:27 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Quan, Evan
; Koenig, Christian
Subject: [PATCH] drm/amdgpu: update the domain
[Public]
Series is:
Reviewed-by: Guchun Chen
+Alex to comment this series as well.
Regards,
Guchun
-Original Message-
From: Cui, Flora
Sent: Monday, November 22, 2021 5:04 PM
To: amd-gfx@lists.freedesktop.org; Chen, Guchun
Cc: Cui, Flora
Subject: [PATCH 1/2] drm/amdgpu: fix vkms
[Public]
Hi Jane/Alex,
Adding a check of new IP in this case looks good to me.
Regards,
Guchun
From: Jian, Jane
Sent: Wednesday, November 24, 2021 10:54 AM
To: Deucher, Alexander ; Chen, Guchun
; Chen, JingWen
Cc: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu/sriov/vcn: skip
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Yang Wang
Sent: Wednesday, November 24, 2021 12:37 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Lazar, Lijo
; Wang, Yang(Kevin) ; Zhang,
Hawking
Subject: [PATCH] drm/amdg
mdgpu_sriov_vf(adev))
amdgpu_device_ip_block_add(adev, &jpeg_v3_0_ip_block);
break;
Regards,
Guchun
-Original Message-
From: Alex Deucher
Sent: Wednesday, November 24, 2021 10:23 PM
To: Jian, Jane
Cc: Deucher, Alexander ; Chen, Guchun
; Chen, JingWen ; amd-gfx list
Subject: Re: [PATC
mdgpu_sriov_vf(adev))
amdgpu_device_ip_block_add(adev, &jpeg_v3_0_ip_block);
break;
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Chen, Guchun
Sent: Thursday, November 25, 2021 10:19 AM
To: Alex Deucher ; Jian, Jane
Cc: Deucher, Alexander ; Chen, JingWen
; amd-gfx li
[Public]
I guess you need to add this IP version in nv_query_video_codecs as well.
With above clarified/fixed, this patch is:
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Jane Jian
Sent: Thursday, November 25, 2021 11:15 AM
To: Deucher, Alexander ; Chen, Guchun
[Public]
Use dev_warn to be mGPU friendly?
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Lijo Lazar
Sent: Thursday, November 25, 2021 7:51 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Limonciello, Mario
; Zhang, Hawking
Subject: [PATCH] drm/amd/pm: Add
[Public]
Thanks for clarification, Lijo.
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Lazar, Lijo
Sent: Thursday, November 25, 2021 9:32 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Limonciello, Mario
; Zhang, Hawking
Subject
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Lijo Lazar
Sent: Friday, November 26, 2021 1:25 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Limonciello, Mario
; Zhang, Hawking
Subject: [PATCH v2] drm/amd/pm: Add warnin
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Lijo Lazar
Sent: Friday, November 26, 2021 2:43 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhang, Hawking
Subject: [PATCH] drm/amdgpu: Use MAX_HWIP instead of HW_ID_MAX
[Public]
Two nit-picks.
1. It's better to drop "return" in amdgpu_dpm_get_current_power_state.
2. In some functions, when function pointer is NULL, sometimes it returns 0,
while in other cases, it returns -EOPNOTSUPP. Is there any cause for this?
Regards,
Guchun
-Original Message-
Fro
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Thursday, December 2, 2021 5:36 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu: handle SRIOV VCN revision parsing
For SR-IOV, th
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Cui, Flora
Sent: Tuesday, December 7, 2021 3:12 PM
To: Chen, Guchun ; Yuan, Perry ; Shi,
Leslie ; amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: [PATCH] drm/amdgpu: fix drm_plane alloc in amdgpu_vkms
[Public]
Hi Leslie,
Can we move revision handling in this patch into
amdgpu_discovery_get_vcn_version? Then we will maintain all revision handlings
only in amdgpu_discovery.c.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Leslie Shi
Sent: Wednesday, December 8, 2021 4
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Leslie Shi
Sent: Wednesday, December 8, 2021 4:46 PM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH] drm/amdgpu: add modifiers in amdgpu_vkms_plane_init()
Fix following warning in SRIOV
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Shi, Leslie
Sent: Thursday, December 9, 2021 4:27 PM
To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Shi, Leslie
Subject: [PATCH v3] drm/amdgpu: fix incorrect VCN revision in SRIOV
Guest
Lazar, Lijo
Sent: Thursday, December 9, 2021 4:53 PM
To: Shi, Leslie ; amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun
Subject: Re: [PATCH v3] drm/amdgpu: fix incorrect VCN revision in SRIOV
On 12/9/2021 1:56 PM, Leslie Shi wrote:
> Guest OS will setup VCN instance 1 which is disabled as a
list
; Chen, Guchun
Subject: Re: [PATCH v2] drm/amdgpu: fix incorrect VCN revision in SRIOV
On Thu, Dec 9, 2021 at 12:18 AM Leslie Shi wrote:
>
> Guest OS will setup VCN instance 1 which is disabled as an enabled
> instance and execute initialization work on it, but this causes VCN i
[Public]
In SMU11/SMU12, it will cache pm.fw_version unconditionally only in APU case.
So we should apply the same code in smu_v13_0_check_fw_version?
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Mario
Limonciello
Sent: Friday, December 10, 2021 10:29 PM
To: amd-gfx@l
[Public]
A coding style nitpick.
int ret = 0;
+ uint32_t profile_mode_mask = AMD_DPM_FORCED_LEVEL_PROFILE_STANDARD |
+ AMD_DPM_FORCED_LEVEL_PROFILE_MIN_SCLK |
+ AMD_DPM_FORCED_LEVEL_PROFILE_MIN_MCLK |
+
[Public]
- if (unlikely(smu->smu_debug_mask & SMU_DEBUG_HALT_ON_ERROR) &&
+ if (unlikely(adev->smu_debug_mask & SMU_DEBUG_HALT_ON_ERROR) &&
res && (res != -ETIME)) {
amdgpu_device_halt(smu->adev);
[Guchun] As we have set an 'adev' variable, we can replace '
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Quan, Evan
Sent: Monday, December 13, 2021 3:20 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Chen, Guchun
; Lazar, Lijo ; Quan, Evan
Subject: [PATCH V2] drm/amdgpu: move smu_debug_mask to a
[Public]
A nitpick.
As we have defined a local variable 'adev', so code like 'smu->adev' should be
replaced directly by 'adev' in the function to make code clean.
With above addressed, the series is:
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behal
[Public]
+ if (adev->asic_type == CHIP_ALDEBARAN)
+ offset = 0;
if (!is_fru_eeprom_supported(adev))
return 0;
I assume the logic should be adjusted. It's better to put the asic_type check
after is_fru_eeprom_supported.
Regards,
Guchun
-Original
[Public]
How about set a define like PRODUCT_NAME_LEN to be 64, and use it in FRU code?
In this case, if it needs to bump string length of product name later on, it
will be simple.
#define PRODUCT_NAME_LEN 64
unsigned char buff[PRODUCT_NAME_LEN + 2];
Regards,
Guchun
-Original Message
strnstr(atom_ctx->vbios_version, "D163",
sizeof(atom_ctx->vbios_version)))
return true;
else
return false;
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf
[Public]
Acked-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Evan Quan
Sent: Tuesday, December 14, 2021 9:34 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Quan, Evan
; Limonciello, Mario
Subject: [PATCH] drm/amdgpu: correct the wrong ca
[Public]
Thank you, Mario.
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Limonciello, Mario
Sent: Tuesday, December 14, 2021 11:58 AM
To: amd-gfx@lists.freedesktop.org
Cc: Limonciello, Mario ; Chen, Guchun
Subject: [PATCH] drivers/amd/pm: smu13: use local
[AMD Public Use]
Hi Christian,
I will conduct one stress test for this tomorrow. Would you mind waiting for my
ack before submitting?
Regards,
Guchun
-Original Message-
From: Christian König
Sent: Monday, March 22, 2021 8:41 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun
[AMD Public Use]
Thanks for your patch, Silva. The issue has been fixed by " a5c6007e20e1
drm/amd/display: fix modprobe failure on vega series".
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Gustavo A.
R. Silva
Sent: Monday, March 22, 2021 8:51 PM
To: Lee Jones ; Wentl
holding on this patch before rooting cause it.
Regards,
Guchun
-Original Message-
From: Das, Nirmoy
Sent: Tuesday, March 23, 2021 5:09 PM
To: Chen, Guchun ; Christian König
; amd-gfx@lists.freedesktop.org
Cc: Das, Nirmoy
Subject: Re: [PATCH] drm/amdgpu: re-apply "use the new curs
, March 29, 2021 11:39 AM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Quan, Evan ; Long,
Gang ; Gui, Jack
Subject: [PATCH] drm/amd/amdgpu: set MP1 state to UNLOAD before reload its FW
for vega20
When resume from gpu reset, need set MP1 state to UNLOAD before reload SMU FW
Signed-off-by:
[AMD Public Use]
Reviewed-and-tested-by: Guchun Chen
guchun.c...@amd.com<mailto:guchun.c...@amd.com>
Regards,
Guchun
From: Lazar, Lijo
Sent: Monday, March 29, 2021 12:04 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Xu, Feifei ;
Chen, Guchun
Subject: [PATCH] drm/amdgpu:
[AMD Public Use]
amdgpu_irq_restore_msix should be one static function?
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Emily Deng
Sent: Tuesday, March 30, 2021 12:42 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deng, Emily
Subject: [PATCH 3/6] drm/amdgpu: Restore msix after
[AMD Public Use]
Inline comments after yours'.
Regards,
Guchun
-Original Message-
From: Koenig, Christian
Sent: Tuesday, March 30, 2021 6:40 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Zhang,
Hawking
Subject: Re: [PATCH 2/2] drm/amdgpu: fix compiler warning
Am 30.03.
30, 2021 6:39 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Koenig,
Christian ; Zhang, Hawking
Subject: Re: [PATCH 1/2] drm/amdgpu: fix NULL pointer dereference
Am 30.03.21 um 12:02 schrieb Guchun Chen:
> ttm->sg needs to be checked before accessing its child member.
>
>
[AMD Public Use]
Hi Peng Ju,
Patch 4 breaks the driver modprobe sequence for the ASICs with GFX IP v9.0. The
modification in WREG32_RLC will route to one different path for GFX v9. Please
check it.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Deng, Emily
Sent: Thursd
[AMD Public Use]
Hi Felix and Christian,
If the regression you are talking about is the NULL pointer problem when
running KFD tests, it should fixed by below patch in this series.
drm/amdgpu: fix NULL pointer dereference
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of C
[AMD Public Use]
Hi Peng Ju,
Before merging your patches, it's suggested to conduct a full test in BM mode
as well to avoid regression, as register access is changed.
Another problem is, it seems the subject of patch 2, 4 and 5 is the same. Can
you please modify it respectively a bit to be mor
[AMD Public Use]
* The ASPM function is not fully enabled and verified on
* Navi yet. Temporarily skip this until ASPM enabled.
*/
The comments needs to be adjusted as well?
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Kenneth Feng
Sent: Thursday, Apr
[AMD Public Use]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Shi, Leslie
Sent: Monday, May 10, 2021 5:56 PM
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
; Chen, Guchun
Subject: [PATCH] drm/amdgpu: avoid undefined return value
Fixes: a7c22df2fd07
[AMD Public Use]
The series look good to me.
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Gao, Likun
Sent: Tuesday, May 11, 2021 11:52 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Chen, Guchun
; Song, Asher ; Gao, Likun
Subject: [PATCH 1/2
[AMD Public Use]
3 nit-picks inline.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Lijo Lazar
Sent: Thursday, May 13, 2021 5:48 PM
To: amd-gfx@lists.freedesktop.org
Cc: Wang, Kevin(Yang) ; Feng, Kenneth
; Zhang, Hawking
Subject: [PATCH 2/3] drm/amd/pm: Fix showing inco
om: Koenig, Christian
Sent: Wednesday, December 15, 2021 7:00 PM
To: Shi, Leslie ; Grodzovsky, Andrey
; Pan, Xinhui ; Deucher,
Alexander ; amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun
Subject: Re: [PATCH] drm/amdgpu: add drm_dev_unplug() in GPU initialization
failure to prevent crash
Am 15.1
From: Shi, Leslie
Sent: Thursday, December 16, 2021 2:14 PM
To: Grodzovsky, Andrey ; Koenig, Christian
; Pan, Xinhui ; Deucher,
Alexander ; amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Shi, Leslie
Subject: [PATCH v2] drm/amdgpu: Call amdgpu_device_unmap_mmio() iff device is
unplugged to pr
1 - 100 of 587 matches
Mail list logo
