[Public] +/* + * Helper function to query RAS EEPROM address + * + * @adev: amdgpu_device pointer + * + * Return true if vbios supports ras rom address reporting
As you have documented the first argument of function amdgpu_atomfirmware_ras_rom_addr, the other one "uint8_t* i2c_address" should be documented as well. BTW, if this patch fixes https://gitlab.freedesktop.org/drm/amd/-/issues/1670? Regards, Guchun From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Clements, John Sent: Wednesday, August 4, 2021 5:14 PM To: Clements, John <john.cleme...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking <hawking.zh...@amd.com> Subject: RE: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS [AMD Official Use Only] Updated patch with reviewed changes From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org<mailto:amd-gfx-boun...@lists.freedesktop.org>> On Behalf Of Clements, John Sent: Wednesday, August 4, 2021 4:48 PM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Cc: Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>> Subject: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS [AMD Official Use Only] Submitting patch to get RAS EEPROM I2C address from VBIOS FW info table. Thank you, John Clements
<<attachment: winmail.dat>>