Re: [PATCH] drm/amd/display: Old sequence for HUBP blank

2021-02-17 Thread Aurabindo Pillai
On 2021-02-17 10:29 a.m., Rodrigo Siqueira wrote: On 02/17, Aurabindo Pillai wrote: On 2021-02-17 8:40 a.m., Rodrigo Siqueira wrote: Hi, Is this commit a direct revert from be7af780ef3cbb8fe1004db48dc66caf2da595cd ? If so, I recommend you to use the standard way to identify "r

Re: [PATCH 2/2] drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work

2021-02-26 Thread Aurabindo Pillai
(system_highpri_wq, &handler_data_add->work)) +    DRM_DEBUG("__func__: a work_struct is allocated and queued, " + "src %d\n", irq_source); +    else +    DRM_ERROR("__func__: a new work_struct cannot be queued, &qu

[PATCH] Revert freesync video patches temporarily

2021-03-06 Thread Aurabindo Pillai
d03ee581eee6 drm/amd/display: Add module parameter for freesync video mode Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 - .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 369

Re: [PATCH] Revert "Revert freesync video patches temporarily"

2021-03-16 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 2021-03-16 11:15 a.m., Nikola Cornij wrote: This reverts commit e9a777fc0c264542fbd6d51b8fe51739d09032c1 Sinc this is a "revert of a revert", the end effect is that freesync video is back to its original state, the way it was before the fi

[PATCH] drm/amd/amdkfd: Fix large framesize for kfd_smi_ev_read()

2020-05-20 Thread Aurabindo Pillai
The buffer allocated is of 1024 bytes. Allocate this from heap instead of stack. Also remove check for stack size since we're allocating from heap Signed-off-by: Aurabindo Pillai Tested-by: Amber Lin --- drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 26 +++-- 1 file ch

Re: [PATCH] drm/amd/amdkfd: Fix large framesize for kfd_smi_ev_read()

2020-05-21 Thread Aurabindo Pillai
On 05/20, Felix Kuehling wrote: > Am 2020-05-20 um 9:53 a.m. schrieb Aurabindo Pillai: > > The buffer allocated is of 1024 bytes. Allocate this from > > heap instead of stack. > > > > Also remove check for stack size since we're allocating from heap > &g

[PATCH 01/16] drm/amd/display: DSC Slice height debugfs write entry

2020-07-30 Thread Aurabindo Pillai
cided to be enabled on that connector. Signed-off-by: Eryk Brol Signed-off-by: Mikita Lipski Reviewed-by: Mikita Lipski Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + .../amd/display/amdg

[PATCH 04/16] drm/amd/display: Read VBIOS Golden Settings Tbl

2020-07-30 Thread Aurabindo Pillai
From: Igor Kravchenko [Why] For ver.4.4 and higher VBIOS contains default setting table. {How] Read Golden Settings Table from VBIOS, apply Aux tuning parameters. Signed-off-by: Igor Kravchenko Reviewed-by: Aric Cyr Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/bios

[PATCH 03/16] drm/amd/display: Use parameter for call to set output mux

2020-07-30 Thread Aurabindo Pillai
From: Eric Bernstein Signed-off-by: Eric Bernstein Reviewed-by: Chris Park Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm

[PATCH 05/16] drm/amd/display: populate new dml variable

2020-07-30 Thread Aurabindo Pillai
From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml

[PATCH 00/16] DC Patches 2020 July 27

2020-07-30 Thread Aurabindo Pillai
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Display Core version 3.2.97 * New firmware release * DSC improvements * Bug fixes across DML, pipe managment * Regression fixes for DP -- Alvin Lee (1): drm/amd/display: Separate pipe disconnect from rest of p

[PATCH 02/16] drm/amd/display: Update virtual stream encoder

2020-07-30 Thread Aurabindo Pillai
From: Eric Bernstein Signed-off-by: Eric Bernstein Reviewed-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai --- .../amd/display/dc/virtual/virtual_stream_encoder.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/virtual

[PATCH 07/16] drm/amd/display: Fix logger context

2020-07-30 Thread Aurabindo Pillai
From: Harry Wentland [Why&How] use correct logger context Signed-off-by: Harry Wentland Reviewed-by: Roman Li Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/inc/hw/clk_mgr_internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 06/16] drm/amd/display: DSC Bit target rate debugfs write entry

2020-07-30 Thread Aurabindo Pillai
decided to be enabled on that connector. Signed-off-by: Eryk Brol Signed-off-by: Mikita Lipski Reviewed-by: Mikita Lipski Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + .../amd/display/amdgpu_dm

[PATCH 11/16] drm/amd/display: Change null plane state swizzle mode to 4kb_s

2020-07-30 Thread Aurabindo Pillai
] Change the default swizzle mode from linear to 4kb_s and update pitch accordingly. Signed-off-by: George Shen Reviewed-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 13/16] drm/amd/display: Add debugfs for forcing stream timing sync

2020-07-30 Thread Aurabindo Pillai
rent synchornization state and grouping. Example usage to force a resync (from an X based desktop): echo 1 > /sys/kernel/debug/dri/0/amdgpu_dm_force_timing_sync xset dpms force off && xset dpms force on Signed-off-by: Victor Lu Reviewed-by: Aurabindo Jayamohanan Pillai Acked-by: Aurabi

[PATCH 08/16] drm/amd/display: Comments on how to use DSC debugfs some entries

2020-07-30 Thread Aurabindo Pillai
From: Eryk Brol [why] Some of the DSC debugfs read enteries are missing comments explaining how to use and how to comprehend the results. Signed-off-by: Eryk Brol Signed-off-by: Mikita Lipski Reviewed-by: Mikita Lipski Acked-by: Aurabindo Pillai --- .../amd/display/amdgpu_dm

[PATCH 12/16] drm/amd/display: Display goes blank after inst

2020-07-30 Thread Aurabindo Pillai
sum of base dce_info offset and golden table offset Signed-off-by: Igor Kravchenko Reviewed-by: Aric Cyr Acked-by: Aurabindo Pillai --- .../drm/amd/display/dc/bios/bios_parser2.c| 4 +- .../display/dc/dcn30/dcn30_dio_link_encoder.c | 53 ++- .../display/dc/dcn30

[PATCH 15/16] drm/amd/display: [FW Promotion] Release 0.0.27

2020-07-30 Thread Aurabindo Pillai
From: Anthony Koo | [Header Changes] | - Reworked the FW versioning to include hotfix | and test bits Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 15 --- 1 file changed, 12

[PATCH 14/16] drm/amd/display: Separate pipe disconnect from rest of progrmaming

2020-07-30 Thread Aurabindo Pillai
ent this. [How] Move MPCC disconnect into separate operation than the rest of the pipe programming. Signed-off-by: Alvin Lee Reviewed-by: Jun Lei Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 10 ++ .../drm/amd/display/dc/dcn20/dcn20_hwseq.c

[PATCH 10/16] drm/amd/display: Use helper function to check for HDMI signal

2020-07-30 Thread Aurabindo Pillai
From: "JinZe.Xu" [How] Use dc_is_hdmi_signal to determine signal type. Signed-off-by: JinZe.Xu Reviewed-by: Charlene Liu Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

[PATCH 09/16] drm/amd/display: AMD OUI (DPCD 0x00300) skipped on some sink

2020-07-30 Thread Aurabindo Pillai
From: Aric Cyr [Why] Sink OUI supported cap is not set so driver skips programming it. [How] Revert the change the skips OUI programming if the cap is not set Signed-off-by: Aric Cyr Reviewed-by: Anthony Koo Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

[PATCH 16/16] drm/amd/display: 3.2.97

2020-07-30 Thread Aurabindo Pillai
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index ae0e27c67ef9

[PATCH 05/33] drm/amd/display: Reverting "Add connector to the state if DSC debugfs is set"

2020-10-21 Thread Aurabindo Pillai
From: Eryk Brol This reverts commit 39edb76689b8c9e41b1b9e2557da4897a405221b. Reason for revert: Patch introduces performance issues and might cause memory consistency problems with multiple connectors. Signed-off-by: Eryk Brol Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display

[PATCH 02/33] drm/amd/display: add dcn21 bw validation

2020-10-21 Thread Aurabindo Pillai
From: Dmytro Laktyushkin [Why&How] Create a separate dcn21_fast_validate_bw function for dcn21. Signed-off-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai --- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +- .../drm/amd/display/dc/dcn20/dcn20_resource.h | 3 + .../drm/amd/dis

[PATCH 00/33] DC Patches - 29 October 2020

2020-10-21 Thread Aurabindo Pillai
This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC version 3.2.108 * Firmware release 0.0.38 * Tracing additions * Improvements & fixes across ODM, DSC, watermarks and others. -- Alvin Lee (2): drm/amd/display: Set WM set A to 0 if full pstate not supporte

[PATCH 10/33] drm/amd/display: Add an option to limit max DSC target bpp per sink

2020-10-21 Thread Aurabindo Pillai
From: Nikola Cornij [Why] Can be used for debug purposes [How] Add max target bpp override field and related handling Signed-off-by: Nikola Cornij Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4

[PATCH 23/33] drm/amd/display: [FW Promotion] Release 0.0.38

2020-10-21 Thread Aurabindo Pillai
events Signed-off-by: Anthony Koo Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 04/33] drm/amd/display: Source minimum HBlank support

2020-10-21 Thread Aurabindo Pillai
From: Ashley Thomas [Why] Some sink devices wish to have access to the minimum HBlank supported by the ASIC. [How] Make the ASIC minimum HBlank available in Source Device information address 0x340. Signed-off-by: Ashley Thomas Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/core

[PATCH 13/33] drm/amd/display: adding reading OEM init_data to dcn3

2020-10-21 Thread Aurabindo Pillai
From: Martin Leung why: missing OEM data to control graphics card functions how: load it into init_data. copied over from dcn2 implementation. copied destruction sequence as well. Signed-off-by: Martin Leung Acked-by: Aurabindo Pillai --- .../drm/amd/display/dc/dcn30/dcn30_resource.c

[PATCH 20/33] drm/amd/display: Don't trigger flip twice when ODM combine in use

2020-10-21 Thread Aurabindo Pillai
From: Aric Cyr [Why] When ODM combine is in use we trigger multiple update events causing issues with variable refresh rate. [How] Only trigger on a single ODM instance. Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 5 ++--- 1 file changed

[PATCH 09/33] drm/amd/display: [FW Promotion] Release 0.0.37

2020-10-21 Thread Aurabindo Pillai
From: Anthony Koo | [Header Changes] |- Add GPINT to change timestamping mode for traces Signed-off-by: Anthony Koo Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 22/33] drm/amd/display: adding ddc_gpio_vga_reg_list to ddc reg def'ns

2020-10-21 Thread Aurabindo Pillai
From: Martin Leung why: oem-related ddc read/write fails without these regs how: copy from hw_factory_dcn20.c Signed-off-by: Martin Leung Acked-by: Aurabindo Pillai --- .../drm/amd/display/dc/gpio/dcn30/hw_factory_dcn30.c | 12 1 file changed, 12 insertions(+) diff --git a

[PATCH 08/33] drm/amd/display: Define PSR ERROR Status bit VSC_SDP

2020-10-21 Thread Aurabindo Pillai
From: Reza Amini [why] So we can track VSC SDP errors from display [how] Define the bit, and use it in driver logic Signed-off-by: Reza Amini Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/inc/hw/link_encoder.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 16/33] drm/amd/display: Revert check for flip pending before locking pipes

2020-10-21 Thread Aurabindo Pillai
From: Isabel Zhang [Why] Causes underflow regression [How] This reverts commit f61b3a065f129a90ca83bb214a507b29b9c15ba7 Signed-off-by: Isabel Zhang Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 11 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 156

[PATCH 17/33] drm/amd/display: Reduce height of visual confirm on right side.

2020-10-21 Thread Aurabindo Pillai
From: Yongqiang Sun [Why] right side visual confirm is too thick due to it is 4 times of left side (16 lines). [How] Change factor from 4 to 2. Signed-off-by: Yongqiang Sun Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 2 +- 1 file changed, 1

[PATCH 25/33] drm/amd/display: Decouple amdgpu_dm_trace from service

2020-10-21 Thread Aurabindo Pillai
errors when we try to reuse some of the existing structures. This commit decouples part of the amdgpu_dm_trace from DC core to simplify the trace enlargement in future changes. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 39

[PATCH 24/33] drm/amd/display: 3.2.108

2020-10-21 Thread Aurabindo Pillai
From: Aric Cyr Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index daa2589464fe..7622cd222d66 100644

[PATCH 19/33] drm/amd/display: Update GSL state if leaving immediate flip

2020-10-21 Thread Aurabindo Pillai
From: Alvin Lee [Why] We should leave GSL if we're not doing immediate flip no matter if we're doing pipe split or not [How] Check for updating GSL state whenever we're not doing immediate flip Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/displ

[PATCH 18/33] drm/amd/display: disable seamless boot for VSC_SDP

2020-10-21 Thread Aurabindo Pillai
From: Yu-Ting Shen [WHY] VBIOS will not enable VSC_SDP during pre-OS to lead MISC1[6] wasn't matched with driver. [HOW] disabled seamless boot if sink supports VSC_SDP Signed-off-by: Yu-Ting Shen Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 1

[PATCH 01/33] drm/amd/display: Add Bounding Box State for Low DF PState but High Voltage State

2020-10-21 Thread Aurabindo Pillai
is high. Watermarks vlevel calculation logic was also udpated to assume state 1 contains the new optimized state. Signed-off-by: Sung Lee Acked-by: Aurabindo Pillai --- .../drm/amd/display/dc/dcn21/dcn21_resource.c | 71 ++- 1 file changed, 53 insertions(+), 18 deletions(-) diff

[PATCH 11/33] drm/amd/display: 3.2.107

2020-10-21 Thread Aurabindo Pillai
From: Aric Cyr Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 3f888570ffad..daa2589464fe 100644

[PATCH 07/33] drm/amd/display: Raise DPG height during timing synchronization

2020-10-21 Thread Aurabindo Pillai
From: Taimur Hassan [Why] Underflow counter increases in AGM when performing some mode switches due to timing sync, which is a known hardware issue. [How] Temporarily raise DPG height during timing sync so that underflow is not reported. Signed-off-by: Taimur Hassan Acked-by: Aurabindo Pillai

[PATCH 14/33] drm/amd/display: Refactor ABM_MASK_SH_LIST_DCN301 naming

2020-10-21 Thread Aurabindo Pillai
: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 4 ++-- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h b/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h

[PATCH 15/33] drm/amd/display: skip avmute action

2020-10-21 Thread Aurabindo Pillai
From: Brandon Syu [Why] For some monitors, they can't display under BIOS with avmute enabled. [How] Add monitor patch for skip avmute action. Signed-off-by: Brandon Syu Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 5 +++-- drivers/gpu/drm/amd/displ

[PATCH 32/33] drm/amd/display: Using udelay for specific dongle while edid return defer

2020-10-21 Thread Aurabindo Pillai
From: jinlong zhang [why] Some platform has a limitation of 2ms for udelay [how] Add 1ms udelay for specific dongle. Signed-off-by: jinlong zhang Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 7 +++ drivers/gpu/drm/amd/display/dc/dce/dce_aux.c

[PATCH 12/33] drm/amd/display: DCN2.1 Disable 48MHz Powerdown Debug Option

2020-10-21 Thread Aurabindo Pillai
From: Sung Lee [WHY & HOW] Currently disable 48mhz debug option only disables on boot. Need to put option check in update_clocks as well to make it affect more areas. Signed-off-by: Sung Lee Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 +

[PATCH 26/33] drm/amd/display: Rework registers tracepoint

2020-10-21 Thread Aurabindo Pillai
From: Rodrigo Siqueira amdgpu_dc_rreg and amdgpu_dc_wreg are very similar, for this reason, this commits abstract these two events by using DECLARE_EVENT_CLASS and create an instance of it for each one of these events. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai --- .../amd

[PATCH 30/33] drm/amd/display: prevent null pointer access

2020-10-21 Thread Aurabindo Pillai
From: Dmytro Laktyushkin Prevent null pointer access when checking odm tree. Signed-off-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai Cc: --- .../gpu/drm/amd/display/dc/dcn30/dcn30_resource.c| 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu

[PATCH 21/33] drm/amd/display: Fix max brightness pixel accuracy

2020-10-21 Thread Aurabindo Pillai
f 1.0. Signed-off-by: Felipe Clark Acked-by: Aurabindo Pillai --- .../amd/display/modules/color/color_gamma.c | 110 ++ 1 file changed, 89 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/

[PATCH 06/33] drm/amd/display: Set WM set A to 0 if full pstate not supported

2020-10-21 Thread Aurabindo Pillai
From: Alvin Lee [Why] If full pstate is not supported, we should set WM set A to 0 to prevent any hangs [How] If pstate is not supported, set watermark set A to 0 Signed-off-by: Alvin Lee Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- 1 file

[PATCH 28/33] drm/amd/display: Add pipe_state tracepoint

2020-10-21 Thread Aurabindo Pillai
, however, it can be added to other DCN architecture. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai --- .../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 108 ++ drivers/gpu/drm/amd/display/dc/core/dc.c | 4 + drivers/gpu/drm/amd/display/dc/dc_trace.h | 33

[PATCH 29/33] drm/amd/display: Add tracepoint for capturing clocks state

2020-10-21 Thread Aurabindo Pillai
From: Rodrigo Siqueira The clock state update is the source of many problems, and capturing this sort of information helps debug. This commit introduces tracepoints for capturing clock values and also add traces in DCE, DCN1, DCN2x, and DCN3. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo

[PATCH 27/33] drm/amd/display: Add tracepoint for amdgpu_dm

2020-10-21 Thread Aurabindo Pillai
From: Rodrigo Siqueira Debug amdgpu_dm could be a complicated task, therefore, this commit adds tracepoints in some convenient functions such as plane and connector check inside amdgpu_dm. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm

[PATCH 03/33] drm/amd/display: enable odm + full screen mpo on dcn21

2020-10-21 Thread Aurabindo Pillai
From: Dmytro Laktyushkin [WHY & HOW] Enable ODM Combine + Fullscreen MPO on DCN2.1 For lower power consumption in video use cases. Signed-off-by: Dmytro Laktyushkin Signed-off-by: Sung Lee Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 8 ++ .../drm

[PATCH 31/33] drm/amd/display: Removed unreferenced variables.

2020-10-21 Thread Aurabindo Pillai
From: George Shen Signed-off-by: George Shen Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_sink.c | 1 - drivers/gpu/drm/amd/display/dc/dc.h | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_sink.c

[PATCH 33/33] drm/amd/display: combined user regamma and OS GAMMA_CS_TFM_1D

2020-10-21 Thread Aurabindo Pillai
From: Derek Lai [Why] For user regamma we're missing this function call to combine user regamma + OS for GAMMA_CS_TFM_1D type. [How] Applied 1D LUT in the mod_color_build_user_regamma. And Set the regamma dirty as updateGamma. Signed-off-by: Derek Lai Acked-by: Aurabindo Pillai --- ..

[PATCH] drm/amd/display: Fixed panic during seamless boot.

2020-10-23 Thread Aurabindo Pillai
From: David Galiffi [why] get_pixel_clk_frequency_100hz is undefined in clock_source_funcs. [how] set function pointer: ".get_pixel_clk_frequency_100hz = get_pixel_clk_frequency_100hz" Signed-off-by: David Galiffi --- drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 3 ++- 1 file chan

Re: [PATCH] drm/amd/display: Fixed panic during seamless boot.

2020-10-23 Thread Aurabindo Pillai
> [AMD Official Use Only - Internal Distribution Only] > > > > > > > > Reviewed-by: Bhawanpreet Lakha Thanks for the review. > > > > > From: Aurabindo Pillai > > Sent: October 23, 2020 1:09 PM > > To: amd-gfx@lists.freedes

Re: [PATCH] drm/amd/display: Add DPCS regs for dcn302 link encoder

2020-11-19 Thread Aurabindo Pillai
Reviewed-by: Aurabindo Pillai On 2020-11-18 2:19 p.m., Bhawanpreet Lakha wrote: > dpcs reg are missing for dcn302 link encoder regs list, so add them. > Just like dcn3 > > Signed-off-by: Bhawanpreet Lakha > --- > drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 1 +

[PATCH] drm/amd/display: Clear dc remote sinks on MST disconnect

2020-11-26 Thread Aurabindo Pillai
[Why&How] Recent changes to upstream mst code remove the callback which cleared the internal state for mst. Move the missing functionality that was previously called through the destroy call back for mst connector destroy Signed-off-by: Aurabindo Pillai Signed-off-by: Eryk Brol --- ...

Re: [PATCH] drm/amd/display: Clear dc remote sinks on MST disconnect

2020-11-26 Thread Aurabindo Pillai
On 2020-11-26 9:35 a.m., Kazlauskas, Nicholas wrote: > On 2020-11-26 9:31 a.m., Aurabindo Pillai wrote: >> [Why&How] >> Recent changes to upstream mst code remove the callback which >> cleared the internal state for mst. Move the missing functionality >> that wa

[PATCH] drm/amd/display: turn DPMS off on mst connector unplug

2020-11-26 Thread Aurabindo Pillai
[Why&How] Set dpms off on the MST connector that was unplugged, for the side effect of releasing some references held through deallocation of mst payload. Signed-off-by: Aurabindo Pillai Signed-off-by: Eryk Brol --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 63 ++

[PATCH v2] drm/amd/display: turn DPMS off on mst connector unplug

2020-11-26 Thread Aurabindo Pillai
[Why&How] Set dpms off on the MST connector that was unplugged, for the side effect of releasing some references held through deallocation of mst payload. Signed-off-by: Aurabindo Pillai Signed-off-by: Eryk Brol --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Re: [PATCH] drm/amd/display: turn DPMS off on mst connector unplug

2020-11-26 Thread Aurabindo Pillai
On 2020-11-26 3:11 p.m., Kazlauskas, Nicholas wrote: > On 2020-11-26 2:50 p.m., Aurabindo Pillai wrote: >> [Why&How] >> >> Set dpms off on the MST connector that was unplugged, for the side >> effect of >> releasing some references held through deallocatio

[PATCH v3] drm/amd/display: turn DPMS off on mst connector unplug

2020-11-26 Thread Aurabindo Pillai
[Why&How] Set dpms off on the MST connector that was unplugged, for the side effect of releasing some references held through deallocation of mst payload. Signed-off-by: Aurabindo Pillai Signed-off-by: Eryk Brol --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 00/11] DC Patches Nov 30, 2020

2020-11-27 Thread Aurabindo Pillai
This DC patchset brings improvements in multiple areas. In summary, we have: * DC 3.2.114 * DMUB firmware 0.0.44 * Power optimizations * Bug fixes -- Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.44 Aric Cyr (1): drm/amd/display: DC Release 3.2.114 Aurabindo Pillai (1

[PATCH 01/11] drm/amd/display: Remove unused smu related function

2020-11-27 Thread Aurabindo Pillai
[Why&How] Function definition was removed in earlier commit titled "drm/amd/display: init soc bounding box for dcn3.01.". However declaration did not get removed. This fixes a compile warning. Fixes: fa7580010 ("drm/amd/display: init soc bounding box for dcn3.01.") Signed-

[PATCH 02/11] drm/amd/display: Revert update clk_mgr for vg

2020-11-27 Thread Aurabindo Pillai
From: Eric Bernstein This reverts commit 15033eeab3f1b6177d87ae353c3d9b554b1d4b53. It caused a regression in internal FPGA tests. Signed-off-by: Eric Bernstein Reviewed-by: Eric Yang Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c | 8 .../gpu

[PATCH 03/11] drm/amd/display: Add HDR3DLUT and SHAPER memory shutdown support

2020-11-27 Thread Aurabindo Pillai
ry to shutdown when SHAPER is not used. Signed-off-by: Jacky Liao Reviewed-by: Eric Yang Acked-by: Yongqiang Sun Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c | 38 +++ .../gpu/drm/amd/display/dc/dcn30/dcn30_dpp.h | 14 ++- 2 files change

[PATCH 06/11] drm/amd/display: Init clock value by current vbios CLKs

2020-11-27 Thread Aurabindo Pillai
From: Brandon Syu [Why] While booting into OS, driver updates DPP/DISP CLKs. But init clock value is zero which is invalid. [How] Get current clocks value to update init clocks. To avoid underflow. Signed-off-by: Brandon Syu Reviewed-by: Tony Cheng Acked-by: Aurabindo Pillai --- .../drm

[PATCH 04/11] drm/amd/display: Update dram_clock_change_latency for DCN2.1

2020-11-27 Thread Aurabindo Pillai
with short vblanks such as on 1080p 360hz or 300hz panels. [HOW] Update latency from 23.84 to 11.72. Signed-off-by: Sung Lee Reviewed-by: Tony Cheng Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 05/11] drm/amd/display: Check link_active instead of lane_settings != unknown

2020-11-27 Thread Aurabindo Pillai
cleared, which blocks MST links from being re-enabled after a reinitialization. [How] - check for link_status->link_active instead, as it's the real intent - clear cur_link_settings when we clear link_active Signed-off-by: Joshua Aberback Reviewed-by: Wenjing Liu Acked-by: Aurabind

[PATCH 07/11] drm/amd/display: Add DSCL memory low power support

2020-11-27 Thread Aurabindo Pillai
d-off-by: Jacky Liao Reviewed-by: Eric Yang Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 1 + .../gpu/drm/amd/display/dc/dcn10/dcn10_dpp.h | 8 +++ .../drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 24 ++- .../gpu/drm/amd/display/dc/

[PATCH 09/11] drm/amd/display: Properly define DPCS related info for DCN301

2020-11-27 Thread Aurabindo Pillai
From: Zhan Liu [Why] DPCS related info needs to be properly defined within code. [How] Add missing DPCS related info to code. Signed-off-by: Zhan Liu Reviewed-by: Nikola Cornij Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 11 +-- 1 file

[PATCH 11/11] drm/amd/display: DC Release 3.2.114

2020-11-27 Thread Aurabindo Pillai
From: Aric Cyr Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 7400b0b449eb..54a829f95346 100644

[PATCH 08/11] drm/amd/display: Do full modeset when DSC debugfs is changed

2020-11-27 Thread Aurabindo Pillai
: Aurabindo Pillai --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e213246e3f04..f964cca5ad6e 100644 --- a/drivers/gpu/drm/amd

[PATCH 10/11] drm/amd/display: [FW Promotion] Release 0.0.44

2020-11-27 Thread Aurabindo Pillai
From: Anthony Koo Add feature caps to allow way for driver to query what features FW supports Signed-off-by: Anthony Koo Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 54 ++- 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a

[PATCH 1/3] drm/amd/display: Add module parameter for freesync video mode

2020-12-09 Thread Aurabindo Pillai
cted monitor's VRR range. Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 83a

[PATCH 0/3] Experimental freesync video mode optimization

2020-12-09 Thread Aurabindo Pillai
to the driver modelist, and also enables the optimization to skip modeset when using one of these modes. -- Aurabindo Pillai (3): drm/amd/display: Add module parameter for freesync video mode drm/amd/display: Add freesync video modes based on preferred modes drm/amd/display: Skip modeset for

[PATCH 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2020-12-09 Thread Aurabindo Pillai
the base freesync mode based off which timings have been generated for the rest of the freesync modes) since these modes only differ from the base mode with front porch timing. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 197 ++ 1 file cha

[PATCH 3/3] drm/amd/display: Skip modeset for front porch change

2020-12-09 Thread Aurabindo Pillai
same stream. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 169 -- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + 2 files changed, 153 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/dri

Re: [PATCH 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2020-12-10 Thread Aurabindo Pillai
Hi Shashank, Thanks for the review. Please see my inline responses. On Thu, 2020-12-10 at 18:07 +0530, Shashank Sharma wrote: > Hello Aurabindo, > > > On 10/12/20 8:15 am, Aurabindo Pillai wrote: > > > [Why&How] > > If experimental freesync video mode modul

Re: [PATCH 3/3] drm/amd/display: Skip modeset for front porch change

2020-12-10 Thread Aurabindo Pillai
On Thu, 2020-12-10 at 18:29 +0530, Shashank Sharma wrote: > On 10/12/20 8:15 am, Aurabindo Pillai wrote: > > [Why&How] > > Inorder to enable freesync video mode, driver adds extra > > modes based on preferred modes for common freesync frame rates. > > When commi

[PATCH v2 0/3] Experimental freesync video mode optimization

2020-12-10 Thread Aurabindo Pillai
a module parameter which is disabled by default. Enabling this paramters adds additional modes to the driver modelist, and also enables the optimization to skip modeset when using one of these modes. -- Aurabindo Pillai (3): drm/amd/display: Add module parameter for freesync video mode drm

[PATCH v2 1/3] drm/amd/display: Add module parameter for freesync video mode

2020-12-10 Thread Aurabindo Pillai
cted monitor's VRR range. Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 83a

[PATCH v2 3/3] drm/amd/display: Skip modeset for front porch change

2020-12-10 Thread Aurabindo Pillai
same stream. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 163 -- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + 2 files changed, 149 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/dri

[PATCH v2 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2020-12-10 Thread Aurabindo Pillai
the base freesync mode based off which timings have been generated for the rest of the freesync modes) since these modes only differ from the base mode with front porch timing. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 167 ++ 1 file cha

[PATCH v3 0/3] Experimental freesync video mode optimization

2020-12-14 Thread Aurabindo Pillai
guarded by a module parameter which is disabled by default. Enabling this paramters adds additional modes to the driver modelist, and also enables the optimization to skip modeset when using one of these modes. -- Aurabindo Pillai (3): drm/amd/display: Add module parameter for freesync video mode

[PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode

2020-12-14 Thread Aurabindo Pillai
cted monitor's VRR range. Signed-off-by: Aurabindo Pillai Acked-by: Christian König Reviewed-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v3 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2020-12-14 Thread Aurabindo Pillai
the base freesync mode based off which timings have been generated for the rest of the freesync modes) since these modes only differ from the base mode with front porch timing. Signed-off-by: Aurabindo Pillai Acked-by: Christian König --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_d

[PATCH v3 3/3] drm/amd/display: Skip modeset for front porch change

2020-12-14 Thread Aurabindo Pillai
same stream. Signed-off-by: Aurabindo Pillai Acked-by: Christian König --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 210 +++--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + 2 files changed, 179 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/dis

Re: [PATCH v3 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2020-12-15 Thread Aurabindo Pillai
On Tue, 2020-12-15 at 08:32 +0530, Shashank Sharma wrote: > > On 15/12/20 3:50 am, Aurabindo Pillai wrote: > > [Why&How] > > If experimental freesync video mode module parameter is enabled, > > add > > few extra display modes into the driver's mode list corr

Re: [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode

2020-12-17 Thread Aurabindo Pillai
On Thu, Dec 17, 2020 at 14:11, Alex Deucher wrote: On Mon, Dec 14, 2020 at 5:21 PM Aurabindo Pillai wrote: [Why&How] Adds a module parameter to enable experimental freesync video mode modeset optimization. Enabling this mode allows the driver to skip a full modeset when free

Re: [PATCH 3/3] drm/amd/display: Skip modeset for front porch change

2021-01-04 Thread Aurabindo Pillai
On Mon, 2021-01-04 at 11:16 -0500, Kazlauskas, Nicholas wrote: > On 2020-12-09 9:45 p.m., Aurabindo Pillai wrote: > > [Why&How] > > Inorder to enable freesync video mode, driver adds extra > > modes based on preferred modes for common freesync frame rates. > > When

Re: [PATCH v2 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2021-01-04 Thread Aurabindo Pillai
On Mon, 2021-01-04 at 11:06 -0500, Kazlauskas, Nicholas wrote: > On 2020-12-11 12:54 a.m., Shashank Sharma wrote: > > > > On 11/12/20 12:18 am, Aurabindo Pillai wrote: > > > [Why&How] > > > If experimental freesync video mode module parameter is enabled, &g

[PATCH v3 0/3] Experimental freesync video mode optimization

2021-01-04 Thread Aurabindo Pillai
to this mode does not trigger blanking. This feature is guarded by a module parameter which is disabled by default. Enabling this paramters adds additional modes to the driver modelist, and also enables the optimization to skip modeset when using one of these modes. -- Aurabindo Pillai (3): drm

[PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode

2021-01-04 Thread Aurabindo Pillai
cted monitor's VRR range. Signed-off-by: Aurabindo Pillai Acked-by: Christian König Reviewed-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v3 3/3] drm/amd/display: Skip modeset for front porch change

2021-01-04 Thread Aurabindo Pillai
same stream. Signed-off-by: Aurabindo Pillai Acked-by: Christian König --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 219 +++--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + 2 files changed, 188 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/dis

[PATCH v3 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2021-01-04 Thread Aurabindo Pillai
the base freesync mode based off which timings have been generated for the rest of the freesync modes) since these modes only differ from the base mode with front porch timing. Signed-off-by: Aurabindo Pillai Acked-by: Christian König Reviewed-by: Shashank Sharma --- .../gpu/drm/amd/display/

<    1   2   3   4   5   6   7   >