Re: [PATCH] add mes type in mes ring dump.

2025-03-14 Thread StDenis, Tom
[AMD Official Use Only - AMD Internal Distribution Only] Thanks this was pushed out to main just now. Cheers, Tom From: Zhang, Yifan Sent: Wednesday, March 12, 2025 21:40 To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom; Zhang, Yifan Subject: [PATCH] a

[PATCH v1 2/3] drm/ci: uprev IGT

2025-03-14 Thread Vignesh Raman
Uprev IGT to the latest version and update expectation files. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 8 +- .../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 1 + drivers/gpu/drm/ci/xfails/i915-aml

[PATCH v1 1/3] drm/ci: uprev mesa

2025-03-14 Thread Vignesh Raman
LAVA was recently patched [1] with a fix on how parameters are parsed in `lava-test-case`, so we don't need to repeat quotes to send the arguments properly to it. Uprev mesa to fix this issue. [1] https://gitlab.com/lava/lava/-/commit/18c9cf79 Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci

[PATCH v1 0/3] drm/ci: uprev mesa, IGT

2025-03-14 Thread Vignesh Raman
Uprev mesa to fix lava-test-case argument parsing. LAVA recently fixed parameter parsing in `lava-test-case` [1], eliminating the need for repeated quotes in arguments. Uprev IGT to the latest version. Also update expectation files. The mediatek display driver fails to probe on mt8173-elm-hana an

Re: [PATCH 03/11] drm/amdgpu/gfx: add generic handling for disable_kq

2025-03-14 Thread Khatri, Sunil
Reviewed-by: Sunil Khatri On 3/13/2025 8:11 PM, Alex Deucher wrote: Add proper checks for disable_kq functionality in gfx helper functions. Add special logic for families that require the clear state setup. v2: use ring count as per Felix suggestion v3: fix num_gfx_rings handling in amdgpu_gf

[PATCH 2/3] drm/amdgpu: use specific ip_discovery.bin for legacy asics

2025-03-14 Thread Flora Cui
vega10/vega12/vega20/raven/raven2/picasso/arcturus/aldebaran Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 28 ++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amd

Re: [PATCH] drm/amdgpu/gfx12: correct cleanup of 'me' field with gfx_v12_0_me_fini()

2025-03-14 Thread Markus Elfring
… > can only release 'pfp' field of 'gfx'. The release function of 'me' field > should be gfx_v12_0_me_fini(). Do you care for an imperative wording in such a change description? https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rs

[PATCH RFC v4 0/6] drm/display: dp: add new DPCD access functions

2025-03-14 Thread Dmitry Baryshkov
Existing DPCD access functions return an error code or the number of bytes being read / write in case of partial access. However a lot of drivers either (incorrectly) ignore partial access or mishandle error codes. In other cases this results in a boilerplate code which compares returned value with

[PATCH RFC v4 4/6] drm/display: dp-cec: use new DCPD access helpers

2025-03-14 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_cec.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_cec.c | 37 ++-- 1 file changed, 18 insertions(+), 19 delet

[PATCH RFC v4 1/6] drm/display: dp: implement new access helpers

2025-03-14 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Existing DPCD access functions return an error code or the number of bytes being read / write in case of partial access. However a lot of drivers either (incorrectly) ignore partial access or mishandle error codes. In other cases this results in a boilerplate code which com

[PATCH RFC v4 2/6] drm/display: dp: change drm_dp_dpcd_read_link_status() return value

2025-03-14 Thread Dmitry Baryshkov
From: Dmitry Baryshkov drm_dp_dpcd_read_link_status() follows the "return error code or number of bytes read" protocol, with the code returning less bytes than requested in case of some errors. However most of the drivers interpreted that as "return error code in case of any error". Switch drm_dp

[PATCH RFC v4 5/6] drm/display: dp-mst-topology: use new DCPD access helpers

2025-03-14 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_mst_topology.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 +- 1 file changed, 51 insertions(+),

[PATCH] drm/amdgpu: Higher log level for missing PCIe atomics caps

2025-03-14 Thread Daisuke Matsuda
Currently, ROCm requires CPUs that support PCIe atomics. The message is more urgent for GPGPU users, meaning basic functionalities of ROCm are not available on the node. Signed-off-by: Daisuke Matsuda --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgv_srio

[PATCH v1 3/3] drm/ci: arm64.config: mediatek: enable PHY drivers

2025-03-14 Thread Vignesh Raman
The mediatek display driver fails to probe on mt8173-elm-hana and mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY configurations. Enable the following PHY drivers for MediaTek platforms: - CONFIG_PHY_MTK_HDMI=y for HDMI display - CONFIG_PHY_MTK_MIPI_DSI=y for DSI display Signed

[PATCH] drm/amdgpu: Add EEPROM I2C address support for smu v13_0_12

2025-03-14 Thread Candice Li
Add EEPROM I2C address support for smu v13_0_12. Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c index 3597ecd9baca3

RE: [PATCH V2 1/2] drm/amdgpu/gfx: fix ref counting for ring based profile handling

2025-03-14 Thread Feng, Kenneth
[AMD Official Use Only - AMD Internal Distribution Only] Test-by: Kenneth Feng Series is Reviewed-by: Kenneth Feng -Original Message- From: Deucher, Alexander Sent: Wednesday, March 12, 2025 10:19 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Wang, Yang(Kevin) ; Feng,

RE: [PATCH] drm/amdgpu: Add EEPROM I2C address support for smu v13_0_12

2025-03-14 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Candice Li Sent: Friday, March 14, 2025 15:33 To: amd-gfx@lists.freedesktop.org Cc: Li, Candice Subject: [PATCH] drm/amdgpu: Add EEPROM I2C

[PATCH] drm/amdgpu: Add active_umc_mask to ras init_flags

2025-03-14 Thread Candice Li
Add active_umc_mask to ras init_flags. Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/ta_ras_if.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c ind

Re: [PATCH 4/8] drm/amdgpu: rework how isolation is enforced v2

2025-03-14 Thread Christian König
Hi Siqueira, as discussed on the call if you can wrap your head around how the amdgpu_device_enforce_isolation() function works it should be trivial to write a new function or extend the function to insert a CPU bubble whenever the ownership of one of the compute rings change. IIRC we already

RE: [PATCH] drm/amdgpu: Add active_umc_mask to ras init_flags

2025-03-14 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Candice Li Sent: Friday, March 14, 2025 15:33 To: amd-gfx@lists.freedesktop.org Cc: Li, Candice Subject: [PATCH] drm/amdgpu: Add active_umc

RE: [PATCH 1/7] drm/amd/amdgpu: Simplify SDMA reset mechanism by removing dynamic callbacks

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: Alex Deucher > Sent: Thursday, March 13, 2025 10:38 AM > To: Zhang, Jesse(Jie) > Cc: Koenig, Christian ; amd- > g...@lists.freedesktop.org; Deucher, Alexander ; > Kim, Jonathan ; Zhu, Jiadong > > Subject: Re: [PATCH 1/7] drm/amd/amdgpu: Simplify SDM

[PATCH RFC v4 3/6] drm/display: dp: use new DCPD access helpers

2025-03-14 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_helper.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_helper.c | 296 +--- 1 file changed, 116 insertions(+), 180

RE: [PATCH 2/3] drm/amdgpu: adjust drm_firmware_drivers_only() handling

2025-03-14 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, March 13, 2025 9:02 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 2/3] drm/amdgpu:

Re: [PATCH 1/2] drm/amdgpu/gfx: adjust workload profile handling

2025-03-14 Thread Lazar, Lijo
On 3/14/2025 7:17 PM, Alex Deucher wrote: > No need to make the workload profile setup dependent > on the results of cancelling the delayed work thread. > We have all of the necessary checking in place for the > workload profile reference counting, so separate the > two. As it is now, we can th

[PATCH 3/3] drm/amdgpu/discovery: optionally use fw based ip discovery

2025-03-14 Thread Flora Cui
From: Alex Deucher On chips without native IP discovery support, use the fw binary if available, otherwise we can continue without it. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 38 +++ 1 file changed, 30 insertions(+), 8 deletions(-) diff

RE: [PATCH 3/3] drm/amdgpu: don't free conflicting apertures for non-display devices

2025-03-14 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, March 13, 2025 9:02 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 3/3] drm/amdgpu:

Re: [PATCH 1/2] drm/amdgpu/gfx: adjust workload profile handling

2025-03-14 Thread Alex Deucher
On Fri, Mar 14, 2025 at 10:53 AM Lazar, Lijo wrote: > > > > On 3/14/2025 7:17 PM, Alex Deucher wrote: > > No need to make the workload profile setup dependent > > on the results of cancelling the delayed work thread. > > We have all of the necessary checking in place for the > > workload profile r

Re: [PATCH 3/3] drm/amdgpu/discovery: optionally use fw based ip discovery

2025-03-14 Thread Lazar, Lijo
On 3/14/2025 3:24 PM, Flora Cui wrote: > From: Alex Deucher > > On chips without native IP discovery support, use the fw binary > if available, otherwise we can continue without it. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 38 +++---

Re: [PATCH v2 4/9] drm/amdkfd: Validate user queue buffers

2025-03-14 Thread Dieter Faulbaum
Hello Philip, Philip Yang writes: On 2025-02-12 17:42, Uwe Kleine-König wrote: #regzbot introduced: 68e599db7a549f010a329515f3508d8a8c3467a4 #regzbot monitor: https://bugs.debian.org/1093124 Hello, On Thu, Jul 18, 2024 at 05:05:53PM -0400, Philip Yang wrote: Find user queue rptr, ring

Re: [PATCH] drm/amdgpu/pm: Handle SCLK offset correctly in overdrive for smu 14.0.2

2025-03-14 Thread Alex Deucher
Applied. Thanks! On Wed, Mar 12, 2025 at 11:28 PM Wang, Yang(Kevin) wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > It looks good to me. > > Reviewed-by: Yang Wang > > Best Regards, > Kevin > > -Original Message- > From: amd-gfx On Behalf Of Tomasz > Pakula > S

Re: [PATCH 3/8] drm/amdgpu: overwrite signaled fence in amdgpu_sync

2025-03-14 Thread Christian König
Am 12.03.25 um 16:06 schrieb SRINIVASAN SHANMUGAM: > > On 3/7/2025 7:18 PM, Christian König wrote: >> This allows using amdgpu_sync even without peeking into the fences for a >> long time. >> >> Signed-off-by: Christian König >> --- >>   drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 13 +

Re: [PATCH 6/8] drm/amdgpu: stop reserving VMIDs to enforce isolation

2025-03-14 Thread Christian König
Am 12.03.25 um 16:10 schrieb SRINIVASAN SHANMUGAM: > On 3/7/2025 7:18 PM, Christian König wrote: >> That was quite troublesome for gang submit. Completely drop this >> approach and enforce the isolation separately. >> >> Signed-off-by: Christian König >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_c

Re: [PATCH 07/11] drm/amdgpu/gfx11: add support for disable_kq

2025-03-14 Thread Khatri, Sunil
Reviewed-by: Sunil Khatri On 3/13/2025 8:11 PM, Alex Deucher wrote: Plumb in support for disabling kernel queues in GFX11. We have to bring up a GFX queue briefly in order to initialize the clear state. After that we can disable it. v2: use ring counts per Felix' suggestion v3: fix stream fa

[PATCH] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Harish Kasiviswanathan
.config_dequeue_wait_counts returns a nop case. Modify return parameter to reflect that since the caller also needs to ignore this condition. Fixes: <98a5af8103f> ("drm/amdkfd: Add pm_config_dequeue_wait_counts API") Signed-off-by: Harish Kasiviswanathan --- drivers/gpu/drm/amd/amdkfd/kfd_packe

[PATCH 1/3] drm/amdgpu: check ip_discovery fw file available

2025-03-14 Thread Flora Cui
Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 31 ++- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index 967a992829bd..2b4854e03821 1006

[PATCH 1/2] drm/amdgpu/gfx: adjust workload profile handling

2025-03-14 Thread Alex Deucher
No need to make the workload profile setup dependent on the results of cancelling the delayed work thread. We have all of the necessary checking in place for the workload profile reference counting, so separate the two. As it is now, we can theoretically end up with the call from begin_use happeni

Re: [PATCH 1/8] drm/amdgpu: grab an additional reference on the gang fence v2

2025-03-14 Thread SRINIVASAN SHANMUGAM
Thanks for these patches and feedback's. The series is: Acked-by: Srinivasan Shanmugam On 3/14/2025 7:50 PM, Christian König wrote: Am 14.03.25 um 05:09 schrieb SRINIVASAN SHANMUGAM: On 3/7/2025 7:18 PM, Christian König wrote: We keep the gang submission fence around in adev, make sure that

RE: [PATCH 1/7] drm/amd/amdgpu: Simplify SDMA reset mechanism by removing dynamic callbacks

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, March 14, 2025 5:46 PM > To: Kim, Jonathan > Cc: Zhang, Jesse(Jie) ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Zhu, Jiadong > Subject: Re: [PATCH 1/7] drm/amd/amdgpu: Simplify SDMA reset

RE: [PATCH v2] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Kasiviswanathan, Harish
[Public] -Original Message- From: Kim, Jonathan Sent: Friday, March 14, 2025 5:35 PM To: Kasiviswanathan, Harish ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH v2] drm/amdkfd: Update return value of config_dequeue_wait_counts [Public] > -Original Message- > From: Kasivisw

Re: [PATCH V2 1/2] drm/amdgpu/gfx: fix ref counting for ring based profile handling

2025-03-14 Thread Alex Deucher
On Fri, Mar 14, 2025 at 6:31 AM Lazar, Lijo wrote: > > > > On 3/12/2025 7:49 PM, Alex Deucher wrote: > > We need to make sure the workload profile ref counts are > > balanced. This isn't currently the case because we can > > increment the count on submissions, but the decrement may > > be delayed

Re: [PATCH v2 4/9] drm/amdkfd: Validate user queue buffers

2025-03-14 Thread Alex Deucher
On Fri, Mar 14, 2025 at 8:55 AM Dieter Faulbaum wrote: > > > Hello Philip, > > Philip Yang writes: > > > On 2025-02-12 17:42, Uwe Kleine-König wrote: > > > > #regzbot introduced: 68e599db7a549f010a329515f3508d8a8c3467a4 > > #regzbot monitor: https://bugs.debian.org/1093124 > > > > Hello, > > > >

[PATCH] drm/amdkfd: set precise mem ops caps to disabled for gfx 11 and 12

2025-03-14 Thread Jonathan Kim
Clause instructions with precise memory enabled currently hang the shader so set capabilities flag to disabled since it's unsafe to use for debugging. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/

RE: [PATCH v2] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Kasiviswanathan, Harish
[Public] -Original Message- From: Kim, Jonathan Sent: Friday, March 14, 2025 4:41 PM To: Kasiviswanathan, Harish ; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish Subject: RE: [PATCH v2] drm/amdkfd: Update return value of config_dequeue_wait_counts [Public] > -Original

[PATCH v2] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Harish Kasiviswanathan
.config_dequeue_wait_counts returns a nop case. Modify return parameter to reflect that since the caller also needs to ignore this condition. v2: Removed redudant code. Tidy up code based on review comments Fixes: <98a5af8103f> ("drm/amdkfd: Add pm_config_dequeue_wait_counts API") Signed-off

RE: [PATCH v2] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kasiviswanathan, Harish > Sent: Friday, March 14, 2025 5:04 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH v2] drm/amdkfd: Update return value of > config_dequeue_wait_counts > > [Public] > > -Original Message- >

Re: [PATCH 1/7] drm/amd/amdgpu: Simplify SDMA reset mechanism by removing dynamic callbacks

2025-03-14 Thread Alex Deucher
On Fri, Mar 14, 2025 at 10:43 AM Kim, Jonathan wrote: > > [Public] > > > -Original Message- > > From: Alex Deucher > > Sent: Thursday, March 13, 2025 10:38 AM > > To: Zhang, Jesse(Jie) > > Cc: Koenig, Christian ; amd- > > g...@lists.freedesktop.org; Deucher, Alexander ; > > Kim, Jonathan

Re: commit 7ffb791423c7 breaks steam game

2025-03-14 Thread Bert Karwatzki
Am Freitag, dem 14.03.2025 um 08:54 +1100 schrieb Balbir Singh: > On 3/14/25 05:12, Bert Karwatzki wrote: > > Am Donnerstag, dem 13.03.2025 um 22:47 +1100 schrieb Balbir Singh: > > > > > > > > > Anyway, I think the nokaslr result is interesting, it seems like with > > > nokaslr > > > even the olde

Re: [PATCH V2 1/2] drm/amdgpu/gfx: fix ref counting for ring based profile handling

2025-03-14 Thread Lazar, Lijo
On 3/12/2025 7:49 PM, Alex Deucher wrote: > We need to make sure the workload profile ref counts are > balanced. This isn't currently the case because we can > increment the count on submissions, but the decrement may > be delayed as work comes in. Track when we enable the > workload profile s

[PATCH 1/2] drm/amdgpu/gfx: adjust workload profile handling

2025-03-14 Thread Alex Deucher
No need to make the workload profile setup dependent on the results of cancelling the delayed work thread. We have all of the necessary checking in place for the workload profile reference counting, so separate the two. As it is now, we can theoretically end up with the call from begin_use happeni

Re: commit 7ffb791423c7 breaks steam game

2025-03-14 Thread Balbir Singh
On 3/15/25 01:18, Bert Karwatzki wrote: > Am Samstag, dem 15.03.2025 um 00:34 +1100 schrieb Balbir Singh: >> On 3/14/25 17:14, Balbir Singh wrote: >>> On 3/14/25 09:22, Bert Karwatzki wrote: Am Freitag, dem 14.03.2025 um 08:54 +1100 schrieb Balbir Singh: > On 3/14/25 05:12, Bert Karwatzki

[pull] amdgpu, amdkfd, radeon drm-next-6.15

2025-03-14 Thread Alex Deucher
Hi Dave, Simona, Updates for 6.15. The following changes since commit 236f475d29f8e585a72fb6fac7f8bb4dc4b162b7: Merge tag 'amd-drm-next-6.15-2025-03-07' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2025-03-10 09:04:52 +1000) are available in the Git repository at: https:/

RE: [PATCH] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: amd-gfx On Behalf Of Harish > Kasiviswanathan > Sent: Friday, March 14, 2025 12:17 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: [PATCH] drm/amdkfd: Update return value of config_dequeue_wait_counts > > .config_deque

Re: [PATCH 3/3] drm/amdgpu/discovery: optionally use fw based ip discovery

2025-03-14 Thread Alex Deucher
On Fri, Mar 14, 2025 at 6:28 AM Lazar, Lijo wrote: > > > > On 3/14/2025 3:24 PM, Flora Cui wrote: > > From: Alex Deucher > > > > On chips without native IP discovery support, use the fw binary > > if available, otherwise we can continue without it. > > > > Signed-off-by: Alex Deucher > > --- > >

Re: [PATCH 5/8] drm/amdgpu: rework how the cleaner shader is emitted v3

2025-03-14 Thread Christian König
Am 14.03.25 um 05:24 schrieb SRINIVASAN SHANMUGAM: > On 3/7/2025 7:18 PM, Christian König wrote: >> Instead of emitting the cleaner shader for every job which has the >> enforce_isolation flag set only emit it for the first submission from >> every client. >> >> v2: add missing NULL check >> v3: fi

RE: [PATCH v2] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: amd-gfx On Behalf Of Harish > Kasiviswanathan > Sent: Friday, March 14, 2025 4:22 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: [PATCH v2] drm/amdkfd: Update return value of > config_dequeue_wait_counts > > .config_d

[PATCH v3] drm/amdkfd: Fix bug in config_dequeue_wait_counts

2025-03-14 Thread Harish Kasiviswanathan
For certain ASICs where dequeue_wait_count don't need to be initialized, pm_config_dequeue_wait_counts_v9 return without filling in the packet information. However, the calling function interprets this as a success and sends the uninitialized packet to firmware causing hang. Fix the above bug by n

RE: [PATCH v3] drm/amdkfd: Fix bug in config_dequeue_wait_counts

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: amd-gfx On Behalf Of Harish > Kasiviswanathan > Sent: Friday, March 14, 2025 8:44 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: [PATCH v3] drm/amdkfd: Fix bug in config_dequeue_wait_counts > > For certain ASICs where