On Thu, Dec 12, 2024 at 11:36:29AM +0530, Vignesh Raman wrote:
> Hi Dmitry,
>
> On 12/12/24 03:09, Dmitry Baryshkov wrote:
> > On Wed, Dec 11, 2024 at 07:58:05PM +0530, Vignesh Raman wrote:
> > > Uprev IGT to the latest version and update expectation files.
> > >
> > > Signed-off-by: Vignesh Rama
On 12/11/2024 4:23 AM, Alex Deucher wrote:
> Pass the instance to the helpers.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 437
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 12 +-
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 16 +-
Am 11.12.24 um 17:14 schrieb Li, Yunxiang (Teddy):
[Public]
From: Koenig, Christian
Sent: Wednesday, December 11, 2024 10:03
Am 11.12.24 um 15:02 schrieb Li, Yunxiang (Teddy):
[Public]
From: Koenig, Christian
Sent: Wednesday, December 11, 2024 3:16 Am 10.12.24 um 18:59 schrieb
Yunxiang Li:
On 12/11/2024 4:23 AM, Alex Deucher wrote:
> Pass the vcn instance structure to these functions rather
> than adev and the instance number.
>
> TODO: clean up the function internals to use the vinst state
> directly rather than accessing it indirectly via adev->vcn.inst[].
>
> Signed-off-by: A
It corrects the issue by checking if 'adev->dm.dmub_srv' is NULL before
accessing its 'meta_info' member. This ensures that we do not
dereference a NULL pointer.
Fixes the below:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:917
dmub_tracebuffer_show()
warn:
On Thu, Dec 12, 2024 at 9:18 AM Dheeraj Reddy Jonnalagadda
wrote:
>
> Remove the logically dead code in the last return statement of
> amdgpu_ras_eeprom_init. The condition res < 0 is redundant since
> res is already checked for a negative value earlier. Replace
> return res < 0 ? res : 0; with re
On Wed, Dec 11, 2024 at 11:24 PM Lijo Lazar wrote:
>
> Driver has different ways to fetch VBIOS. If one of the methods doesn't
> find an authentic one, it will show misleading info messages eventhough
> a subsequent method finds a valid VBIOS. Keep the message level at debug
> and add device conte
Applied. Thanks!
On Wed, Dec 11, 2024 at 8:47 PM Jiapeng Chong
wrote:
>
> Use existing swap() function rather than duplicating its implementation.
>
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:185:47-48: WARNING
> opportunity for swap().
> ./drivers/gpu/drm/amd/display/amdgpu_dm/a
On 2024-12-12 0:30, Zhu Lingshan wrote:
> On 12/12/2024 12:19 PM, Felix Kuehling wrote:
>>
>> On 2024-12-11 22:06, Zhu Lingshan wrote:
>>> kfd_process_wq_release() signals eviction fence by
>>> dma_fence_signal() which wanrs if dma_fence
>>> is NULL.
>> That's news to me. Looking at the dma_fenc
On 12/11/2024 4:22 AM, Alex Deucher wrote:
> Move more per instance data into the per instance structure.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 196
> drivers/gpu/drm/amd/a
Am 11.12.24 um 18:10 schrieb Pierre-Eric Pelloux-Prayer:
Since 2320c9e6a768 ("drm/sched: memset() 'job' in drm_sched_job_init()")
accessing job->base.sched can produce unexpected results as the initialisation
of (*job)->base.sched done in amdgpu_job_alloc is overwritten by the
memset.
This commi
It corrects the issue by checking if 'adev->dm.dmub_srv' is NULL before
accessing its 'meta_info' member. This ensures that we do not
dereference a NULL pointer.
Fixes the below:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:917
dmub_tracebuffer_show()
warn:
Hi Vignesh,
thanks for the patch.
On Wed, 11 Dec 2024 11:28:05 -0300 Vignesh Raman wrote ---
> Uprev IGT to the latest version and update expectation files.
>
> Signed-off-by: Vignesh Raman vignesh.ra...@collabora.com>
> ---
>
> v1:
> - Pipeline link -
> https://gitlab.
[Public]
> From: Koenig, Christian
> Sent: Thursday, December 12, 2024 4:25
> Am 11.12.24 um 17:14 schrieb Li, Yunxiang (Teddy):
> > [Public]
> >
> >> From: Koenig, Christian
> >> Sent: Wednesday, December 11, 2024 10:03 Am 11.12.24 um 15:02 schrieb
> >> Li, Yunxiang (Teddy):
> >>> [Public]
> >>
Remove the logically dead code in the last return statement of
amdgpu_ras_eeprom_init. The condition res < 0 is redundant since
res is already checked for a negative value earlier. Replace
return res < 0 ? res : 0; with return 0 to improve clarity.
Fixes: 63d4c081a556 ("drm/amdgpu: Optimize EEPROM
Use existing swap() function rather than duplicating its implementation.
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:185:47-48: WARNING
opportunity for swap().
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c:125:53-54: WARNING
opportunity for swap().
Reported-by: Abaci Robot
Hello Leo Li,
Commit 5a498172c8d0 ("drm/amd/display: Make DMCUB tracebuffer debugfs
chronological") from Nov 26, 2024 (linux-next), leads to the
following Smatch static checker warning:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:917
dmub_tracebuffer_show()
On Wed, Dec 11, 2024 at 06:15:44PM +0800, jianqi.ren...@windriver.com wrote:
> From: Wayne Lin
>
> [ Upstream commit fcf6a49d79923a234844b8efe830a61f3f0584e4 ]
>
> [Why]
> When unplug one of monitors connected after mst hub, encounter null pointer
> dereference.
>
> It's due to dc_sink get rel
On Wed, Dec 11, 2024 at 06:14:12PM +0100, Maxime Ripard wrote:
> On Wed, Dec 04, 2024 at 01:17:17PM +0200, Raag Jadav wrote:
> > + misc maintainers
> >
> > On Tue, Dec 03, 2024 at 11:18:00AM +0100, Christian König wrote:
> > > Am 03.12.24 um 06:00 schrieb Raag Jadav:
> > > > On Mon, Dec 02, 2024 a
On Thu, Dec 12, 2024 at 03:07:58PM +0530, Srinivasan Shanmugam wrote:
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> index 11a7ac54f91c..0092d4a1e59d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgp
Hi Dmitry,
Em 11/12/2024 16:35, Dmitry Baryshkov escreveu:
On Wed, Dec 11, 2024 at 12:25:07AM -0300, André Almeida wrote:
Hi,
The goal of this work is to find a nice way to allow amdgpu to perform
async page flips in the overlay plane as well, not only on the primary
one. Currently, when using
Thanks!
regards,
dan carpenter
On 12/11/2024 11:30 PM, Zhu Lingshan wrote:
On 12/12/2024 12:19 PM, Felix Kuehling wrote:
On 2024-12-11 22:06, Zhu Lingshan wrote:
kfd_process_wq_release() signals eviction fence by
dma_fence_signal() which wanrs if dma_fence
is NULL.
That's news to me. Looking at the dma_fence_signal impleme
Am 12.12.24 um 15:04 schrieb Li, Yunxiang (Teddy):
[Public]
From: Koenig, Christian
Sent: Thursday, December 12, 2024 4:25
Am 11.12.24 um 17:14 schrieb Li, Yunxiang (Teddy):
[Public]
From: Koenig, Christian
Sent: Wednesday, December 11, 2024 10:03 Am 11.12.24 um 15:02 schrieb
Li, Yunxiang
This is a note to let you know that I've just added the patch titled
[PATCH 6.1.y] drm/amd/display: Don't refer to dc_sink in
is_dsc_need_re_compute
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filen
Apply sign extension to seq64 va address.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
index
From: Christian König
Modify the MES process va end limit to max pfn.
Signed-off-by: Christian König
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 3 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 2 +-
drivers/gpu/drm/amd/amdgpu/mes_userqueue.
Fix the wait IOCTL lockup issue.
[Dec 6 17:53] watchdog: BUG: soft lockup - CPU#4 stuck for 26s!
[Xwayland:cs0:2634]
[ +0.02] RIP: 0010:amdgpu_userq_wait_ioctl+0x3ce/0xfe0 [amdgpu]
[ +0.03] RSP: 0018:ada901f4fc38 EFLAGS: 0202
[ +0.03] RAX: 0001 RBX:
Add the correct fences count variable [num_fences] in the fences
array iteration to handle the userq / non-userq fences.
v2:(Christian)
- All fences in the array either come from some reservation object
or drm_syncobj. If any of those are NULL then there is a bug
somewhere else.
Signed-
The xarray pointer which has the userqueue xarray structure
reference should be cleared when the userqueue gets
destroyed. Otherwise, we may access the freed xa memory and
see the below warnings.
warning 1:
BUG: KASAN: slab-use-after-free in _raw_spin_lock+0x7a/0xe0
[ +0.44] Call Trace:
[ +0
Fix out-of-bounds issue in userq fence create when
accessing the userq xa structure. Added a lock to
protect the race condition.
BUG: KASAN: slab-out-of-bounds in amdgpu_userq_fence_create+0x726/0x880 [amdgpu]
[ +0.06] Call Trace:
[ +0.05]
[ +0.05] dump_stack_lvl+0x6c/0x90
[ +0.
Add mqd for userq compute queue for gfx11/gfx12
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 4
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c| 4
drivers/gpu/drm/amd/include/v11_structs.h | 4 ++--
drivers/gpu/drm/amd/include/v12_structs.h | 4 ++
[AMD Official Use Only - AMD Internal Distribution Only]
Please help us review this patch.
Thanks!
From: Bokun Zhang
Sent: Wednesday, December 11, 2024 4:48 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Bokun
Subject: [PATCH] drm/amdgpu/vcn: reset fw_shared
Define how to handle buffers with multiple possible placement so we
don't get incompatible implementations. Callout the resident requirement
for drm-purgeable- explicitly. Remove the requirement for there to be
only drm-memory- or only drm-resident-, it's not what's implemented and
having both is b
amdgpu_vm_bo_invalidate doesn't use the adev parameter and not all
callers have a reference to adev handy, so remove it for cleanliness.
Signed-off-by: Yunxiang Li
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
Before, every time fdinfo is queried we try to lock all the BOs in the
VM and calculate memory usage from scratch. This works okay if the
fdinfo is rarely read and the VMs don't have a ton of BOs. If either of
these conditions is not true, we get a massive performance hit.
In this new revision, we
When memory stats is generated fresh everytime by going though all the
BOs, their active information is quite easy to get. But if the stats are
tracked with BO's state this becomes harder since the job scheduling
part doesn't really deal with individual buffers.
Make drm-active- optional to enable
Right now every time the fdinfo is read, we go through the vm lists and
lock all the BOs to calcuate the statistics. This causes a lot of lock
contention when the VM is actively used. It gets worse if there is a lot
of shared BOs or if there's a lot of submissions. We have seen
submissions lock-up
Add a helper to check if the memory stats is zero, this will be used to
check for memory accounting errors.
Signed-off-by: Yunxiang Li
Reviewed-by: Christian König
CC: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_file.c | 10 ++
include/drm/drm_file.h | 1 +
2 files cha
On Wed, Dec 11, 2024 at 4:48 PM Bokun Zhang wrote:
>
> - The previous patch only considered the case for baremetal
> and not applicable for SRIOV code path. We also need to
> init fw_share for SRIOV VF
>
> Signed-off-by: Bokun Zhang
Fixes: c4b519b70d9f ("drm/amdgpu/vcn: reset fw_shared when
[AMD Official Use Only - AMD Internal Distribution Only]
Series is
Reviewed-by: Yang Wang
Best Regards,
Kevin
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Friday, December 13, 2024 06:09
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 1/6]
[AMD Official Use Only - AMD Internal Distribution Only]
Series is
Reviewed-by: Yang Wang
Best Regards,
Kevin
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Friday, December 13, 2024 05:54
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 1/2]
Wang, Yang(Kevin) would like to recall the message, "[PATCH 1/2]
drm/amdgpu/nbio7.7: fix IP version check".
[AMD Official Use Only - AMD Internal Distribution Only]
Looks good to me as well, With Christian's comment accommodated:
Acked-by: Shashank Sharma
Regards
Shashank
From: Koenig, Christian
Sent: Friday, December 13, 2024 8:34 AM
To: André Almeida ; Raag Jadav ;
This commit enlarges the hashtable size of
kfd_process to 256
Signed-off-by: Zhu Lingshan
---
drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
index 9e5ca0b93b2
kfd_process_wq_release() signals eviction fence by
dma_fence_signal() which wanrs if dma_fence
is NULL.
kfd_process->ef is initialized by kfd_process_device_init_vm()
through ioctl. That means the fence is NULL for a new
created kfd_process, and close a kfd_process right
after open it will trigger
Am 12.12.24 um 20:09 schrieb André Almeida:
Use DRM's device wedged event to notify userspace that a reset had
happened. For now, only use `none` method meant for telemetry
capture.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
1 file changed, 3 inserti
Use the helper function rather than reading it directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c
b/drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c
index 49e953f86ced4
Use the helper function rather than reading it directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c
b/drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c
index 1ac730328516f
Use the helper function rather than reading it directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c
b/drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c
index 0fbc
Use the helper function rather than reading it directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c
b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c
index 814ab59fdd
Use the helper function rather than reading it directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c
b/drivers/gpu/drm/amd/amdgpu/nbio_v7_0.c
index 49e953f86ced4
Use the helper function rather than reading it directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
index 035fc392526d3
Use the helper function rather than reading it directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c
b/drivers/gpu/drm/amd/pm/swsmu/s
Use the helper function rather than reading it directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c
b/drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c
index 1ac730328516f
55 matches
Mail list logo
