[AMD Official Use Only - AMD Internal Distribution Only] Looks good to me as well, With Christian's comment accommodated: Acked-by: Shashank Sharma <shashank.sha...@amd.com>
Regards Shashank ________________________________ From: Koenig, Christian <christian.koe...@amd.com> Sent: Friday, December 13, 2024 8:34 AM To: André Almeida <andrealm...@igalia.com>; Raag Jadav <raag.ja...@intel.com>; airl...@gmail.com <airl...@gmail.com>; sim...@ffwll.ch <sim...@ffwll.ch>; lucas.demar...@intel.com <lucas.demar...@intel.com>; rodrigo.v...@intel.com <rodrigo.v...@intel.com>; jani.nik...@linux.intel.com <jani.nik...@linux.intel.com>; andriy.shevche...@linux.intel.com <andriy.shevche...@linux.intel.com>; l...@asahilina.net <l...@asahilina.net>; michal.wajdec...@intel.com <michal.wajdec...@intel.com>; Sharma, Shashank <shashank.sha...@amd.com> Cc: intel-...@lists.freedesktop.org <intel-...@lists.freedesktop.org>; dri-de...@lists.freedesktop.org <dri-de...@lists.freedesktop.org>; himal.prasad.ghimi...@intel.com <himal.prasad.ghimi...@intel.com>; aravind.iddamse...@linux.intel.com <aravind.iddamse...@linux.intel.com>; anshuman.gu...@intel.com <anshuman.gu...@intel.com>; Deucher, Alexander <alexander.deuc...@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; kernel-...@igalia.com <kernel-...@igalia.com> Subject: Re: [PATCH 1/1] drm/amdgpu: Use device wedged event Am 12.12.24 um 20:09 schrieb André Almeida: > Use DRM's device wedged event to notify userspace that a reset had > happened. For now, only use `none` method meant for telemetry > capture. > > Signed-off-by: André Almeida <andrealm...@igalia.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 96316111300a..19e1a5493778 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -6057,6 +6057,9 @@ int amdgpu_device_gpu_recover(struct amdgpu_device > *adev, > dev_info(adev->dev, "GPU reset end with ret = %d\n", r); > > atomic_set(&adev->reset_domain->reset_res, r); > + > + drm_dev_wedged_event(adev_to_drm(adev), DRM_WEDGE_RECOVERY_NONE); That looks really good in general. I would just make the DRM_WEDGE_RECOVERY_NONE depend on the value of "r". @Shashank any objections? IIRC you have worked on the AMD specific event we never upstreamed. Regards, Christian. > + > return r; > } >
