Re: [PATCH 1/2] drm/amdgpu: add userq specific kernel config for fence ioctls

2024-10-29 Thread Christian König
Am 24.10.24 um 14:10 schrieb Arunpravin Paneer Selvam: Keep the user queue fence signal and wait IOCTLs in the kernel config CONFIG_DRM_AMDGPU_NAVI3X_USERQ. Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH v1 8/9] drm/amdgpu: update vcn_v5.0 devcoredump on per instance basis

2024-10-29 Thread Sunil Khatri
vcn code is restructured for per instance basis. Each vcn instance is represented by an ip_block and hence a need to update the dump and print functions for each instance as an IP. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 77 - 1 file chan

Re: [PATCH v3] drm/amdgpu: Fix the memory allocation issue in amdgpu_discovery_get_nps_info()

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 8:53 AM Li Huafei wrote: > > Fix two issues with memory allocation in amdgpu_discovery_get_nps_info() > for mem_ranges: > > - Add a check for allocation failure to avoid dereferencing a null >pointer. > > - As suggested by Christophe, use kvcalloc() for memory allocat

Re: [PATCH 1/2] drm/amdgpu: add userq specific kernel config for fence ioctls

2024-10-29 Thread Christian König
Am 29.10.24 um 14:32 schrieb Alex Deucher: On Tue, Oct 29, 2024 at 5:38 AM Christian König wrote: Am 24.10.24 um 14:10 schrieb Arunpravin Paneer Selvam: Keep the user queue fence signal and wait IOCTLs in the kernel config CONFIG_DRM_AMDGPU_NAVI3X_USERQ. Signed-off-by: Arunpravin Paneer Selva

Re: [PATCH 1/2] drm/amdgpu: add userq specific kernel config for fence ioctls

2024-10-29 Thread Paneer Selvam, Arunpravin
On 10/29/2024 7:33 PM, Christian König wrote: Am 29.10.24 um 14:32 schrieb Alex Deucher: On Tue, Oct 29, 2024 at 5:38 AM Christian König wrote: Am 24.10.24 um 14:10 schrieb Arunpravin Paneer Selvam: Keep the user queue fence signal and wait IOCTLs in the kernel config CONFIG_DRM_AMDGPU_NAV

Re: [PATCH] drm/amd/display: Remove unused cm3_helper_translate_curve_to_degamma_hw_format

2024-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Oct 8, 2024 at 8:43 PM wrote: > > From: "Dr. David Alan Gilbert" > > cm3_helper_translate_curve_to_degamma_hw_format() since it was added in > 2020's commit > 03f54d7d3448 ("drm/amd/display: Add DCN3 DPP") > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert

Re: [PATCH] drm/amd/display: Remove last parts of timing_trace

2024-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Oct 10, 2024 at 4:52 PM wrote: > > From: "Dr. David Alan Gilbert" > > Commit c2c2ce1e9623 ("drm/amd/display: Optimize passive update planes.") > removed the last caller of context_timing_trace. > Remove it. > > With that gone, no one is now looking at the 'timing_

[PATCH v1 2/9] drm/amdgpu: update vcn_v2.0 devcoredump on per instance basis

2024-10-29 Thread Sunil Khatri
vcn code is restructured for per instance basis. Each vcn instance is represented by an ip_block and hence a need to update the dump and print functions for each instance as an IP. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 77 +-- 1 file chan

Re: [PATCH] drm/amdgpu: Group gfx sysfs functions

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 2:58 AM SRINIVASAN SHANMUGAM wrote: > > > On 10/29/2024 12:07 PM, SRINIVASAN SHANMUGAM wrote: > > > On 10/29/2024 10:57 AM, Lijo Lazar wrote: > > Make amdgpu_gfx_sysfs_init/fini functions as common entry points for all > gfx related sysfs nodes. > > Signed-off-by: Lijo Laza

Re: [RFC 4/4] drm/amdgpu: Expose special on chip memory pools in fdinfo

2024-10-29 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Oct 28, 2024 at 1:51 PM Christian König wrote: > > Am 24.10.24 um 11:23 schrieb Tvrtko Ursulin: > > From: Tvrtko Ursulin > > > > In the past these specialized on chip memory pools were reported as system > > memory (aka 'cpu') which was not correct and

[PATCH v2 0/2] Two zero RPM features

2024-10-29 Thread Wolfgang Müller
Here's v2 of this series, now also with support for setting the zero RPM stop temperature. Additionally, the fan_zero_rpm knob has been renamed fan_zero_rpm_enable. As before I successfully tested both changes on my own system. Wolfgang Müller (2): drm/amd/pm: add zero RPM OD setting support fo

Re: [PATCH] drm/amdgpu: Group gfx sysfs functions

2024-10-29 Thread Lazar, Lijo
On 10/29/2024 6:59 PM, Alex Deucher wrote: > On Tue, Oct 29, 2024 at 2:58 AM SRINIVASAN SHANMUGAM > wrote: >> >> >> On 10/29/2024 12:07 PM, SRINIVASAN SHANMUGAM wrote: >> >> >> On 10/29/2024 10:57 AM, Lijo Lazar wrote: >> >> Make amdgpu_gfx_sysfs_init/fini functions as common entry points for a

Re: [PATCH 1/2] drm/amdgpu: add userq specific kernel config for fence ioctls

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 5:38 AM Christian König wrote: > > Am 24.10.24 um 14:10 schrieb Arunpravin Paneer Selvam: > > Keep the user queue fence signal and wait IOCTLs in the > > kernel config CONFIG_DRM_AMDGPU_NAVI3X_USERQ. > > > > Signed-off-by: Arunpravin Paneer Selvam > > --- > > drivers/gpu

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2024-10-29 Thread Alex Deucher
On Sun, Oct 27, 2024 at 10:18 AM R Sundar wrote: > > Use string choice helpers for better readability. I personally find this less readable, but if this is the preferred method going forward, I'm fine to take the patch. Alex > > Reported-by: kernel test robot > Reported-by: Julia Lawall > Clo

[PATCH v1 5/9] drm/amdgpu: update vcn_v4.0.3 devcoredump on per instance basis

2024-10-29 Thread Sunil Khatri
vcn code is restructured for per instance basis. Each vcn instance is represented by an ip_block and hence a need to update the dump and print functions for each instance as an IP. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 80 - 1 file chan

[PATCH v1 0/9] update devcoredump for new VCN instance design

2024-10-29 Thread Sunil Khatri
Sunil Khatri (9): drm/amdgpu: update vcn_v1 devcoredump on per instance basis drm/amdgpu: update vcn_v2.0 devcoredump on per instance basis drm/amdgpu: update vcn_v2.5 devcoredump on per instance basis drm/amdgpu: update vcn_v3.0 devcoredump on per instance basis drm/amdgpu: update vcn_v4

[PATCH v1 7/9] drm/amdgpu: update vcn_v4 devcoredump on per instance basis

2024-10-29 Thread Sunil Khatri
vcn code is restructured for per instance basis. Each vcn instance is represented by an ip_block and hence a need to update the dump and print functions for each instance as an IP. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 80 +-- 1 file chan

[PATCH v1 3/9] drm/amdgpu: update vcn_v2.5 devcoredump on per instance basis

2024-10-29 Thread Sunil Khatri
vcn code is restructured for per instance basis. Each vcn instance is represented by an ip_block and hence a need to update the dump and print functions for each instance as an IP. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 77 +-- 1 file chan

[PATCH v1 4/9] drm/amdgpu: update vcn_v3.0 devcoredump on per instance basis

2024-10-29 Thread Sunil Khatri
vcn code is restructured for per instance basis. Each vcn instance is represented by an ip_block and hence a need to update the dump and print functions for each instance as an IP. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 75 +-- 1 file chan

[PATCH v1 9/9] drm/amdgpu: remove unused ip_dump from vcn device

2024-10-29 Thread Sunil Khatri
ip_dump pointer for the vcn has now moved to the per instance ip_block hence clean the old pointer from the vcn device. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h b/drivers

Re: [PATCH 2/2] drm/amdgpu: Add gpu_addr support to seq64 allocation

2024-10-29 Thread Christian König
Am 24.10.24 um 14:10 schrieb Arunpravin Paneer Selvam: Add gpu address support to seq64 alloc function. v1:(Christian) - Add the user of this new interface change to the same patch. Signed-off-by: Arunpravin Paneer Selvam Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdg

Re: [PATCH 1/5 V4 1/5] drm/amdgpu: Add sysfs interface for gc reset mask

2024-10-29 Thread Lazar, Lijo
On 10/29/2024 1:55 PM, Zhang, Jesse(Jie) wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Lijo, > > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, October 29, 2024 3:58 PM > To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander

Re: [PATCH] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-29 Thread Li Huafei
On 2024/10/28 22:33, Lazar, Lijo wrote: > > > On 10/29/2024 3:29 AM, Li Huafei wrote: >> Fix the potential NULL pointer dereference on mem_ranges in >> amdgpu_discovery_get_nps_info(). Additionally, assign the output >> parameters nps_type and range_cnt after the kvzalloc() call to prevent >>

[PATCH] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-29 Thread Li Huafei
Fix the potential NULL pointer dereference on mem_ranges in amdgpu_discovery_get_nps_info(). Additionally, assign the output parameters nps_type and range_cnt after the kvzalloc() call to prevent modifying the output parameters in case of an error return. Fixes: b194d21b9bcc ("drm/amdgpu: Use NPS

[PATCH v2 3/3] drm: remove driver date from struct drm_driver and all drivers

2024-10-29 Thread Jani Nikula
We stopped using the driver initialized date in commit 7fb8af6798e8 ("drm: deprecate driver date") and (eventually) started returning "0" for drm_version ioctl instead. Finish the job, and remove the unused date member from struct drm_driver, its initialization from drivers, along with the common

Re: [PATCH v2] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-29 Thread Christophe JAILLET
Le 29/10/2024 à 11:18, Li Huafei a écrit : Fix the potential NULL pointer dereference on mem_ranges in amdgpu_discovery_get_nps_info(). Additionally, assign the output parameters nps_type and range_cnt after the kvzalloc() call to prevent modifying the output parameters in case of an error return

Re: [PATCH v2] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-29 Thread Li Huafei
On 2024/10/29 16:18, Christophe JAILLET wrote: > Le 29/10/2024 à 11:18, Li Huafei a écrit : >> Fix the potential NULL pointer dereference on mem_ranges in >> amdgpu_discovery_get_nps_info(). Additionally, assign the output >> parameters nps_type and range_cnt after the kvzalloc() call to prevent

[PATCH v2 1/2] drm/amd/pm: add zero RPM OD setting support for SMU13

2024-10-29 Thread Wolfgang Müller
Whilst we have support for setting fan curves there is no support for disabling the zero RPM feature. Since the relevant bits are already present in the OverDriveTable, hook them up to a sysctl setting so users can influence this behaviour. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3

[PATCH v2 2/2] drm/amd/pm: add zero RPM stop temperature OD setting support for SMU13

2024-10-29 Thread Wolfgang Müller
Together with the feature to enable or disable zero RPM in the last commit, it also makes sense to expose the OD setting determining under which temperature the fan should stop if zero RPM is enabled. Signed-off-by: Wolfgang Müller --- Documentation/gpu/amdgpu/thermal.rst | 6 ++ .../g

Re: [PATCH v2] drm/amd/pm: correct the workload setting

2024-10-29 Thread Alex Deucher
On Mon, Oct 28, 2024 at 11:48 PM Lazar, Lijo wrote: > > > > On 10/28/2024 11:42 PM, Alex Deucher wrote: > > On Thu, Oct 24, 2024 at 5:18 AM Kenneth Feng wrote: > >> > >> Correct the workload setting in order not to mix the setting > >> with the end user. Update the workload mask accordingly. > >>

Re: [PATCH v2] drm/amd/pm: correct the workload setting

2024-10-29 Thread Alex Deucher
On Thu, Oct 24, 2024 at 5:18 AM Kenneth Feng wrote: > > Correct the workload setting in order not to mix the setting > with the end user. Update the workload mask accordingly. > > v2: changes as below: > 1. the end user can not erase the workload from driver except default > workload. > 2. always

Re: [PATCH v2] drm/amdgpu: add userq specific kernel config for fence ioctls

2024-10-29 Thread Christian König
Am 29.10.24 um 12:00 schrieb Arunpravin Paneer Selvam: Keep the user queue fence signal and wait IOCTLs in the kernel config CONFIG_DRM_AMDGPU_NAVI3X_USERQ. v2(Christian): - Remove the userq specific config added for kernel queues fence init function. Signed-off-by: Arunpravin Paneer Se

[PATCH v3] drm/amdgpu: Fix the memory allocation issue in amdgpu_discovery_get_nps_info()

2024-10-29 Thread Li Huafei
Fix two issues with memory allocation in amdgpu_discovery_get_nps_info() for mem_ranges: - Add a check for allocation failure to avoid dereferencing a null pointer. - As suggested by Christophe, use kvcalloc() for memory allocation, which checks for multiplication overflow. Additionally,

Re: [PATCH] drm/fourcc: add AMD_FMT_MOD_TILE_GFX9_4K_D_X

2024-10-29 Thread Alex Deucher
On Fri, Oct 25, 2024 at 2:03 AM Qiang Yu wrote: > > From: Qiang Yu > > This is used when radeonsi export small texture's modifier > to user with eglExportDMABUFImageQueryMESA(). > > mesa changes is available here: > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31658 > > Signed-off-by

Re: [PATCH] drm: amdgpu: fix comment about amdgpu.abmlevel defaults

2024-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Oct 24, 2024 at 9:07 AM wrote: > > Since 040fdcde288a2830edc31dd507963d6aadf990d2 ("drm/amdgpu: respect the > abmlevel module parameter value if it is set"), the default value for > amdgpu.abmlevel was set to -1, or auto. However, the comment explaining > the defau

Re: [PATCH 0/1] On DRM -> stable process

2024-10-29 Thread Sasha Levin
On Tue, Oct 29, 2024 at 04:31:40PM +0300, Fedor Pchelkin wrote: BTW, a question to the stable-team: what Git magic (3-way-merge?) let the duplicate patch be applied successfully? The patch context in stable trees was different to that moment so should the duplicate have been expected to fail to b

[PATCH v1 1/9] drm/amdgpu: update vcn_v1 devcoredump on per instance basis

2024-10-29 Thread Sunil Khatri
vcn code is restructured for per instance basis. Each vcn instance is represented by an ip_block and hence a need to update the dump and print functions for each instance as an IP. Existing way was to capture the ip dump for each instance in a same memory dump but now each ip_block of vcn is an in

[PATCH 17/29] drm/amdgpu: power vcn 5_0_0 by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang For vcn 5_0_0, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_b

[PATCH 22/29] drm/amdgpu: sw_fini for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass instance parameter to amdgpu_vcn_sw_fini(), and perform sw fini ONLY for the given vcn instance, instead of for all vcn instances. Modify each vcn generation accordingly. Signed-off-by: Boyuan Zhang Acked-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 3

[PATCH 13/29] drm/amdgpu: power vcn 3_0 by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang For vcn 3_0, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_blo

[PATCH 16/29] drm/amdgpu: power vcn 4_0_5 by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang For vcn 4_0_5, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_b

[PATCH 07/29] drm/amdgpu: pass ip_block in set_powergating_state

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass ip_block instead of adev in set_powergating_state callback function. Modify set_powergating_state ip functions for all correspoding ip blocks. v2: fix a ip block index error. v3: remove type casting Signed-off-by: Boyuan Zhang Suggested-by: Christian König Acked-by: C

[PATCH 03/29] drm/amd/pm: add inst to smu_dpm_set_vcn_enable

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang First, add an instance parameter to smu_dpm_set_vcn_enable() function, and calling dpm_set_vcn_enable() with this given instance. Second, modify vcn_gated to be an array, to track the gating status for each vcn instance separately. With these 2 changes, smu_dpm_set_vcn_enable

[PATCH 18/29] drm/amdgpu/vcn: separate idle work by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Previously idle working handling is for all VCN instances. As a result, when one of the instance finishes its job, the idle work can't be triggered if the other instance is still busy. Now, move the idle_work from amdgpu_vcn to amdgpu_vcn_inst, in order to track work by vcn in

[PATCH 21/29] drm/amdgpu: sw_init for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass instance parameter to amdgpu_vcn_sw_init(), and perform sw init ONLY for the given vcn instance, instead of for all vcn instances. Modify each vcn generation accordingly. Signed-off-by: Boyuan Zhang Acked-by: Sunil Khatri Reviewed-by: Alex Deucher --- drivers/gpu/drm/

[PATCH 10/29] drm/amdgpu: move per inst variables to amdgpu_vcn_inst

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Move all per instance variables from amdgpu_vcn to amdgpu_vcn_inst. Move adev->vcn.fw[i] from amdgpu_vcn to amdgpu_vcn_inst. Move adev->vcn.vcn_config[i] from amdgpu_vcn to amdgpu_vcn_inst. Move adev->vcn.vcn_codec_disable_mask[i] from amdgpu_vcn to amdgpu_vcn_inst. Signed-of

[PATCH 06/29] drm/amdgpu: add inst to amdgpu_dpm_enable_vcn

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Add an instance parameter to amdgpu_dpm_enable_vcn() function, and change all calls from vcn ip functions to add instance argument. vcn generations with only one instance (v1.0, v2.0) always use 0 as instance number. vcn generations with multiple instances (v2.5, v3.0, v4.0, v4

[PATCH 05/29] drm/amd/pm: add inst to dpm_set_powergating_by_smu

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Add an instance parameter to amdgpu_dpm_set_powergating_by_smu() function, and use the instance to call set_powergating_by_smu(). v2: remove duplicated functions. remove for-loop in amdgpu_dpm_set_powergating_by_smu(), and temporarily move it to amdgpu_dpm_enable_vcn(), in or

[PATCH 28/29] drm/amdgpu: wait_for_idle for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Perform wait_for_idle only for the instance of the current vcn IP block, instead of perform it for all vcn instances. v2: remove unneeded local variable initialization. Signed-off-by: Boyuan Zhang Acked-by: Leo Liu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/

[PATCH 29/29] drm/amdgpu: set_powergating for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Perform set_powergating_state only for the instance of the current vcn IP block, instead of perform it for all vcn instances. Signed-off-by: Boyuan Zhang Acked-by: Christian König Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 313 -

[PATCH 25/29] drm/amdgpu: resume for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass instance parameter to amdgpu_vcn_resume(), and perform resume ONLY for the given vcn instance, instead of for all vcn instances. Modify each vcn generation accordingly. Signed-off-by: Boyuan Zhang Acked-by: Leo Liu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amd

[PATCH 26/29] drm/amdgpu: setup_ucode for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass instance parameter to amdgpu_vcn_setup_ucode(), and perform setup ucode ONLY for the given vcn instance, instead of for all vcn instances. Modify each vcn generation accordingly. Signed-off-by: Boyuan Zhang Acked-by: Leo Liu Reviewed-by: Alex Deucher --- drivers/gpu/d

[PATCH 15/29] drm/amdgpu: power vcn 4_0_3 by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang For vcn 4_0_3, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_b

[PATCH 02/29] drm/amd/pm: power up or down vcn by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang For smu ip with multiple vcn instances (smu 11/13/14), remove all the for loop in dpm_set_vcn_enable() functions. And use the instance argument to power up/down vcn for the given instance only, instead of powering up/down for all vcn instances. v2: remove all duplicated functi

[PATCH 00/29] Separating vcn power management by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang v6: revise patch #3, #5 based on Alex's comments. add reviewed-by/acked-by and rebase patches. v5: revise patch #6, #28 based on Christian's comments. revise patch #7, #8 based on Sunil's comments. revise patch #24 due to Lijo's recent commit. remove patch #28, #29, #31 in v

[PATCH 08/29] drm/amdgpu: pass ip_block in set_clockgating_state

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass ip_block instead of adev in set_clockgating_state() callback functions. Modify set_clockgating_state()for all correspoding ip blocks. v2: remove all changes for is_idle(), remove type casting Signed-off-by: Boyuan Zhang Acked-by: Christian König Reviewed-by: Sunil Khat

[PATCH 19/29] drm/amdgpu: set powergating state by vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Set powergating state by vcn instance in idle_work_handler() and ring_begin_use() functions for vcn with multiple instances. v2: Add instance parameter to amdgpu_device_ip_set_powergating_state(), instead of creating new function. Signed-off-by: Boyuan Zhang Reviewed-by: Chr

[PATCH 24/29] drm/amdgpu: suspend for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass instance parameter to amdgpu_vcn_suspend(), and perform suspend ONLY for the given vcn instance, instead of for all vcn instances. Modify each vcn generation accordingly. v2: add vcn instance to amdgpu_vcn_save_vcpu_bo() Signed-off-by: Boyuan Zhang Acked-by: Leo Liu Re

[PATCH 23/29] drm/amdgpu: hw_init for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass instance parameter to amdgpu_vcn_hw_init(), and perform hw init ONLY for the given vcn instance, instead of for all vcn instances. Modify each vcn generation accordingly. Signed-off-by: Boyuan Zhang Acked-by: Sunil Khatri Acked-by: Leo Liu Reviewed-by: Alex Deucher --

Re: [PATCH 03/29] drm/amd/pm: add inst to smu_dpm_set_vcn_enable

2024-10-29 Thread Boyuan Zhang
On 2024-10-28 15:04, Alex Deucher wrote: On Thu, Oct 24, 2024 at 10:36 PM wrote: From: Boyuan Zhang First, add an instance parameter to smu_dpm_set_vcn_enable() function, and calling dpm_set_vcn_enable() with this given instance. Second, modify vcn_gated to be an array, to track the gating

Re: [PATCH 05/29] drm/amd/pm: add inst to dpm_set_powergating_by_smu

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 1:43 PM wrote: > > From: Boyuan Zhang > > Add an instance parameter to amdgpu_dpm_set_powergating_by_smu() function, > and use the instance to call set_powergating_by_smu(). > > v2: remove duplicated functions. > > remove for-loop in amdgpu_dpm_set_powergating_by_smu(), an

Re: [PATCH 03/29] drm/amd/pm: add inst to smu_dpm_set_vcn_enable

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 1:53 PM wrote: > > From: Boyuan Zhang > > First, add an instance parameter to smu_dpm_set_vcn_enable() function, > and calling dpm_set_vcn_enable() with this given instance. > > Second, modify vcn_gated to be an array, to track the gating status > for each vcn instance sep

[PATCH 20/29] drm/amdgpu: early_init for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass instance parameter to amdgpu_vcn_early_init(), and perform early init ONLY for the given vcn instance, instead of for all vcn instances. Modify each vcn generation accordingly. Signed-off-by: Boyuan Zhang Acked-by: Sunil Khatri Reviewed-by: Alex Deucher --- drivers/gp

[PATCH 2/7] drm/amdgpu: add dce8 drm_panic support

2024-10-29 Thread Alex Deucher
Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/d

[PATCH 27/29] drm/amdgpu: set funcs for each vcn instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Pass instance parameter to set_dec_ring_funcs(), set_enc_ring_funcs(), and set_irq_funcs(), and perform function setup ONLY for the given vcn instance, instead of for all vcn instances. Modify each vcn generation accordingly. Signed-off-by: Boyuan Zhang Reviewed-by: Christian

Re: [PATCH] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-10-29 Thread Mario Limonciello
On 10/29/2024 18:32, Antonio Quartulli wrote: acpi_evaluate_object() may return AE_NOT_FOUND (failure), which would result in dereferencing buffer.pointer (obj) while being NULL. Bail out also when status is AE_NOT_FOUND with a proper error message. This fixes 1 FORWARD_NULL issue reported by C

RE: [PATCH v2 2/2] drm/amd/pm: add zero RPM stop temperature OD setting support for SMU13

2024-10-29 Thread Feng, Kenneth
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Kenneth Feng -Original Message- From: Wolfgang Müller Sent: Tuesday, October 29, 2024 7:18 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH v2 2/2] drm/amd/pm: add zero RPM stop tempe

[PATCH 09/29] drm/amdgpu: track instances of the same IP block

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Add a new function to count the number of instance of the same IP block in the current ip_block list, then use the returned count value to set the newly defined instance variable in ip_block, to track the instance number of each ip_block. Signed-off-by: Boyuan Zhang Signed-of

Re: [PATCH v2 3/3] drm: remove driver date from struct drm_driver and all drivers

2024-10-29 Thread Jeffrey Hugo
On 10/28/2024 12:51 PM, Jani Nikula wrote: We stopped using the driver initialized date in commit 7fb8af6798e8 ("drm: deprecate driver date") and (eventually) started returning "0" for drm_version ioctl instead. Finish the job, and remove the unused date member from struct drm_driver, its initia

[PATCH 6.1 1/1] Revert "drm/amd/display: Skip Recompute DSC Params if no Stream on Link"

2024-10-29 Thread Fedor Pchelkin
This reverts commit 7c887efda1201110211fed8921a92a713e0b6bcd. It is a duplicate of the change made in 6.1.105 by commit 282f0a482ee6 ("drm/amd/display: Skip Recompute DSC Params if no Stream on Link"). This is a consequence of two "similar" upstream commits existence, one of which has been cherry

[PATCH 0/1] On DRM -> stable process

2024-10-29 Thread Fedor Pchelkin
Hi all, I'm writing as a bystander working with 6.1.y stable branch and possibly lacking some context with the established DRM -> stable patch flow, Cc'ing a large number of people. The commit being reverted from 6.1.y is the one that duplicates the changes already backported to that branch with

Re: [PATCH 0/1] On DRM -> stable process

2024-10-29 Thread Fedor Pchelkin
On Tue, 29. Oct 10:20, Sasha Levin wrote: > On Tue, Oct 29, 2024 at 04:31:40PM +0300, Fedor Pchelkin wrote: > > BTW, a question to the stable-team: what Git magic (3-way-merge?) let the > > duplicate patch be applied successfully? The patch context in stable trees > > was different to that moment s

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 1:05 PM R Sundar wrote: > > On 29/10/24 19:11, Alex Deucher wrote: > > On Sun, Oct 27, 2024 at 10:18 AM R Sundar wrote: > >> > >> Use string choice helpers for better readability. > > > > I personally find this less readable, but if this is the preferred > > method going f

Re: [PATCH 05/29] drm/amd/pm: add inst to dpm_set_powergating_by_smu

2024-10-29 Thread Boyuan Zhang
On 2024-10-28 15:11, Alex Deucher wrote: On Thu, Oct 24, 2024 at 10:36 PM wrote: From: Boyuan Zhang Add an instance parameter to amdgpu_dpm_set_powergating_by_smu() function, and use the instance to call set_powergating_by_smu(). v2: remove duplicated functions. remove for-loop in amdgpu_

Re: [PATCH 09/29] drm/amdgpu: track instances of the same IP block

2024-10-29 Thread Boyuan Zhang
On 2024-10-28 16:05, Alex Deucher wrote: On Mon, Oct 28, 2024 at 3:53 PM Boyuan Zhang wrote: On 2024-10-28 15:27, Alex Deucher wrote: On Thu, Oct 24, 2024 at 10:48 PM wrote: From: Boyuan Zhang Add a new function to count the number of instance of the same IP block in the current ip_bloc

[PATCH v1 6/9] drm/amdgpu: update vcn_v4.0.5 devcoredump on per instance basis

2024-10-29 Thread Sunil Khatri
vcn code is restructured for per instance basis. Each vcn instance is represented by an ip_block and hence a need to update the dump and print functions for each instance as an IP. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 80 - 1 file chan

[PATCH 6/7] drm/amd/display: add clear_tiling support for all DCN families

2024-10-29 Thread Alex Deucher
DCN 1.x - 4.x. Signed-off-by: Alex Deucher --- .../drm/amd/display/dc/hubp/dcn10/dcn10_hubp.c| 15 +++ .../drm/amd/display/dc/hubp/dcn10/dcn10_hubp.h| 2 ++ .../drm/amd/display/dc/hubp/dcn20/dcn20_hubp.c| 15 +++ .../drm/amd/display/dc/hubp/dcn20/dcn20_hubp.h

[PATCH 4/7] drm/amdgpu: add dce11 drm_panic support

2024-10-29 Thread Alex Deucher
Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/d

[PATCH 0/7] Add panic support for all DCE/DCN

2024-10-29 Thread Alex Deucher
This builds on the patches from Lu and Jocelyn to fill in panic support for all DCE/DCN variants and code pathes. Alex Deucher (5): drm/amdgpu: add dce8 drm_panic support drm/amdgpu: add dce10 drm_panic support drm/amdgpu: add dce11 drm_panic support drm/amd/display: add clear_tiling suppo

[PATCH 1/7] drm/amdgpu: add dce6 drm_panic support

2024-10-29 Thread Alex Deucher
From: Lu Yao Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 48 +++ 1 file changed, 48 ins

[PATCH 5/7] drm/amdgpu: Add dcn30 drm_panic support

2024-10-29 Thread Alex Deucher
From: Jocelyn Falempe Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. It should work on all radeon using amdgpu_dm_plane.c, when the framebuffer is linear (like when in a VT). For tiled framebuffer, it will only

[PATCH 7/7] drm/amd/display: add panic support for DCE based IPs

2024-10-29 Thread Alex Deucher
This adds panic support for DCE based IPs. Signed-off-by: Alex Deucher --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 73 --- .../drm/amd/display/dc/dce/dce_mem_input.c| 34 +++-- .../gpu/drm/amd/display/dc/inc/hw/mem_input.h | 2 + 3 files changed, 92 insertions(+)

[PATCH 3/7] drm/amdgpu: add dce10 drm_panic support

2024-10-29 Thread Alex Deucher
Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/d

[PATCH 12/29] drm/amdgpu: power vcn 2_5 by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang For vcn 2_5, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_blo

[PATCH 11/29] drm/amdgpu/vcn: separate gating state by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang vcn gating state should now be based on instance. For example, instance 0 can be gated while instance 1 is ungated, or vice versa. Therefore, change the cur_state to be an array, so that it can track the gating status for each vcn instance now. v2: remove redundant codes in v

[PATCH 04/29] drm/amd/pm: add inst to set_powergating_by_smu

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Add an instance parameter to set_powergating_by_smu() function, and re-write all amd_pm functions accordingly. Then use the instance to call smu_dpm_set_vcn_enable(). v2: remove duplicated functions. remove for-loop in smu_dpm_set_power_gate(), and temporarily move it to to a

[PATCH 14/29] drm/amdgpu: power vcn 4_0 by instance

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang For vcn 4_0, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_blo

[PATCH 01/29] drm/amd/pm: add inst to dpm_set_vcn_enable

2024-10-29 Thread boyuan.zhang
From: Boyuan Zhang Add an instance parameter to the existing function dpm_set_vcn_enable() for future implementation. Re-write all pptable functions accordingly. v2: Remove duplicated dpm_set_vcn_enable() functions in v1. Instead, adding instance parameter to existing functions. Signed-off-by:

[PATCH v2] drm/amdgpu: add userq specific kernel config for fence ioctls

2024-10-29 Thread Arunpravin Paneer Selvam
Keep the user queue fence signal and wait IOCTLs in the kernel config CONFIG_DRM_AMDGPU_NAVI3X_USERQ. v2(Christian): - Remove the userq specific config added for kernel queues fence init function. Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c

Re: [PATCH] drm/amdkfd: Differentiate logging message for driver oversubscription

2024-10-29 Thread Mukul Joshi
On 10/28/2024 5:40 PM, Xiaogang.Chen wrote: > From: Xiaogang Chen > > To allow user better understand the cause triggering runlist oversubscription. > No function change. > > Signed-off-by: Xiaogang Chen xiaogang.c...@amd.com > --- > .../gpu/drm/amd/amdkfd/kfd_packet_manager.c | 55 +++

Re: [PATCH] drm/amdkfd: Differentiate logging message for driver oversubscription

2024-10-29 Thread Chen, Xiaogang
On 10/29/2024 10:01 AM, Mukul Joshi wrote: On 10/28/2024 5:40 PM, Xiaogang.Chen wrote: From: Xiaogang Chen To allow user better understand the cause triggering runlist oversubscription. No function change. Signed-off-by: Xiaogang chenxiaogang.c...@amd.com --- .../gpu/drm/amd/amdkfd/kfd_pa

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-10-29 Thread Alex Deucher
Applied. Thanks. Alex On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: > > Add support for the drm_panic module, which displays a pretty user > friendly message on the screen when a Linux kernel panic occurs. > > Signed-off-by: Lu Yao > --- > Changes in v2: > 1. Drop include "drm_internal.h" > 2.

RE: [PATCH 1/5 V4 1/5] drm/amdgpu: Add sysfs interface for gc reset mask

2024-10-29 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Lijo, -Original Message- From: Lazar, Lijo Sent: Tuesday, October 29, 2024 3:58 PM To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Huang, Tim Subject: Re: [PATCH 1/5 V4 1/5] d

Re: [PATCH] drm/amdgpu: Group gfx sysfs functions

2024-10-29 Thread Lazar, Lijo
On 10/29/2024 12:18 PM, SRINIVASAN SHANMUGAM wrote: > > On 10/29/2024 12:07 PM, SRINIVASAN SHANMUGAM wrote: >> >> >> On 10/29/2024 10:57 AM, Lijo Lazar wrote: >>> Make amdgpu_gfx_sysfs_init/fini functions as common entry points for all >>> gfx related sysfs nodes. >>> >>> Signed-off-by: Lijo La

Re: [PATCH 1/5 V4 1/5] drm/amdgpu: Add sysfs interface for gc reset mask

2024-10-29 Thread Lazar, Lijo
On 10/29/2024 12:44 PM, jesse.zh...@amd.com wrote: > From: "jesse.zh...@amd.com" > > Add two sysfs interfaces for gfx and compute: > gfx_reset_mask > compute_reset_mask > > These interfaces are read-only and show the resets supported by the IP. > For example, full adapter reset (mode1/mode2/B

RE: [PATCH 1/5 V4 1/5] drm/amdgpu: Add sysfs interface for gc reset mask

2024-10-29 Thread Huang, Tim
[AMD Official Use Only - AMD Internal Distribution Only] This Series is, Reviewed-by: Tim Huang > -Original Message- > From: jesse.zh...@amd.com > Sent: Tuesday, October 29, 2024 3:15 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Huang, Tim ; Z

Re: [PATCH 23/29] drm/amdgpu: hw_init for each vcn instance

2024-10-29 Thread Khatri, Sunil
Acked-by: Sunil Khatri On 10/25/2024 8:05 AM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Pass instance parameter to amdgpu_vcn_hw_init(), and perform hw init ONLY for the given vcn instance, instead of for all vcn instances. Modify each vcn generation accordingly. Signed-off-by: Boyuan Z

[PATCH 1/5 V4 1/5] drm/amdgpu: Add sysfs interface for gc reset mask

2024-10-29 Thread jesse.zh...@amd.com
From: "jesse.zh...@amd.com" Add two sysfs interfaces for gfx and compute: gfx_reset_mask compute_reset_mask These interfaces are read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. V2: the sysfs node

[PATCH 2/5 V4] drm/amdgpu: Add sysfs interface for sdma reset mask

2024-10-29 Thread jesse.zh...@amd.com
From: "jesse.zh...@amd.com" Add the sysfs interface for sdma: sdma_reset_mask The interface is read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. V2: the sysfs node returns a text string instead of

Re: [PATCH v8 2/4] drm/doc: Document device wedged event

2024-10-29 Thread Christian König
Am 25.10.24 um 10:48 schrieb Raag Jadav: Add documentation for device wedged event in a new 'Device wedging' chapter. The describes basic definitions and consumer expectations along with an example. v8: Improve documentation (Christian, Rodrigo) Signed-off-by: Raag Jadav --- Documentation/gp

  1   2   >