Re: [PATCH v2 1/5] drm/amdgpu: update the handle ptr in early_init

2024-09-30 Thread Christian König
Am 27.09.24 um 17:00 schrieb Sunil Khatri: update the handle ptr to amdgpu_ip_block ptr for all functions pointers on early_init. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 24 +-- dr

Re: [PATCH v2 1/5] drm/amdgpu: update the handle ptr in early_init

2024-09-30 Thread Khatri, Sunil
Sure Christian. Changes related to dummy functions i was planning to remove in a separate patch as there are many empty functions. Also related to using the local variable ip_block also i am planning to take in one separate commit as it impacts all the functions where these changes are being d

Re: [PATCH v2 2/5] drm/amdgpu: update the handle ptr in late_init

2024-09-30 Thread Christian König
Am 27.09.24 um 17:00 schrieb Sunil Khatri: Update the ptr handle to amdgpu_ip_block ptr in all the functions of late_init function ptr. Signed-off-by: Sunil Khatri Apart from a few minor comments on patch #1 the whole series is Reviewed-by: Christian König Regards, Christian. --- driv

RE: [PATCH v2] drm/amdkfd: Fix an eviction fence leak

2024-09-30 Thread Yu, Lang
[Public] Network issue. Please ignore this duplicate one. : ) >-Original Message- >From: amd-gfx On Behalf Of Lang Yu >Sent: Monday, September 30, 2024 2:38 PM >To: amd-gfx@lists.freedesktop.org >Cc: Kuehling, Felix ; Yu, Lang ; >Kuehling, Felix >Subject: [PATCH v2] drm/amdkfd: Fix an e

Re: AMD Radeon out of memory causes system instability.

2024-09-30 Thread James Lawrence
No worries Christian! I know everyone puts a lot of work in and stuff gets lost. I was mainly just firing the information into the ether in the hopes someone sees it and was like 'oh yeah' ;) I was running kernels 6.9-6.10. I havent hit it w/ 6.11 but thats likely because I havent been using my

Re: [PATCH v4 1/6] drm: add DRM_SET_CLIENT_NAME ioctl

2024-09-30 Thread Dmitry Osipenko
On 9/27/24 11:48, Pierre-Eric Pelloux-Prayer wrote: > Giving the opportunity to userspace to associate a free-form > name with a drm_file struct is helpful for tracking and debugging. > > This is similar to the existing DMA_BUF_SET_NAME ioctl. > > Access to client_name is protected by a mutex, an

[PATCH] drm/radeon/r600_cs: Fix possible int overflow in r600_packet3_check()

2024-09-30 Thread Igor Artemiev
It is possible, although unlikely, that an integer overflow will occur when the result of radeon_get_ib_value() is shifted to the left. Avoid it by casting one of the operands to larger data type (u64). Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Signe

Re: [PATCH v4 0/6] DRM_SET_CLIENT_NAME ioctl

2024-09-30 Thread Dmitry Osipenko
On 9/27/24 12:16, Jani Nikula wrote: > On Fri, 27 Sep 2024, Christian König wrote: >> Am 27.09.24 um 10:48 schrieb Pierre-Eric Pelloux-Prayer: >>> v4 changelog: >>> * DRM_SET_NAME -> DRM_SET_CLIENT_NAME (Dmitry) >>> * reject names that would mess up with formatting (Sima), >>>and use a stricte

[PATCH v4] docs/gpu: ci: update flake tests requirements

2024-09-30 Thread Vignesh Raman
Update the documentation to specify linking to a relevant GitLab issue or email report for each new flake entry. Added specific GitLab issue urls for amdgpu, i915, msm and xe driver. Acked-by: Maxime Ripard Acked-by: Rodrigo Vivi #intel and xe Acked-by: Abhinav Kumar # msm Acked-by: Dmitry Bary

[PATCH] drm/amd/powerplay: Delete unused function and maths library

2024-09-30 Thread linux
From: "Dr. David Alan Gilbert" We start with the function 'atomctrl_calculate_voltage_evv_on_sclk' which has been unused since 2016's commit e805ed83ba1c ("drm/amd/powerplay: delete useless files.") Remove it. It was the last user of the struct ATOM_ASIC_PROFILING_INFO_V3_4 remove it. It was a

[PATCH] Revert "drm/radeon: use GEM references instead of TTMs"

2024-09-30 Thread Huacai Chen
This reverts commit fd69ef05029f9beb7b031ef96e7a36970806a670. The original patch causes NULL pointer references: [ 21.620856] CPU 3 Unable to handle kernel paging request at virtual address , era == 94bf61d8, ra == 94bf61d4 [ 21.717958] Oops[#1]: [ 21.803205

Re: [PATCH v3] docs/gpu: ci: update flake tests requirements

2024-09-30 Thread Vignesh Raman
Hi Rodrigo, On 27/09/24 20:05, Rodrigo Vivi wrote: On Fri, Sep 27, 2024 at 10:54:14AM +0530, Vignesh Raman wrote: Update the documentation to specify linking to a relevant GitLab issue or email report for each new flake entry. Added specific GitLab issue urls for i915, msm and amdgpu driver. A

Re: [PATCH v3 08/09] drm/amdgpu: add vm root BO lock before accessing the vm

2024-09-30 Thread Christian König
Am 30.09.24 um 13:59 schrieb Arunpravin Paneer Selvam: Add a vm root BO lock before accessing the userqueue VM. v1:(Christian) - Keep the VM locked until you are done with the mapping. - Grab a temporary BO reference, drop the VM lock and acquire the BO. When you are done with ever

Re: [PATCH 00/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > DRM's aperture helpers are merely wrappers around the respective > helpers in drivers/video/. The DRM interface existed first, but was > later generalized for use with fbdev and a few other graphics-related > places in the kernel. It is time to remove th

Re: [PATCH 3/8] drm/sched: Always increment correct scheduler score

2024-09-30 Thread Christian König
Am 30.09.24 um 15:22 schrieb Tvrtko Ursulin: On 30/09/2024 14:07, Christian König wrote: Am 30.09.24 um 15:01 schrieb Tvrtko Ursulin: On 13/09/2024 17:05, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Entities run queue can change during drm_sched_entity_push_job() so make sure to update th

[PATCH 24/28] drm/vc4: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Maxime Ripard Cc: Dave Stevenson Cc: Raspberry Pi Kernel Maintenance --- drivers/gpu/drm

[PATCH 00/35] Reorganize kerneldoc parameter names

2024-09-30 Thread Julia Lawall
Reorganize kerneldoc parameter names to match the parameter order in the function header. The misordered cases were identified using the following Coccinelle semantic patch: // @initialize:ocaml@ @@ let parse_doc l = let pieces = List.map String.trim (String.split_on_char '*' l) in let l =

Re: [PATCH v4 1/6] drm: add DRM_SET_CLIENT_NAME ioctl

2024-09-30 Thread Tvrtko Ursulin
On 27/09/2024 09:48, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl. Access to client_name is protected by a mutex, and the

[PATCH 25/35] drm/amd/display: Reorganize kerneldoc parameter names

2024-09-30 Thread Julia Lawall
Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall --- drivers/gpu/drm/amd/display/dc/core/dc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/di

Re: [PATCH v4 6/6] drm/amdgpu: use drm_file::name in task_info::process_desc

2024-09-30 Thread Tvrtko Ursulin
On 27/09/2024 09:48, Pierre-Eric Pelloux-Prayer wrote: If a drm_file name is set append it to the process name. This information is useful with the virtio/native-context driver: this allows the guest applications identifier to visible in amdgpu's output. The output in amdgpu_vm_info/amdgpu_ge

linux-6.12-rc1/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c:653: Possible &/&& mixup ?

2024-09-30 Thread David Binderman
Hello there, Static analyser cppcheck says: linux-6.12-rc1/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c:653:19: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition] Source code is if (!surf_linear & (log2_dpte_req

Re: [PATCH 3/8] drm/sched: Always increment correct scheduler score

2024-09-30 Thread Tvrtko Ursulin
On 13/09/2024 17:05, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Entities run queue can change during drm_sched_entity_push_job() so make sure to update the score consistently. Signed-off-by: Tvrtko Ursulin Fixes: d41a39dda140 ("drm/scheduler: improve job distribution with multiple queues")

[PATCH 29/35] drivers/gpu/drm: Reorganize kerneldoc parameter names

2024-09-30 Thread Julia Lawall
Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |2 +- drivers/gpu/drm/radeon/radeon_ib.c |2 +- 2 files changed, 2 insertions(+),

Re: [PATCH 29/35] drivers/gpu/drm: Reorganize kerneldoc parameter names

2024-09-30 Thread Julia Lawall
On Mon, 30 Sep 2024, Christian König wrote: > Am 30.09.24 um 13:21 schrieb Julia Lawall: > > Reorganize kerneldoc parameter names to match the parameter > > order in the function header. > > Please split that up by driver, apart from that looks good to me. Thanks for the feedback. I will wait

Re: [PATCH 3/8] drm/sched: Always increment correct scheduler score

2024-09-30 Thread Tvrtko Ursulin
On 30/09/2024 14:07, Christian König wrote: Am 30.09.24 um 15:01 schrieb Tvrtko Ursulin: On 13/09/2024 17:05, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Entities run queue can change during drm_sched_entity_push_job() so make sure to update the score consistently. Signed-off-by: Tvrtko Ur

Re: [PATCH 00/12] update the handle ptr for reset of the functions

2024-09-30 Thread Christian König
Feel free to put my Reviewed-by: Christian König on the full series. There are a bunch of dummy functions we can probably remove, but that can be separate patches as well. Thanks, Christian. Am 30.09.24 um 16:30 schrieb Sunil Khatri: *** BLURB HERE *** Sunil Khatri (12): drm/amdgpu: re

Re: [PATCH 25/35] drm/amd/display: Reorganize kerneldoc parameter names

2024-09-30 Thread Harry Wentland
On 2024-09-30 07:21, Julia Lawall wrote: > Reorganize kerneldoc parameter names to match the parameter > order in the function header. > > Problems identified using Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/display/dc/core/dc.c |2 +- > 1 file changed, 1

RE: [PATCH 00/13] DC Patches Sept 23, 2024

2024-09-30 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on 4 systems, two dGPU and two APU based, and tested across multiple display and connection types. APU * Single Display eDP -> 1080p 60hz, 2560x1600 120hz, 1920x1200 165hz * Single Display DP -> 4k144hz, 4k240hz * Multi

Re: [PATCH] drm/amd/powerplay: Delete unused function and maths library

2024-09-30 Thread Alex Deucher
On Sun, Sep 29, 2024 at 5:28 PM wrote: > > From: "Dr. David Alan Gilbert" > > We start with the function 'atomctrl_calculate_voltage_evv_on_sclk' > which has been unused since 2016's commit > e805ed83ba1c ("drm/amd/powerplay: delete useless files.") > > Remove it. > > It was the last user of the

Re: [PATCH] drm/radeon/r600_cs: Fix possible int overflow in r600_packet3_check()

2024-09-30 Thread Alex Deucher
On Sun, Sep 29, 2024 at 8:08 PM Igor Artemiev wrote: > > It is possible, although unlikely, that an integer overflow will occur > when the result of radeon_get_ib_value() is shifted to the left. > > Avoid it by casting one of the operands to larger data type (u64). > > Found by Linux Verification

Re: [PATCH 25/35] drm/amd/display: Reorganize kerneldoc parameter names

2024-09-30 Thread Alex Deucher
Applied. Thanks! On Mon, Sep 30, 2024 at 10:49 AM Harry Wentland wrote: > > > > On 2024-09-30 07:21, Julia Lawall wrote: > > Reorganize kerneldoc parameter names to match the parameter > > order in the function header. > > > > Problems identified using Coccinelle. > > > > Signed-off-by: Julia La

Re: [PATCH v1 7/9] drm/amd/pm: add sysfs attribute access wrappers

2024-09-30 Thread Pierre-Eric Pelloux-Prayer
Le 25/09/2024 à 09:54, Pierre-Eric Pelloux-Prayer a écrit : All attributes do the same thing wrt to runtime power management, so we can consolidate the handling in 2 wrappers. For some setters this will change the behavior slightly, as rpm is now done before arguments validation - so the devi

Re: [PATCH 5/5] drm: Add client-lib module

2024-09-30 Thread Jocelyn Falempe
On 27/09/2024 16:37, Thomas Zimmermann wrote: Add drm_client_lib.ko to contain most of the client code. Move the existing client for fbdev emulation into the new module. Protect the new module behind CONFIG_DRM_CLIENT. The Kconfig rules separate the DRM drivers from the DRM clients. A driver can

Re: [PATCH 5/5] drm: Add client-lib module

2024-09-30 Thread Jocelyn Falempe
On 30/09/2024 13:55, Jocelyn Falempe wrote: On 27/09/2024 16:37, Thomas Zimmermann wrote: Add drm_client_lib.ko to contain most of the client code. Move the existing client for fbdev emulation into the new module. Protect the new module behind CONFIG_DRM_CLIENT. The Kconfig rules separate the D

Re: [PATCH v3 01/09] drm/amdgpu: Implement userqueue signal/wait IOCTL

2024-09-30 Thread Christian König
Am 30.09.24 um 13:58 schrieb Arunpravin Paneer Selvam: This patch introduces new IOCTL for userqueue secure semaphore. The signal IOCTL called from userspace application creates a drm syncobj and array of bo GEM handles and passed in as parameter to the driver to install the fence into it. The

Re: AMD drm patch workflow is broken for stable trees

2024-09-30 Thread Alex Deucher
Resending now that rc1 is out. These should be ignored for stable. 8151a6c13111 drm/amd/display: Skip Recompute DSC Params if no Stream on Link fbfb5f034225 drm/amdgpu: fix contiguous handling for IB parsing v2 ec0d7abbb0d4 drm/amd/display: Fix Potential Null Dereference 332315885d3c drm/amd/disp

Re: [PATCH v3 09/09] drm/amdgpu: Add separate array of read and write for BO handles

2024-09-30 Thread Christian König
Am 30.09.24 um 13:59 schrieb Arunpravin Paneer Selvam: Drop AMDGPU_USERQ_BO_WRITE as this should not be a global option of the IOCTL, It should be option per buffer. Hence adding separate array for read and write BO handles. Signed-off-by: Arunpravin Paneer Selvam Still some potential to de-d

Re: NULL pointer dereference with kernel 6.12.0-rc1 and ARUBA GPU

2024-09-30 Thread Christian König
I've been running into the same issue as well. Going to take a look. Christian. Am 30.09.24 um 17:25 schrieb Arthur Marsh: [ 13.069630] [drm] radeon kernel modesetting enabled. [ 13.069681] radeon :00:01.0: vgaarb: deactivate vga console [ 13.070435] Console: switching to colour dummy

[PATCH v3 02/09] drm/amdgpu: screen freeze and userq driver crash

2024-09-30 Thread Arunpravin Paneer Selvam
Screen freeze and userq fence driver crash while playing Xonotic v2: (Christian) - There is change that fence might signal in between testing and grabbing the lock. Hence we can move the lock above the if..else check and use the dma_fence_is_signaled_locked(). Signed-off-by: Arunp

[PATCH v3 04/09] drm/amdgpu: Enable userq fence interrupt support

2024-09-30 Thread Arunpravin Paneer Selvam
Add support to handle the userqueue protected fence signal hardware interrupt. Create a xarray which maps the doorbell index to the fence driver address. This would help to retrieve the fence driver information when an userq fence interrupt is triggered. Firmware sends the doorbell offset value an

[PATCH v3 01/09] drm/amdgpu: Implement userqueue signal/wait IOCTL

2024-09-30 Thread Arunpravin Paneer Selvam
This patch introduces new IOCTL for userqueue secure semaphore. The signal IOCTL called from userspace application creates a drm syncobj and array of bo GEM handles and passed in as parameter to the driver to install the fence into it. The wait IOCTL gets an array of drm syncobjs, finds the fence

[PATCH v3 06/09] drm/amdgpu: Few optimization and fixes for userq fence driver

2024-09-30 Thread Arunpravin Paneer Selvam
Few optimization and fixes for userq fence driver. v1:(Christian): - Remove unnecessary comments. - In drm_exec_init call give num_bo_handles as last parameter it would making allocation of the array more efficient - Handle return value of __xa_store() and improve the error handling of

[PATCH v3 07/09] drm/amdgpu: Add the missing error handling for xa_store() call

2024-09-30 Thread Arunpravin Paneer Selvam
Add the missing error handling for xa_store() call in the function amdgpu_userq_fence_driver_alloc(). Signed-off-by: Arunpravin Paneer Selvam Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v3 08/09] drm/amdgpu: add vm root BO lock before accessing the vm

2024-09-30 Thread Arunpravin Paneer Selvam
Add a vm root BO lock before accessing the userqueue VM. v1:(Christian) - Keep the VM locked until you are done with the mapping. - Grab a temporary BO reference, drop the VM lock and acquire the BO. When you are done with everything just drop the BO lock and then the temporary BO

[PATCH v3 03/09] drm/amdgpu: Add wait IOCTL timeline syncobj support

2024-09-30 Thread Arunpravin Paneer Selvam
Add user fence wait IOCTL timeline syncobj support. v2:(Christian) - handle dma_fence_wait() return value. - shorten the variable name syncobj_timeline_points a bit. - move num_points up to avoid padding issues. v3:(Christian) - Handle timeline drm_syncobj_find_fence() call error hand

[PATCH v3 05/09] drm/amdgpu: Remove the MES self test

2024-09-30 Thread Arunpravin Paneer Selvam
Remove MES self test as this conflicts the userqueue fence interrupts. v2:(Christian) - remove the amdgpu_mes_self_test() function and any now unused code. Signed-off-by: Arunpravin Paneer Selvam Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 - drivers/gpu/dr

[PATCH v3 09/09] drm/amdgpu: Add separate array of read and write for BO handles

2024-09-30 Thread Arunpravin Paneer Selvam
Drop AMDGPU_USERQ_BO_WRITE as this should not be a global option of the IOCTL, It should be option per buffer. Hence adding separate array for read and write BO handles. Signed-off-by: Arunpravin Paneer Selvam --- .../gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 238 +- include/ua

[PATCH 05/28] drm/hisilicon/hibmc: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Xinliang Liu Cc: Tian Tao Cc: Xinwei Kong Cc: Sumit Semwal Cc: Yongqin Liu Cc: John Stu

[PATCH 28/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Thomas Zimmermann
The DRM aperture helpers are wrappers around video helpers from . There are no callers of these functions. Remove them entirely. Signed-off-by: Thomas Zimmermann Cc: Jonathan Corbet --- Documentation/gpu/drm-internals.rst | 12 -- MAINTAINERS | 2 - drivers/gpu/drm/Ma

[PATCH 03/28] drm/armada: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 4 ++-- 1 file changed, 2 insertion

[PATCH 21/28] drm/bochs: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Gerd Hoffmann --- drivers/gpu/drm/tiny/bochs.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH 04/28] drm/ast: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 4 ++-- 1 file change

[PATCH 06/12] drm/amdgpu: update the handle ptr in soft_reset

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of soft_reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 2 +- driver

[PATCH 00/12] update the handle ptr for reset of the functions

2024-09-30 Thread Sunil Khatri
*** BLURB HERE *** Sunil Khatri (12): drm/amdgpu: remove the dummy fn acp_early_init drm/amdgpu: update the handle ptr in late_fini drm/amdgpu: update the handle ptr in prepare_suspend drm/amdgpu: update the handle ptr in check_soft_reset drm/amdgpu: update the handle ptr in pre_soft_res

[PATCH 12/12] drm/amdgpu: update the handle ptr in hw_fini

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of hw_fini. Also update the ip_block ptr where ever needed as there were cyclic dependency of hw_fini on suspend and some followed clean up. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 4

[PATCH 07/12] drm/amdgpu: update the handle ptr in post_soft_reset

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of post_soft_reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 5 +++-- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ++-- drivers/gpu/drm/a

[PATCH 02/12] drm/amdgpu: update the handle ptr in late_fini

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of late_fini. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/include/amd_shared.h | 2 +- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 4 ++-- drivers/

[PATCH 10/12] drm/amdgpu: update the handle ptr in resume

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of resume. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/aldebaran.c| 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 8

[PATCH 08/12] drm/amdgpu: update the handle ptr in wait_for_idle

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of wait_for_idle. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 2 +- driver

[PATCH 01/12] drm/amdgpu: remove the dummy fn acp_early_init

2024-09-30 Thread Sunil Khatri
acp_early_init is a dummy function and is not being used and hence removed. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 04/12] drm/amdgpu: update the handle ptr in check_soft_reset

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of check_soft_reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 3 ++- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 4 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 4 +

[PATCH 09/12] drm/amdgpu: update the handle ptr in suspend

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of suspend. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/aldebaran.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 4 ++-- drive

[PATCH 05/12] drm/amdgpu: update the handle ptr in pre_soft_reset

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of pre_soft_reset. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 4 ++-- drivers/gpu/drm/amd

[PATCH 11/12] drm/amdgpu: update the handle ptr in hw_init

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of hw_init. Also update the ip_block ptr where ever needed as there were cyclic dependency of hw_init on resume. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 10 ++ drivers/gpu/dr

[PATCH 03/12] drm/amdgpu: update the handle ptr in prepare_suspend

2024-09-30 Thread Sunil Khatri
Update the *handle to amdgpu_ip_block ptr for all functions pointers of prepare_suspend. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 4 ++-- drivers/gpu/drm/am

Re: [PATCH 01/12] drm/amdgpu: remove the dummy fn acp_early_init

2024-09-30 Thread Christian König
Am 30.09.24 um 16:30 schrieb Sunil Khatri: acp_early_init is a dummy function and is not being used and hence removed. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff -

Re: [PATCH 29/35] drivers/gpu/drm: Reorganize kerneldoc parameter names

2024-09-30 Thread Christian König
Am 30.09.24 um 13:21 schrieb Julia Lawall: Reorganize kerneldoc parameter names to match the parameter order in the function header. Please split that up by driver, apart from that looks good to me. Christian. Problems identified using Coccinelle. Signed-off-by: Julia Lawall --- driver

Re: [PATCH 3/5] drm: Move client-device functions in to drm_client_dev.c

2024-09-30 Thread Jocelyn Falempe
On 27/09/2024 16:37, Thomas Zimmermann wrote: A number of DRM-client functions serve as entry points from device operations to client code. Move them info a separate file, so that the other client functions can be moved into a different module. Thanks, I'm not sure I can review this, but it lo

Re: [PATCH 0/5] drm: Introduce DRM client library

2024-09-30 Thread Jocelyn Falempe
On 27/09/2024 16:37, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the common client code. It's designed

Re: [PATCH 3/8] drm/sched: Always increment correct scheduler score

2024-09-30 Thread Christian König
Am 30.09.24 um 15:01 schrieb Tvrtko Ursulin: On 13/09/2024 17:05, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Entities run queue can change during drm_sched_entity_push_job() so make sure to update the score consistently. Signed-off-by: Tvrtko Ursulin Fixes: d41a39dda140 ("drm/scheduler: imp

Re: [PATCH 4/5] drm: Select fbdev helpers for modules that require them

2024-09-30 Thread Jocelyn Falempe
On 27/09/2024 16:37, Thomas Zimmermann wrote: Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann

RE: [PATCH] drm/amdgpu: Fix logic to determine TOS reload

2024-09-30 Thread Bhardwaj, Rajneesh
[Public] Looks good to me. Acked-by: Rajneesh Bhardwaj -Original Message- From: Lazar, Lijo Sent: Monday, September 30, 2024 8:21 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Bhardwaj, Rajneesh ; Xu, Feifei Subject: [PATCH] drm/amdgpu: Fix logic to d

Re: [PATCH 09/28] drm/meson: Use video aperture helpers

2024-09-30 Thread Neil Armstrong
On 30/09/2024 15:03, Thomas Zimmermann wrote: DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome

Re: [PATCH v3 03/09] drm/amdgpu: Add wait IOCTL timeline syncobj support

2024-09-30 Thread Christian König
Am 30.09.24 um 13:59 schrieb Arunpravin Paneer Selvam: Add user fence wait IOCTL timeline syncobj support. v2:(Christian) - handle dma_fence_wait() return value. - shorten the variable name syncobj_timeline_points a bit. - move num_points up to avoid padding issues. v3:(Christian) -

[PATCH] drm/amdgpu: Fix logic to determine TOS reload

2024-09-30 Thread Lijo Lazar
Avoid comparing TOS version on APUs. On APUs driver doesn't take care of TOS load. Fixes: 2edc5ecbf1a9 ("drm/amdgpu: Add interface for TOS reload cases") Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

Re: [PATCH 0/5] drm: Introduce DRM client library

2024-09-30 Thread Thomas Zimmermann
Hi Am 30.09.24 um 13:46 schrieb Jocelyn Falempe: On 27/09/2024 16:37, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko st

[PATCH 11/28] drm/msm: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: Marijn Suijten ---

[PATCH 13/28] drm/ofdrm: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ofdrm.c | 4 ++-- 1 file changed, 2 inse

[PATCH 00/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture helpers are merely wrappers around the respective helpers in drivers/video/. The DRM interface existed first, but was later generalized for use with fbdev and a few other graphics-related places in the kernel. It is time to remove the DRM wrappers and call the video helpers directly.

[PATCH 01/28] drm/amdgpu: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan --- drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH 06/28] drm/hyperv-drm: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Deepak Rawat --- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 4 ++-- 1 file changed, 2 inser

[PATCH 14/28] drm/qxl: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.c | 4 ++-- 1 file changed,

[PATCH 09/28] drm/meson: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome Brunet Cc: Martin Blumenstingl --- drivers/g

[PATCH 07/28] drm/i915: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin --- drivers/gpu/drm

[PATCH 17/28] drm/simpledrm: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/tiny/simpledrm.c | 8 +--- 1 file changed

[PATCH 22/28] drm/cirrus: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Gerd Hoffmann --- drivers/gpu/drm/tiny/cirrus.c | 4 ++-- 1 file changed,

[PATCH 02/28] drm/arm/hdlcd: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Liviu Dudau --- drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH 10/28] drm/mgag200: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.c | 4 ++-- 1 fil

[PATCH 23/28] drm/vboxvideo: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 5 +++-- 1 file changed, 3 insert

[PATCH 08/28] drm/loongson: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Sui Jingfeng --- drivers/gpu/drm/loongson/lsdc_drv.c | 8 1 file changed, 4 inser

[PATCH 15/28] drm/radeon: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan --- drivers/gpu/drm/radeon/radeon_drv.

[PATCH 19/28] drm/sun4i: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Jernej Skrabec Cc: Samuel Holland --- drivers/gpu/dr

[PATCH 16/28] drm/rockchip: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_d

[PATCH 20/28] drm/tegra: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Thierry Reding Cc: Mikko Perttunen Cc: Jonathan Hunter --- drivers/gpu/drm/tegra/drm.c |

[PATCH 18/28] drm/stm: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Yannick Fertre Cc: Raphael Gallais-Pou Cc: Philippe Cornu Cc: Maxime Coquelin Cc: Alexan

[PATCH 12/28] drm/nouveau: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_drm

[PATCH 25/28] drm/virtgpu: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: David Airlie Cc: Gerd Hoffmann Cc: Gurchetan Singh Cc: Chia-I Wu --- drivers/gpu/drm/vi

[PATCH 26/28] drm/vmwgfx: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Zack Rusin Cc: Broadcom internal kernel review list --- drivers/gpu/drm/vmwgfx/vmwgfx_drv

[PATCH 27/28] drm/xe: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Lucas De Marchi Cc: "Thomas Hellström" Cc: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_device

RE: [PATCH 28/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of Thomas > Zimmermann > Sent: Monday, September 30, 2024 9:03 AM > To: javi...@redhat.com; airl...@gmail.com; sim...@ffwll.ch; > maarten.lankho...@linux.intel.com; mrip...@kernel.org > Cc: dri-de...@lists.freedesktop.org; amd-gfx@li

  1   2   >