Re: [PATCH 2/2] drm/amdgpu/vcn3.0: remove extra asic type check

2020-07-24 Thread Christian König
Acked-by: Christian König for both. Am 23.07.20 um 21:28 schrieb Liu, Leo: These 2 patches are: Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of James Zhu Sent: July 23, 2020 12:10 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH 2/2] drm/amdgpu

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Christian König
Am 24.07.20 um 00:58 schrieb Mazin Rezk: On Thursday, July 23, 2020 6:32 PM, Kees Cook wrote: On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: When amdgpu_dm_atomic_commit_tail is running in the workqueue, drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is

Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param `ppfeaturemask` to hexint

2020-07-24 Thread Christian König
Am 23.07.20 um 15:44 schrieb Paul Menzel: Dear Linus, dear Christian, Am 03.07.20 um 17:29 schrieb Christian König: Am 03.07.20 um 16:29 schrieb Paul Menzel: The newly added hexint helper is more convenient for bitmasks. Before: $ more /sys/module/amdgpu/parameters/ppfeaturemask 4

RE: [PATCH] drm/amd/powerplay: revise the outputs layout of amdgpu_pm_info debugfs

2020-07-24 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Ping.. -Original Message- From: Quan, Evan Sent: Tuesday, July 14, 2020 3:27 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/powerplay: revise the outputs layout of amdgpu_pm_info de

[PATCH] drm/amdgpu: fix PSP autoload twice in FLR

2020-07-24 Thread Liu ChengZhe
the block->status.hw = false assignment will overwrite PSP's previous hw status, which will cause PSP execute resume operation after hw init. Signed-off-by: Liu ChengZhe --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers

RE: [PATCH] drm/amd/powerplay: update driver if file for sienna_cichlid

2020-07-24 Thread Chen, Jiansong (Simon)
[AMD Official Use Only - Internal Distribution Only] See my comments below. -Original Message- From: Gao, Likun Sent: Friday, July 24, 2020 5:39 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth ; Chen, Jiansong (Simon) ; Gao, Likun Subject: [PATCH] drm/amd/power

[PATCH][next] drm/amdgpu: fix spelling mistake "Falied" -> "Failed"

2020-07-24 Thread Colin King
From: Colin Ian King There is a spelling mistake in a DRM_ERROR error message. Fix it. Signed-off-by: Colin Ian King --- Can folk please use checkpatch, it should catch these errors. --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Paul Menzel
Dear Kees, Am 24.07.20 um 00:32 schrieb Kees Cook: On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: When amdgpu_dm_atomic_commit_tail is running in the workqueue, drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is running, causing a race condition where state

Re: [PATCH] drm/amd/powerplay: revise the outputs layout of amdgpu_pm_info debugfs

2020-07-24 Thread Alex Deucher
On Fri, Jul 24, 2020 at 4:43 AM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Ping.. Whoops, missed this one. Reviewed-by: Alex Deucher > > -Original Message- > From: Quan, Evan > Sent: Tuesday, July 14, 2020 3:27 PM > To: amd-gfx@lists.freedesktop.org

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Kees Cook
On Fri, Jul 24, 2020 at 09:45:18AM +0200, Paul Menzel wrote: > Am 24.07.20 um 00:32 schrieb Kees Cook: > > On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: > As Linux 5.8-rc7 is going to be released this Sunday, I wonder, if commit > 3202fa62f ("slub: relocate freelist pointer to middle

Re:

2020-07-24 Thread Alex Deucher
On Wed, Jul 22, 2020 at 3:57 AM Mauro Rossi wrote: > > Hello, > re-sending and copying full DL > > On Wed, Jul 22, 2020 at 4:51 AM Alex Deucher wrote: >> >> On Mon, Jul 20, 2020 at 6:00 AM Mauro Rossi wrote: >> > >> > Hi Christian, >> > >> > On Mon, Jul 20, 2020 at 11:00 AM Christian König >> >

Re: [PATCH v3 3/3] drm/amdgpu: Change type of module param `ppfeaturemask` to hexint

2020-07-24 Thread Linus Torvalds
On Fri, Jul 24, 2020 at 12:54 AM Christian König wrote: > > But since you already addressed Linus comments and it looks rather clean > I think I can just push it to drm-misc-next on Monday if nobody objects > over the weekend. Yeah, no objections from me. Add a note to it to the pull request, so

[pull] amdgpu drm-next-5.9

2020-07-24 Thread Alex Deucher
Hi Dave, Daniel, Last few bits 5.9. Fixes and cleanups. The following changes since commit 6e14adea0ac3037d923a9591d1a094c115d7947c: drm/amd/amdkfd: Fix large framesize for kfd_smi_ev_read() (2020-07-15 13:27:34 -0400) are available in the Git repository at: git://people.freedesktop.org/

[PATCH 02/15] drm/amd/display: Rename bytes_pp to the correct bits_pp

2020-07-24 Thread Eryk Brol
[Why] Struct dcn_dsc_state is used for reading current state and parameters of DSC on a pipe, the target rate parameter uses bytes per pixel even though its reading BITS_PER_PIXEL register. [How] Changing it to Bits Per Pixel for consistency. Signed-off-by: Eryk Brol Signed-off-by: Mikita Lipski

[PATCH 03/15] drm/amd/display: Fix naming of DSC Debugfs entry

2020-07-24 Thread Eryk Brol
[why] Fix naming and return bits rather than bytes per pixel for naming consistency. Because registers return Bytes per pixel, but DSC Config structure is expecting bits per pixel as input. So when returning the value convert from bytes into bits. Signed-off-by: Eryk Brol Signed-off-by: Mikita Li

[PATCH 00/15] DC Patches July 29, 2020

2020-07-24 Thread Eryk Brol
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fixes in DP Compliance, ABM, and others; * Enhancements in DSC; * Improvements in FSFT, DCN, and others. Alvin Lee (1): drm/amd/display: Don't compare dppclk before updating DTO Anthony Koo (1): drm/amd/disp

[PATCH 05/15] drm/amd/display: Check lane status again after link training done

2020-07-24 Thread Eryk Brol
From: Martin Tsai [Why] Some monitors could suffer symbol unlock but cannot send HPD IRQ to notic source device to handle link loss. This makes monitor stuck in abnormal status and causes black screen. [How] According to the suggestion from scalar vendor, to check lane status again after link tr

[PATCH 01/15] drm/amd/display: Clean up global sync param retrieval

2020-07-24 Thread Eryk Brol
From: Dmytro Laktyushkin [Why] This change replaces older looping code in favor of these functions. [How] There are built in functions for extracting global sync params during mode validation now. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Eryk Brol --- .../drm/

[PATCH 04/15] drm/amd/display: Don't compare dppclk before updating DTO

2020-07-24 Thread Eryk Brol
From: Alvin Lee [Why] In dcn3_update_clocks there are situations where dppclk is not lowered (i.e. stays the same), but DTO still needs to be increased before we program pipe frontend (i.e. in prepare_bandwidth). If we don't program the new DTO value before we program the pipe, we will underflow

[PATCH 09/15] drm/amd/display: DSC Clock enable debugfs write entry

2020-07-24 Thread Eryk Brol
[Why] Need a mechanism to force enable DSC on any connector [How] Debugfs entry overwrites newly added connector's dsc preffered settings structure and sets dsc_clock_en flag on it. During the attomic commit, depending if connector is SST or MST, we will enable DSC manually by overwriting stream's

[PATCH 11/15] drm/amd/display: dchubbub p-state warning during surface planes switch

2020-07-24 Thread Eryk Brol
From: hersen wu [Why] ramp_up_dispclk_with_dpp is to change dispclk, dppclk and dprefclk according to bandwidth requirement. call stack: rv1_update_clocks --> update_clocks --> dcn10_prepare_bandwidth / dcn10_optimize_bandwidth --> prepare_bandwidth / optimize_bandwidth. before change dcn hw, pre

[PATCH 10/15] drm/amd/display: [FW Promotion] Release 0.0.26

2020-07-24 Thread Eryk Brol
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmu

[PATCH 08/15] drm/amd/display: Allow asic specific FSFT timing optimization

2020-07-24 Thread Eryk Brol
From: Reza Amini [Why] Each asic can optimize best based on its capabilities [How] Optimizing timing for a new pixel clock Signed-off-by: Reza Amini Reviewed-by: Anthony Koo Acked-by: Eryk Brol --- .../gpu/drm/amd/display/dc/core/dc_stream.c | 18 ++--- drivers/gpu/drm/amd/display

[PATCH 12/15] drm/amd/display: Use hw lock mgr

2020-07-24 Thread Eryk Brol
From: Wyatt Wood [Why] Feature requires synchronization of dig, pipe, and cursor locking between driver and fw. [How] Set flag to force psr to use hw lock mgr. Signed-off-by: Wyatt Wood Reviewed-by: Anthony Koo Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 +- 1

[PATCH 07/15] drm/amd/display: Disable idle optimizations before programming DCN

2020-07-24 Thread Eryk Brol
From: Jun Lei [Why] Programming DCN is explicitly forbidden during idle optimzations allowed state. Existing implemenation relies on OS/DM, which is not robust. Instead DC should sequence this. Note that DC will not re-enter idle optimized state on its own, it is only responsible for catching ou

[PATCH 06/15] drm/amd/display: Fix dmesg warning from setting abm level

2020-07-24 Thread Eryk Brol
From: Stylon Wang [Why] Setting abm level does not correctly update CRTC state. As a result no surface update is added to dc stream state and triggers warning. [How] Correctly update CRTC state when setting abm level property. CC: Stable Signed-off-by: Stylon Wang Reviewed-by: Nicholas Kazlau

[PATCH 13/15] drm/amd/display: DSC Slice width debugfs write entry

2020-07-24 Thread Eryk Brol
[Why] We need to be able to specify slice width for DSC on aconnector [How] Getting slice width parameter from debugfs entry, if it is a valid the value is set in connector's dsc preffered settings structure. Which then overwrites dsc_cfg structure's parameters if DSC is decided to be enabled. Wor

[PATCH 14/15] drm/amd/display: 3.2.96

2020-07-24 Thread Eryk Brol
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index f50ef4255020..ae0e27c67

[PATCH 15/15] drm/amd/display: Fix DP Compliance tests 4.3.2.1 and 4.3.2.2

2020-07-24 Thread Eryk Brol
From: Aric Cyr [Why] Test expects that we also read HPD_IRQ_VECTOR when checking for symbol loss as well lane status. [How] Read bytes 0x200-0x205 instead of just 0x202-0x205 Signed-off-by: Aric Cyr Reviewed-by: Jun Lei Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Paul Menzel
Dear Kees, Am 24.07.20 um 19:33 schrieb Kees Cook: On Fri, Jul 24, 2020 at 09:45:18AM +0200, Paul Menzel wrote: Am 24.07.20 um 00:32 schrieb Kees Cook: On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: As Linux 5.8-rc7 is going to be released this Sunday, I wonder, if commit 3202f

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Mazin Rezk
On Thursday, July 23, 2020 6:57 PM, Mazin Rezk wrote: > It seems that I spoke too soon. I ran the system for another hour after > submitting the patch and the bug just occurred. :/ > > Sadly, that means the bug isn't really fixed and that I have to go > investigate further. > > At the very least,

[PATCH 1/1] drm/amdkfd: Fix spurious debug exception on gfx10

2020-07-24 Thread Felix Kuehling
From: Jay Cornwall s_barrier triggers a debug exception when issued with PRIV=1, DEBUG_EN=1. This causes spurious notifications to rocm-gdb. Clear MODE before issuing s_barrier and restore MODE afterwards in the context restore handler. Signed-off-by: Jay Cornwall Tested-by: Laurent Morichetti