Re: Kenel Ooops with: "drm/amdgpu: poll ras_controller_irq and err_event_athub_irq status" [bisected].

2019-09-02 Thread Przemek Socha
Dnia niedziela, 1 września 2019 19:40:25 CEST piszesz: > On Sun, Sep 1, 2019 at 1:09 PM Przemek Socha wrote: > > Hello everyone, > > > > after today sync with amd-staging-drm-next repo my machine was hit by > > Ooops > > bug. > > Maybe my google-foo is weak, but I could not find any fix on patchw

Re: [BUG, regression] Dereferencing of NULL pointer in radeon_mn_unregister()

2019-09-02 Thread Jason Gunthorpe
On Sun, Sep 01, 2019 at 05:48:36PM +0200, Petr Cvek wrote: > > Is just adding a > > > > if (!rmn) > >retrun > > > > To the top of radeon_mn_unregister enough to fix it? > > Yeah it seems to work. A further test with minetest works too. Okay, I added this patch to the hmm tree, thanks.

RE: [PATCH] drm/amd/powerplay: update cached feature enablement status V3

2019-09-02 Thread Quan, Evan
Ping.. > -Original Message- > From: Evan Quan > Sent: 2019年8月23日 12:49 > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH] drm/amd/powerplay: update cached feature enablement > status V3 > > Need to update in cache feature enablement status after pp_feature > setting

RE: [PATCH] drm/amd/powerplay: update cached feature enablement status V3

2019-09-02 Thread Gui, Jack
Reviewed-by: Jack Gui -Original Message- From: Quan, Evan Sent: Monday, September 2, 2019 4:16 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Gui, Jack Subject: RE: [PATCH] drm/amd/powerplay: update cached feature enablement status V3 Ping.. > -Original Message- > Fro

[PATCH] drm/amd/display: Restore backlight brightness after system resume

2019-09-02 Thread Kai-Heng Feng
Laptops with AMD APU doesn't restore display backlight brightness after system resume. This issue started when DC was introduced. Let's use BL_CORE_SUSPENDRESUME so the backlight core calls update_status callback after system resume to restore the backlight level. Tested on Dell Inspiron 3180 (S

[PATCH 2/3] drm/amdgpu: reserve at least 4MB of VRAM for page tables

2019-09-02 Thread Christian König
This hopefully helps reduce the contention for page tables. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 9 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amd

[PATCH 1/3] drm/amdgpu: use moving fence instead of exclusive for VM updates

2019-09-02 Thread Christian König
Make VM updates depend on the moving fence instead of the exclusive one. Makes it less likely to actually have a dependency. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/a

[PATCH 3/3] drm/amdgpu: remove amdgpu_cs_try_evict

2019-09-02 Thread Christian König
Trying to evict things from the current working set doesn't work that well anymore because of per VM BOs. Rely on reserving VRAM for page tables to avoid contention. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 71 +--

Re: [PATCH 3/3] drm/edid: no CEA extension is not an error

2019-09-02 Thread Ville Syrjälä
On Fri, Aug 30, 2019 at 06:16:52PM +0200, Jean Delvare wrote: > It is fine for displays without audio functionality to not implement > CEA extension in their EDID. Do not return an error in that case, > instead return 0 as if there was a CEA extension with no audio or > speaker block. > > This fix

Re: [PATCH 3/3] drm/edid: no CEA extension is not an error

2019-09-02 Thread Ville Syrjälä
On Mon, Sep 02, 2019 at 01:55:21PM +0200, Jean Delvare wrote: > On Mon, 2 Sep 2019 14:46:51 +0300, Ville Syrjälä wrote: > > On Fri, Aug 30, 2019 at 06:16:52PM +0200, Jean Delvare wrote: > > > It is fine for displays without audio functionality to not implement > > > CEA extension in their EDID. Do

Re: [PATCH 3/3] drm/amdgpu: remove amdgpu_cs_try_evict

2019-09-02 Thread Kenny Ho
Hey Christian, Can you go into details a bit more on the how and why this doesn't work well anymore? (such as its relationship with per VM BOs?) I am curious to learn more because I was reading into this chunk of code earlier. Is this something that the Shrinker API can help with? Regards, Ken

Re: [PATCH 3/3] drm/amdgpu: remove amdgpu_cs_try_evict

2019-09-02 Thread Christian König
Hi Kenny, When we do a CS we have a certain set of buffers which the submission is working with and are locked down while we prepare the submission. This working set contains of the buffers in the BO list as well as the one in the VM plus one or two for CSA and user fences etc.. Now what ca

Re: [PATCH 3/3] drm/amdgpu: remove amdgpu_cs_try_evict

2019-09-02 Thread Kenny Ho
Ah ok, thanks for the explanation. About the last bit, what is the reason behind the differences in page size? (I assume that's what you meant by PTE? Or is that something else?) Regards, Kenny On Mon, Sep 2, 2019 at 10:31 AM Christian König wrote: > > Hi Kenny, > > When we do a CS we have a

Re: [PATCH 3/3] drm/amdgpu: remove amdgpu_cs_try_evict

2019-09-02 Thread Christian König
PTE means Page Table Entry. Starting with Vega10 we have multi level page tables and when you continuously allocate 2MB (or even 1GB) you can set a bit in the hierarchy that the walker should stop and take the address and flags for the whole 2MB block. The result is that with 4K pages you ne

[PATCH 1/2] drm/amdgpu: cleanup mtype mapping

2019-09-02 Thread Christian König
Unify how we map the UAPI flags to the PTE hardware flags for a mapping. Only the MTYPE is actually ASIC dependent, all other flags should be copied over 1 to 1 and ASIC differences are handled later on. Signed-off-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- d

[PATCH 2/2] drm/amdgpu: cleanup PTE flag generation

2019-09-02 Thread Christian König
Move the ASIC specific code into a new callback function. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29 ++--- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 22 ++- drivers/gpu/d

Re: [PATCH] drm/amd/display: Restore backlight brightness after system resume

2019-09-02 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.2.11, v4.19.69, v4.14.141, v4.9.190, v4.4.190. v5.2.11: Build OK! v4.19.69: Bui

[PATCH 01/10] drm/amdgpu: set ip specific ras interface pointer to NULL after free it

2019-09-02 Thread Zhang, Hawking
to prevent access to dangling pointers Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 7 +-- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 8 ++-- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 4 +++- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 4 drivers/gpu/drm/a

[PATCH 04/10] drm/amdgpu/sdma: switch to amdgpu_sdma_ras_late_init helper function

2019-09-02 Thread Zhang, Hawking
amdgpu_sdma_ras_late_init is used to init sdma specfic ras debugfs/sysfs node and sdma specific interrupt handler. It can be shared among sdma generations Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 52 drivers/gpu/drm/amd/amdgpu/a

[PATCH 03/10] drm/amdgpu/gfx: switch to amdgpu_gfx_ras_late_init helper function

2019-09-02 Thread Zhang, Hawking
amdgpu_gfx_ras_late_init is used to init gfx specfic ras debugfs/sysfs node and gfx specific interrupt handler. It can be shared among gfx generations Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 49 + drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH 02/10] drm/amdgpu/gmc: switch to amdgpu_gmc_ras_late_init helper function

2019-09-02 Thread Zhang, Hawking
amdgpu_gmc_ras_late_init is used to init gmc specfic ras debugfs/sysfs node and gmc specific interrupt handler. It can be shared among gmc generations. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 49 + drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 05/10] drm/amdgpu/mmhub: switch to amdgpu_mmhub_ras_late_init helper function

2019-09-02 Thread Zhang, Hawking
amdgpu_mmhub_ras_late_init is used to init mmhub specfic ras debugfs/sysfs node and mmhub specific interrupt handler. It can be shared among mmhub generations Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c | 56 ++

[PATCH 07/10] drm/amdgpu: init UMC & RSMU register base address

2019-09-02 Thread Zhang, Hawking
UMC RAS feature requires access to UMC & RSMU registers Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/arct_reg_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/arct_reg_init.c b/drivers/gpu/drm/amd/amdgpu/arct_reg_init.c index 4853899..e62609

[PATCH 06/10] drm/amdgpu/nbio: switch to amdgpu_nbio_ras_late_init helper function

2019-09-02 Thread Zhang, Hawking
amdgpu_nbio_ras_late_init is used to init nbio specfic ras debugfs/sysfs node and nbio specific interrupt handler. It can be shared among nbio generations Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.c | 70

[PATCH 10/10] drm/amdgpu: init mmhub ras functions for arcturus

2019-09-02 Thread Zhang, Hawking
arcturus mmhub ras is different from vg20 and need to implement arcturus/mmhub_9_4_1 specific mmhub callbacks Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++ drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 11 +++ drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.h | 1

[PATCH 09/10] drm/amdgpu: init arcturus umc callback functions and configurations

2019-09-02 Thread Zhang, Hawking
arcturus share the same umc callback functions and umc configurations as vg20 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index 86213f6..a

[PATCH 08/10] drm/amdgpu: allow check ras capabiltiy for arcturus

2019-09-02 Thread Zhang, Hawking
RAS will be supported on arcturus. The patch allow driver to check ras hw & sw availablity on arcturus. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/d

[PATCH] drm/amd/powerplay: do proper cleanups on hw_fini

2019-09-02 Thread Quan, Evan
These are needed for smu_reset support. Change-Id: If29ede4b99758adb08fd4e16665f44fd893ec99b Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 17 + drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 3 +++ drivers/gpu/drm/amd/powerplay/smu_v11_0.c

RE: [PATCH] drm/amd/powerplay: do proper cleanups on hw_fini

2019-09-02 Thread Gui, Jack
Reviewed-by: Jack Gui -Original Message- From: Quan, Evan Sent: Tuesday, September 3, 2019 11:44 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Candice ; Gui, Jack ; Quan, Evan Subject: [PATCH] drm/amd/powerplay: do proper cleanups on hw_fini These are needed for smu_reset support. Ch

[PATCH] drm/amdgpu: remove the redundant null check

2019-09-02 Thread zhong jiang
debugfs_remove and kfree has taken the null check in account. hence it is unnecessary to check it. Just remove the condition. No functional change. Signed-off-by: zhong jiang --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a

Re: [pull] amdgpu drm-next-5.4

2019-09-02 Thread Dave Airlie
On Sat, 31 Aug 2019 at 07:27, Alex Deucher wrote: > > Hi Dave, Daniel, > > Mostly bug fixes. The big addition is display support for renoir > which is new for 5.4. I realize it's a bit late to add it but the > rest of the code for renoir is already in so it would be nice to > get the display par

Re: gnome-shell stuck because of amdgpu driver [5.3 RC5]

2019-09-02 Thread Mikhail Gavrilov
On Fri, 30 Aug 2019 at 08:30, Hillf Danton wrote: > > Add a warning to show if it makes sense in field: neither regression nor > problem will have been observed with the warning printed. > I caught the problem. [21793.094289] [ cut here ] [21793.094296] gnome shell stuck

RE: [PATCH 2/3] drm/amdgpu: reserve at least 4MB of VRAM for page tables

2019-09-02 Thread Zhou, David(ChunMing)
Do you need update the vram size reported to UMD ? -David -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Monday, September 2, 2019 6:52 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/3] drm/amdgpu: reserve at least 4MB of VRAM for page tables This hopefully