On Mon, Dec 11, 2017 at 9:54 PM, Felix Kuehling wrote:
> On 2017-12-11 10:23 AM, Oded Gabbay wrote:
>> On Sat, Dec 9, 2017 at 6:09 AM, Felix Kuehling
>> wrote:
>>> From: Amber Lin
>>>
>>> For hardware blocks whose performance counters are accessed via MMIO
>>> registers, KFD provides the suppor
One minor style nit pick:
+ } else
+ ring->use_pollmem = true;
When the true part of an "if/else" uses {} the false part should use it
as well.
With that fixed and a Monks comment addressed the patch is Reviewed-by:
Christian König .
Christian.
Am 12.12.
Hi Emil,
On Fri, Dec 01, 2017 at 02:40:11PM +, Emil Velikov wrote:
> On 30 November 2017 at 23:49, Sudip Mukherjee
> wrote:
> > Hi Daniel,
> >
> > On Wed, Nov 29, 2017 at 10:56:34AM +0100, Daniel Vetter wrote:
> > submit it to dri-devel.
> >
> A crazy idea, mostly towards Tedd and Sudip:
>
Am 11.12.2017 um 22:29 schrieb Marek Olšák:
From: Marek Olšák
Signed-off-by: Marek Olšák
---
Is this really correct? I have no easy way to test it.
It's a step in the right direction, but I would rather vote for
something else:
Instead of disabling the timeout by default we only disable
Am 11.12.2017 um 13:08 schrieb Christian König:
Am 11.12.2017 um 06:52 schrieb Chunming Zhou:
On 2017年12月09日 00:41, Christian König wrote:
Not needed any more.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 52
+++---
drivers/gpu
Am 12.12.2017 um 08:58 schrieb Chunming Zhou:
On 2017年12月09日 00:41, Christian König wrote:
Instead of falling back to 2 level and very limited address space use
2+1 PD support and 128TB + 512GB of virtual address space.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h
On 2017年12月12日 17:23, Christian König wrote:
Am 11.12.2017 um 13:08 schrieb Christian König:
Am 11.12.2017 um 06:52 schrieb Chunming Zhou:
On 2017年12月09日 00:41, Christian König wrote:
Not needed any more.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 52
+
Change-Id: I0c6571c2a64e6c5bdad80ccbcccb40eba1c20b4e
Signed-off-by: Roger He
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
drivers/gpu/drm/ttm/ttm_bo.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
b/drivers
on_alloc_stage: is this operation on allocation stage
resv: reservation bo used of this operation
Change-Id: I01ea482e8c7470014196eb218e2ff8913306eef0
Signed-off-by: Roger He
---
include/drm/ttm/ttm_bo_api.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/drm/ttm/ttm_bo_api.h b/i
include ttm_bo_move_memcpy and ttm_bo_move_ttm
Change-Id: I160b2fe1da3200405810d0215c4521b5f0d3615a
Signed-off-by: Roger He
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 +++
drivers/gpu/drm/nouveau/nouveau_bo.c| 7 +++
drivers/gpu/drm/qxl/qxl_ttm.c | 3 +--
drivers/gpu/d
Change-Id: I8db51d843955f5db14bb4bbff892eaedbd9f0abe
Signed-off-by: Roger He
---
drivers/gpu/drm/ttm/ttm_bo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 17fe8be..eb8c568 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/driv
Change-Id: I491d4ceb8c98bb3d8e6e0ddef2330284ce2fe5f6
Signed-off-by: Roger He
---
drivers/gpu/drm/ttm/ttm_bo.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index eb8c568..22b6ca5 100644
--- a/drivers/gpu/drm/
Change-Id: I83ac6a77f24e14698aa386a497a262e24c5bbdb6
Signed-off-by: Roger He
---
drivers/gpu/drm/ttm/ttm_bo.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 22b6ca5..f138e95 100644
--- a/drivers/gpu/drm/t
shrink_pages is in unit of Order after ttm_page_pool_free,
but it is used by nr_free in next round so need change
it into native page unit
Change-Id: I33b77ac1616e24b1b881eee54c3bd7342cfa9ab8
Signed-off-by: Monk Liu
---
drivers/gpu/drm/ttm/ttm_page_alloc.c | 1 +
1 file changed, 1 insertion(+)
Change-Id: I7093791939fc1cccf2a13d8cc7ef7a6cca95351d
Signed-off-by: Monk Liu
---
drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c
b/drivers/gpu/drm/ttm/ttm_page_alloc.c
index 71945cc..b5ba644 100644
---
Change-Id: I6d6004b8f84e4654b5c4da53b4ebdf3936602883
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 8d03baa.
Change-Id: I7304577a500fc2d41482f2fe3f1692ae3797f576
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 44523a8..f62b07a 1
Change-Id: Ia13f12207d2e563f1f0c5d62cee74e0ae7d62e83
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
index 1469963..7cb7
Change-Id: I03fbf3ffb67f40a88769fac1b66fa1707479a3ea
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 50a1edb..468aed5 100644
-
From: Frank Min
Change-Id: Ic1bc49c21d3a90c477d11162f9d6d9e2073fbbd3
Signed-off-by: Frank Min
---
drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c
b/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c
index 55f018
Reviewed-by: Roger He
Thanks
Roger(Hongbo.He)
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Monk
Liu
Sent: Tuesday, December 12, 2017 5:47 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Monk
Subject: [PATCH 1/7] drm/ttm:fix incorrect calcul
NAK, it does make sense but that would change the user space interface
in a non backward compatible way, wouldn't it?
Christian.
Am 12.12.2017 um 10:46 schrieb Monk Liu:
Change-Id: I7304577a500fc2d41482f2fe3f1692ae3797f576
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c |
Patch #1-#3 and #5 are Reviewed-by: Christian König
.
Patch #6 and #7 are Acked-by: Christian König .
Regards,
Christian.
Am 12.12.2017 um 10:46 schrieb Monk Liu:
shrink_pages is in unit of Order after ttm_page_pool_free,
but it is used by nr_free in next round so need change
it into native p
BTW, in the shortlog (subject) there should always be a space after the
prefix's ":".
On 2017-12-12 10:46 AM, Monk Liu wrote:
> shrink_pages is in unit of Order after ttm_page_pool_free,
> but it is used by nr_free in next round so need change
> it into native page unit
>
> Change-Id: I33b77ac1
Without this patch a timed out submit will never be caught, is it really good ?
For the backward compatible why it's applied on incorrect logic ?
-Original Message-
From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
Sent: 2017年12月12日 18:20
To: Liu, Monk ; amd-gfx@lists.freed
Am 12.12.2017 um 10:33 schrieb Roger He:
on_alloc_stage: is this operation on allocation stage
resv: reservation bo used of this operation
Change-Id: I01ea482e8c7470014196eb218e2ff8913306eef0
Signed-off-by: Roger He
---
include/drm/ttm/ttm_bo_api.h | 4
1 file changed, 4 insertions(+)
Am 12.12.2017 um 10:33 schrieb Roger He:
Change-Id: I0c6571c2a64e6c5bdad80ccbcccb40eba1c20b4e
Signed-off-by: Roger He
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
drivers/gpu/drm/ttm/ttm_bo.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers
Am 12.12.2017 um 10:33 schrieb Roger He:
include ttm_bo_move_memcpy and ttm_bo_move_ttm
Change-Id: I160b2fe1da3200405810d0215c4521b5f0d3615a
Signed-off-by: Roger He
Reviewed-by: Christian König
But please separate that out and wait for a few days before committing,
maybe some nouveau devs
Am 12.12.2017 um 10:33 schrieb Roger He:
Change-Id: I8db51d843955f5db14bb4bbff892eaedbd9f0abe
Signed-off-by: Roger He
Reviewed-by: Christian König
That is a bug fix, isn't it? If yes maybe add CC:stable and commit it
first before all other patches.
Christian.
---
drivers/gpu/drm/ttm/t
Am 12.12.2017 um 10:33 schrieb Roger He:
Change-Id: I491d4ceb8c98bb3d8e6e0ddef2330284ce2fe5f6
Signed-off-by: Roger He
I would squash this one with patch #6.
---
drivers/gpu/drm/ttm/ttm_bo.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_
dma_fence_wait_any_timeout() return 1 when some fences was signaled even
when the timeout parameter is 0.
And later on we check for "wait->out.status = (r > 0);". So the logic
should actually work correct.
If it doesn't we need to fix something else.
Christian.
Am 12.12.2017 um 11:23 schrie
Okay
-Original Message-
From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
Sent: 2017年12月12日 18:44
To: Liu, Monk ; Koenig, Christian ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/7] drm/amdgpu:return ETIME if really time out
dma_fence_wait_any_timeout() return 1 wh
That's alright. I admit that it was a bit self-serving in that I was asked to
get something somewhere to get the information out, and it was the simplest
solution. I can see if I can come up with a more acceptable option in a future
patch set, but for now I think Felix is right in that we can ju
On 12/12/2017 04:01 AM, Christian König wrote:
Am 11.12.2017 um 22:29 schrieb Marek Olšák:
From: Marek Olšák
Signed-off-by: Marek Olšák
---
Is this really correct? I have no easy way to test it.
It's a step in the right direction, but I would rather vote for
something else:
Instead of
Fixes test failure on rhel.
Signed-off-by: Andrey Grodzovsky
---
tests/amdgpu/basic_tests.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c
index a78cf52..474a679 100644
--- a/tests/amdgpu/basic_tests.c
+++ b/tests/amdgpu/basic_tests.c
Am 11.12.2017 um 11:28 schrieb Christian König:
Am 11.12.2017 um 09:16 schrieb Chunming Zhou:
The hiberachy of page table is as below, which aligns hw names.
PDB2->PDB1->PDB0->PTB, accordingly:
level3 --- PDB2
level2 --- PDB1
level1 --- PDB0
level0 --- PTB
v2:
previous the root pdb is level0, n
On Tue, Dec 12, 2017 at 10:01 AM, Christian König
wrote:
> Am 11.12.2017 um 22:29 schrieb Marek Olšák:
>>
>> From: Marek Olšák
>>
>> Signed-off-by: Marek Olšák
>> ---
>>
>> Is this really correct? I have no easy way to test it.
>
>
> It's a step in the right direction, but I would rather vote fo
On Tue, Dec 12, 2017 at 4:18 AM, Liu, Monk wrote:
> NAK, you change break SRIOV logic:
>
> Without lockup_timeout set, this gpu_recover() won't get called at all ,
> unless your IB triggered invalid instruct and that IRQ invoked
> Amdgpu_gpu_recover(), by this cause you should disable the logic t
From: amd-gfx on behalf of Rex Zhu
Sent: Tuesday, December 12, 2017 2:24 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, Rex
Subject: [PATCH] drm/amd/pp: implement dpm_get_sclk/mclk for RV
Change-Id: I3abf5bde8c64ccab8e842a7c22aee011fc34e69f
Reviewed-by: Evan Qua
Am 12.12.2017 um 15:57 schrieb Marek Olšák:
On Tue, Dec 12, 2017 at 10:01 AM, Christian König
wrote:
Am 11.12.2017 um 22:29 schrieb Marek Olšák:
From: Marek Olšák
Signed-off-by: Marek Olšák
---
Is this really correct? I have no easy way to test it.
It's a step in the right direction, but
Reviewed-by: Qiang Yu
Regards,
Qiang
From: Andrey Grodzovsky
Sent: Tuesday, December 12, 2017 9:36:53 PM
To: dri-de...@lists.freedesktop.org
Cc: amd-gfx@lists.freedesktop.org; Yu, Qiang; Ma, Le; Huan, Alvin; Jin, Anna;
Grodzovsky, Andrey
Subject: [PATCH
Add new parameter to control GPU recovery procedure.
Retire old way of disabling GPU recovery by setting lockup_timeout == 0 and
set default for lockup_timeout to 10s.
Signed-off-by: Andrey Grodzovsky
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_device.
On Tue, Dec 12, 2017 at 2:16 PM, Andrey Grodzovsky
wrote:
> Add new parameter to control GPU recovery procedure.
> Retire old way of disabling GPU recovery by setting lockup_timeout == 0 and
> set default for lockup_timeout to 10s.
>
> Signed-off-by: Andrey Grodzovsky
> ---
> drivers/gpu/drm/amd
On Tue, Dec 12, 2017 at 5:36 PM, Christian König
wrote:
> Am 12.12.2017 um 15:57 schrieb Marek Olšák:
>>
>> On Tue, Dec 12, 2017 at 10:01 AM, Christian König
>> wrote:
>>>
>>> Am 11.12.2017 um 22:29 schrieb Marek Olšák:
From: Marek Olšák
Signed-off-by: Marek Olšák
---
>
Leftover from bring up.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/clearstate_gfx9.h | 8 ++--
.../drm/amd/include/asic_reg/gc/gc_9_0_default.h | 7
.../drm/amd/include/asic_reg/gc/gc_9_0_offset.h| 14 ---
.../drm/amd/include/asic_reg/gc/gc_9_0_sh_mask.h
No longer used.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 22 --
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 2 --
2 files changed, 24 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
b/drivers/gpu/drm/amd/amdgp
The expectation is that the base driver doesn't mess with these.
Some components interact with these directly so let the components
handle these directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/d
The expectation is that the base driver doesn't mess with these.
Some components interact with these directly so let the components
handle these directly.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/d
On 2017-12-12 03:27 PM, Alex Deucher wrote:
> The expectation is that the base driver doesn't mess with these.
> Some components interact with these directly so let the components
> handle these directly.
>
> Signed-off-by: Alex Deucher
Series is Reviewed-by: Harry Wentland
Harry
> ---
> dri
-Original Message-
From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
Sent: Tuesday, December 12, 2017 6:34 PM
To: He, Roger ; amd-gfx@lists.freedesktop.org;
dri-de...@lists.freedesktop.org
Subject: Re: [PATCH 3/6] drm/ttm: use an ttm operation ctx for ttm_bo_move_xxx
Am 12.
That is a bug fix, isn't it? If yes maybe add CC:stable and commit it
first before all other patches.
Fortunately so far there is no issue directly resulted from that.
Thanks
Roger(Hongbo.He)
-Original Message-
From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
Sen
Implement gart flush gpu tlbs with INVALIDATE_TLBS
package on gfx9/gmc9
Change-Id: I851fb93db17e04d19959768c01ba6c677cbb777c
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 +
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c| 7 ++
a new gart flush tlb function implemented for SRIOV,
and invoke it during RUNTIME for gart flush TLBs
this could avoid the issue that gart flush (via CPU MMIO)
being interrupted by word switch which lead to DMAR error
on Host/IOMMU side, with this function the gart flush
tlbs always run on KIQ wit
-Original Message-
From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
Sent: Tuesday, December 12, 2017 6:40 PM
To: He, Roger ; amd-gfx@lists.freedesktop.org;
dri-de...@lists.freedesktop.org
Subject: Re: [PATCH 5/6] drm/ttm: enable eviction for Per-VM-BO
Am 12.12.2017 um 10:3
allow_reserved_eviction: Allow eviction of reserved BOs
resv: Reservation object to allow reserved evictions with
Change-Id: I01ea482e8c7470014196eb218e2ff8913306eef0
Signed-off-by: Roger He
---
include/drm/ttm/ttm_bo_api.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/drm/ttm/
Change-Id: I0c6571c2a64e6c5bdad80ccbcccb40eba1c20b4e
Signed-off-by: Roger He
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index dc0a8be..7
Change-Id: I0c6ece0decd18d30ccc94e5c7ca106d351941c62
Signed-off-by: Roger He
---
drivers/gpu/drm/ttm/ttm_bo.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 098b22e..e7438b0 100644
--- a/drivers/gp
When unload amdgpu driver we use sdma to evict vram but there is no
irq process after sdma completed work which raises that waiting for the
fence costs 2s which will trigger VFLR under SRIOV and at last make
unload driver failed.The reason is that the shutdown varible in adev
is set to true before
Change-Id: Ic1f39d3bc853e9e4259d3e03a22920eda822eec5
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 69 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 14 +++
2 files changed, 66 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/d
On Wed, Dec 13, 2017 at 1:42 AM, Jason Gunthorpe wrote:
> On Tue, Dec 12, 2017 at 05:27:07PM -0600, Bjorn Helgaas wrote:
>> [+cc Ram, Michal, Ariel, Doug, Jason]
>>
>> The [29/37] in the subject makes it look like this is part of a larger
>> series, but I can't find the rest of it on linux-pci or
On Tue, Dec 12, 2017 at 1:11 PM, Russell, Kent wrote:
> That's alright. I admit that it was a bit self-serving in that I was asked to
> get something somewhere to get the information out, and it was the simplest
> solution. I can see if I can come up with a more acceptable option in a
> future
Hi,
We met a problem on ubuntu17.10 for arm server with amdgpu(AMD RADEON
PRO WX7100), we use open source driver which are integrated in ubuntu17.10.
And the architecture is AArch64-linux-gnu.
we install :
apt-get install xserver-xorg xinit xfce4 and mesa-utils glmar
62 matches
Mail list logo
