dma_fence_wait_any_timeout() return 1 when some fences was signaled even
when the timeout parameter is 0.
And later on we check for "wait->out.status = (r > 0);". So the logic
should actually work correct.
If it doesn't we need to fix something else.
Christian.
Am 12.12.2017 um 11:23 schrieb Liu, Monk:
Without this patch a timed out submit will never be caught, is it really good ?
For the backward compatible why it's applied on incorrect logic ?
-----Original Message-----
From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
Sent: 2017年12月12日 18:20
To: Liu, Monk <monk....@amd.com>; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/7] drm/amdgpu:return ETIME if really time out
NAK, it does make sense but that would change the user space interface in a non
backward compatible way, wouldn't it?
Christian.
Am 12.12.2017 um 10:46 schrieb Monk Liu:
Change-Id: I7304577a500fc2d41482f2fe3f1692ae3797f576
Signed-off-by: Monk Liu <monk....@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 44523a8..f62b07a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -1506,8 +1506,8 @@ static int amdgpu_cs_wait_any_fence(struct
amdgpu_device *adev,
if (first < fence_count && array[first])
r = array[first]->error;
- else
- r = 0;
+ else if (r == 0)
+ r = -ETIME;
err_free_fence_array:
for (i = 0; i < fence_count; i++)
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
