Re: [PATCH 3/6] drm/amdgpu: IOCTL interface for PRT support v3

2017-02-05 Thread Christian König
Am 04.02.2017 um 20:14 schrieb Bas Nieuwenhuizen: I get an error when trying to map a PRT region: [ 41.588224] BUG: unable to handle kernel NULL pointer dereference at 01e8 [ 41.589899] IP: [] ttm_eu_reserve_buffers+0x136/0x370 [ttm] Oh, yeah the bug is rather obvious when I lo

Re: [RFC]: More robust build sys for UMR

2017-02-05 Thread StDenis, Tom
Hi Edward, Well the patches apply and work but I'm not really sure what problem it's meant to solve [😊] . Building previously was actually simpler with "make" as opposed to "mkdir build && cd build && cmake .. && make". On a BSD system (where this wouldn't really work without the correspondi

Re: [RFC]: More robust build sys for UMR

2017-02-05 Thread Bas Nieuwenhuizen
Hi, I think the current build system is a bit too naive though. On my distro archlinux the libdrm headers are installed in /usr/include/libdrm, which causes the include to drm/drm.h in src/lib/query_drm.c to fail. So if it is in /usr/include/drm on Ubuntu, we are going to need some autodetecti

Re: [RFC]: More robust build sys for UMR

2017-02-05 Thread Edward O'Callaghan
On 02/05/2017 10:42 PM, StDenis, Tom wrote: > Hi Edward, Hey Tom, > > > Well the patches apply and work but I'm not really sure what problem > it's meant to solve 😊. Building previously was actually simpler with So the idea here was to implement something a little more robust and extensible

Re: [RFC]: More robust build sys for UMR

2017-02-05 Thread StDenis, Tom
Hi Edward, Sounds good to me. I'm sure our build-team folks would actually be in favour of something that could help make deb/rpm packages. I typically only run Fedora and Ubuntu so if others who run Arch/Gentoo/SUSE/etc want to weigh in that'd be appreciated. If nobody raises any objectio

Re: [RFC]: More robust build sys for UMR

2017-02-05 Thread StDenis, Tom
Hi Bas, What would be a good way to work around the paths though? Is there a pkg config for libdrm? Thanks, Tom From: amd-gfx on behalf of Bas Nieuwenhuizen Sent: Sunday, February 5, 2017 08:12 To: amd-gfx@lists.freedesktop.org Subject: Re: [RFC]: More robust

Re: [RFC]: More robust build sys for UMR

2017-02-05 Thread StDenis, Tom
Hi all, Never mind answered my own question: $ pkg-config libdrm --cflags -I/usr/include/libdrm So we could in theory include "drm.h" and then just add that to the head of our CFLAGS. Tom From: amd-gfx on behalf of StDenis, Tom Sent: Sunday, February 5,

Add autodetect for libdrm to umr

2017-02-05 Thread Tom St Denis
While the cmake commits haven't been pushed yet I'd like to get feedback on this patch which helps find the libdrm headers. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] autodetect path to libdrm

2017-02-05 Thread Tom St Denis
Signed-off-by: Tom St Denis --- CMakeLists.txt | 4 +++- src/lib/query_drm.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index bef94fdba788..d2f393f0fa9b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -25,6 +25,8 @@ include_di

Re: [RFC]: More robust build sys for UMR

2017-02-05 Thread Andres Rodriguez
Hey Tom, It's great to see umr make it to the public. I've given it a quick spin and it is pretty awesome, although I don't have much time this weekend to play with it. Wanted to weigh in my 2c regarding cmake. Some of the things I like about cmake: * Compatible with out of tree builds by

Re: [RFC]: More robust build sys for UMR

2017-02-05 Thread StDenis, Tom
Hi Andres, Thanks for the feedback. I've decided to push Edward's patches to master since it's in the projects best interest to minimize build/package friction going forward. Of course now I have to rebase our NPI branches internally since they're based on the older makefile ... That's mor

Re: [PATCH] autodetect path to libdrm

2017-02-05 Thread Andres Rodriguez
Hey Tom, Overall in cmake calling pkg_check_modules() directly is usually not a good practice. The common approach is to have a file in cmake/modules/Find$(name).cmake that takes care of everything. For example, you could use this FindLibdrm.cmake from the KDE project: https://github.com/KDE/kwi

Re: [PATCH] autodetect path to libdrm

2017-02-05 Thread StDenis, Tom
Hi Andres, Oh I can see how that's much simpler than a Makefile [😊] (100 lines of "find libdrm" later...). I'd rather not wholesale rip off KDE since their license (appears to be BSDish) is different. I may just clone the one Edward provided as you suggested instead. Tom __

Re: [PATCH] autodetect path to libdrm

2017-02-05 Thread Andres Rodriguez
Yeah that approach should be perfectly fine. I don't think libdrm needs anything fancier than that. Regards, Andres On 2/5/2017 4:53 PM, StDenis, Tom wrote: Hi Andres, Oh I can see how that's much simpler than a Makefile 😊 (100 lines of "find libdrm" later...). I'd rather not wholesale rip

[PATCH] Autodetect libdrm path (v2)

2017-02-05 Thread Tom St Denis
(v2): Use findLibDRM script instead of directly finding path Signed-off-by: Tom St Denis --- CMakeLists.txt | 3 +++ cmake_modules/FindLibDRM.cmake | 35 +++ src/lib/query_drm.c| 4 ++-- 3 files changed, 40 insertions(+), 2 deletions

Re: [PATCH] Autodetect libdrm path (v2)

2017-02-05 Thread Andres Rodriguez
Reviewed-by: Andres Rodriguez On 2/5/2017 5:24 PM, Tom St Denis wrote: (v2): Use findLibDRM script instead of directly finding path Signed-off-by: Tom St Denis --- CMakeLists.txt | 3 +++ cmake_modules/FindLibDRM.cmake | 35 +++ src/lib/query_

Re: [PATCH] Autodetect libdrm path (v2)

2017-02-05 Thread StDenis, Tom
Thanks. Pushed it. Tom From: Andres Rodriguez Sent: Sunday, February 5, 2017 17:28 To: Tom St Denis; amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: Re: [PATCH] Autodetect libdrm path (v2) Reviewed-by: Andres Rodriguez On 2/5/2017 5:24 PM, Tom St Den

Re: [RFC]: More robust build sys for UMR

2017-02-05 Thread Michel Dänzer
On 06/02/17 12:16 AM, StDenis, Tom wrote: > > $ pkg-config libdrm --cflags > -I/usr/include/libdrm > > So we could in theory include "drm.h" and then just add that to the head > of our CFLAGS. Make that , but yes, that's the correct way, not just in theory. :) -- Earthling Michel Dänzer

答复: [PATCH 07/21] drm/amdgpu:fix gart table vram pin

2017-02-05 Thread Liu, Monk
anyone to review those patches ? they are for SRIOV case mainly, and they are prepare for later TDR feature (GPU-reset on SR-IOV) 发件人: Monk Liu 发送时间: 2017年2月4日 18:34:59 收件人: amd-gfx@lists.freedesktop.org 抄送: Liu, Monk 主题: [PATCH 07/21] drm/amdgpu:fix gart table

RE: [PATCH 02/21] drm/amdgpu:fix golden init for sriov

2017-02-05 Thread Yu, Xiangliang
Does FIJI need the golden init? Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Saturday, February 04, 2017 6:22 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject: [PATCH 02/21] drm/

RE: [PATCH 05/21] drm/amdgpu:BUG if gpu_reste and asic_reset from VF

2017-02-05 Thread Yu, Xiangliang
Have you tried the patch for unloading driver? Ps: the index of patch make people confused, I think there are 21 patches in the series. Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Saturday,

答复: [PATCH 02/21] drm/amdgpu:fix golden init for sriov

2017-02-05 Thread Liu, Monk
FIJI is not supported in current stack 发件人: Yu, Xiangliang 发送时间: 2017年2月6日 10:35:34 收件人: Liu, Monk; amd-gfx@lists.freedesktop.org 抄送: Liu, Monk 主题: RE: [PATCH 02/21] drm/amdgpu:fix golden init for sriov Does FIJI need the golden init? Thanks! Xiangliang Yu > --

答复: [PATCH 05/21] drm/amdgpu:BUG if gpu_reste and asic_reset from VF

2017-02-05 Thread Liu, Monk
yeah, there are 21 patches totally, but no need to expose all in one time 发件人: Yu, Xiangliang 发送时间: 2017年2月6日 10:38:23 收件人: Liu, Monk; amd-gfx@lists.freedesktop.org 抄送: Liu, Monk 主题: RE: [PATCH 05/21] drm/amdgpu:BUG if gpu_reste and asic_reset from VF Have you tri

答复: [PATCH 02/21] drm/amdgpu:fix golden init for sriov

2017-02-05 Thread Liu, Monk
this patch is not needed, xgpu_vi_init_golden_registers(adev) will further process each VI asic accordingly. 发件人: amd-gfx 代表 Liu, Monk 发送时间: 2017年2月6日 10:37:55 收件人: Yu, Xiangliang; amd-gfx@lists.freedesktop.org 主题: 答复: [PATCH 02/21] drm/amdgpu:fix golden init

答复: [PATCH 05/21] drm/amdgpu:BUG if gpu_reste and asic_reset from VF

2017-02-05 Thread Liu, Monk
thanks for the catch, without those full access protection reboot is failed, I'll remove it and adjust later patches for TDR BR Monk 发件人: Liu, Monk 发送时间: 2017年2月6日 10:39:08 收件人: Yu, Xiangliang; amd-gfx@lists.freedesktop.org 主题: 答复: [PATCH 05/21] drm/amdgpu:BUG i

Re: 答复: [PATCH 05/21] drm/amdgpu:BUG if gpu_reste and asic_reset from VF

2017-02-05 Thread Michel Dänzer
On 06/02/17 11:39 AM, Liu, Monk wrote: > yeah, there are 21 patches totally, but no need to expose all in one time Then please edit the numbers in the mail subjects accordingly in the future. :) -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusias

答复: 答复: [PATCH 05/21] drm/amdgpu:BUG if gpu_reste and asic_reset from VF

2017-02-05 Thread Liu, Monk
I'll re-send the patch serials later, couple patches once BR Monk 发件人: amd-gfx 代表 Michel Dänzer 发送时间: 2017年2月6日 11:07:08 收件人: Liu, Monk; Yu, Xiangliang 抄送: amd-gfx@lists.freedesktop.org 主题: Re: 答复: [PATCH 05/21] drm/amdgpu:BUG if gpu_reste and asic_reset from

[PATCH 1/2] drm/amd/display: fix array lenth error.

2017-02-05 Thread Rex Zhu
Change-Id: I09011c5e6d5493db7e3d9a7ff7ab8c871a8db862 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c b/drivers/gpu/drm/amd/disp

[PATCH 2/2] drm/amd/powerplay: refine code to avoid potential bug that the memory not cleared.

2017-02-05 Thread Rex Zhu
Change-Id: If286d163cbabd8e9921a9d3cfcb71bb2b99aaceb Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay

[PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-05 Thread Pixel Ding
The SRIOV host driver cleans framebuffer for each VF, guest driver needn't this action which costs much time on some virtualization platform, otherwise it might get timeout to initialize. Signed-off-by: Pixel Ding --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 4 +++- 1 file changed, 3 insertions(

amd-gfx@lists.freedesktop.org

2017-02-05 Thread Zhou, David(ChunMing)
I'm curious what problem this patch fix? Any crash? My impression list_for will check if the list is empty, am I wrong? Regards, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Monk Liu Sent: Saturday, February 04, 2017 6:22 PM To:

[PATCH 2/2] drm/amdgpu: increase mailbox timeout to 5000ms

2017-02-05 Thread Pixel Ding
When mutiple VFs try to enter exclusive mode at the same time, the looping mechansim doesn't help to ensure each can get it because it only loops active VFs, then the last one has to wait for a long interval. Signed-off-by: Pixel Ding --- drivers/gpu/drm/amd/amdgpu/mxgpu_vi.h | 2 +- 1 file chan

[PATCH 1/2] drm/amdgpu/virt: refine handshake between guest and host by mailbox

2017-02-05 Thread Pixel Ding
From: Ken Xue The previous handshake doesn't check the VALID flag for mailbox. A bug occurs that the driver believes it's in exclusive mode but actually it's not, then the subsequent initliaztion fails. The right protocol should be that guest driver checks VALID flag and makes sure the host driv

[PATCH 1/2] drm/amdgpu/virt: refine handshake between guest and host by mailbox

2017-02-05 Thread Pixel Ding
From: Ken Xue The previous handshake doesn't check the VALID flag for mailbox. A bug occurs that the driver believes it's in exclusive mode but actually it's not, then the subsequent initliaztion fails. The right protocol should be that guest driver checks VALID flag and makes sure the host driv

RE: [PATCH 2/2] drm/amdgpu: increase mailbox timeout to 5000ms

2017-02-05 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Pixel Ding > Sent: Monday, February 06, 2017 2:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Ding, Pixel ; ding.pi...@amd.com > Subject:

[PATCH 2/2] drm/amdgpu/virt: schedule work to handle vm fault for VF

2017-02-05 Thread Pixel Ding
VF uses KIQ to access registers that invoking fence_wait to get the accessing completed. When VM fault occurs, the driver can't sleep in interrupt context. For some test cases, VM fault is 'legal' and shouldn't cause driver soft lockup. Signed-off-by: Pixel Ding --- drivers/gpu/drm/amd/amdgpu/g

RE: [PATCH 1/2] drm/amdgpu/virt: refine handshake between guest and host by mailbox

2017-02-05 Thread Yu, Xiangliang
Reviewed-by: Xiangliang.Yu Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Pixel Ding > Sent: Monday, February 06, 2017 3:00 PM > To: amd-gfx@lists.freedesktop.org > Cc: Xue, Ken > Subject: [PATCH 1/2] drm/amdgpu

RE: [PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-05 Thread Yu, Xiangliang
Acked-by: Xiangliang.Yu Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Pixel Ding > Sent: Monday, February 06, 2017 2:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Ding, Pixel ; ding.pi...@amd.com > Subject: [P