[PATCH 2/2] drm/amd/powerplay: refine code to avoid potential bug that the memory not cleared.

[Rex Zhu]

Change-Id: If286d163cbabd8e9921a9d3cfcb71bb2b99aaceb
Signed-off-by: Rex Zhu <rex....@amd.com>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c 
b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
index 0a6c833..18f8ee7 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
@@ -4397,16 +4397,14 @@ static int smu7_get_sclks(struct pp_hwmgr *hwmgr, 
struct amd_pp_clocks *clocks)
                if (table_info == NULL || table_info->vdd_dep_on_sclk == NULL)
                        return -EINVAL;
                dep_sclk_table = table_info->vdd_dep_on_sclk;
-               for (i = 0; i < dep_sclk_table->count; i++) {
+               for (i = 0; i < dep_sclk_table->count; i++)
                        clocks->clock[i] = dep_sclk_table->entries[i].clk;
-                       clocks->count++;
-               }
+               clocks->count = dep_sclk_table->count;
        } else if (hwmgr->pp_table_version == PP_TABLE_V0) {
                sclk_table = hwmgr->dyn_state.vddc_dependency_on_sclk;
-               for (i = 0; i < sclk_table->count; i++) {
+               for (i = 0; i < sclk_table->count; i++)
                        clocks->clock[i] = sclk_table->entries[i].clk;
-                       clocks->count++;
-               }
+               clocks->count = sclk_table->count;
        }
 
        return 0;
@@ -4440,14 +4438,13 @@ static int smu7_get_mclks(struct pp_hwmgr *hwmgr, 
struct amd_pp_clocks *clocks)
                        clocks->clock[i] = dep_mclk_table->entries[i].clk;
                        clocks->latency[i] = smu7_get_mem_latency(hwmgr,
                                                dep_mclk_table->entries[i].clk);
-                       clocks->count++;
                }
+               clocks->count = dep_mclk_table->count;
        } else if (hwmgr->pp_table_version == PP_TABLE_V0) {
                mclk_table = hwmgr->dyn_state.vddc_dependency_on_mclk;
-               for (i = 0; i < mclk_table->count; i++) {
+               for (i = 0; i < mclk_table->count; i++)
                        clocks->clock[i] = mclk_table->entries[i].clk;
-                       clocks->count++;
-               }
+               clocks->count = mclk_table->count
        }
        return 0;
 }
-- 
1.9.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx