RE: [PATCH] drm/amdgpu: move smu_debug_mask to a more proper place

2021-12-12 Thread Quan, Evan
[Public] Updated in V2. Thanks, Evan > -Original Message- > From: Chen, Guchun > Sent: Monday, December 13, 2021 2:02 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: RE: [PATCH] drm/amdgpu: move smu_debug_ma

RE: [PATCH] drm/amdgpu: move smu_debug_mask to a more proper place

2021-12-12 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, December 13, 2021 2:52 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH] drm/amdgpu: move smu_debug_mask to a more > proper place >

Re: [PATCH] drm/amdgpu: move smu_debug_mask to a more proper place

2021-12-12 Thread Lazar, Lijo
On 12/13/2021 11:12 AM, Evan Quan wrote: As the smu_context will be invisible from outside(of power). Also, the smu_debug_mask can be shared around all power code instead of some specific framework(swSMU) only. Signed-off-by: Evan Quan Change-Id: I1a0e1a436a51fc520a47b3fb28cde527d4e5eb6e ---

RE: [PATCH] drm/amdgpu: move smu_debug_mask to a more proper place

2021-12-12 Thread Chen, Guchun
[Public] - if (unlikely(smu->smu_debug_mask & SMU_DEBUG_HALT_ON_ERROR) && + if (unlikely(adev->smu_debug_mask & SMU_DEBUG_HALT_ON_ERROR) && res && (res != -ETIME)) { amdgpu_device_halt(smu->adev); [Guchun] As we have set an 'adev' variable, we can replace '