Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-29 Thread Christian König
x27;s easier to mask problem. Regards, Jack -Original Message- From: Koenig, Christian Sent: Tuesday, August 28, 2018 2:46 PM To: Xiao, Jack ; Kuehling, Felix ; Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC

RE: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-29 Thread Xiao, Jack
; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9 Completely agree with Felix here. It makes system memory access slightly simpler, but I would say that you accidentally corrupt the GART table and that you accidentally corrupt the the

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-29 Thread Christian König
al Message- From: Koenig, Christian Sent: Tuesday, August 28, 2018 2:46 PM To: Xiao, Jack ; Kuehling, Felix ; Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9 This series patches seems to make AGP aperture allowed to

RE: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-28 Thread Xiao, Jack
, but I guess the overhead is little. Regards, Jack -Original Message- From: Christian König Sent: Tuesday, August 28, 2018 7:42 PM To: Xiao, Jack ; Koenig, Christian ; Kuehling, Felix ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 01/10] drm/amdgpu: use only the lower address sp

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-28 Thread Felix Kuehling
ithout explicit claiming, it's easier to mask problem. >> >> Regards, >> Jack >> >> -Original Message- >> From: Koenig, Christian >> Sent: Tuesday, August 28, 2018 2:46 PM >> To: Xiao, Jack ; Kuehling, Felix >> ; Christian König >>

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-28 Thread Felix Kuehling
On 2018-08-28 02:53 AM, Christian König wrote: > Am 28.08.2018 um 06:21 schrieb zhoucm1: >> >> >> On 2018年08月28日 03:03, Felix Kuehling wrote: >>> The point of this series seems to be to allow access to small system >>> memory BOs (one page) without a GART mapping. I'm guessing that reduces >>> pres

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-28 Thread Christian König
hling, Felix ; Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9 This series patches seems to make AGP aperture allowed to access any system memory (16GB) bypass GPU VM protection. The system aperture should only be a

RE: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-28 Thread Xiao, Jack
d-gfx@lists.freedesktop.org Subject: Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9 > This series patches seems to make AGP aperture allowed to access any system > memory (16GB) bypass GPU VM protection. The system aperture should only be active in the system domain, o

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-27 Thread Christian König
Am 28.08.2018 um 06:21 schrieb zhoucm1: On 2018年08月28日 03:03, Felix Kuehling wrote: The point of this series seems to be to allow access to small system memory BOs (one page) without a GART mapping. I'm guessing that reduces pressure on the GART and removes the need for HDP and TLB flushes. I

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-27 Thread Christian König
? Regards, Jack -Original Message- From: amd-gfx On Behalf Of Felix Kuehling Sent: Tuesday, August 28, 2018 3:03 AM To: Christian König ; amd-gfx@lists.freedesktop.org; Koenig, Christian Subject: Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9 The point of this

RE: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-27 Thread Xiao, Jack
. Is it worth doing this, but exposing risk? Regards, Jack -Original Message- From: amd-gfx On Behalf Of Felix Kuehling Sent: Tuesday, August 28, 2018 3:03 AM To: Christian König ; amd-gfx@lists.freedesktop.org; Koenig, Christian Subject: Re: [PATCH 01/10] drm/amdgpu: use only the lower

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-27 Thread zhoucm1
On 2018年08月28日 03:03, Felix Kuehling wrote: The point of this series seems to be to allow access to small system memory BOs (one page) without a GART mapping. I'm guessing that reduces pressure on the GART and removes the need for HDP and TLB flushes. I think if adding these explain/reason to c

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-27 Thread Zhang, Jerry (Junwei)
On 08/28/2018 09:56 AM, Zhang, Jerry (Junwei) wrote: On 08/28/2018 12:53 AM, Christian König wrote: Only use the lower address space on GMC9 for the system domain. Otherwise we would need to sign extend GMC addresses. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c |

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-27 Thread Zhang, Jerry (Junwei)
On 08/28/2018 12:53 AM, Christian König wrote: Only use the lower address space on GMC9 for the system domain. Otherwise we would need to sign extend GMC addresses. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++ 1 file changed, 3 insertions(+), 4 deleti

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-27 Thread Felix Kuehling
The point of this series seems to be to allow access to small system memory BOs (one page) without a GART mapping. I'm guessing that reduces pressure on the GART and removes the need for HDP and TLB flushes. Why does Patch 10 only enable that on GFXv9? Is there less benefit on older chips? Is this

Re: [PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-27 Thread Alex Deucher
On Mon, Aug 27, 2018 at 12:56 PM Christian König wrote: > > Only use the lower address space on GMC9 for the system domain. > Otherwise we would need to sign extend GMC addresses. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++ > 1 file changed, 3 in

[PATCH 01/10] drm/amdgpu: use only the lower address space on GMC9

2018-08-27 Thread Christian König
Only use the lower address space on GMC9 for the system domain. Otherwise we would need to sign extend GMC addresses. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc