bother
me ...
BTW:
We can check "sched_job.id" to judge if the upcoming timeout reporting is a
repeated one and skip the waring string if it is repeated,
I hat my DMESG all flushed by those identical warning all my screen ....
/Monk
-----Original Message-----
From: Christian
(etc) you could use the
drm_sched_suspend_timeout() and drm_sched_resume_timeout() helpers which
allow us to disable the scheduler timeout for a moment.
Regards,
Christian.
/Monk
-Original Message-----
From: Koenig, Christian
Sent: Thursday, May 9, 2019 7:45 PM
To: Liu, Monk ; amd-gfx@list
ssage-
From: Koenig, Christian
Sent: Thursday, May 9, 2019 7:45 PM
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
Well putting the other drivers aside for moment, I would also say that it is
bad design to not restart the timeout. So even
stomer branch if except
> ARM reason there are other bad side effects
>
> /Monk
>
> -Original Message-
> From: Christian König
> Sent: Thursday, May 9, 2019 7:09 PM
> To: Liu, Monk ; Koenig, Christian
> ; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] dr
inal Message-
From: Christian König
Sent: Thursday, May 9, 2019 7:08 PM
To: Liu, Monk ; Koenig, Christian ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
[CAUTION: External Email]
Hi Monk,
the timeout handler might only kill waves u
May 9, 2019 7:09 PM
To: Liu, Monk ; Koenig, Christian ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
[CAUTION: External Email]
Hi Monk,
the timeout handler might only kill waves until we see some progress again and
then continue.
E.g. we don
stian
> Sent: Thursday, May 9, 2019 6:54 PM
> To: Liu, Monk ; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
>
> [CAUTION: External Email]
>
> Hi Monk,
>
> ok you don't seem to understand: It is intentional that th
2019 6:54 PM
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
[CAUTION: External Email]
Hi Monk,
ok you don't seem to understand: It is intentional that the same job times out
multiple times! So we can't really chang
M
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
[CAUTION: External Email]
Hi Monk,
ok you don't seem to understand: It is intentional that the same job times out
multiple times! So we can't really change anything
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
[CAUTION: External Email]
Hi Monk,
ok you don't seem to understand: It is intentional that the same job times out
multiple times! So we can't really change anything here.
What we ca
d-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
[CAUTION: External Email]
Hi Monk,
ok you don't seem to understand: It is intentional that the same job times out
multiple times! So we can't really change anything here.
What we can do is instead of s
t drm_sched_backend_ops {
>* @timedout_job: Called when a job has taken too long to execute,
>* to trigger GPU recovery.
> */
> - void (*timedout_job)(struct drm_sched_job *sched_job);
> + int (*timedout_job)(struct drm_sched_job *sched_job);
>
inal Message-----
From: Christian König
Sent: Thursday, May 9, 2019 6:30 PM
To: Liu, Monk ; Koenig, Christian ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
[CAUTION: External Email]
drm_sched_start() is not necessary called fro
there is a
"drm_sched_start_timeout()" in the tail
/Monk
-Original Message-
From: Christian König
Sent: Thursday, May 9, 2019 3:18 PM
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: fix the duplicated TMO message for one IB
[CAUTION: External Email]
Am 09.05
e: [PATCH] drm/sched: fix the duplicated TMO message for one IB
[CAUTION: External Email]
Am 09.05.19 um 06:31 schrieb Monk Liu:
> we don't need duplicated IB's timeout error message reported
> endlessly, just one report per timedout IB is enough
Well, NAK. We don't need mul
Am 09.05.19 um 06:31 schrieb Monk Liu:
we don't need duplicated IB's timeout error message reported endlessly,
just one report per timedout IB is enough
Well, NAK. We don't need multiple timeout reports, but we really need to
restart the timeout counter after handling it.
Otherwise we will n
we don't need duplicated IB's timeout error message reported endlessly,
just one report per timedout IB is enough
Signed-off-by: Monk Liu
---
drivers/gpu/drm/scheduler/sched_main.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c
b/drivers/gpu/drm/s
17 matches
Mail list logo
