Re: [PATCH] drm/amdgpu: miss PRT case when bo update

2020-03-16 Thread Christian König
Am 16.03.20 um 11:08 schrieb Yintian Tao: Originally, only the PTE valid is taken in consider. The PRT case is missied when bo update which raise problem. We need add condition for PRT case. v2: add PRT condition for amdgpu_vm_bo_update_mapping, too Good point, yes. Feel free to commit it like

[PATCH] drm/amdgpu: miss PRT case when bo update

2020-03-16 Thread Yintian Tao
Originally, only the PTE valid is taken in consider. The PRT case is missied when bo update which raise problem. We need add condition for PRT case. v2: add PRT condition for amdgpu_vm_bo_update_mapping, too v3: fix one typo error Signed-off-by: Yintian Tao Reviewed-by: Christian König --- dri

[PATCH] drm/amdgpu: miss PRT case when bo update

2020-03-16 Thread Yintian Tao
Originally, only the PTE valid is taken in consider. The PRT case is missied when bo update which raise problem. We need add condition for PRT case. v2: add PRT condition for amdgpu_vm_bo_update_mapping, too Signed-off-by: Yintian Tao --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +++--- 1 fil

RE: [PATCH] drm/amdgpu: miss PRT case when bo update

2020-03-16 Thread Tao, Yintian
Hi Christian Many thanks for your review Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2020年3月16日 17:38 To: Tao, Yintian ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: miss PRT case when bo update Am 16.03.20 um

Re: [PATCH] drm/amdgpu: miss PRT case when bo update

2020-03-16 Thread Christian König
Am 16.03.20 um 08:52 schrieb Yintian Tao: Originally, only the PTE valid is taken in consider. The PRT case is missied when bo update which raise problem. We need add condition for PRT case. Good catch, just one style nit pick below. Signed-off-by: Yintian Tao --- drivers/gpu/drm/amd/amdg

[PATCH] drm/amdgpu: miss PRT case when bo update

2020-03-16 Thread Yintian Tao
Originally, only the PTE valid is taken in consider. The PRT case is missied when bo update which raise problem. We need add condition for PRT case. Signed-off-by: Yintian Tao --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/driv