Re: [PATCH] drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset

On 4/9/2025 7:26 PM, Dan Carpenter wrote: > On Wed, Apr 09, 2025 at 07:19:25PM +0530, Lazar, Lijo wrote: >> >> >> On 4/9/2025 7:09 PM, Ce Sun wrote: >>> Checking hive is more readable. >>> >>> The following smatch warning: >>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset

Re: [PATCH] drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset

On Wed, Apr 09, 2025 at 07:19:25PM +0530, Lazar, Lijo wrote: > > > On 4/9/2025 7:09 PM, Ce Sun wrote: > > Checking hive is more readable. > > > > The following smatch warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset() > > warn: iterator used outside loop: 'tmp_a

Re: [PATCH] drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset

Am 09.04.25 um 15:18 schrieb Ce Sun: > Checking hive is more readable. > > The following smatch warning: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset() > warn: iterator used outside loop: 'tmp_adev' Please also remove the setting of hive and tmp_adev to NULL at the decla

Re: [PATCH] drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset

Am 09.04.25 um 15:39 schrieb Ce Sun: > Checking hive is more readable. > > The following smatch warning: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset() > warn: iterator used outside loop: 'tmp_adev' > > Fixes: 8ba904f54148 ("drm/amdgpu: Multi-GPU DPC recovery support") I

Re: [PATCH] drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset

On 4/9/2025 7:09 PM, Ce Sun wrote: > Checking hive is more readable. > > The following smatch warning: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset() > warn: iterator used outside loop: 'tmp_adev' > > Fixes: 8ba904f54148 ("drm/amdgpu: Multi-GPU DPC recovery support")

[PATCH] drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset

Checking hive is more readable. The following smatch warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset() warn: iterator used outside loop: 'tmp_adev' Fixes: 8ba904f54148 ("drm/amdgpu: Multi-GPU DPC recovery support") Reported-by: Dan Carpenter Signed-off-by: Ce Sun

[PATCH] drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset

Checking hive is more readable. The following smatch warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset() warn: iterator used outside loop: 'tmp_adev' Fixes: 8ba904f54148 ("drm/amdgpu: Multi-GPU DPC recovery support") Reported-by: Dan Carpenter Signed-off-by: Ce Sun