RE: [PATCH 5/9] drm/amdgpu: add userq object va track helpers

2025-05-30 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] + user_addr = ALIGN_DOWN(addr >> AMDGPU_GPU_PAGE_SHIFT, 0x100); This is a PAGE_ALIGN_DOWN() macro can simplify your code logic. Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Prike Liang Sent:

RE: [PATCH] drm/amd/pm: Use external link order for xgmi data

2025-05-19 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] "-1" is meaningless, it is recommended to use -EINVAL or -EOPNOTSUPP. Acked-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Monday, May 19, 2025 19:02 T

Re: [PATCH] drm/amd/pm: Use macro to initialize metrics table

2025-04-28 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] #define smu_cmn_init_soft_gpu_metrics(ptr, a, b) it is better to use frev/crev to instead of a,b . apart is ok for me. Reviewed-by: Yang Wang Best Regards, Kevin 发件人: Zhang, Hawking 发送时间: 星期二, 四月 29

RE: [PATCH] drm/amd/pm: Fix comment style

2025-04-27 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Monday, April 28, 2025 13:03 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad

[PATCH] Fixed the warning at ./drivers/gpu/drm/amd/include/amd_shared.h:369

2025-04-06 Thread Kevin Paul Reddy Janagari
warning: Incorrect use of kernel-doc format: * @DC_HDCP_LC_ENABLE_SW_FALLBACK If set, upon HDCP Locality Check FW Signed-off-by: Kevin Paul Reddy Janagari --- drivers/gpu/drm/amd/include/amd_shared.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include

RE: [PATCH 2/2] drm/amd/amdgpu: disable ASPM in some situations

2025-04-04 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Tuesday, April 1, 2025 16:08 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH 2/2] drm

RE: [PATCH] drm/amdgpu: Decode deferred error type in gfx aca bank parser

2025-03-20 Thread Wang, Yang(Kevin)
to error statistics of different types of errors. In the aca parser interface, I think there is enough information to identify the types of errors and correctly count errors, Please double check it, thanks. Best Regards, Kevin -Original Message- From: Liu, Xiang(Dean) Sent: Thursday

RE: [PATCH] drm/amd/amdgpu: Revert "drm/amd/amdgpu: shorten the gfx idle worker timeout"

2025-03-18 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Wednesday, March 19, 2025 14:38 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/amdgpu

RE: [PATCH] drm/amdgpu: Use correct aca handle to validate aca bank

2025-03-18 Thread Wang, Yang(Kevin)
of some RAS ip blocks. e.g: The SMU returned 6 banks in total, including 3 umc aca banks, 2 xgmi banks, and 1 unsupported bank. Best Regards, Kevin _ From: Zhang, Hawking Sent: Tuesday, March 18, 2025 17:19 To: Liu, Xiang(Dean) ; amd-gfx@lists.freedes

RE: [PATCH] drm/amdgpu/pm: Handle SCLK offset correctly in overdrive for smu 14.0.2

2025-03-12 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] It looks good to me. Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Tomasz Pakula Sent: Wednesday, March 12, 2025 05:39 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject

RE: [PATCH] drm/amdgpu: disable ras ta if module param amdgpu_ras_enable = 0

2025-03-11 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] It is ok, thank you for your explanation. Best Regards, Kevin -Original Message- From: Zhang, Hawking Sent: Wednesday, March 12, 2025 11:58 To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: RE: [PATCH

RE: [PATCH] drm/amd/pm: add unique_id for gfx12

2025-03-11 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Harish Kasiviswanathan Sent: Wednesday, March 12, 2025 02:17 To: amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish Subject

RE: [PATCH 2/2] drm/amd/pm: prevent skipping the workload setting back to bootup default

2025-03-11 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Please add following information into commit message. Fixes: bd3c9d1cde0c ("drm/amd/pm: fix and simplify workload handling”) Series is Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng

RE: [PATCH 1/2] drm/amd/amdgpu: shorten the gfx idle worker timeout

2025-03-11 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Please correct the code comments before committing the patch. /* 1 second timeout */ 10ms With that fixed, Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Tuesday, March 11, 2025 16:55

RE: [PATCH] drm/amd/pm: always allow ih interrupt from fw

2025-03-02 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Friday, February 28, 2025 17:05 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject

RE: [PATCH] drm/amd/pm: add fan abnormal detection

2025-02-26 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Thursday, February 27, 2025 10:16 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: add

RE: [PATCH] drm/amdgpu: Remove redundant check of adev

2025-02-18 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Xiang Liu Sent: Wednesday, February 19, 2025 12:37 To: amd-gfx@lists.freedesktop.org Cc: k...@ijzerbout.nl; Zhang, Hawking ; Zhou1, Tao

RE: [PATCH] drm/amd/pm: extend the gfxoff delay for compute workload

2025-02-16 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Kenneth Feng Sent: Friday, February 14, 2025 19:15 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: extend the gfxoff delay for compute workload extend

RE: [PATCH] drm/amd/pm: Rename pmfw message SetPstatePolicy

2025-02-10 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Asad Kamal Sent: Monday, February 10, 2025 16:02 To: amd-gfx@lists.freedesktop.org; Lazar, Lijo Cc: Ma, Le ; Zhang, Hawking ; Zhang

RE: [PATCH] drm/amdgpu/mes: Add cleaner shader fence address handling in MES for GFX11

2025-02-07 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] typo: amdgpu_device_wb_put() -> amdgpu_device_wb_free() Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Wang, Yang(Kevin) Sent: Friday, February 7, 2025 17:26 To: SHANMUGAM, SRINIVASAN ; Koenig, Christ

RE: [PATCH] drm/amdgpu/mes: Add cleaner shader fence address handling in MES for GFX11

2025-02-07 Thread Wang, Yang(Kevin)
_API_SET_HW_RSRC_1; mes_set_hw_res_pkt.header.dwsize = API_FRAME_SIZE_IN_DWORDS; mes_set_hw_res_pkt.enable_mes_info_ctx = 1; + mes_set_hw_res_pkt.cleaner_shader_fence_mc_addr = adev->wb.gpu_addr + + (cleaner_fence_offse

RE: [PATCH v3] drm/amd/pm: Fix smu v13.0.6 caps initialization

2025-01-20 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Lazar, Lijo Sent: Tuesday, January 21, 2025 13:39 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Wang, Yang(Kevin

RE: [PATCH] drm/amd/pm: Use correct macros for smu caps

2025-01-19 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Lazar, Lijo Sent: Friday, January 17, 2025 23:14 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Wang, Yang(Kevin) Subject: [PATCH] drm/amd/pm: Use correct

RE: [PATCH] drm/amd/pm: Refactor SMU 13.0.6 SDMA reset firmware version checks

2025-01-16 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] You'd better re-coding this patch base on following patch from Lijo. [PATCH] drm/amd/pm: Add capability flags for SMU v13.0.6 Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of jesse.zh...@amd.com Sent: F

RE: [RFC v2 07/15] drm/admgpu: rename amdgpu_ras_pre_fini() to amdgpu_ras_early_fini()

2025-01-16 Thread Wang, Yang(Kevin)
struct ras_common_if *r return 0; late_fini: [kevin]: It's better to rename above label name together. Best Regards, Kevin - amdgpu_ras_block_late_fini(adev, ras_block); + amdgpu_ras_block_early_fini(adev, ras_block); return r; } diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

RE: [RFC v2 01/15] drm/amdgpu: add helper functions to track status for ras manager

2025-01-16 Thread Wang, Yang(Kevin)
ev, + struct ras_common_if *head, int marker) { + struct ras_manager *obj = amdgpu_ras_find_obj(adev, head); + + WARN_ON(marker > 63); + WARN_ON(obj->markers & (0x1ull << marker)); [kevin]: It's best to check for null pointers before accessing me

RE: [PATCH] drm/amd/pm: Add capability flags for SMU v13.0.6

2025-01-16 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Lazar, Lijo Sent: Thursday, January 16, 2025 20:29 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Wang, Yang(Kevin

RE: [PATCH 1/2] drm/amdgpu: cache gpu pcie link width

2025-01-13 Thread Wang, Yang(Kevin)
pcie_mlw_mask == 0) { > + /* asic caps */ > + if (link_width == PCIE_LNK_WIDTH_UNKNOWN) { > + adev->pm.pcie_mlw_mask |= > AMDGPU_DEFAULT_ASIC_PCIE_MLW_MASK; In this condition, we already know this variable (adev->pm.pcie_mlw_

Recall: [PATCH] drm/amdgpu: disable gfxoff with the compute workload on gfx12

2025-01-09 Thread Wang, Yang(Kevin)
Wang, Yang(Kevin) would like to recall the message, "[PATCH] drm/amdgpu: disable gfxoff with the compute workload on gfx12".

RE: [PATCH] drm/amdgpu: disable gfxoff with the compute workload on gfx12

2025-01-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Thursday, January 9, 2025 16:25 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amdgpu

RE: [PATCH v2 1/2] drm/amd/pm: add the interface to set and save the bootup workload type

2025-01-07 Thread Wang, Yang(Kevin)
ile_mode, !en); + mutex_lock(&adev->pm.mutex); + smu->power_profile_mode = saved_profile_mode; + smu->saved_power_profile_mode = PP_SMC_POWER_PROFILE_BOOTUP_DEFAULT; + mutex_unlock(&adev->pm.mutex); + } [kevin]: I think we

RE: [PATCH 1/6] drm/amdgpu/nbio7.7: fix IP version check

2024-12-12 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, December 13, 2024 06:09 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/6

Recall: [PATCH 1/2] drm/amdgpu/nbio7.7: fix IP version check

2024-12-12 Thread Wang, Yang(Kevin)
Wang, Yang(Kevin) would like to recall the message, "[PATCH 1/2] drm/amdgpu/nbio7.7: fix IP version check".

RE: [PATCH 1/2] drm/amdgpu/nbio7.7: fix IP version check

2024-12-12 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, December 13, 2024 05:54 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/2

RE: [PATCH] drm/amd/pm: Revert state if force level fails

2024-12-08 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Friday, December 6, 2024 21:00 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad

RE: [PATCH v2] drm/amd/pm: Set SMU v13.0.7 default workload type

2024-12-04 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Wednesday, December 4, 2024 4:32 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Lazar, Lijo ; Feng, Kenneth Subject

RE: [PATCH] drm/amd/pm: set the default workload type to bootup type on smu v13.0.7

2024-12-03 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Wednesday, December 4, 2024 3:04 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm

RE: [PATCH] drm/amdgpu: use sjt mec fw on gfx943 for sriov

2024-11-26 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Zhao, Victor Sent: Tuesday, November 26, 2024 17:56 To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: use

RE: [PATCH] drm/amd/pm: disable pcie speed switching on Intel platform for smu v14.0.2/3

2024-11-18 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Monday, November 18, 2024 16:01 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH

RE: [PATCH] drm/amdgpu/pm: skip the power source check on smu v14.0.2/3

2024-11-18 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Kenneth Feng Sent: Tuesday, November 19, 2024 13:48 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amdgpu/pm: skip the power source check on smu v14.0.2/3

RE: [PATCH] drm/amdgpu/pm: add gen5 display to the user on smu v14.0.2/3

2024-11-18 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Tuesday, November 19, 2024 11:13 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject

Re: [PATCH] drm/amd/pm: Update data types used for uapi i/f

2024-11-13 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin 发件人: amd-gfx 代表 Asad Kamal 发送时间: 星期三, 十一月 13, 2024 5:31 下午 收件人: amd-gfx@lists.freedesktop.org ; Lazar, Lijo ; Wang, Yang(Kevin) ; Zhang, Hawking 抄送: Ma, Le

RE: [PATCH v2 1/2] drm/amd/pm: Add gpu_metrics_v1_7

2024-11-13 Thread Wang, Yang(Kevin)
*/ + u64 gfx_below_host_limit_acc[MAX_XCC]; +}; [kevin]: It is better to change the type to 'uint64/32/16_t' (stdint.h) to indicate that it is a uapi interface. With fixed, Reviewed-by: Yang Wang Best Regards, Kevin + struct amd_pm_funcs { /* export for dpm on ci and si */

RE: [PATCH] drm/amd/pm: always pick the pptable from IFWI

2024-10-31 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] I suppose there is no backward compatibility issue with this patch. Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Friday, November 1, 2024 11:57 AM To: amd-gfx@lists.freedesktop.org Cc

RE: [PATCH 1/3] drm/amdgpu: Adjust debugfs register access permissions

2024-10-30 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Alex Deucher Sent: Thursday, October 31, 2024 10:59 AM To: Wang, Yang(Kevin) Cc: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/amdgpu: Adjust debugfs register access

RE: [PATCH 1/3] drm/amdgpu: Adjust debugfs register access permissions

2024-10-30 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, October 31, 2024 12:03 AM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/3

RE: [PATCH] drm/amdgpu: optimize ACA log print

2024-10-25 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Fix typo, DE -> UE. Best Regards, Kevin -Original Message- From: Wang, Yang(Kevin) Sent: Friday, October 25, 2024 5:20 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao Subject: RE: [PATCH]

RE: [PATCH] drm/amdgpu: optimize ACA log print

2024-10-25 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Lazar, Lijo Sent: Friday, October 25, 2024 3:25 PM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao Subject: Re: [PATCH] drm/amdgpu: optimize ACA log print On 10/25

RE: [PATCH] drm/amd/pm: update deep sleep status on smu v14.0.2/3

2024-10-16 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Kenneth Feng Sent: Wednesday, October 16, 2024 3:19 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: update deep sleep status on smu v14.0.2/3

RE: [PATCH] drm/amdgpu: Zero-initialize mqd backup memory

2024-10-14 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Tuesday, October 15, 2024 1:34 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Koenig

RE: [PATCH] drm/amd/pm: update overdrive function on smu 14.0.2/3

2024-10-11 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Saturday, October 12, 2024 10:00 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm

RE: [PATCH] drm/amd/pm: update the driver-fw interface file for smu v14.0.2/3

2024-10-10 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Thursday, October 10, 2024 5:37 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm

RE: [PATCH] drm/amdgpu: fix vbios fetching for SR-IOV

2024-09-25 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Tested-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: 2024年9月26日 2:20 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm

RE: [PATCH] drm/amd/pm: update the features set on smu v14.0.2/3

2024-09-05 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Thursday, September 5, 2024 3:40 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm

RE: [PATCH] drm/amd/pm: Do not support swSMU if SMU IP is disabled

2024-08-19 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Zhang, Hawking Sent: Tuesday, August 20, 2024 2:31 PM To: amd-gfx@lists.freedesktop.org; Wang, Yang(Kevin) ; Feng, Kenneth Cc: Zhang, Hawking Subject: [PATCH

Re: [PATCH] drm/amd/pm: update message interface for smu v14.0.2/3

2024-08-19 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin From: Kenneth Feng Sent: Tuesday, August 20, 2024 08:59 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm

Re: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

2024-08-19 Thread Kevin Holm
On 17.08.24 10:42, Greg KH wrote: On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote: From: Wayne Lin [ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ] [Why] dm_dp_mst_is_port_support_mode() is a bit not following the original design rule and cause light up issue with

RE: [PATCH] drm/amd/amdgpu: add HDP_SD support on gc 12.0.0/1

2024-08-07 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Thursday, August 8, 2024 12:24 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject

RE: [PATCH] drm/amdgpu: remove RAS unused paramter 'err_addr'

2024-08-01 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Due to certain network issues, the same patch has been sent twice. Please ignore this one. Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Friday, August 2, 2024 10:18 AM To: amd-gfx

[PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

2024-07-31 Thread Kevin Holm
pixel encoding for mst mode validation") Link: https://lore.kernel.org/stable/d74a7768e957e6ce88c27a5bece0c64dff132...@holm.dev/T/#u Signed-off-by: Kevin Holm --- I resolved the merge conflict so that, after this patch is applied to the linux-6.10.y branch of the stable git repository, the

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-30 Thread kevin
ovide something for 6.10.y? > > Ciao, Thorsten > I reverted 4df96ba6676034 from v6.10.2 from the stable/linux git, resolving the conflict by removing everything that git marked as from the current branch and kept everything marked as from before the branch to merge. That resulted in

RE: [PATCH] drm/amd/pm: add overdrive support on smu v14.0.2/3

2024-07-29 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Some comments inline. After fixed, the patch is Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Tuesday, July 30, 2024 9:45 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin

RE: [PATCH] drm/amd/pm: update powerplay structure on smu v14.0.2/3

2024-07-28 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Monday, July 29, 2024 9:26 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: update

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-27 Thread kevin
> [adding a few people and lists to the recipients] > > Hi! Thx for your rpeort. > > On 27.07.24 18:07, ke...@holm.dev wrote: > > > > > Connecting two 4k displays with display port through a lenovo usb-c > > > > dock (type 40AS) to a Lenovo P14s Gen 2 (type 21A0) results in no > > > > image

RE: [PATCH v4 3/4] drm/amdgpu: add ras POSION_CONSUMPTION event id support

2024-07-07 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Zhang, Hawking Sent: Monday, July 8, 2024 1:06 PM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: RE: [PATCH v4 3/4] drm/amdgpu: add ras POSION_CONSUMPTION event id support

RE: [PATCH] amdgpu/pm: support gpu_metrics sysfs interface for smu v14.0.2/3

2024-07-03 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang It is better to change the patch tile prefix to 'drm/amd/pm' . Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Thursday, July 4, 2024 8:17 AM To: amd-gfx@lists.freedesktop.or

RE: [PATCH 3/4] drm/amdgpu: add ras POSION_CONSUMPTION event id support

2024-07-03 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Zhou1, Tao Sent: Wednesday, July 3, 2024 4:28 PM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: RE: [PATCH 3/4] drm/amdgpu: add ras POSION_CONSUMPTION event id support

RE: [PATCH] drm/amdgpu: sysfs node disable query error count during gpu reset

2024-06-28 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] it is better to apply changes on both ACA and MCA path. Best Regards, Kevin -Original Message- From: Chai, Thomas Sent: Friday, June 28, 2024 3:31 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li

RE: [PATCH] drm/amd/pm: check whether smu is idle in sriov case

2024-06-18 Thread Wang, Yang(Kevin)
This looks more like a workaround. Can we write the C2PMSG_90 register to 1 on the PF side when host receive GPU_RESET/GPU_INIT request command? Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Danijel Slivka Sent: 2024年6月18日 23:00 To: amd-gfx@lists.freedesktop.org

RE: [PATCH 5/5] drm/amdgpu: add gpu reset check and exception handling

2024-06-18 Thread Wang, Yang(Kevin)
-Original Message- From: Chai, Thomas Sent: 2024年6月18日 14:34 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, Stanley ; Chai, Thomas Subject: [PATCH 5/5] drm/amdgpu: add gpu reset check and exception handling Add gpu reset

RE: [PATCH 00/18] Enhance amdgpu_firmware_request() to improve function flexibility

2024-06-05 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Chris, I have checked my inbox and did not see your email. Could you please resend it? Best Regards, Kevin -Original Message- From: Koenig, Christian Sent: Wednesday, June 5, 2024 7:21 PM To: Wang, Yang(Kevin) ; amd-gfx

RE: [PATCH 00/18] Enhance amdgpu_firmware_request() to improve function flexibility

2024-06-05 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Ping... Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Monday, June 3, 2024 9:42 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH 00/18] Enhance

RE: [PATCH 05/12] drm/amd/pm: remove dead code in navi10_emit_clk_levels and navi10_print_clk_levels

2024-06-03 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Thank you for your clarification. Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Zhang, Jesse(Jie) Sent: Tuesday, June 4, 2024 11:52 AM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Deucher

RE: [PATCH 05/12] drm/amd/pm: remove dead code in navi10_emit_clk_levels and navi10_print_clk_levels

2024-06-03 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] CC [M] drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/navi10_ppt.o /home/kevin/Work/disk/linux/linux-next/drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/navi10_ppt.c: In function 'navi10_emit_clk_levels': /home/kevin/Work/disk/l

RE: [PATCH 05/12] drm/amd/pm: remove dead code in navi10_emit_clk_levels and navi10_print_clk_levels

2024-06-03 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Could you share the problems you encountered? Some compilers may prompt you to forget to handle default cases. Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Jesse Zhang Sent: Monday, June 3, 2024 4:48 PM To

RE: [PATCH 04/18] drm/amdgpu: refine mes firmware loading

2024-05-31 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Deucher, Alexander Sent: Friday, May 31, 2024 10:24 PM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: RE: [PATCH 04/18] drm/amdgpu: refine mes firmware loading [AMD

RE: [PATCH v2] drm/amd/pm: add missing error handling in function smu_v13_0_6_allocate_dpm_context

2024-05-31 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Bob Zhou Sent: Friday, May 31, 2024 4:22 PM To: amd-gfx@lists.freedesktop.org; Wang, Yang(Kevin) ; Huang, Tim ; Zhang, Jesse(Jie) Cc: Deucher, Alexander

RE: [PATCH] drm/amd/pm: add missing error handling in function smu_v13_0_6_allocate_dpm_context

2024-05-31 Thread Wang, Yang(Kevin)
smu_v13_0_6_allocate_dpm_context(struct smu_context *smu) smu_dpm->dpm_policies = kzalloc(sizeof(struct smu_dpm_policy_ctxt), GFP_KERNEL); + if (!smu_dpm->dpm_policies) + return -ENOMEM; [Kevin]: the 'smu_dpm->dpm_context' needs to be released together t

RE: [PATCH] drm/amdgpu/soc24: use common nbio callback to set remap offset

2024-05-29 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, May 30, 2024 2:08 AM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: Fix missing error code in amdgpu_od_set_init

2024-05-28 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Hi SRINIVASAN, Please pause this patch. The original intention of the patch was to avoid creating an empty directory ("gpu_od") , as this change may result in incorrect results. Thanks. Best Regards, Kevin -Origin

RE: [PATCH] drm/amdgpu: use u32 for buf size in __amdgpu_eeprom_xfer

2024-05-20 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Tuesday, May 21, 2024 11:17 AM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: use u32 for

RE: [PATCH] drm/amdgpu: update type of buf size to u32 for eeprom functions

2024-05-19 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Monday, May 20, 2024 10:46 AM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: update type of

RE: [PATCH v4 01/10] drm/amd/pm: Add support for DPM policies

2024-05-15 Thread Wang, Yang(Kevin)
); + struct amdgpu_device *adev = drm_to_adev(ddev); + + if (amdgpu_in_reset(adev)) + return -EPERM; + if (adev->in_suspend && !adev->in_runpm) + return -EPERM; + + return amdgpu_dpm_get_pm_policy_info(adev, buf); } + +#define STR_SOC_

RE: [PATCH] drm/amdgpu: fix compiler 'side-effect' check issue for RAS_EVENT_LOG()

2024-05-14 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Ping... Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Tuesday, May 14, 2024 8:03 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Kamal, Asad Subject: [PATCH] drm/amdgpu: fix compiler

RE: [PATCH 2/2] drm/amd/pm: check specific index for aldebaran

2024-05-14 Thread Wang, Yang(Kevin)
= smu_cmn_send_smc_msg_with_param(smu, > +SMU_MSG_GfxDeviceDriverReset, PPSMC_MSG_GfxDriverReset is different from SMU_MSG_GfxDeviceDriverReset. Use PPSMC_MSG_GfxDriverReset here (for both patches). Thanks, Lijo [Kevin]: There is no interface here to directly use PPSMC_MSG_XXX to send messages t

RE: [PATCH 1/5] drm/amdgpu/pm: Fix the null pointer dereference for smu7

2024-05-13 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Ma, Jun Sent: Monday, May 13, 2024 4:56 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Deucher, Alexander ; Wang, Yang(Kevin) ; Koenig, Christian

RE: [PATCH 3/5] drm/amdgpu: Fix null pointer dereference to aca_handle

2024-05-13 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Ma, Jun Sent: Monday, May 13, 2024 4:56 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Deucher, Alexander ; Wang, Yang(Kevin) ; Koenig, Christian ; Ma, Jun Subject: [PATCH 3/5] drm/amdgpu: Fix

RE: [PATCH 12/22] drm/amd/pm: remove logically dead code

2024-05-12 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Zhang, Jesse(Jie) Sent: Monday, May 13, 2024 10:19 AM To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig

RE: [PATCH 17/22] drm/amdgpu: fix the warning bad bit shift operation for aca_error_type type

2024-05-12 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Zhang, Jesse(Jie) Sent: Monday, May 13, 2024 10:19 AM To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander

Re: [PATCH 3/3] drm/amdgpu/pm: Fix the null pointer dereference in apply_state_adjust_rules

2024-05-10 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Series is Acked-by: Yang Wang Best Regards, Kevin From: Ma, Jun Sent: Friday, May 10, 2024 17:42 To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Deucher, Alexander ; Wang, Yang(Kevin) ; Koenig, Christian ; Ma, Jun

RE: [PATCH 13/22] drm/amd/pm: remove logically dead code for renoir

2024-05-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Please add following information into commit message. Fixes: ca55f459f5ad ("drm/amd/pm: add the fine grain tuning function for Renoir") Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Jesse

RE: [PATCH 15/22] drm/amd/pm: fix enum feature compared against 0

2024-05-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Jesse Zhang Sent: Friday, May 10, 2024 10:51 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Huang, Tim ; Zhang, Jesse(Jie

RE: [PATCH 05/22] drm/amd/pm: check specific index for aldebaran

2024-05-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Jesse Zhang Sent: Friday, May 10, 2024 10:50 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Huang, Tim ; Zhang, Jesse(Jie

RE: [PATCH 09/22] drm/amd/pm: check specific index for smu13

2024-05-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Reviewed-by: Yang Wang -Original Message- From: amd-gfx On Behalf Of Jesse Zhang Sent: Friday, May 10, 2024 10:50 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Huang, Tim ; Zhang, Jesse(Jie) ; Zhang, Jesse(Jie) Sub

RE: [PATCH 1/2] drm/amdgpu/pm: Check input value for power profile setting on smu13 and smu14

2024-05-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Ok, I miss this patch #2. And please merge swsmu parts in patch#1 to patch#2. (patch #1 : powerplay, patch #2: swsmu) Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Ma, Jun Sent: Friday, May 10, 2024 9:00 AM To: Wang, Yang

RE: [PATCH 1/2] drm/amdgpu/pm: Check input value for power profile setting on smu13 and smu14

2024-05-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] please fix similar issues in other xxx_ppt.c file together? e. g: navi10_ppt.c, etc Best Regards, Kevin -Original Message- From: Ma, Jun Sent: Thursday, May 9, 2024 5:37 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Deucher, Alexander

RE: [PATCH] drm/amdgpu/pm: Fix code alignment issue

2024-05-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Ma, Jun Sent: Thursday, May 9, 2024 5:37 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Deucher, Alexander ; Wang, Yang(Kevin) ; Koenig, Christian ; Ma, Jun Subject

RE: [PATCH] drm/amd/pm: Fix aldebaran pcie speed reporting

2024-05-09 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Lazar, Lijo Sent: Thursday, May 9, 2024 4:59 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Wang, Yang(Kevin) Subject: [PATCH] drm/amd/pm: Fix

RE: [PATCH] drm/amdgpu: change log level

2024-05-06 Thread Wang, Yang(Kevin)
Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Chai, Thomas Sent: 2024年5月7日 14:27 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, Stanley ; Chai, Thomas Subject: [PATCH] drm/amdgpu: change log level

RE: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches

2024-05-06 Thread Wang, Yang(Kevin)
Ping... Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: 2024年5月6日 14:47 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice Subject: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches This patch

  1   2   3   4   5   6   7   >