[PATCH] drm/amdgpu: fix incorrect MALL size for GFX1151

2025-05-08 Thread Tim Huang
On GFX1151, the reported MALL cache size reflects only half of its actual size; this adjustment corrects the discrepancy. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c

[PATCH] drm/amdgpu: add discovery support for DCN IP version 3.6.0

2025-02-07 Thread Tim Huang
Add discovery entry for DCN IP version 3.6.0. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index eca431e52038

[PATCH 5/7] drm/amdgpu: enable VCN/JPEG CGPG for GC IP version 11.5.3

2025-01-08 Thread Tim Huang
Enable VCN/JPEG CGPG for ASIC with GFX version 11.5.3. Signed-off-by: Saleemkhan Jamadar Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/soc21.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c

[PATCH 6/7] drm/amdgpu: add support for SMU IP version 14.0.5

2025-01-08 Thread Tim Huang
This initializes SMU IP version 14.0.5. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 + drivers/gpu/drm/amd/pm/swsmu/smu14

[PATCH 3/7] drm/amdgpu: add support for NBIO IP version 7.11.2

2025-01-08 Thread Tim Huang
This initializes NBIO IP version 7.11.2. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + drivers/gpu/drm/amd/amdgpu/soc21.c| 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

[PATCH 7/7] drm/amdgpu: add support for PSP IP version 14.0.5

2025-01-08 Thread Tim Huang
This initializes PSP IP version 14.0.5. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 drivers/gpu/drm/amd/amdgpu/psp_v14_0.c| 10 ++ 3 files changed, 15

[PATCH 4/7] drm/amdgpu: add support for MMHUB IP version 3.3.2

2025-01-08 Thread Tim Huang
This initializes MMHUB IP version 3.3.2. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 1 + drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm

[PATCH 1/7] drm/amdgpu: add support for GC IP version 11.5.3

2025-01-08 Thread Tim Huang
This initializes GC IP version 11.5.3. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 6 + drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 12 +- drivers/gpu/drm/amd/amdgpu

[PATCH 2/7] drm/amdgpu: add support for SDMA IP version 6.1.3

2025-01-08 Thread Tim Huang
This initializes SDMA IP version 6.1.3. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c| 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 ++ 3 files changed, 4 insertions(+) diff

[PATCH 2/2] drm/amdgpu: fix incorrect number of active RBs for gfx12

2025-01-05 Thread Tim Huang
The RB bitmap should be global active RB bitmap & active RB bitmap based on active SA. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c b/drivers/gpu/drm

[PATCH 1/2] drm/amdgpu: fix incorrect active RB bitmap in setup RBs

2025-01-05 Thread Tim Huang
The RB bitmap width per SA may be 0x1 for some ASICs. Use the actual bitmap of SA instead of 0x3 to determine the active RB bitmap. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amd/pm: print pp_dpm_mclk in ascending order on SMU v14.0.0

2024-10-27 Thread Tim Huang
Currently, the pp_dpm_mclk values are reported in descending order on SMU IP v14.0.0/1/4. Adjust to ascending order for consistency with other clock interfaces. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 2/2] drm/amd/pm: ensure the fw_info is not null before using it

2024-08-09 Thread Tim Huang
This resolves the dereference null return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm

[PATCH 1/2] drm/amdgpu: ensure the connector is not null before using it

2024-08-09 Thread Tim Huang
This resolves the dereference null return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amd/display: fix double free issue during amdgpu module unload

2024-08-06 Thread Tim Huang
+0x58/0x120 [ 279.194954] entry_SYSCALL_64_after_hwframe+0x6e/0x76 [ 279.194980] Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/display/dc/link/link_factory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/link_factory.c b/drivers

[PATCH 3/4] drm/amdgpu: fix unchecked return value warning for amdgpu_atombios

2024-08-01 Thread Tim Huang
This resolves the unchecded return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 35 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu

[PATCH 4/4] drm/amdgpu: check return for setting engine dram timings

2024-08-01 Thread Tim Huang
This resolves the unchecded return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 4 ++-- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 8 +--- 3 files changed, 11

[PATCH 2/4] drm/amdgpu: fix unchecked return value warning for amdgpu_gfx

2024-08-01 Thread Tim Huang
This resolves the unchecded return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd

[PATCH 1/4] drm/amd/pm: fix unchecked return value warning for vega10_hwmgr

2024-08-01 Thread Tim Huang
This resolves the unchecked return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu

[PATCH] drm/amdgpu: fix Coverity explicit null dereferenced warnings

2024-07-24 Thread Tim Huang
This is to address the Coverity explicit null dereferenced warnings by NULL returns from amdgpu_mes_ctx_get_offs* but without follow-up Checks. Meanwhile refactor the code to keep only one *_get_gpu/cpu_addr. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 +- drivers

[PATCH] drm/amdgpu: add missed harvest check for VCN IP v4/v5

2024-07-23 Thread Tim Huang
093093] init_module_from_file+0x97/0xd0 [ 54.093428] ? init_module_from_file+0x97/0xd0 [ 54.093777] idempotent_init_module+0x11c/0x2a0 [ 54.094134] __x64_sys_finit_module+0x64/0xc0 [ 54.094476] do_syscall_64+0x58/0x120 [ 54.094767] entry_SYSCALL_64_after_hwframe+0x6e/0x76 Signed-off-b

[PATCH] drm/amdgpu: fix potential probe issue for VCN IP v4.0.6

2024-07-23 Thread Tim Huang
093428] ? init_module_from_file+0x97/0xd0 [ 54.093777] idempotent_init_module+0x11c/0x2a0 [ 54.094134] __x64_sys_finit_module+0x64/0xc0 [ 54.094476] do_syscall_64+0x58/0x120 [ 54.094767] entry_SYSCALL_64_after_hwframe+0x6e/0x76 Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/vcn_v4

[PATCH] drm/amd/pm: early return if disabling DPMS for GFX IP v11.5.2

2024-07-14 Thread Tim Huang
This was intended to add support for GFX IP v11.5.2, but it needs to be applied to all GFX11 and subsequent APUs. Therefore the code should be revised to accommodate this. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 16 1 file changed, 4 insertions

[PATCH] drm/amd/pm: avoid to load smu firmware for APUs

2024-06-30 Thread Tim Huang
Certain call paths still load the SMU firmware for APUs, which needs to be skipped. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 8 +++- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 8 +++- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 8 +++- drivers/gpu/drm/amd/pm

[PATCH 7/7] drm/amdgpu: add firmware for PSP IP v14.0.4

2024-06-30 Thread Tim Huang
This patch is to add firmware for PSP 14.0.4. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c index 407477b895d1

[PATCH 5/7] drm/amdgpu: add SMU IP v14.0.4 discovery support

2024-06-30 Thread Tim Huang
This patch is to add SMU 14.0.4 support Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH 3/7] drm/amd/pm: smu v14.0.4 reuse smu v14.0.0 dpmtable

2024-06-30 Thread Tim Huang
From: Li Ma Replace IP VERSION with smu->is_apu in if condition. And the dpmtable of smu v14.0.4 is same as smu v14.0.0. Signed-off-by: Li Ma Reviewed-by: Yifan Zhang --- .../gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c| 18 --- .../drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 30 +++

[PATCH 6/7] drm/amdgpu: enable mode2 reset for SMU IP v14.0.4

2024-06-30 Thread Tim Huang
Set the default reset method to mode2 for SMU 14.0.4. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c index b43c50f1c7ad

[PATCH 4/7] drm/amd/pm: add SMU IP v14.0.4 support

2024-06-30 Thread Tim Huang
This patch is to add SMU 14.0.4 support. Signed-off-by: Li Ma Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 + drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd

[PATCH 2/7] drm/amdgpu: add PSP IP v14.0.4 discovery support

2024-06-30 Thread Tim Huang
This patch is to add PSP 14.0.4 support. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH 1/7] drm/amdgpu: add PSP IP v14.0.4 support

2024-06-30 Thread Tim Huang
This patch is to add PSP 14.0.4 support. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm

[PATCH 2/3] drm/amdgpu: add VPE IP v6.1.3 discovery support

2024-06-30 Thread Tim Huang
This patch is to add VPE 6.1.3 support. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH 3/3] drm/amdgpu: add firmware for VPE IP v6.1.3

2024-06-30 Thread Tim Huang
This patch is to add firmware for VPE 6.1.3. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/vpe_v6_1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vpe_v6_1.c b/drivers/gpu/drm/amd/amdgpu/vpe_v6_1.c index 09315dd5a1ec

[PATCH 1/3] drm/amdgpu: add VPE IP v6.1.3 support

2024-06-30 Thread Tim Huang
This patch is to add VPE 6.1.3 support. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c index bad232859972

[PATCH 1/2] drm/amdgpu: add NBIO IP v7.11.3 discovery support

2024-06-30 Thread Tim Huang
This patch is to add NBIO 7.11.3 support. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH 2/2] drm/amdgpu: Add NBIO IP v7.11.3 support

2024-06-30 Thread Tim Huang
Enable setting soc21 common clockgating for NBIO 7.11.3. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c index b04c763015d3

[PATCH 3/3] drm/amdgpu: add firmware for SDMA IP v6.1.2

2024-06-30 Thread Tim Huang
This patch is to add firmware for SDMA 6.1.2. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c index c833b6b8373b

[PATCH 2/3] drm/amdkfd: add KFD support for SDMA IP v6.1.2

2024-06-30 Thread Tim Huang
Enable KFD setting SDMA info for SDMA 6.1.2. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c index e6debd63a116

[PATCH 1/3] drm/amdgpu: add SDMA IP v6.1.2 discovery support

2024-06-30 Thread Tim Huang
This patch is to add SDMA 6.1.2 support. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH 7/7] drm/amdgpu: add firmware for GC IP v11.5.2

2024-06-30 Thread Tim Huang
This patch is to add firmware for GC 11.5.2. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 4 drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 1 + drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 ++ 3 files changed, 7 insertions(+) diff --git a

[PATCH 5/7] drm/amdgpu: add GC IP v11.5.2 to GC 11.5.0 family

2024-06-30 Thread Tim Huang
This patch is to add GC 11.5.2 to GC 11.5.0 family. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang Reviewed-by: Veerabadhran Gopalakrishnan --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 6/7] drm/amdkfd: add KFD support for GC IP v11.5.2

2024-06-30 Thread Tim Huang
Enable KFD for GC 11.5.2. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c | 5 + 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd

[PATCH 3/7] drm/amdgpu: add tmz support for GC IP v11.5.2

2024-06-30 Thread Tim Huang
Add tmz support for GC 11.5.2. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c index 3a7622611916..c02659025656

[PATCH 4/7] drm/amdgpu: add GC IP v11.5.2 soc21 support

2024-06-30 Thread Tim Huang
Add CG and PG flags for GFX IP v11.5.2 and PG flags for VCN IP v4.0.5. Signed-off-by: Saleemkhan Jamadar Signed-off-by: Li Ma Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang Reviewed-by: Veerabadhran Gopalakrishnan --- drivers/gpu/drm/amd/amdgpu/soc21.c | 26 ++ 1

[PATCH 2/7] drm/amdgpu: add GFXHUB IP v11.5.2 support

2024-06-30 Thread Tim Huang
This patch is to add GFXHUB 11.5.2 support. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c index cad883783834

[PATCH 1/7] drm/amdgpu: initialize GC IP v11.5.2

2024-06-30 Thread Tim Huang
Initialize GC 11.5.2 and set gfx hw configuration. Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 2/2] drm/amdgpu: fix mc_data out-of-bounds read warning

2024-05-06 Thread Tim Huang
Clear warning that read mc_data[i-1] may out-of-bounds. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c index 52b12c1718eb

[PATCH 1/2] drm/amdgpu: fix ucode out-of-bounds read warning

2024-05-06 Thread Tim Huang
Clear warning that read ucode[] may out-of-bounds. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c index b8280be6225d..c3d89088123d

[PATCH 3/3] drm/amdgpu: fix uninitialized variable warning for jpeg_v4

2024-05-05 Thread Tim Huang
Clear warning that using uninitialized variable r. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c index da6bb9022b80

[PATCH 2/3] drm/amdgpu: fix uninitialized variable warning for amdgpu_xgmi

2024-05-05 Thread Tim Huang
Clear warning that using uninitialized variable current_node. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c index dd2ec48cf5c2

[PATCH 1/3] drm/amdgpu: fix uninitialized variable warning for sdma_v7

2024-05-05 Thread Tim Huang
Clear warning that using uninitialized variable index. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c index 35d99a4afe83

[PATCH] drm/amd/pm: fix uninitialized variable warning for smu_v13

2024-04-29 Thread Tim Huang
Clear warning that using uninitialized variable when the dpm is not enabled and reuse the code for SMU13 to get the boot frequency. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 4 ++ .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 55 +-- .../drm

[PATCH 2/2] drm/amd/pm: fix uninitialized variable warnings for vangogh_ppt

2024-04-28 Thread Tim Huang
1. Fix a issue that using uninitialized mask to get the ultimate frequency. 2. Check return of smu_cmn_send_smc_msg_with_param to avoid using uninitialized variable residency. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 14 ++ 1 file changed, 14

[PATCH 1/2] drm/amd/pm: fix uninitialized variable warnings for vega10_hwmgr

2024-04-28 Thread Tim Huang
Clear warnings that using uninitialized variable when fails to get the valid value from SMU. Signed-off-by: Tim Huang --- .../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 46 ++- .../amd/pm/powerplay/smumgr/vega10_smumgr.c | 6 ++- 2 files changed, 39 insertions(+), 13

[PATCH] drm/amd/pm: fix uninitialized variable warning for smu8_hwmgr

2024-04-26 Thread Tim Huang
Clear warnings that using uninitialized value level when fails to get the value from SMU. Signed-off-by: Tim Huang --- .../drm/amd/pm/powerplay/hwmgr/smu8_hwmgr.c| 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr

[PATCH] drm/amdgpu: fix uninitialized scalar variable warning

2024-04-25 Thread Tim Huang
Clear warning that field bp is uninitialized when calling amdgpu_virt_ras_add_bps. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

[PATCH] drm/amdgpu: fix overflowed array index read warning

2024-04-25 Thread Tim Huang
Clear overflowed array index read warning by cast operation. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c index

[PATCH v2] drm/amdgpu: fix overflowed array index read warning

2024-04-25 Thread Tim Huang
From: Tim Huang Clear warning that cast operation might have overflowed. v2: keep reverse xmas tree order to declare "int r;" (Christian) Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] drm/amdgpu: fix overflowed array index read warning

2024-04-24 Thread Tim Huang
From: Tim Huang Clear warning that cast operation might have overflowed. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: fix potential resource leak warning

2024-04-24 Thread Tim Huang
From: Tim Huang Clear resource leak warning that when the prepare fails, the allocated amdgpu job object will never be released. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v3] drm/amdgpu: fix uninitialized scalar variable warning

2024-04-23 Thread Tim Huang
From: Tim Huang Clear warning that uses uninitialized value fw_size. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c

[PATCH v2] drm/amdgpu: fix uninitialized scalar variable warning

2024-04-23 Thread Tim Huang
From: Tim Huang Clear warning that uses uninitialized value fw_size. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c

[PATCH] drm/amdgpu: fix uninitialized scalar variable warning

2024-04-22 Thread Tim Huang
Clear warning that uses uninitialized value fw_size. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c index d9dc5485

[PATCH] drm/amdgpu: fix incorrect number of active RBs for gfx11

2024-04-03 Thread Tim Huang
From: Tim Huang The RB bitmap should be global active RB bitmap & active RB bitmap based on active SA. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers

[PATCH] drm/amd/pm: fixes a random hang in S4 for SMU v13.0.4/11

2024-03-27 Thread Tim Huang
From: Tim Huang While doing multiple S4 stress tests, GC/RLC/PMFW get into an invalid state resulting into hard hangs. Adding a GFX reset as workaround just before sending the MP1_UNLOAD message avoids this failure. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu13

[PATCH] drm/amdgpu: reserve more memory for MES runtime DRAM

2024-02-22 Thread Tim Huang
: Tim Huang --- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c index 26d71a22395d..36127e204dfe 100644 --- a/drivers/gpu/drm/amd/amdgpu/mes_v11_0

[PATCH v2] drm/amdgpu: fix memory overflow in the IB test

2023-11-21 Thread Tim Huang
Fix a memory overflow issue in the gfx IB test for some ASICs. At least 20 bytes are needed for the IB test packet. v2: correct code indentation errors. (Christian) Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2

[PATCH] drm/amdgpu: fix memory overflow in the IB test

2023-11-20 Thread Tim Huang
Fix a memory overflow issue in the gfx IB test for some ASICs. At least 20 bytes are needed for the IB test packet. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2

[PATCH v2] drm/amdgpu: fix GRBM read timeout when do mes_self_test

2023-11-01 Thread Tim Huang
Use a proper MEID to make sure the CP_HQD_* and CP_GFX_HQD_* registers can be touched when initialize the compute and gfx mqd in mes_self_test. Otherwise, we expect no response from CP and an GRBM eventual timeout. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 16

[PATCH] drm/amdgpu: fix GRBM read timeout when do mes_self_test

2023-11-01 Thread Tim Huang
Use a proper MEID to make sure the CP_HQD_* and CP_GFX_HQD_* registers can be touched when initialize the compute and gfx mqd in mes_self_test. Otherwise, we expect no response from CP and an GRBM eventual timeout. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 16

[PATCH 2/2] drm/amdgpu: move kfd_resume before the ip late init

2023-10-30 Thread Tim Huang
The kfd_resume needs to touch GC registers to enable the interrupts, it needs to be done before GFXOFF is enabled to ensure that the GFX is not off and GC registers can be touched. So move kfd_resume before the amdgpu_device_ip_late_init which enables the CGPG/GFXOFF. Signed-off-by: Tim Huang

[PATCH 1/2] drm/amd/pm: not stop rlc for IMU enabled APUs when suspend

2023-10-30 Thread Tim Huang
For IMU enabled APUs, after sending the PrepareMp1ForUnload message to SMU in system_features_control, the RLC registers can't be touched. The driver to stop the rlc in suspending is no longer required. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 + 1 file ch

[PATCH] drm/amd/pm: wait for completion of the EnableGfxImu command

2023-10-09 Thread Tim Huang
Wait for completion of sending the EnableGfxImu message when using the PSP FW loading. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b

[PATCH 2/2] drm/amd: flush any delayed gfxoff on suspend entry

2023-08-14 Thread Tim Huang
;t put in work queue but instead processed immediately. This is dead code due to commit 5d70a549d00d ("drm/amdgpu: skip CG/PG for gfx during S0ix") because GFXOFF will now not be explicitly called as part of the suspend entry code. Remove that dead code. Signed-off-by: Mario Limonci

[PATCH 1/2] drm/amdgpu: skip fence GFX interrupts disable/enable for S0ix

2023-08-14 Thread Tim Huang
configuration will be restored by GFXOFF exit. Signed-off-by: Tim Huang Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 41 +-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd

[PATCH] drm/amd/pm: bump SMU v13.0.5 driver_if header version

2023-08-10 Thread Tim Huang
Align the SMU driver interface version with PMFW to suppress the version mismatch message on driver loading. Signed-off-by: Tim Huang --- .../gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_5.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm

[PATCH] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11

2023-07-27 Thread Tim Huang
From: Tim Huang For SMU v13.0.4/11, driver does not need to stop RLC for S0i3, the firmwares will handle that properly. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu

[PATCH 3/3] drm/amd/pm: enable more Pstates profile levels for SMU v13.0.5

2023-06-09 Thread Tim Huang
This patch enables following UMD stable Pstates profile levels for power_dpm_force_performance_level interface. - profile_peak - profile_min_sclk - profile_standard Signed-off-by: Tim Huang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 40 ++- .../drm/amd/pm/swsmu/smu13

[PATCH 2/3] drm/amd/pm: enable vclk and dclk Pstates for SMU v13.0.5

2023-06-09 Thread Tim Huang
Add the ability to control the vclk and dclk frequency by power_dpm_force_performance_level interface. Signed-off-by: Tim Huang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 29 +++ 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13

[PATCH 1/3] drm/amd/pm: fix vclk setting failed for SMU v13.0.5

2023-06-09 Thread Tim Huang
PMFW use the left-shifted 16 bits argument to set the VCLK DPM frequency for SMU v13.0.5. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13

[PATCH 2/3] drm/amd/pm: enable vclk and dclk Pstates for SMU v13.0.4

2023-06-07 Thread Tim Huang
Add the ability to control the vclk and dclk frequency by power_dpm_force_performance_level interface. Signed-off-by: Tim Huang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 29 +++ 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13

[PATCH 3/3] drm/amd/pm: enable more Pstates profile levels for SMU v13.0.4

2023-06-07 Thread Tim Huang
This patch enables following UMD stable Pstates profile levels for power_dpm_force_performance_level interface. - profile_peak - profile_min_mclk - profile_min_sclk - profile_standard Signed-off-by: Tim Huang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 54 ++- 1 file

[PATCH 1/3] drm/amd/pm: fix vclk setting failed for SMU v13.0.4

2023-06-07 Thread Tim Huang
PMFW use the left-shifted 16 bits argument to set the VCLK DPM frequency for SMU v13.0.4. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 ++ drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 11 +-- 2 files changed, 11 insertions(+), 2

[PATCH] drm/amd/pm: reverse mclk and fclk clocks levels for renoir

2023-05-22 Thread Tim Huang
ff-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c index 5cdc07165480..8a8ba25c9ad7 100644 --- a/drivers/gpu/dr

[PATCH 3/4] amd/pm/swsmu: reverse mclk and fclk clocks levels for yellow carp

2023-05-22 Thread Tim Huang
ently. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c index ac5fcca0e47f..a92da33

[PATCH 1/4] amd/pm/swsmu: reverse mclk and fclk clocks levels for SMU v13.0.4

2023-05-22 Thread Tim Huang
ently. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c index 0a0a7debb3ae..46a8a36

[PATCH 4/4] amd/pm/swsmu: reverse mclk and fclk clocks levels for vangogh

2023-05-22 Thread Tim Huang
ently. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c index 7433dcaa16e0..067b4e0b026c 1

[PATCH 2/4] amd/pm/swsmu: reverse mclk clocks levels for SMU v13.0.5

2023-05-22 Thread Tim Huang
ff-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c index 165b2470b017..7c3ac535f68a 100644

[PATCH] drm/amdgpu: allow more APUs to do mode2 reset when go to S4 (v2)

2023-03-30 Thread Tim Huang
go to S4") Signed-off-by: Tim Huang Tested-by: Yuan Perry --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c index 0f7cd3e8e00b..edaf3ded4

[PATCH] drm/amdgpu: allow more APUs to do mode2 reset when go to S4

2023-03-29 Thread Tim Huang
Skip mode2 reset only for IMU enabled APUs when do S4. This patch is to fix the regression issue https://gitlab.freedesktop.org/drm/amd/-/issues/2483 It is generated by patch "2bedd3f21b30 drm/amdgpu: skip ASIC reset for APUs when go to S4". Signed-off-by: Tim Huang --- drivers/g

[PATCH] drm/amd/pm: re-enable the gfx imu when smu resume

2023-03-24 Thread Tim Huang
If the gfx imu is poweroff when suspend, then it need to be re-enabled when resume. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 40 --- 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b

[PATCH 2/2] drm/amdgpu: skip ASIC reset for APUs when go to S4

2023-03-15 Thread Tim Huang
d old GFX9 APUs. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 5f02c530e2cc..64214996278b 100644 --- a/drivers/gp

[PATCH 1/2] drm/amdgpu: reposition the gpu reset checking for reuse

2023-03-15 Thread Tim Huang
Move the amdgpu_acpi_should_gpu_reset out of CONFIG_SUSPEND to share it with hibernate case. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 40 +--- 2 files changed, 24 insertions(+), 20 deletions

[PATCH] drm/amdgpu: skip ASIC reset for GC IP v11.0.4/11 when go to S4

2023-03-13 Thread Tim Huang
lback(): pci_pm_freeze+0x0/0xd0 returns -62 [ 100.415311] amdgpu :62:00.0: PM: pci_pm_freeze+0x0/0xd0 returned -62 after 4623202 usecs [ 100.416608] amdgpu :62:00.0: PM: failed to freeze async: error -62 [How] Skip the ASIC reset for S4, assuming we can resume properly without reset. Signed-off-by

[PATCH] drm/amd/pm: bump SMU 13.0.4 driver_if header version

2023-03-07 Thread Tim Huang
Align the SMU driver interface version with PMFW to suppress the version mismatch message on driver loading. Signed-off-by: Tim Huang --- .../drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_4.h| 4 ++-- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 +- 2 files changed

[PATCH RESEND] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11

2023-01-27 Thread Tim Huang
PMFW will handle the features disablement properly for gpu reset case, driver involvement may cause some unexpected issues. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu

[PATCH v2] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11

2023-01-20 Thread Tim Huang
PMFW will handle that properly for gpu reset case. Driver involvement may cause some unexpected issues. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers

[PATCH RESEND] drm/amdgpu: skip psp suspend for IMU enabled ASICs mode2 reset

2023-01-20 Thread Tim Huang
The psp suspend & resume should be skipped to avoid destroy the TMR and reload FWs again for IMU enabled APU ASICs. Signed-off-by: Tim Huang Acked-by: Alex Deucher Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 1 file changed, 12 insert

[PATCH 1/2] drm/amdgpu: skip psp suspend for IMU enabled ASICs mode2 reset

2023-01-20 Thread Tim Huang
The psp suspend & resume should be skipped to avoid destroy the TMR and reload FWs again for IMU enabled APU ASICs. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/am

[PATCH 2/2] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11

2023-01-20 Thread Tim Huang
PMFW will handle that properly. Driver involvement may cause some unexpected issues. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu

  1   2   >