Re: [PATCH 0/3] drm/amd/display: fixes for kernel crashes since cursor overlay mode

On 12/17/24 1:45 PM, Melissa Wen wrote: Hi, Some issues have been found by Cosmic users of AMD display since the introduction of cursor overlay mode: page fault and divide errors causing interface freezes. Both are 100% reproducible and affects multiple HW versions. Patch 1 addresses the pag

Re: [PATCH 0/2] drm/amd/display: Fix Power Gating Configuration

On 11/5/24 7:02 AM, Zicheng Qu wrote: Hi all, I am submitting two patches to correct power gating configurations in the AMD display driver. 1. Patch 1/2 (Fixes: 46825fcfbe16): Corrects DOMAIN10_PG_CONFIG to use DOMAIN10_POWER_FORCEON. 2. Patch 2/2 (Fixes: 46825fcfbe16): Corrects DOMAIN11_PG_

Re: [RFC PATCH] drm/amd/display/dc: Refactor remove duplications

Hi Luan, Sorry for the delay. Anyway, I ran your changes in our CI, and overall, everything looks good. I just have some comments for your V1. On 10/9/24 9:34 AM, Luan Icaro Pinto Arcanjo wrote: From: LipArcanjo It looks like your Signed-off-by does not match with the author. All dce co

Re: [PATCH] drm/amd/display: Add debug option to disable idle optimizations

On 10/15/24 11:41 AM, Aurabindo Pillai wrote: For debugging purposes, add a runtime override to disable display scanout from MALL cache (MALL Static Screen) by disallowing the driver from triggering the idle power optimizations when desktop is idle. Signed-off-by: Aurabindo Pillai --- driv

Re: [PATCH 22/24] drm/amd/display: Adjust cursor position

On 8/8/24 4:06 PM, Melissa Wen wrote: On 07/08/2024 04:55, Tom Chung wrote: From: Rodrigo Siqueira [why & how] When the commit 9d84c7ef8a87 ("drm/amd/display: Correct cursor position on horizontal mirror") was introduced, it used the wrong calculation for the position copy for X. This com

Re: [PATCH] drm/amd/display: Add kdoc entry for 'bs_coeffs_updated' in dpp401_dscl_program_isharp

On 7/22/24 7:15 AM, Srinivasan Shanmugam wrote: Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/dpp/dcn401/dcn401_dpp_dscl.c:961: warning: Function parameter or struct member 'bs_coeffs_updated' not described in 'dpp401_dscl_program_isharp' Fixes: 431ae65ea4e1 ("drm/a

Re: [PATCH] drm/amd/display: fix corruption with high refresh rates on DCN 3.0

On 7/16/24 11:33 AM, Alex Deucher wrote: This reverts commit bc87d666c05a13e6d4ae1ddce41fc43d2567b9a2 and the register changes from commit 6d4279cb99ac4f51d10409501d29969f687ac8dc. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3478 Cc: mikhail.v.gavri...@gmail.com Cc: Rodrigo Siquei

Re: [PATCH v2] drm/amd/display: Add otg_master NULL check within init_pipe_slice_table_from_context

On 7/9/24 3:10 AM, Ma Ke wrote: To avoid reports of NULL_RETURN warning, we should add otg_master NULL check. Cc: sta...@vger.kernel.org Fixes: c51d87202d1f ("drm/amd/display: do not attempt ODM power optimization if minimal transition doesn't exist") Signed-off-by: Ma Ke --- Changes in v2: -

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

On 7/9/24 6:41 AM, Linux regression tracking (Thorsten Leemhuis) wrote: On 30.06.24 01:18, Mikhail Gavrilov wrote: On Sat, Jun 29, 2024 at 9:46 PM Rodrigo Siqueira Jordao wrote: I'm trying to reproduce this issue, but until now, I've been unable to reproduce it. I tried some

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

On 6/29/24 5:18 PM, Mikhail Gavrilov wrote: On Sat, Jun 29, 2024 at 9:46 PM Rodrigo Siqueira Jordao wrote: Hi Mikhail, I'm trying to reproduce this issue, but until now, I've been unable to reproduce it. I tried some different scenarios with the following components: 1. Display

Re: [PATCH] drm/amd/display/dc: Remove dc code repetition

Hi Joao, First of all, thanks for your patch. Follows some of my comments: > On 6/13/24 10:05 AM, Joao Paulo Pereira da Silva wrote: You can drop the dc part in the commit title. Also, the title should highlight that you are decoupling one part of the code in a single place to avoid duplicati

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

On 6/28/24 9:19 AM, Alex Deucher wrote: On Fri, Jun 21, 2024 at 6:45 AM Mikhail Gavrilov wrote: On Fri, Jun 21, 2024 at 12:56 PM Linux regression tracking (Thorsten Leemhuis) wrote: Hmmm, I might have missed something, but it looks like nothing happened here since then. What's the status?

Re: [PATCH v2] drm/amd/display: Fix null pointer deref in dcn20_resource.c

On 6/26/24 4:28 PM, Aurabindo Pillai wrote: Changes in v2: detailed description about the how the issue is reproduced, and remove an extraneous else keyword. Just remove this 'Changes in v2' part, with this change: Reviewed-by: Rodrigo Siqueira Fixes a hang thats triggered when MPV is r

Re: [PATCH] drm/amd/display: Fix null pointer deref in dcn20_resource.c

On 6/26/24 11:16 AM, Aurabindo Pillai wrote: Fixes a hang that has the following calltrace: [ 181.843989] BUG: kernel NULL pointer dereference, address: [ 181.843997] #PF: supervisor instruction fetch in kernel mode [ 181.844003] #PF: error_code(0x0010) - not-present page

Re: [PATCH] drm/amd/display: fix documentation warnings for mpc.h

Hi Marcelo, First of all, thanks a lot for your patch! Please check some of my inline comments. On 4/27/24 10:05 AM, Marcelo Mendes Spessoto Junior wrote: Fix most of the display documentation compile warnings by documenting struct mpc_funcs functions in dc/inc/hw/mpc.h file. Could you add

Re: [PATCH 1/2] drm/amd/display: clean inconsistent indenting

On 2/13/24 3:43 PM, Joao Paulo Pereira da Silva wrote: From: jppaulo Clean some wrong indenting that throw errors in checkpatch. Signed-off-by: Joao Paulo Pereira da Silva --- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --gi

Re: [PATCH] drm/amd/display: Remove duplicated function signature from dcn3.01 DCCG

On 2/22/24 7:19 AM, David Tadokoro wrote: In the header file dc/dcn301/dcn301_dccg.h, the function dccg301_create is declared twice, so remove duplication. Signed-off-by: David Tadokoro --- drivers/gpu/drm/amd/display/dc/dcn301/dcn301_dccg.h | 6 -- 1 file changed, 6 deletions(-) dif

Re: [PATCH] drm/amd/display: use mpcc_count to log MPC state

On 4/12/24 10:39 AM, Melissa Wen wrote: According to [1]: ``` DTN only logs 'pipe_count' instances of MPCC. However in some cases there are different number of MPCC than DPP (pipe_count). ``` As DTN log still relies on pipe_count to print mpcc state, switch to mpcc_count in all occurrences.

Re: [PATCH RESEND] drm/amd/display: Fix division by zero in setup_dsc_config

On 4/22/24 8:35 AM, Jose Fernandez wrote: When slice_height is 0, the division by slice_height in the calculation of the number of slices will cause a division by zero driver crash. This leaves the kernel in a state that requires a reboot. This patch adds a check to avoid the division by zero.

Re: [PATCH] Revert "drm/amd/display: Fix sending VSC (+ colorimetry) packets for DP/eDP displays without PSR"

On 3/12/24 9:24 AM, Harry Wentland wrote: This causes flicker on a bunch of eDP panels. The info_packet code also caused regressions on other OSes that we haven't' seen on Linux yet, but that is likely due to the fact that we haven't had a chance to test those environments on Linux. We'll nee

Re: [PATCH] drm/amd/display: Remove redundant condition in dcn35_calc_blocks_to_gate()

On 2/23/24 11:39 PM, Srinivasan Shanmugam wrote: pipe_ctx->plane_res.mpcc_inst is of a type that can only hold values between 0 and 255, so it's always greater than or equal to 0. Thus the condition 'pipe_ctx->plane_res.mpcc_inst >= 0' was always true and has been removed. Fixes the below: d

Re: [PATCH] drm/amd/display: Improve 'dml32_TruncToValidBPP()' function

On 2/23/24 11:39 PM, Srinivasan Shanmugam wrote: Refactors the dml32_TruncToValidBPP function by removing a redundant return statement. The function previously had a return statement at the end that was never executed because all execution paths in the function ended with a return statement b

Re: [PATCH] drm/amd/display: Address kdoc for commit_minimal_transition_state_in_dc_update()

On 3/18/24 6:50 AM, Srinivasan Shanmugam wrote: Adds descriptions for 'new_context', 'srf_updates', and 'surface_count', and removes the excess description for 'context'. Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Function parameter or mem

Re: [PATCH v5 7/8] drm/amd/display: Introduce KUnit tests to dc_dmub_srv library

On 2/26/24 04:12, Jani Nikula wrote: On Thu, 22 Feb 2024, Rodrigo Siqueira wrote: diff --git a/drivers/gpu/drm/amd/display/test/kunit/.kunitconfig b/drivers/gpu/drm/amd/display/test/kunit/.kunitconfig index eb6f81601757..4c5861ad58bd 100644 --- a/drivers/gpu/drm/amd/display/test/kunit/.kuni

Re: [PATCH] drm/amd/display: Use kcalloc() instead of kzalloc()

On 1/28/24 02:04, Lenko Donchev wrote: We are trying to get rid of all multiplications from allocation functions to prevent integer overflows. Here the multiplication is obviously safe, but using kcalloc() is more appropriate and improves readability. This patch has no effect on runtime behavi

Re: [PATCH] drm/amd/display: clean unnecessary braces

Hi Túlio, First of all thanks for your patch. See my comments inline. On 2/17/24 13:20, Túlio Fernandes wrote: Clean unnecessary braces in dc/dcn32/dcn32_resource_helpers.c and dc/dcn32/dcn201_link_encoder.c Did you identify this issue with checkpatch? If so, I recommend you paste the error

Re: [PATCH] drm/amdgpu/display: Address kdoc for 'is_psr_su' in 'fill_dc_dirty_rects'

On 2/15/24 05:57, Srinivasan Shanmugam wrote: The is_psr_su parameter is a boolean flag indicating whether the Panel Self Refresh Selective Update (PSR SU) feature is enabled which is a power-saving feature that allows only the updated regions of the screen to be refreshed, reducing the amount

Re: [PATCH v2 0/8] Expand and improve AMDGPU documentation

On 1/23/24 09:19, Hamza Mahfooz wrote: On 1/22/24 16:24, Rodrigo Siqueira wrote: This patchset improves how the AMDGPU display documentation is organized, expands the kernel-doc to extract information from the source, and adds more context about DC workflow. Finally, at the end of this series

Re: [PATCH v2] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions

Hi Srinivasan On 1/17/24 08:23, Srinivasan Shanmugam wrote: The 'status' variable in 'core_link_read_dpcd()' & 'core_link_write_dpcd()' was uninitialized. Thus, initializing 'status' variable to 'DC_ERROR_UNEXPECTED' by default. Fixes the below: drivers/gpu/drm/amd/amdgpu/../display/dc/link/pr

Re: [PATCH] drm/amd/display: cleanup inconsistent indenting in amdgpu_dm_color

On 1/5/24 15:02, Melissa Wen wrote: smatch warnings: amdgpu_dm_update_plane_color_mgmt() warn: inconsistent indenting Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202401051643.ppdbmg1u-...@intel.com/ Signed-off-by: Melissa Wen --- drivers/gpu/drm/amd/displ

Re: [PATCH 1/1] Revert "drm/amd/display: fix bandwidth validation failure on DCN 2.1"

On 1/7/24 11:51, Melissa Wen wrote: On 01/06, LIPSKI, IVAN wrote: [AMD Official Use Only - General] @Siqueira, Rodrigo From: LIPSKI, IVAN Sent: January 5, 2024 7:40 PM To: amd-gfx@lists.freedesktop.org Cc: rodrigo.siqui...@a

Re: [PATCH v2] drm/amd/display: Adjust kdoc for 'dcn35_hw_block_power_down' & 'dcn35_hw_block_power_up'

On 12/21/23 10:13, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn35/dcn35_hwseq.c:1124: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Charlene Liu C

Re: [PATCH] drm/amd/display: Adjust kdoc for 'dcn35_hw_block_power_down' & 'dcn35_hw_block_power_up'

On 12/19/23 00:37, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn35/dcn35_hwseq.c:1124: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Charlene Liu C

Re: [PATCH v2] drm/amd/display: Address function parameter 'context' not described in 'dc_state_rem_all_planes_for_stream' & 'populate_subvp_cmd_drr_info'

On 12/21/23 09:28, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_state.c:524: warning: Function parameter or member 'state' not described in 'dc_state_rem_all_planes_for_stream' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc

Re: [PATCH] drm/amd/display: Disable IPS by default

On 12/20/23 12:30, roman...@amd.com wrote: From: Roman Li [Why] Instability is observed on DCN35 if idle power optimization is enabled. [How] Disable IPS until issue is resolved. Signed-off-by: Roman Li Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2

Re: [PATCH v3 3/9] drm/amd/display: read gamut remap matrix in fixed-point 31.32 format

On 11/28/23 10:52, Melissa Wen wrote: Instead of read gamut remap data from hw values, convert HW register values (S2D13) into a fixed-point 31.32 matrix for color state log. Change DCN10 log to print data in the format of the gamut remap matrix. Signed-off-by: Melissa Wen --- .../amd/disp

Re: [PATCH v3 1/9] drm/amd/display: decouple color state from hw state log

On 11/28/23 10:52, Melissa Wen wrote: Prepare to hook up color state log according to the DCN version. v3: - put functions in single line (Siqueira) Signed-off-by: Melissa Wen --- .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 26 +-- 1 file changed, 18 insertions(+), 8

Re: [PATCH] drm/amd/display: add kernel docs for dc_stream_forward_crc_window

Hi Sagar, First of all, thanks for your patch. On 10/25/23 08:04, Sagar Vashnav wrote: Add kernel documentation for the dc_stream_forward_crc_window Signed-off-by: Sagar Vashnav --- drivers/gpu/drm/amd/display/dc/core/dc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/

Re: [PATCH v2 0/2] Fix issues caused by DML2 in ASICs older than DCN35

On 10/20/23 15:38, Harry Wentland wrote: On 2023-10-20 17:26, Rodrigo Siqueira wrote: The first commit of this series just sets the variable using_dml2 to false for all ASICs that do not require it. The second commit adds a fix to the DC sequence that calls a DML2 operation in ASICs that does

Re: [PATCH 0/2] Reduce stack size for DML2

Hi Nathan, (+Hamza) First of all, thanks a lot for your feedback. You can see my comments inline. On 10/17/23 11:22, Nathan Chancellor wrote: Hi Rodrigo, On Mon, Oct 16, 2023 at 08:19:16AM -0600, Rodrigo Siqueira wrote: Stephen discovers a stack size issue when compiling the latest amdgpu c

Re: [PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation.

On 9/21/23 08:15, Sebastian Andrzej Siewior wrote: Hi, I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix is #4 + #5 and the rest was made while looking at the code. Sebastian Hi Sebastian, Thanks a lot for this patchset. We tested it on multiple devices, and ever

Re: [PATCH] drm/amd/display: switch DC over to the new DRM logging macros

On 9/22/23 08:42, Hamza Mahfooz wrote: On 9/22/23 10:36, Rodrigo Siqueira Jordao wrote: Hi Hamza, This is a very nice improvement and overall lgtm. I just one comment and one question. For future series like this, I recommend splitting your commit into minor changes to make it easier to

Re: [PATCH] drm/amd/display: switch DC over to the new DRM logging macros

Hi Hamza, This is a very nice improvement and overall lgtm. I just one comment and one question. For future series like this, I recommend splitting your commit into minor changes to make it easier to review and revert changes in case of regressions. Also, with a patchset, you could add a cov

Re: [RFC PATCH v2 0/5] drm/amd/display: improve DTN color state log

On 9/13/23 10:43, Melissa Wen wrote: Hi, This is an update of previous RFC [0] improving the data collection of Gamma Correction and Blend Gamma color blocks. As I mentioned in the last version, I'm updating the color state part of DTN log to match DCN3.0 HW better. Currently, the DTN log co

Re: [RFC PATCH v2 2/5] drm/amd/display: fill up DCN3 DPP color state

On 9/13/23 10:43, Melissa Wen wrote: DCN3 DPP color state was uncollected and some state elements from DCN1 doesn't fit DCN3. Create new elements according to DCN3 color caps and fill them up for DTN log output. rfc-v2: - fix reading of gamcor and blnd gamma states Signed-off-by: Melissa Wen

Re: [RFC PATCH v2 1/5] drm/amd/display: detach color state from hw state logging

On 9/13/23 10:43, Melissa Wen wrote: Prepare to hook color state logging according to DCN version. Signed-off-by: Melissa Wen --- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 27 +-- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/disp

Re: [PATCH v2] drm/amd/display: Adjust kdoc for 'optc35_set_odm_combine'

On 8/29/23 08:38, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_optc.c:46: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Enable CRTC Cc

Re: [PATCH] drm/amd/display: Fix up kdoc for 'optc35_set_odm_combine'

Hi, Consider renaming the commit title to something like "Adjust kernel-doc for ...". Anyway, avoid use the keyword "Fix/Fixes" for kernel-doc. On 8/28/23 22:50, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_opt

Re: [PATCH] drm/amd/display: Fix useless else if in display_mode_vba_util_32.c

On 8/16/23 00:51, Srinivasan Shanmugam wrote: The assignment of the else if and else branches is the same, so the else if here is redundant, hence removed it. Fixes the below: drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no

Re: [PATCH] drm/amd/display: Use seq_puts() in 'amdgpu_current_colorspace_show()' & 'edp_ilr_show()'

On 6/22/23 02:58, Srinivasan Shanmugam wrote: Replace seq_printf with seq_puts when there is no argument list. Fix the checkpatch warning: WARNING: Prefer seq_puts to seq_printf Cc: Wayne Lin Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam

Re: [PATCH] drm/amd/display: Remove redundant braces in 'amdgpu_dm_crtc_notify_ta_to_read()'

On 6/22/23 03:38, Srinivasan Shanmugam wrote: Adhere to Linux kernel coding style. Reported by checkpatch: WARNING: braces {} are not necessary for single statement blocks Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdg

Re: [PATCH] drm/amd/display: Remove spaces before tabs in amdgpu_dm_hdcp.c

On 6/22/23 05:00, Srinivasan Shanmugam wrote: Conform to Linux kernel coding style. Reported by checkpatch: WARNING: please, no space before tabs Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 40 +++

Re: [PATCH] drm/amd/display: Clean up style problems in amdgpu_dm_irq.c

On 6/22/23 08:12, Srinivasan Shanmugam wrote: Fix the following warnings reported by checkpatch: WARNING: Block comments use a trailing */ on a separate line WARNING: Comparisons should place the constant on the right side of the test WARNING: space prohibited between function name and open p

Re: [PATCH v2] drm/amd/display: Remove else after return in 'dm_crtc_get_scanoutpos()'

On 6/20/23 20:51, Srinivasan Shanmugam wrote: Conform to Linux kernel coding style. Reported by checkpatch: WARNING: else is not generally useful after a break or return Expressions under 'else' branch in function 'dm_crtc_get_scanoutpos' are executed whenever the expression in 'if' is Fals

Re: [PATCH] drm/amd/display: Remove else after return statement in 'dm_update_plane_state'

On 6/19/23 06:02, Srinivasan Shanmugam wrote: Else is not necessary after return statements, hence remove it. Reported by checkpatch: WARNING: else is not generally useful after a break or return drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9776: return -

Re: [PATCH] drm/amd/display: Fix errors & warnings in amdgpu_dm.c

Please, remove the word "Fix" from the commit tittle before merge it. On 6/17/23 09:56, Srinivasan Shanmugam wrote: Fix the following errors & warnings reported by checkpatch: ERROR: space required before the open brace '{' ERROR: space required before the open parenthesis '(' ERROR: that open

Re: [PATCH] drm/amd/display: Fix errors & warnings in amdgpu_dm.c

On 6/17/23 09:56, Srinivasan Shanmugam wrote: Fix the following errors & warnings reported by checkpatch: ERROR: space required before the open brace '{' ERROR: space required before the open parenthesis '(' ERROR: that open brace { should be on the previous line ERROR: space prohibited befor

Re: [PATCH] drm/amd/display: Convert to kdoc formats in dc/core/dc.c

On 6/13/23 19:21, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3483: warning: Cannot understand * *** drivers/gpu/drm/amd/amdgpu/../display/dc/cor

Re: [PATCH] drm/amd/display: Provide function name for 'optc32_enable_crtc()'

On 6/3/23 08:28, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_optc.c:109: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Enable CRT

Re: [PATCH] drm/amdgpu: Add missing function parameter 'optc' & 'enable' to kdoc in optc3_set_timing_double_buffer()

On 6/3/23 08:53, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:285: warning: Function parameter or member 'optc' not described in 'optc3_set_timing_double_buffer' drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30

Re: [PATCH] drm/amd/display: Correct kdoc formats in dcn10_opp.c

On 6/4/23 23:10, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning: display/dc/dcn10/dcn10_opp.c:52: warning: Function parameter or member 'oppn10' not described in 'opp1_set_truncation' display/dc/dcn10/dcn10_opp.c:52: warning: Function parameter or member 'params' n

Re: [PATCH] drm/amd/display: Correct and remove excess function parameter names in kdoc

On 6/11/23 19:32, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:872: warning: Excess function parameter 'drr_pipe' description in 'subvp_drr_schedulable' drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fp

Re: [PATCH] drm/amd/display: Only use ODM2:1 policy for high pixel rate displays

On 6/6/23 09:47, Aurabindo Pillai wrote: We only gain a benefit of using the ODM2:1 dynamic policy if it allow us to decrease DISPCLK to use the VMIN freq. If the display config can already achieve VMIN DISPCLK freq without ODM2:1, don't apply the policy. This patch was reverted but that cau

Re: [PATCH] Revert "drm/amd/display: Only use ODM2:1 policy for high pixel rate displays"

On 6/2/23 12:04, Aurabindo Pillai wrote: This reverts commit 047783cdd5f604d87398236beb4971abb4d43293 since it causes higher power consumption for single display use case (4k60). Also, this patch introduced a 35% performance drop in a Vulkan benchmark. * The patch disabled the ODM-combinatio

Re: [PATCH v2] drm/amd/display: Address kdoc warnings in dcn30_fpu.c

On 6/2/23 09:19, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: display/dc/dml/dcn30/dcn30_fpu.c:677: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Finds dummy_latency_index when MCLK switching using f

Re: [PATCH] drm/amd/display: Add gnu_printf format attribute for snprintf_count()

On 5/30/23 14:33, Srinivasan Shanmugam wrote: Fix the following W=1 kernel build warning: display/dc/dcn10/dcn10_hw_sequencer_debug.c: In function ‘snprintf_count’: display/dc/dcn10/dcn10_hw_sequencer_debug.c:56:2: warning: function ‘snprintf_count’ might be a candidate for ‘gnu_printf’ form

Re: [PATCH v2] drm/amd/display: Avoid disabling GCC specific flag with clang for snprintf_count()

Hi, Imho, it makes more sense to use: https://patchwork.freedesktop.org/patch/540285 Thanks Siqueira On 6/1/23 22:14, Srinivasan Shanmugam wrote: These warning can cause build failure: display/dc/dcn10/dcn10_hw_sequencer_debug.c: In function ‘snprintf_count’: display/dc/dcn10/dcn10_hw_sequen

Re: [PATCH v2] drm/amd/display: Program OTG vtotal min/max selectors unconditionally for DCN1+

On 6/2/23 09:01, Aurabindo Pillai wrote: For FPO/FAMS, DMCUB will try to change the output timings by writing to the OTG registers. However, the timings written directly to the OTG registers will not be honoured unless VMIN/VMAX selector registers are programmed with the right bits and trigger

Re: [PATCH] drm/amd/display: Fix up dcn30_fpu.c kdoc

On 6/2/23 02:37, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: display/dc/dml/dcn30/dcn30_fpu.c:677: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Finds dummy_latency_index when MCLK switching using f

Re: [PATCH] drm/amd/display: Program OTG vtotal min/max selectors unconditionally for DCN1+

Hi Jay, On 6/1/23 11:09, Aurabindo Pillai wrote: Due to FPO, firmware will try to change OTG timings, which would only latch if min/max selectors for vtotal are written by the driver. Could you elaborate a little bit more about this issue? Right now, do we have some sort of race between firmw

Re: [PATCH v2] drm/amd/display: Fix artifacting on eDP panels when engaging freesync video mode

On 5/18/23 09:45, Aurabindo Pillai wrote: [Why] When freesync video mode is enabled, switching resolution from native mode to one of the freesync video compatible modes can trigger continous artifacts on some eDP panels when running under KDE. The articating can be seen in the attached bug re

Re: [PATCH] drm/amd/display: Fix artifacting on eDP panels when engaging freesync video mode

On 5/17/23 15:10, Aurabindo Pillai wrote: Additional checks are necessary related to stream and scaling changes before setting freesync video mode when an eDP panel is in use, otherwise it can create artifacts on the panel. Hi Jay, Could you expand the commit message to elaborate more about

Re: [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()

On 5/17/23 12:33, Hamza Mahfooz wrote: Since, we are only interested in having drm_edid_override_connector_update(), update the value of connector->edid_blob_ptr. We don't care about the return value of drm_edid_override_connector_update() here. So, drop count. Fixes: 068553e14f86 ("drm/amd/d

Re: [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()

On 5/17/23 12:33, Hamza Mahfooz wrote: set_abm_event() is never actually used. So, drop it. Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature") Reported-by: kernel test robot Reported-by: Tom Rix Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 1

Re: [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices()

On 5/17/23 12:33, Hamza Mahfooz wrote: get_available_dsc_slices() returns the number of indices set, and all of the users of get_available_dsc_slices() don't cross the returned bound when iterating over available_slices[]. So, the memset() in get_available_dsc_slices() is redundant and can be

Re: [PATCH 2/3] drm/amd/display: enable low power mode for VGA memory

On 5/11/23 09:38, Aurabindo Pillai wrote: [Why] When unused, all memory blocks should be put in a low power state [How] Check the value of enable_mem_low_power.bits.vga and set corresponding bit in the hardware register Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc

Re: [PATCH 3/3] drm/amd/display: formatting fixes for dcn30_hwseq.c

On 5/11/23 09:38, Aurabindo Pillai wrote: Fix whitespace issues and other trivial formatting fixes Signed-off-by: Aurabindo Pillai --- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 27 --- 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/am

Re: [PATCH 1/3] drm/amd/display: Add some missing register definitions

On 5/11/23 09:38, Aurabindo Pillai wrote: [Why&How] Add some missing register definitions and rearrange some others to maintain consistency with related definitions. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/dce/dce_hwseq.h| 69 +++ .../include/asi

Re: [PATCH v4] drm/amd/display: Add logging when DP link training Channel EQ is Successful

On 4/19/23 06:00, Srinivasan Shanmugam wrote: Log when Channel Equalization is successful. Cc: Aurabindo Pillai Cc: Fangzhi Zuo Signed-off-by: Srinivasan Shanmugam --- v2: - For consistency of the printed messages, either drop or keep %s for both the lines - it is dropped (Aurabi

Re: [PATCH] drm/amd/display: Add logging for eDP v1.4 supported sink rates

On 4/24/23 21:04, Srinivasan Shanmugam wrote: Include eDP v1.4 panels supported sink rates in debug output, useful info for knowing optimized link rates Cc: Aurabindo Pillai Cc: Jerry Zuo Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/dc/link/protocols/link_dp_capability

Re: [PATCH 2/2] drm/amd/display: Program OTG vtotal min/max selectors unconditionally

On 4/21/23 14:39, Aurabindo Pillai wrote: [Why&How] Drop the above line, with that: Reviewed-by: Rodrigo Siqueira OTG_V_TOTAL_MIN/MAX_SEL bits are required to be programmed to 1 if writes to OTG timing registers need to be honoured. This is usually needed only when freesync is active. H

Re: [PATCH 1/2] Revert "drm/amd/display: disable SubVP + DRR to prevent underflow"

On 4/21/23 14:39, Aurabindo Pillai wrote: This reverts commit 541908cc2cca427fc3ae3bd4c9b82797a78e63a9. Hi, Please add an explanation of the reason why we want to revert this patch. With that change: Reviewed-by: Rodrigo Siqueira Thanks Siqueira --- drivers/gpu/drm/amd/display/amdgpu_dm

Re: [PATCH v3 0/6] drm/amd/display: Pass proper parent for DM backlight device v3

On 3/12/23 13:17, Hans de Goede wrote: Hi All, Here is version 3 of my patch series to pass the proper parent device to backlight_device_register(). Changes in v3: - Make amdgpu_dm_register_backlight_device() check bl_idx != 1 before registering the backlight since amdgpu_dm_connector_lat

Re: [RFC v2 0/6] drm/amd/display: Pass proper parent for DM backlight device v2

Hi Hans, Which AMD device do you have available for testing this series? P.s.: If you have a new version of this series, could you also Cc me? Thanks for your patchset. Siqueira On 3/8/23 14:58, Hans de Goede wrote: Hi All, Here is version 2 of my patch series to pass the proper parent devic

Re: [PATCH] drm/amd/display: use a more accurate check in dm_helpers_dp_read_dpcd()

On 3/9/23 14:30, Hamza Mahfooz wrote: We should be checking if drm_dp_dpcd_read() returns the size that we are asking it to read instead of just checking if it is greater than zero. Also, we should WARN_ON() here since this condition is only ever met, if there is an issue worth investigating.

Re: [PATCH] drm/amd/display: remove legacy fields of dc_plane_cap struct

On 3/7/23 15:53, David Tadokoro wrote: The fields blends_with_above and blends_with_below of struct dc_plane_cap (defined in dc/dc.h) are boolean and set to true by default. All instances of a dc_plane_cap maintain the default values of both. Also, there is only one if statement that checks th

Re: [PATCH] Revert "drm/amdgpu/display: change pipe policy for DCN 2.1"

On 2/28/23 12:54, Alex Deucher wrote: This reverts commit fa458eb10dc7218146a84e6d2e072424e64d188a. The issue is no longer present even with this commit present as verified by the original reporter. Signed-off-by: Alex Deucher Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1849#note_

Re: [PATCH] drm/amd/display: Fix set scaling doesn's work

On 1/11/23 10:19, Harry Wentland wrote: On 1/10/23 10:58, Rodrigo Siqueira Jordao wrote: On 11/22/22 06:20, hongao wrote: [Why] Setting scaling does not correctly update CRTC state. As a result dc stream state's src (composition area) && dest (addressable area) was not

Re: [PATCH] drm: amd: display: Fix memory leakage

On 11/29/22 21:50, Konstantin Meskhidze wrote: This commit fixes memory leakage in dc_construct_ctx() function. Signed-off-by: Konstantin Meskhidze --- drivers/gpu/drm/amd/display/dc/core/dc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/

Re: [PATCH] drm/amd/display: Fix set scaling doesn's work

On 11/22/22 06:20, hongao wrote: [Why] Setting scaling does not correctly update CRTC state. As a result dc stream state's src (composition area) && dest (addressable area) was not calculated as expected. This causes set scaling doesn's work. [How] Correctly update CRTC state when setting sca

Re: [PATCH] drm/amd/display: No need for Null pointer check before kfree

On 12/27/22 13:39, Deepak R Varma wrote: kfree() & vfree() internally performs NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree(). Issue reported by ifnullfree.cocci

Re: [PATCH] drm/amd/display: fix array index out of bound error in DCN32 DML

On 12/5/22 16:08, Aurabindo Pillai wrote: [Why&How] LinkCapacitySupport array is indexed with the number of voltage states and not the number of max DPPs. Fix the error by changing the array declaration to use the correct (larger) array size of total number of voltage states. Signed-off-by: A

Re: [PATCH] drm/amd/display: trigger timing sync only if TG is running

On 11/21/22 17:14, Aurabindo Pillai wrote: [Why&How] If the timing generator isnt running, it does not make sense to trigger a sync on the corresponding OTG. Check this condition before starting. Otherwise, this will cause error like: *ERROR* GSL: Timeout on reset trigger! Fixes: 8c7924bdb0f

Re: [PATCH v4 1/1] drm/amd/display: add DCN support for ARM64

On 2022-11-01 12:31, Nathan Chancellor wrote: On Tue, Nov 01, 2022 at 10:36:08AM -0400, Rodrigo Siqueira Jordao wrote: On 2022-10-31 15:37, Ao Zhong wrote: After moving all FPU code to the DML folder, we can enable DCN support for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG

Re: [PATCH v4 1/1] drm/amd/display: add DCN support for ARM64

On 2022-10-31 15:37, Ao Zhong wrote: After moving all FPU code to the DML folder, we can enable DCN support for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the code in the DML folder that needs to use hardware FPU, and add a control mechanism for ARM Neon. Signed-off-by: Ao

Re: [PATCH RESEND 1/1] drm/amd/display: add DCN support for ARM64

On 2022-10-27 15:24, Estela ad Astra wrote: Hello. I have tested it on a Phytium D2000 platform with RX 5500 XT. Distro: Arch Linux ARM Kernel: Linux 6.0.5-1-phytium aarch64 (patched, https://github.com/saeziae/pkgbuild-linux-phytium ) Plug and unplug: OK on all ports. Resolutions teste

Re: [PATCH v3 1/1] drm/amd/display: add DCN support for ARM64

On 2022-10-28 11:09, Nathan Chancellor wrote: Hi Ao, On Thu, Oct 27, 2022 at 09:52:29PM +0200, Ao Zhong wrote: After moving all FPU code to the DML folder, we can enable DCN support for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the code in the DML folder that needs to use

Re: [PATCH] drm/amd/display: Revert logic for plane modifiers

On 2022-10-19 11:15, Joaquín Ignacio Aramendía wrote: This file was split in commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f ("drm/amd/display: Create a file dedicated to planes") the logic in dm_plane_format_mod_supported() function got changed by a switch logic. That change broke drm_plane m

Re: [PATCH] drm/amdgpu/dm/mst: Fix incorrect usage of drm_dp_add_payload_part2()

On 2022-10-04 16:24, Lyude Paul wrote: Yikes, it appears somehow I totally made a mistake here. We're currently checking to see if drm_dp_add_payload_part2() returns a non-zero value to indicate success. That's totally wrong though, as this function only returns a zero value on success - not t

Re: [PATCH] drm/amd/display: Remove unused struct i2c_id_config_access

On 2022-09-27 09:39, Yuan Can wrote: After commit 5a8132b9f606("drm/amd/display: remove dead dc vbios code"), no one use struct i2c_id_config_access, so remove it. Signed-off-by: Yuan Can --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 7 --- 1 file changed, 7 deletions(-) d

  1   2   >