ctive client running in
parallel with GPU hogs.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Danilo Krummrich
Cc: Matthew Brost
Cc: Philipp Stanner
Cc: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/sched_rq.c | 10 ++
1 file changed, 10 insertions(+)
diff --g
aring jobs.
This commit renames DRM_BUDDY_CLEAR_ALLOCATION as
DRM_BUDDY_PREFER_CLEAR_ALLOCATION to make the intent clearer, and
delete the tests that expected that passing this flag would return
cleared memory.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_
order- 1 free: 256 KiB, blocks: 32
The runtime is better (2 sec) and stable across multiple runs, and we
also see that the reported "clear_free" amount is larger than without
the patch.
Fixes: 96950929eb23 ("drm/buddy: Implement tracking clear page feature")
Signed-of
e code and that seem to work as expected.
Pierre-Eric Pelloux-Prayer (3):
drm/buddy: add a flag to disable trimming of non cleared blocks
drm/buddy: use DRM_BUDDY_CLEAR_ALLOCATION as a hint, not a hard req
drm/buddy: dont go over the higher orders multiple times
drivers/gpu/drm/
Le 18/06/2025 à 11:18, Pierre-Eric Pelloux-Prayer a écrit :
Adding an API to reserve fixed numbers would work but:
* if the fixed numbers are chosen by the driver ("drm_reserve_id(u64_max
-1)"), I don't see the benefit over the current patch
* if the fixed numbers are a
Adding an API to reserve fixed numbers would work but:
* if the fixed numbers are chosen by the driver ("drm_reserve_id(u64_max
-1)"), I don't see the benefit over the current patch
* if the fixed numbers are allocated by drm (drm_reserve_id("vm_update") ->
u64), it would then require a way
Le 13/06/2025 à 10:35, Danilo Krummrich a écrit :
On Fri, Jun 13, 2025 at 10:23:15AM +0200, Christian König wrote:
Another option is to just add an interface to get a kernel client_id from the
same atomic / IDA.
That won't give us fixed numbers for in kernel clients.
That's fine, then let
Hi,
Le 13/06/2025 à 01:48, Danilo Krummrich a écrit :
On Thu, Jun 12, 2025 at 09:00:34AM +0200, Christian König wrote:
On 6/11/25 17:11, Danilo Krummrich wrote:
Mhm, reiterating our internal discussion on the mailing list.
I think it would be nicer if we could use negative values for the ke
Since this ID is traced in the gpu_scheduler trace events, this
allows to determine the source of each job sent to the hardware.
To make grepping easier, the IDs are defined as they will appear
in the trace output.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu
Hi,
Le 28/05/2025 à 21:07, Lucas De Marchi a écrit :
On Mon, May 26, 2025 at 02:54:44PM +0200, Pierre-Eric Pelloux-Prayer wrote:
drivers/gpu/drm/xe/xe_sched_job.c | 3 ++-
diff --git a/drivers/gpu/drm/xe/xe_sched_job.c
b/drivers/gpu/drm/xe/xe_sched_job.c
index f0a6ce610948
mstdenis/umr/-/merge_requests/37
- v8:
https://lists.freedesktop.org/archives/dri-devel/2025-March/496781.html
Pierre-Eric Pelloux-Prayer (10):
drm/debugfs: Output client_id in in drm_clients_info
drm/sched: Store the drm client_id in drm_sched_fence
drm/sched: Add device name to the drm_sched_proce
tch to using it.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Christian König
Reviewed-by: Arvind Yadav
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 ++
drivers/gpu/drm/lima/lima_trace.h | 6 ++
.../gp
Log fences using the same format for coherency.
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Christian König
Reviewed-by: Arvind Yadav
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers
r/drm_client_id
together.
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/accel/amdxdna/aie2_ctx.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
drivers/gpu
Log fences using the same format for coherency.
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Christian König
Reviewed-by: Arvind Yadav
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers
tch to using it.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Christian König
Reviewed-by: Arvind Yadav
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 ++
.../gpu/drm/scheduler/gpu_scheduler_trace.h| 18 ++
drivers/gp
r/drm_client_id
together.
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/accel/amdxdna/aie2_ctx.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
drivers/gpu
/496781.html
Pierre-Eric Pelloux-Prayer (10):
drm/debugfs: Output client_id in in drm_clients_info
drm/sched: Store the drm client_id in drm_sched_fence
drm/sched: Add device name to the drm_sched_process_job event
drm/sched: Cleanup gpu_scheduler trace events
drm/sched: Trace dependencies
This information is useful when investigating page faults.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 25 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 3 ++-
drivers/gpu
It can be useful when getting a page fault.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 36 +++
.../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.h | 1 +
2 files changed, 37 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu
Using the drm_printer interface will allow us to use these functions
when generating the coredump.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 5 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
This reverts commit b75818d0d28f1e06ca396cc2b8a38601b44c4788.
dma_resv_describe outputs new lines so it breaks the "one line
per BO" formatting.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 +-
1 file changed, 1 insertion(+), 5
The coredump needs to contain accurate data and reporting a page
fault from a previous issue is incorrect.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 13 -
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.h | 1 +
drivers/gpu/drm
Coredumps are automatically removed after 5 minutes, but if a new one
is created while one exists already, the new one is discarded silently.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 5 +
1 file changed, 5 insertions(+)
diff --git a
on my machine.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 43 +--
.../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.h | 7 +++
2 files changed, 46 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump
unit tests.
* Pulled one cleanup patch earlier.
* Fixed "drm/sched: Avoid double re-lock on the job free path".
Cc: Christian König
Cc: Danilo Krummrich
CC: Leo Liu
Cc: Matthew Brost
Cc: Philipp Stanner
Cc: Pierre-Eric Pelloux-Prayer
Cc: Michel Dänzer
Tvrtko Ursulin (16):
drm/
Le 15/05/2025 à 08:53, Pierre-Eric Pelloux-Prayer a écrit :
Hi,
Le 14/05/2025 à 14:44, Philipp Stanner a écrit :
On Thu, 2025-04-24 at 10:38 +0200, Pierre-Eric Pelloux-Prayer wrote:
This will be used in a later commit to trace the drm client_id in
some of the gpu_scheduler trace events
Hi,
Le 14/05/2025 à 14:44, Philipp Stanner a écrit :
On Thu, 2025-04-24 at 10:38 +0200, Pierre-Eric Pelloux-Prayer wrote:
This will be used in a later commit to trace the drm client_id in
some of the gpu_scheduler trace events.
This requires changing all the users of drm_sched_job_init to
add
Hi Philipp,
Did you get a chance to take a look at the latest revision of this series?
Thanks,
Pierre-Eric
Le 24/04/2025 à 10:38, Pierre-Eric Pelloux-Prayer a écrit :
Hi,
The initial goal of this series was to improve the drm and amdgpu
trace events to be able to expose more of the inner
Log fences using the same format for coherency.
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
tch to using it.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 ++
.../gpu/drm/scheduler/gpu_scheduler_trace.h| 18 ++
drivers/gpu/drm/scheduler/sched_main
r/drm_client_id
together.
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/accel/amdxdna/aie2_ctx.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
drivers/gpu
vents:
https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37
- v8:
https://lists.freedesktop.org/archives/dri-devel/2025-March/496781.html
Pierre-Eric Pelloux-Prayer (10):
drm/debugfs: output client_id in in drm_clients_info
drm/sched: store the drm client_id in drm_sched_fence
drm/sched: add device
Hi,
Le 16/04/2025 à 12:01, Khatri, Sunil a écrit :
On 4/16/2025 12:56 PM, Tvrtko Ursulin wrote:
On 15/04/2025 19:43, Sunil Khatri wrote:
add process and pid information in the userqueue error
logging to make it more useful in resolving the error
by logs.
Sample log:
[ 42.444297] [drm:amdg
Hi,
Le 11/04/2025 à 06:54, Yadav, Arvind a écrit :
Alex,
This is v2 of 2/2 patch. Please review this.
~arvind
On 4/10/2025 8:27 PM, Arvind Yadav wrote:
This patch is load usermode queue based on FW support for gfx12.
CP Ucode FW Vesion: [PFP = 2840, ME = 2780, MEC = 3050, MES = 123]
v2: Addr
've missed something?
Thanks,
Pierre-Eric
Le 20/03/2025 à 10:57, Pierre-Eric Pelloux-Prayer a écrit :
Hi,
The initial goal of this series was to improve the drm and amdgpu
trace events to be able to expose more of the inner workings of
the scheduler and drivers to developers via tools.
T
Reviewed-by: Pierre-Eric Pelloux-Prayer
Le 24/03/2025 à 20:48, Alex Deucher a écrit :
ping on this series?
Alex
On Thu, Mar 20, 2025 at 12:57 PM Alex Deucher wrote:
In dev core dump, dump the full header fifo for
each queue. Each FIFO has 8 entries.
Signed-off-by: Alex Deucher
Log fences using the same format for coherency.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
b/drivers/gpu/drm/amd
tch to using it.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 ++
.../gpu/drm/scheduler/gpu_scheduler_trace.h| 18 ++
drivers/gpu/drm/scheduler/sched_main.c | 1 -
include/drm/
r/drm_client_id
together.
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/accel/amdxdna/aie2_ctx.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
drivers/gpu/drm/amd/amdg
7:
https://lists.freedesktop.org/archives/dri-devel/2025-January/488117.html
Pierre-Eric Pelloux-Prayer (10):
drm/debugfs: output client_id in in drm_clients_info
drm/sched: store the drm client_id in drm_sched_fence
drm/sched: add device name to the drm_sched_process_job event
drm/sched: cleanup gpu_s
Otherwise an uninitialized value can be returned if
amdgpu_res_cleared returns true for all regions.
Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality")
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1
r/drm_client_id
together.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/accel/amdxdna/aie2_ctx.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 8 +---
s/umr/-/merge_requests/37
- v6:
https://lists.freedesktop.org/archives/dri-devel/2024-November/477644.html
Pierre-Eric Pelloux-Prayer (7):
drm/debugfs: output client_id in in drm_clients_info
drm/sched: store the drm client_id in drm_sched_fence
drm/sched: add device name to the drm_sched_process_job
This init is useless because base.sched will be cleared to 0 in
drm_sched_job_init
because of 2320c9e6a768 ("drm/sched: memset() 'job' in drm_sched_job_init()").
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 -
1 file
It's unused.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 6 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 3 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 3 +--
drivers/gpu/dr
tually not used in this function.
The next commit will remove the ring argument completely.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job
Thanks for the updated patch, looks good to me.
Le 09/10/2024 à 14:31, Christian König a écrit :
Am 09.10.24 um 14:28 schrieb Mohammed Anees:
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value fr
Hi,
Le 05/10/2024 à 01:59, Mohammed Anees a écrit :
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value from amdgpu_cs_p1_bo_handles(). This patch
ensures that once an error condition is detected,
Le 08/10/2024 à 10:13, Christian König a écrit :
Am 03.10.24 um 14:43 schrieb Pierre-Eric Pelloux-Prayer:
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit
Le 08/10/2024 à 10:24, Christian König a écrit :
Am 03.10.24 um 14:43 schrieb Pierre-Eric Pelloux-Prayer:
If a drm_file name is set append it to the process name.
This information is useful with the virtio/native-context driver: this
allows the guest applications identifier to visible in
gears/test-set-fd-name --
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 1 +
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29
Add an optional drm-client-name field to drm fdinfo's output.
Reviewed-by: Christian König
Reviewed-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-usage-stats.rst | 5 +
drivers/gpu/drm/drm_file.c| 5 +
2 files changed, 10 inser
And rename it process_desc, since it will soon contain more than
just the process_name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
At the point the VM is locked (through the root PDs dma_resv object), so
it's safer to call amdgpu_vm_set_task_info.
The original place was not protected against concurrent access, but the
risk was limited to mangled process/task name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
driver
valid use, and clears the existing name.
Reviewed-by: Tvrtko Ursulin
Reviewed-by: Dmitry Osipenko
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 14 +++---
drivers/gpu/drm/drm_file.c| 5
drivers/gpu/drm/drm_ioctl.c | 51 +
tches 1, 4 and 6 were slightly reworked based on Tvrtko' suggestions.
v4: https://lists.freedesktop.org/archives/dri-devel/2024-September/471695.html
Pierre-Eric Pelloux-Prayer (6):
drm: add DRM_SET_CLIENT_NAME ioctl
drm: use drm_file client_name in fdinfo
drm/amdgpu: d
Le 25/09/2024 à 09:54, Pierre-Eric Pelloux-Prayer a écrit :
All attributes do the same thing wrt to runtime power management,
so we can consolidate the handling in 2 wrappers.
For some setters this will change the behavior slightly, as rpm
is now done before arguments validation - so the
valid use, and clears the existing name.
Reviewed-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 14 ++---
drivers/gpu/drm/drm_file.c| 5
drivers/gpu/drm/drm_ioctl.c | 55 +++
include/drm/drm_fil
And rename it process_desc, since it will soon contain more than
just the process_name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
gears/test-set-fd-name --
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 1 +
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
ssage of commit 3/6 (Trvtko)
* reworked amdgpu_vm_set_task_info a bit in 4/6 (Trvtko)
v3: https://lists.freedesktop.org/archives/dri-devel/2024-September/470488.html
Pierre-Eric Pelloux-Prayer (6):
drm: add DRM_SET_CLIENT_NAME ioctl
drm: use drm_file client_name in fdinfo
drm/amdgpu: delay th
Add an optional drm-client-name field to drm fdinfo's output.
Reviewed-by: Christian König
Reviewed-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-usage-stats.rst | 5 +
drivers/gpu/drm/drm_file.c| 5 +
2 files changed, 10 inser
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29
At the point the VM is locked (through the root PDs dma_resv object), so
it's safer to call amdgpu_vm_set_task_info.
The original place was not protected against concurrent access, but the
risk was limited to mangled process/task name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
driver
Le 26/09/2024 à 11:27, Lazar, Lijo a écrit :
On 9/25/2024 1:24 PM, Pierre-Eric Pelloux-Prayer wrote:
Don't wake up the GPU for reading pm values. Instead, take a runtime
powermanagement ref when trying to read it iff the GPU is already
awake.
This avoids spurious wake ups (eg:
Le 26/09/2024 à 10:55, Lazar, Lijo a écrit :
On 9/25/2024 1:24 PM, Pierre-Eric Pelloux-Prayer wrote:
Reading pm values from the GPU shouldn't prevent it to be suspended
by resetting the last active timestamp (eg: if an background app
monitors GPU sensors every second, it would preven
Le 25/09/2024 à 15:35, Lazar, Lijo a écrit :
On 9/25/2024 1:24 PM, Pierre-Eric Pelloux-Prayer wrote:
Don't wake up the GPU for reading pm values. Instead, take a runtime
powermanagement ref when trying to read it iff the GPU is already
awake.
This avoids spurious wake ups (eg:
Le 25/09/2024 à 15:37, Lazar, Lijo a écrit :
On 9/25/2024 1:24 PM, Pierre-Eric Pelloux-Prayer wrote:
pm_runtime_get_if_in_use already checks if the GPU is active,
so there's no need for manually checking runtimepm status:
if (adev->in_suspend && !adev->in_runpm)
.
Tested-by: Mario Limonciello
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 399 -
drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h | 16 +-
2 files changed, 78 insertions(+), 337 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm
Same logic as the previous commit ("drm/amdgpu/pm: use
pm_runtime_get_if_active for debugfs getters"): debugfs accesses shouldn't
wake up the GPU nor preventing it to be suspended.
Tested-by: Mario Limonciello
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu
Move stuff that's only used in amdgpu_pm.c to the top of file instead
of leaving it in a .h files included in 30+ files.
Tested-by: Mario Limonciello
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 98 +++
drivers/gpu/drm/amd/p
pm_runtime_get_if_in_use already checks if the GPU is active,
so there's no need for manually checking runtimepm status:
if (adev->in_suspend && !adev->in_runpm)
return -EPERM;
Tested-by: Mario Limonciello
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
dri
wake?" not about "is the GPU awake and something else
prevents suspend?".
Tested-by: Mario Limonciello
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 138 ++---
1 file changed, 69 insertions(+), 69 deletions(-)
diff --git
Using pm_runtime_resume_and_get over pm_runtime_get_sync is recommended.
Tested-by: Mario Limonciello
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 263 ++---
1 file changed, 89 insertions(+), 174 deletions(-)
diff --git a/drivers
They're not used.
Tested-by: Mario Limonciello
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../powerplay/hwmgr/vega20_processpptables.c | 574
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h |5 -
.../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 433 --
.../amd/pm/
Reading pm values from the GPU shouldn't prevent it to be suspended
by resetting the last active timestamp (eg: if an background app
monitors GPU sensors every second, it would prevent the autosuspend
sequence to trigger).
Tested-by: Mario Limonciello
Signed-off-by: Pierre-Eric Pelloux-P
pm_runtime_put_autosuspend must be called from all exit paths.
Tested-by: Mario Limonciello
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
b/drivers/gpu/drm/amd/pm
s/amd-gfx/2024-August/113213.html
It's not a direct successor of it, hence v1.
Instead, this is part of a larger series that applies the same ideas to
the whole amdgpu module.
Pierre-Eric Pelloux-Prayer (9):
drm/amd/pm: remove dump_pptable functions
drm/amd/pm: fix rpm refcount handlin
Le 24/09/2024 à 10:43, Tvrtko Ursulin a écrit :
On 24/09/2024 09:23, Christian König wrote:
Am 23.09.24 um 12:25 schrieb Tvrtko Ursulin:
On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote:
At this point the vm is locked so we safely modify it without risk of
concurrent access.
To
Le 23/09/2024 à 12:06, Tvrtko Ursulin a écrit :
On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote:
Giving the opportunity to userspace to associate a free-form
name with a drm_file struct is helpful for tracking and debugging.
This is similar to the existing DMA_BUF_SET_NAME ioctl
Le 23/09/2024 à 12:58, Tvrtko Ursulin a écrit :
On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote:
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit
Hi Dmitry,
Le 23/09/2024 à 12:28, Dmitry Osipenko a écrit :
On 9/20/24 12:06, Pierre-Eric Pelloux-Prayer wrote:
Giving the opportunity to userspace to associate a free-form
name with a drm_file struct is helpful for tracking and debugging.
This is similar to the existing DMA_BUF_SET_NAME
allocated on first submit
- amdgpu_task_info::process_name was renamed process_desc,
and includes drm_file::name when set. Like task_info
allocation this is done only once.
Pierre-Eric Pelloux-Prayer (6):
drm: add DRM_SET_NAME ioctl
drm: use drm_file name in fdinfo
drm/amdgpu:
And rename it process_desc, since it will soon contain more than
just the process_name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
gears/test-set-fd-name --
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 1 +
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 15 +--
1
At this point the vm is locked so we safely modify it without risk of
concurrent access.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b
Add an optional drm-client-name field to drm fdinfo's output.
Reviewed-by: Christian König
Reviewed-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-usage-stats.rst | 5 +
drivers/gpu/drm/drm_file.c| 5 +
2 files changed, 10 inser
-'
* if a 0-length string is passed the name is cleared
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 12 ++---
drivers/gpu/drm/drm_file.c| 5
drivers/gpu/drm/drm_ioctl.c | 48 +++
include/drm/drm_file.h|
Le 03/07/2024 à 16:10, Christian König a écrit :
Am 03.07.24 um 14:48 schrieb Pierre-Eric Pelloux-Prayer:
Le 02/07/2024 à 15:35, Christian König a écrit :
Am 02.07.24 um 15:23 schrieb Pierre-Eric Pelloux-Prayer:
Before this commit, only submits with both a BO_HANDLES chunk and a
Le 02/07/2024 à 15:35, Christian König a écrit :
Am 02.07.24 um 15:23 schrieb Pierre-Eric Pelloux-Prayer:
Before this commit, only submits with both a BO_HANDLES chunk and a
'bo_list_handle' would be rejected (by amdgpu_cs_parser_bos).
But if UMD sent a multiple BO_HANDLES,
bo_handles would
overwrite the previous p->bo_list value
This commit rejects submissions with multiple BO_HANDLES chunks to
match the implementation of the parser.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4
1 file changed, 4 insertions(+)
Le 26/06/2024 à 15:59, Alex Deucher a écrit :
On Wed, Jun 26, 2024 at 6:54 AM Christian König
wrote:
Am 25.06.24 um 19:44 schrieb Alex Deucher:
On Tue, Jun 25, 2024 at 10:32 AM Pierre-Eric Pelloux-Prayer
wrote:
The call to radeon_vm_clear_freed might clear bo_va->bo, so
we have to ch
The call to radeon_vm_clear_freed might clear bo_va->bo, so
we have to check it before dereferencing it.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/radeon/radeon_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_gem.c
The call to radeon_vm_clear_freed might clear bo_va->bo, so
we have to check it before dereferencing it.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/radeon/radeon_gem.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rad
Le 20/06/2024 à 15:36, Christian König a écrit :
Am 20.06.24 um 15:06 schrieb Pierre-Eric Pelloux-Prayer:
Le 19/06/2024 à 11:26, Christian König a écrit :
Am 18.06.24 um 17:23 schrieb Pierre-Eric Pelloux-Prayer:
Waking up a device can take multiple seconds, so if it's not
going to be
ize.
Marek
On Tue, Jun 18, 2024 at 11:30 AM Pierre-Eric Pelloux-Prayer
wrote:
libdrm_amdgpu uses AMDGPU_INFO_READ_MMR_REG to fill the dev->info.gb_addr_cfg
value.
Since this value is already known by the kernel, this commit implements a new
query to return it.
The libdrm MR to use this qu
Le 19/06/2024 à 11:26, Christian König a écrit :
Am 18.06.24 um 17:23 schrieb Pierre-Eric Pelloux-Prayer:
Waking up a device can take multiple seconds, so if it's not
going to be used we might as well not resume it.
The safest default behavior for all ioctls is to resume the GPU,
so
1 - 100 of 166 matches
Mail list logo
