On Fri, 1 Jul 2022 17:11:02 +0530, Vijendar Mukunda wrote:
> Jadeite(JD) platform is Stoney APU varaint which uses I2S MICSP
> instance and ES8336 Codec.
> This patch series creates I2S platform devices for JD platform,
> adds I2S MICSP instance support and Machine driver support
>
> This patch se
On Fri, Jul 01, 2022 at 05:11:02PM +0530, Vijendar Mukunda wrote:
> This patch set depends on:
> --checkpatch warnings patch
>
> --https://patchwork.kernel.org/project/alsa-devel/patch/20220627125834.481731-1-vijendar.muku...@amd.com/
That's "drm: amd: amdgpu: fix checkpatch warnin
On Thu, Jun 30, 2022 at 08:47:55AM +0530, Vijendar Mukunda wrote:
> + depends on SND_SOC_AMD_ACP && I2C && ACPI
The code treated ACPI as optional so you could relax the ACPI dependency
ot be "ACPI || COMPILE_TEST" (I think the same applies to I2C).
signature.asc
Description: PGP signature
On Thu, Jun 30, 2022 at 08:47:54AM +0530, Vijendar Mukunda wrote:
> +static int st_es8336_hw_params(struct snd_pcm_substream *substream,
> +struct snd_pcm_hw_params *params)
> +{
> + int ret = 0;
> + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substr
On Tue, 28 Jun 2022 10:46:04 +0100, Mauro Carvalho Chehab wrote:
> As we're currently discussing about making kernel-doc issues fatal when
> CONFIG_WERROR is enable, let's fix all 60 kernel-doc warnings
> inside linux-next:
>
> arch/x86/include/uapi/asm/sgx.h:19: warning: Enum value
> 'SGX_
On Mon, 14 Mar 2022 12:53:24 +0100, Julia Lawall wrote:
> Various spelling mistakes in comments.
> Detected with the help of Coccinelle.
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[21/30] spi: sun4i: fix typos in comments
commit: 20
Hi all,
After merging the amdgpu tree, today's linux-next build (x86
allmodconfig) failed like this:
ERROR: modpost: "dc_dsc_stream_bandwidth_in_kbps"
[drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
Probably caused by commit
b6b76b0315ed7b ("drm/amd/display: Fixed EdidUtility build errors"
On Wed, 19 May 2021 10:15:35 +0200, Mauro Carvalho Chehab wrote:
> There are some places at drm that ended receiving a
> REPLACEMENT CHARACTER U+fffd ('�'), probably because of
> some bad charset conversion.
>
> Fix them by using what it seems to be the proper
> character.
Applied to
ht
On Tue, Jan 26, 2021 at 02:23:17PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> The double negative makes it hard to read "if (!ACPI_FAILURE(status))".
> Replace it with "if (ACPI_SUCCESS(status))".
Acked-by: Mark Brown
signatur
On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote:
> This series aims to fix almost all remaining fall-through warnings in
> order to enable -Wimplicit-fallthrough for Clang.
>
> In preparation to enable -Wimplicit-fallthrough for Clang, explicitly
> add multiple break/goto/return/fall
On Mon, Sep 16, 2019 at 11:12:03PM +0100, Mark Brown wrote:
> On Mon, Sep 16, 2019 at 01:51:15PM -0700, Nick Desaulniers wrote:
>
> > + Mark
> > I think this was a result of the resolved merge conflict. See the
> > -next only commit titled:
> > Merge remote
On Tue, Sep 17, 2019 at 02:46:48AM +0900, Masahiro Yamada wrote:
> On Mon, Sep 16, 2019 at 1:46 PM Austin Kim wrote:
> > gcc throws compile error with below message:
> GNU Make throws ...
Xinpeng Liu via Nick Desaulniers sent a description of the problem and a
patch so I think I'll be able to f
On Mon, Sep 16, 2019 at 01:51:15PM -0700, Nick Desaulniers wrote:
> + Mark
> I think this was a result of the resolved merge conflict. See the
> -next only commit titled:
> Merge remote-tracking branch 'drm/drm-next'
Yes, the DRM and the Kbuild people really need to coordinate with each
othe
On Tue, Sep 17, 2019 at 02:46:48AM +0900, Masahiro Yamada wrote:
> (+CC Stephen Rothwell, Mark Brown)
>
> On Mon, Sep 16, 2019 at 1:46 PM Austin Kim wrote:
> >
> > gcc throws compile error with below message:
>
> GNU Make throws ...
>
>
I don't have t
On Wed, Aug 07, 2019 at 10:55:01AM +, Koenig, Christian wrote:
> Am 07.08.19 um 12:41 schrieb Christoph Hellwig:
> > writeq/readq are provided whenever the CPU actually supports 64-bit
> > atomic loads and stores.
> Is there a config option which we can make the driver depend on?
64BIT shoul
On Mon, Aug 05, 2019 at 02:40:32AM -0700, kernelci.org bot wrote:
Today's -next fails to build an arm allmodconfig due to:
> allmodconfig (arm, gcc-8) — FAIL, 2 errors, 16 warnings, 0 section mismatches
>
> Errors:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:279:9: error: implicit
> declar
//chromium-review.googlesource.com/678278
Tested-by: Jason Clinton
Reviewed-by: Jason Clinton
Signed-off-by: Alex Deucher
Signed-off-by: Mark Brown
---
sound/soc/amd/Makefile | 4 ++--
sound/soc/amd/acp-pcm-dma.c | 6 --
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/sou
Reviewed-on: https://chromium-review.googlesource.com/678919
Reviewed-by: Jason Clinton
Reviewed-on: https://chromium-review.googlesource.com/681618
Signed-off-by: Alex Deucher
Signed-off-by: Mark Brown
---
sound/soc/amd/acp-pcm-dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
di
On Wed, Nov 08, 2017 at 02:35:05PM -0500, Alex Deucher wrote:
> On Wed, Nov 8, 2017 at 2:30 PM, Guenter Roeck wrote:
> > On Wed, Nov 8, 2017 at 11:18 AM, Deucher, Alexander
> >> > Is this different to "ASoC: amd: Report accurate hw_ptr during dma"
> >> > which was applied at 16:07?
> >> Yes, thi
On Wed, Nov 08, 2017 at 11:13:50AM -0800, Guenter Roeck wrote:
> On Wed, Nov 8, 2017 at 10:47 AM, Mark Brown wrote:
> > Is this different to "ASoC: amd: Report accurate hw_ptr during dma"
> > which was applied at 16:07?
> I suspect we may be getting hit by chromeos-
On Wed, Nov 08, 2017 at 01:40:32PM -0500, Alex Deucher wrote:
> On Wed, Nov 8, 2017 at 1:22 PM, Mark Brown wrote:
> > Like I said in reply to your other mail please don't resubmit already
> > applied patches. The current tip of my topic/amd branch appears to be
> > t
On Wed, Nov 08, 2017 at 06:12:34PM +, Deucher, Alexander wrote:
> This didn't not appear to be in your tree yet and I never got any
> confirmation it being
> applied. Apologies.
Ah, sorry - my bad. This was one that I tried to apply but which didn't
apply.
signature.asc
Description: PGP
ned-off-by: Akshu Agrawal
Tested-by: Jason Clinton
Reviewed-by: Jason Clinton
Signed-off-by: Alex Deucher
Signed-off-by: Mark Brown
---
sound/soc/amd/Makefile | 4 ++--
sound/soc/amd/acp-pcm-dma.c | 6 --
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/amd/
On Wed, Nov 08, 2017 at 01:18:41PM -0500, Alex Deucher wrote:
> From: Guenter Roeck
>
> ERROR: "__aeabi_uldivmod" [sound/soc/amd/snd-soc-acp-pcm.ko] undefined!
>
> 64-bit divides require special operations to avoid build errors on 32-bit
> systems.
Like I said in reply to your other mail please
On Wed, Nov 08, 2017 at 12:24:02PM -0500, Alex Deucher wrote:
> From: Akshu Agrawal
>
> This fixes the issue of driver not getting auto loaded with
> MODULE_ALIAS.
Please don't resubmit patches that have already been applied, you should
submit patches against current code in the tree you're expe
On Wed, Nov 08, 2017 at 12:24:03PM -0500, Alex Deucher wrote:
> regmap_read(regmap, RT5645_VENDOR_ID2, &val);
>
> + /*
> + * Read after 400msec, as it is the interval required between
> + * read and power On.
> + */
> + msleep(TIME_TO_POWER_MS);
> + regmap_read(r
On Wed, Nov 08, 2017 at 12:45:16PM -0500, Alex Deucher wrote:
> On Wed, Nov 8, 2017 at 12:42 PM, Alex Deucher wrote:
> > I'm not familiar with which are chromium specific (TEST, BUG, FIXUP,
> > FROMLIST I guess?). The info seems useful to have in the bug, but I
> > can respin if it's a big deal.
accordingly the hw pointer.
TEST=
modprobe snd-soc-acp-pcm.ko
modprobe snd-soc-acp-rt5645.ko
aplay
Signed-off-by: Vijendar Mukunda
Signed-off-by: Akshu Agrawal
Tested-by: Akshu Agrawal
Reviewed-by: Jason Clinton
Signed-off-by: Alex Deucher
Signed-off-by: Mark Brown
---
sound/soc/amd/acp-pcm-dma.c
On Tue, Nov 07, 2017 at 09:34:35PM +0530, Agrawal, Akshu wrote:
> On 11/7/2017 5:07 PM, Mark Brown wrote:
> > > > These two URLs are different, what was being reviewed here? What is
> > > > Commit-Ready supposed to mean?
> Same patch is reviewed, once on 4.4 ke
On Tue, Nov 07, 2017 at 07:26:03PM +0530, Mukunda,Vijendar wrote:
> Removing URL links and commit-ready description in v2.
This doesn't really answer my question:
> > These two URLs are different, what was being reviewed here? What is
> > Commit-Ready supposed to mean?
Please don't top post, re
On Fri, Nov 03, 2017 at 04:35:45PM -0400, Alex Deucher wrote:
> Minimum time required between power On of codec and read
> of RT5645_VENDOR_ID2 is 400msec. We should wait and attempt
> before erroring out.
So the description says we have to wait 400ms before attempting a
read...
> BUG=b:66978383
On Fri, Nov 03, 2017 at 04:35:43PM -0400, Alex Deucher wrote:
> Signed-off-by: Vijendar Mukunda
> Signed-off-by: Akshu Agrawal
> Reviewed-on: https://chromium-review.googlesource.com/659699
> Commit-Ready: Akshu Agrawal
> Tested-by: Akshu Agrawal
> Reviewed-by: Jason Clinton
> Reviewed-on: ht
The patch
drm/amdgpu Moving amdgpu asic types to a separate file
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and
capture.Modified Max buffer size to have the
correct mapping between System Memory and SRAM.
Added snd_pcm_hardware structures for playback
and capture for Stoney.
Reviewed-by: Alex Deucher
Signed-off-by: Vijendar Mukunda
Signed-off-by: Alex Deucher
Signed-off-by: Mark Brown
---
sound/soc/amd
SRAM Banks
won't be turned off. By Default, SRAM Bank state set to ON.
Added condition checks to skip SRAM Bank state set logic for
Stoney platform.
Acked-by: Mark Brown
Reviewed-by: Alex Deucher
Signed-off-by: Vijendar Mukunda
Signed-off-by: Alex Deucher
Signed-off-by: Mark Brown
---
Deucher
Signed-off-by: Akshu Agrawal
Signed-off-by: Alex Deucher
Signed-off-by: Dylan Reid
Signed-off-by: Mark Brown
---
sound/soc/amd/Kconfig | 7 ++
sound/soc/amd/Makefile | 2 +
sound/soc/amd/acp-rt5645.c | 199 +
3 files changed, 208
ank 4 will be used for Capture scenario.
Acked-by: Mark Brown
Reviewed-by: Alex Deucher
Signed-off-by: Vijendar Mukunda
Signed-off-by: Alex Deucher
Signed-off-by: Mark Brown
---
sound/soc/amd/acp-pcm-dma.c | 87 +
sound/soc/amd/acp.h |
On Thu, Sep 28, 2017 at 07:21:07PM +, Deucher, Alexander wrote:
> > Any updates with the pull requests?
> Sorry travelling last week and swamped this week. I'm going to try
> and get it done tomorrow, otherwise, probably the week after.
No worries, it's only -rc3 so we've got 3-4 weeks.
s
On Thu, Sep 14, 2017 at 10:42:28AM -0700, Mark Brown wrote:
> On Wed, Sep 13, 2017 at 02:49:08PM -0400, Alex Deucher wrote:
> > I'm not quite sure what you mean by the cross merge. There are no
> > dependencies outside this patch set. The only patches that touch drm
>
On Wed, Sep 13, 2017 at 02:49:08PM -0400, Alex Deucher wrote:
> On Wed, Sep 13, 2017 at 2:12 PM, Mark Brown wrote:
> > No, send me a pull request for the dependencies so we can do a cross
> > merge. I want to make sure that when this gets reviewed it actually
> > gets mer
On Wed, Sep 13, 2017 at 01:57:49PM -0400, Alex Deucher wrote:
> I just need acks from audio on the remaining patches that touch audio
> (1, 5, 6), and then I can send a pull request.
No, send me a pull request for the dependencies so we can do a cross
merge. I want to make sure that when this ge
On Fri, Aug 18, 2017 at 02:10:28PM -0400, Alex Deucher wrote:
> From: Vijendar Mukunda
>
> Added DMA driver changes for Stoney platform.
> Below are the key differences between Stoney and CZ
Acked-by: Mark Brown
signature.asc
Description: P
or
> Stoney platform.
Acked-by: Mark Brown
signature.asc
Description: PGP signature
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On Wed, Aug 30, 2017 at 09:40:07PM +, Deucher, Alexander wrote:
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.
> I sent one patch in the v2 patch set that had already
On Fri, Aug 18, 2017 at 02:10:30PM -0400, Alex Deucher wrote:
> +++ b/sound/soc/amd/Kconfig
> @@ -2,3 +2,10 @@ config SND_SOC_AMD_ACP
> tristate "AMD Audio Coprocessor support"
> help
>This option enables ACP DMA support on AMD platform.
> +config SND_SOC_AMD_CZ_RT5645_MACH
> +
On Fri, Aug 18, 2017 at 02:10:29PM -0400, Alex Deucher wrote:
> +#define ST_PLAYBACK_MAX_PERIOD_SIZE 8192
> +#define ST_CAPTURE_MAX_PERIOD_SIZE 8192
> +#define ST_MAX_BUFFER (ST_PLAYBACK_MAX_PERIOD_SIZE *
> PLAYBACK_MAX_NUM_PERIODS)
These defines will go wrong if the capture size is changed ind
On Wed, Aug 30, 2017 at 11:49:02AM -0700, Eric Anholt wrote:
> Mark Brown writes:
> > You need to get someone from the DRM side to pay attention to the second
> > patch and you need to stop resending the first patch since as has been
> > pointed out a few times now you nee
On Wed, Aug 30, 2017 at 09:33:35AM -0400, Alex Deucher wrote:
> Any comments? Can this patch set go in? This is the second time I've
> resent it since the addressing the initial feedback. Does anyone have
> a preference on which tree?
You need to get someone from the DRM side to pay attention
On Fri, Jul 28, 2017 at 03:31:26PM -0400, Alex Deucher wrote:
> This patch is already applied to the audio tree, I'm just
> including it here for completeness since it's not yet in
> the drm tree.
It's in mainline, please don't resubmit already applied patches.
signature.asc
Description: PGP si
On Thu, Jun 29, 2017 at 12:58:02PM +, Mukunda, Vijendar wrote:
> -Original Message-
> From: Mark Brown [mailto:broo...@kernel.org]
> Sent: Wednesday, June 28, 2017 11:36 PM
> To: Alex Deucher
Please fix your mail client to quote mails in a more normal fashion,
this
DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to Designware
driver. This quirk will set idx value to 1.
By setting this quirk, it will override supported format
as 16 bit resolution and bus width as 2 Bytes.
Reviewed-by: Alex Deucher
Signed-off-by: Vijendar Mukunda
Signed-off-by: Alex Deucher
Signed-off-by: Mark
On Fri, Jun 23, 2017 at 01:05:37PM -0400, Alex Deucher wrote:
> On Fri, Jun 23, 2017 at 12:43 PM, Christian König
> > Have the painkillers jellyfied my brain or are you setting a pointer in the
> > amdgpu device structure to some variable on the stack?
> > If it's just for initialization then tha
On Fri, Jun 23, 2017 at 12:35:01PM -0400, Alex Deucher wrote:
> + if (adev->asic_type == CHIP_STONEY) {
> + i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET |
> + DW_I2S_QUIRK_COMP_PARAM1 |
> + DW_I2S_QUIRK_16BIT_IDX_OVERRIDE;
> + } els
On Fri, Jun 23, 2017 at 12:35:02PM -0400, Alex Deucher wrote:
> Reviewed-by: Alex Deucher
> index dcbf997..e48ae5d 100644
> --- a/sound/soc/amd/acp-pcm-dma.c
> +++ b/sound/soc/amd/acp-pcm-dma.c
> @@ -34,6 +34,8 @@
>
> #define MAX_BUFFER (PLAYBACK_MAX_PERIOD_SIZE * PLAYBACK_MAX_NUM_PERIODS)
>
54 matches
Mail list logo