On Fri, Jun 23, 2017 at 12:35:01PM -0400, Alex Deucher wrote:
> + if (adev->asic_type == CHIP_STONEY) {
> + i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET |
> + DW_I2S_QUIRK_COMP_PARAM1 |
> + DW_I2S_QUIRK_16BIT_IDX_OVERRIDE;
> + } else {
> + i2s_pdata[1].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET |
> + DW_I2S_QUIRK_COMP_PARAM1;
> + }Quirks like this are better written as switch statements since that makes it easier to handle further variants in future.
signature.asc
Description: PGP signature
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
