[PATCH 04/13] drm/amd/display: Initialize mode_select to 0

2025-06-18 Thread Fangzhi Zuo
From: Alex Hung [WHAT] mode_select was supposed to be initialized in mpc_read_gamut_remap but is not set in default case. This can cause indeterminate behaviors. This is reported as an UNINIT error by Coverity. Reviewed-by: Aurabindo Pillai Signed-off-by: Alex Hung Signed-off-by: Fangzhi Zuo

[PATCH 02/13] drm/amd/display: Removed unnecessary comment

2025-06-18 Thread Fangzhi Zuo
From: Alvin Lee Reviewed-by: Sridevi Arvindekar Signed-off-by: Alvin Lee Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c b

[PATCH 13/13] drm/amd/display: Promote DAL to 3.2.339

2025-06-18 Thread Fangzhi Zuo
an Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index f5df271c8d1a..c35978214e38 100644 --- a/drivers/gpu/drm/amd/display/dc/dc.h +++

[PATCH 12/13] drm/amd/display: [FW Promotion] Release 0.1.16.0

2025-06-18 Thread Fangzhi Zuo
: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h index e6730e59d987..93f35ac7f5b9 100644 --- a/drivers/gpu/drm/amd/display/dmub

[PATCH 08/13] drm/amd/display: Rewording Mode Validation Result

2025-06-18 Thread Fangzhi Zuo
It is normal to prune resolutions that exceed hw or bw limitation. Use error oriented wordings could cause misunderstanding. Reviewed-by: Aurabindo Pillai Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 07/13] drm/amd/display: LSDMA support

2025-06-18 Thread Fangzhi Zuo
From: "Ostrowski, Rafal" [Why] Driver should be able to send LSDMA commands to DMCUB [How] Driver can now send LSDMA commands to DMCUB. DMCUB should process them and send to LSDMA controller. Reviewed-by: Alvin Lee Signed-off-by: Ostrowski Rafal Signed-off-by: Fangzhi Zuo --- d

[PATCH 05/13] drm/amd/display: Fix 'failed to blank crtc!'

2025-06-18 Thread Fangzhi Zuo
x27;t poll in case the pixel clock or other clock was bugged or until vactive and the vblank are hit again. Reviewed-by: Nicholas Kazlauskas Signed-off-by: Wen Chen Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 01/13] drm/amd/display: Include EQU Prefetch Bandwidth For Bandwidth Calculations

2025-06-18 Thread Fangzhi Zuo
use it as part of the calculations for required bandwidth. Reviewed-by: Dillon Varone Signed-off-by: Austin Zheng Signed-off-by: Fangzhi Zuo --- .../src/dml2_core/dml2_core_dcn4_calcs.c | 42 +++ .../src/dml2_core/dml2_core_shared_types.h| 16 --- 2 files changed

[PATCH 11/13] drm/amd/display: Add DMUB IPS command support for IPS residency tools

2025-06-18 Thread Fangzhi Zuo
From: Ovidiu Bunea [why & how] Add DMUB IPS CMD interface for driver and DMU to communicate for IPS residency tools. Reviewed-by: Nicholas Kazlauskas Signed-off-by: Ovidiu Bunea Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 102 ++ dri

[PATCH 09/13] drm/amd/display: DML21 Reintegration

2025-06-18 Thread Fangzhi Zuo
From: Austin Zheng Update logging macros for detailed debugging Update structs to contain more detailed information Add HDMI 16 and 20 Gbps rates Reviewed-by: Alvin Lee Signed-off-by: Austin Zheng Signed-off-by: Fangzhi Zuo --- .../dml2/dml21/inc/dml_top_dchub_registers.h | 1

[PATCH 10/13] drm/amd/display: Add num_slices_h to set_dto_dscclk signature

2025-06-18 Thread Fangzhi Zuo
From: Ilya Bakoulin Add the number of horizontal slices argument to allow configuring clock based on slice number. Reviewed-by: Nevenko Stupar Signed-off-by: Ilya Bakoulin Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dccg/dcn401/dcn401_dccg.c | 2 +- drivers/gpu/drm/amd

[PATCH 06/13] drm/amd/display: Remove redundant macro of refresh rate

2025-06-18 Thread Fangzhi Zuo
From: weiguali [Why&How] Found that we add redundant macro on refresh rate when calculating vtotal, so we remove it. Reviewed-by: Robin Chen Signed-off-by: Weiguang Li Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 2 +- 1 file changed, 1 inser

[PATCH 03/13] drm/amd/display: Add new DP tunnel bandwidth validation

2025-06-18 Thread Fangzhi Zuo
From: Cruise Hung [Why & How] Add new function for DP tunnel bandwidth validation. It uses the estimated BW and allocated BW to validate the timings. Reviewed-by: PeiChen Huang Reviewed-by: Meenakshikumar Somasundaram Signed-off-by: Cruise Hung Signed-off-by: Fangzhi Zuo --- .../gpu

[PATCH 00/13] DC Patches June 16, 2025

2025-06-18 Thread Fangzhi Zuo
drm/amd/display: Add new DP tunnel bandwidth validation Fangzhi Zuo (1): drm/amd/display: Rewording Mode Validation Result Ilya Bakoulin (1): drm/amd/display: Add num_slices_h to set_dto_dscclk signature Ostrowski, Rafal (1): drm/amd/display: LSDMA support Ovidiu Bunea (1): drm/amd/di

[PATCH] Revert "drm/amd/display: pause the workload setting in dm"

2025-05-21 Thread Fangzhi Zuo
This reverts commit 243678df7a058f65f5f43e8026b359bcc91e0b69. Reason for revert: cause corruption on Dell U3224KB DP2 display. --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c| 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdg

[PATCH 13/17] drm/amd/display: Do Not Consider DSC if Valid Config Not Found

2025-03-26 Thread Fangzhi Zuo
: Wayne Lin Signed-off-by: Fangzhi Zuo --- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH 09/17] drm/amd/display: use drm_info instead of DRM_INFO

2025-03-26 Thread Fangzhi Zuo
From: Aurabindo Pillai drm_info prints the drm device instance which is helpful when debugging multi gpu issues Reviewed-by: Alex Hung Signed-off-by: Aurabindo Pillai Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 24 +-- 1 file changed, 12

[PATCH 03/17] drm/amd/display: use drm_err in create_validate_stream_for_sink()

2025-03-26 Thread Fangzhi Zuo
From: Aurabindo Pillai make the drm device available in create_validate_stream_for_sink() so that drm_err() can be used Reviewed-by: Alex Hung Signed-off-by: Aurabindo Pillai Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++-- 1 file changed

[PATCH 08/17] drm/amd/display: Consider downspread against max clocks in DML2.1

2025-03-26 Thread Fangzhi Zuo
From: Dillon Varone [WHY&HOW] Core should evaluate support based on the max clocks after considering downspread. Reviewed-by: Austin Zheng Signed-off-by: Dillon Varone Signed-off-by: Fangzhi Zuo --- .../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 6 +++--- .../amd/displa

[PATCH 12/17] drm/amd/display: Add Support for reg inbox0 for host->DMUB CMDs

2025-03-26 Thread Fangzhi Zuo
replacement for the frame buffer based mailbox (Inbox1). It supports all of the required features: - Supports all messages handled by FB Inbox1 - Supports multi command batching Reviewed-by: Nicholas Kazlauskas Signed-off-by: Dillon Varone Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc

[PATCH 07/17] drm/amd/display: Enable Replay Low Hz feature flag

2025-03-26 Thread Fangzhi Zuo
From: Robin Chen Enable replay low refresh rate support. Reviewed-by: ChunTao Tso Signed-off-by: Robin Chen Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc_types.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc

[PATCH 05/17] drm/amd/display: Set ODM Factor Based On DML Architecture

2025-03-26 Thread Fangzhi Zuo
: Fangzhi Zuo --- .../display/dc/dml2/dml2_dc_resource_mgmt.c | 24 +-- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c index a966abd40788

[PATCH 00/17] DC Patches Mar 24, 2024

2025-03-26 Thread Fangzhi Zuo
drm/amd/display: Fix VUpdate offset calculations for dcn401 drm/amd/display: Fix Vertical Interrupt definitions for dcn32, dcn401 Fangzhi Zuo (1): drm/amd/display: Do Not Consider DSC if Valid Config Not Found Joshua Aberback (1): drm/amd/display: Use meaningful size for block_sequence ar

[PATCH 04/17] drm/amd/display: convert more DRM_ERROR to drm_err

2025-03-26 Thread Fangzhi Zuo
From: Aurabindo Pillai prefer drm_err instead of DRM_ERROR since the former prints the associated DRM device, which is helpful when debugging multi-gpu use cases. Reviewed-by: Alex Hung Signed-off-by: Aurabindo Pillai Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/amdgpu_dm

[PATCH 06/17] drm/amd/display: Use meaningful size for block_sequence array

2025-03-26 Thread Fangzhi Zuo
, assume every update occurs on max number of pipes - define array sizes for function parameters, for static analysis Reviewed-by: Dillon Varone Signed-off-by: Joshua Aberback Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 4 ++-- drivers/gpu/drm/amd

[PATCH 15/17] drm/amd/display: Fix VUpdate offset calculations for dcn401

2025-03-26 Thread Fangzhi Zuo
From: Dillon Varone [WHY&HOW] DCN401 uses a different structure to store the VStartup offset used to calculate the VUpdate position, so adjust the calculations to use this value. Reviewed-by: Aric Cyr Signed-off-by: Dillon Varone Signed-off-by: Fangzhi Zuo --- .../amd/display/dc/hwss/dc

[PATCH 17/17] drm/amd/display: Promote DAL to 3.2.327

2025-03-26 Thread Fangzhi Zuo
From: Aric Cyr Summary: * Improve vrr for replay and psr * Rewrite drm debug message * Fix clock issues for dcn32 and dcn401 * Fix mst dsc mode validation issue Reviewed-by: Aurabindo Pillai Signed-off-by: Aric Cyr Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc.h | 2

[PATCH 02/17] drm/amd/display: use drm_err in hpd rx offload

2025-03-26 Thread Fangzhi Zuo
From: Aurabindo Pillai add amdgpu_device pointer to data associated with the work struct such that hpd handlers has access to the drm device for use with drm_err() Reviewed-by: Alex Hung Signed-off-by: Aurabindo Pillai Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/amdgpu_dm

[PATCH 16/17] drm/amd/display: Fix Vertical Interrupt definitions for dcn32, dcn401

2025-03-26 Thread Fangzhi Zuo
From: Dillon Varone [WHY&HOW] - VUPDATE_NO_LOCK should be used in place of VUPDATE always - Add VERTICAL_INTERRUPT1 and VERTICAL_INTERRUPT2 definitions Reviewed-by: Aric Cyr Signed-off-by: Dillon Varone Signed-off-by: Fangzhi Zuo --- .../display/dc/irq/dcn32/irq_service_dcn32.c

[PATCH 10/17] drm/amd/display: use drm_warn instead of DRM_WARN

2025-03-26 Thread Fangzhi Zuo
From: Aurabindo Pillai drm_warn prints the drm device instance which is helpful when debugging multi gpu issues Reviewed-by: Alex Hung Signed-off-by: Aurabindo Pillai Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +-- 1 file changed, 13

[PATCH 14/17] drm/amd/display: Do not enable Replay and PSR while VRR is on in amdgpu_dm_commit_planes()

2025-03-26 Thread Fangzhi Zuo
ed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c b/drivers/gpu/drm/amd/display

[PATCH 11/17] drm/amd/display: Add a Panel Replay config option

2025-03-26 Thread Fangzhi Zuo
From: ChunTao Tso [Why] Replay need special policy for the scenario Teams, add a flag to imply apply special policy or not. [How] Add a config option intended for future use for video conferencing applications. Reviewed-by: Aric Cyr Signed-off-by: ChunTao Tso Signed-off-by: Fangzhi Zuo

[PATCH 01/17] drm/amd/display: convert DRM_ERROR to drm_err in hpd_rx_irq_create_workqueue()

2025-03-26 Thread Fangzhi Zuo
From: Aurabindo Pillai pass in a pointer to amdgpu_device directly to the function. Reviewed-by: Alex Hung Signed-off-by: Aurabindo Pillai Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[PATCH 5/9] drm/amd/display: Check that hw cursor is not required when falling back to subvp sw cursor

2024-11-28 Thread Fangzhi Zuo
fixed by improving the timings check by using the hw cursor required flag to cover the unaccounted use cases. Reviewed-by: Austin Zheng Signed-off-by: Peterson Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/9] DC Patches Nov 26, 2024

2024-11-28 Thread Fangzhi Zuo
This DC patchset brings improvements in multiple areas. In summary, we have: * Fix dcn351 clk table * Bug fix on IP2, reply, DP tunneling Cc: Daniel Wheeler Alex Deucher (1): drm/amdgpu: rework resume handling for display Aric Cyr (1): drm/amd/display: 3.2.312 Ausef Yousof (1): drm/amd/d

[PATCH 3/9] drm/amd/display: Populate chroma prefetch parameters, DET buffer fix

2024-11-28 Thread Fangzhi Zuo
call to calculate UrgBChroma prefetch values -revision commits: small formatting/brackets/null check addition + remove test change + dGPU code Reviewed-by: Charlene Liu Signed-off-by: Ausef Yousof Signed-off-by: Fangzhi Zuo --- .../amd/display/dc/dml2/display_mode_core.c | 5

[PATCH 9/9] drm/amd/display: 3.2.312

2024-11-28 Thread Fangzhi Zuo
From: Aric Cyr DC 3.2.312 contains some improvements as summarized below: * Fix dcn351 clk table * Bug fix on IP2, reply, DP tunneling Reviewed-by: Fangzhi Zuo Signed-off-by: Aric Cyr Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion

[PATCH 7/9] drm/amd/display: fix v tap calculation for non-adaptive scaling in SPL

2024-11-28 Thread Fangzhi Zuo
From: Samson Tam [Why & How] v and h tap calculations slightly different Use h tap calculation for both v and h tap Reviewed-by: Navid Assadian Signed-off-by: Samson Tam Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/spl/dc_spl.c | 8 1 file changed, 4 insert

[PATCH 8/9] drm/amdgpu: rework resume handling for display

2024-11-28 Thread Fangzhi Zuo
From: Alex Deucher Split resume into a 3rd step to handle displays when DCC is enabled on DCN 4.0.1. Move display after the buffer funcs have been re-enabled so that the GPU will do the move and properly set the DCC metadata for DCN. Signed-off-by: Alex Deucher Ack-by: Fangzhi Zuo

[PATCH 6/9] drm/amd/display: Adjust DPCD read for DP tunneling

2024-11-28 Thread Fangzhi Zuo
From: Cruise Move DP tunneling field DPCD reading after all other RX caps are read. Reviewed-by: Wenjing Liu Signed-off-by: Cruise Signed-off-by: Fangzhi Zuo --- .../dc/link/protocols/link_dp_capability.c| 21 +-- 1 file changed, 10 insertions(+), 11 deletions(-) diff

[PATCH 4/9] drm/amd/display: Don't allow IPS2 in D0 for RCG Dynamic

2024-11-28 Thread Fangzhi Zuo
ned-off-by: Nicholas Kazlauskas Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 5 - drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/

[PATCH 2/9] drm/amd/display: correct dcn351 dpm clk table based on pmfw_drv_if

2024-11-28 Thread Fangzhi Zuo
From: Charlene Liu [why] driver got wrong clock table due to miss match dtm_table headers. correct the dtn_clock table based on pmfw header. Reviewed-by: Alvin Lee Reviewed-by: Sung joon Kim Signed-off-by: Charlene Liu Signed-off-by: Fangzhi Zuo --- .../display/dc/clk_mgr/dcn35

[PATCH 1/9] drm/amd/display: Revised for Replay Pseudo vblank control

2024-11-28 Thread Fangzhi Zuo
From: Dennis Chan [why] Revised Replay Full screen video Pseudo vblank control. Reviewed-by: ChunTao Tso Signed-off-by: Dennis Chan Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc_types.h | 4 ++-- drivers/gpu/drm/amd/display/modules/power/power_helpers.c

[PATCH v4 2/2] drm/display/dsc: MST DSC Interface Change

2024-11-08 Thread Fangzhi Zuo
dependency changes for each vendor. 2. Rename passthrough_aux with dsc_passthrough_aux to align with the name of dsc_aux. Signed-off-by: Fangzhi Zuo Signed-off-by: Wayne Lin --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 20

[PATCH v4 0/2] Refactor MST DSC Determination Policy

2024-11-08 Thread Fangzhi Zuo
: split original single patch into two v3: rebase against the latest code v4: fix a ci issue Fangzhi Zuo (2): drm/display/dsc: Refactor DRM MST DSC Determination Policy drm/display/dsc: MST DSC Interface Change .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- .../amd/display/amdgpu_dm

[PATCH v4 1/2] drm/display/dsc: Refactor DRM MST DSC Determination Policy

2024-11-08 Thread Fangzhi Zuo
ce types. 2. Synaptics quirk DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD analyzing is no longer needed as long as we determine dsc aux generically by dpcd info. Signed-off-by: Fangzhi Zuo Signed-off-by: Wayne Lin --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 241 -

[PATCH v3 1/2] drm/display/dsc: Refactor DRM MST DSC Determination Policy

2024-11-06 Thread Fangzhi Zuo
ce types. 2. Synaptics quirk DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD analyzing is no longer needed as long as we determine dsc aux generically by dpcd info. Signed-off-by: Fangzhi Zuo Signed-off-by: Wayne Lin --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 238 -

[PATCH v3 0/2] Refactor MST DSC Determination Policy

2024-11-06 Thread Fangzhi Zuo
: split original single patch into two v3: rebase against the latest code Fangzhi Zuo (2): drm/display/dsc: Refactor DRM MST DSC Determination Policy drm/display/dsc: MST DSC Interface Change .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c

[PATCH v3 2/2] drm/display/dsc: MST DSC Interface Change

2024-11-06 Thread Fangzhi Zuo
dependency changes for each vendor. 2. Rename passthrough_aux with dsc_passthrough_aux to align with the name of dsc_aux. Signed-off-by: Fangzhi Zuo Signed-off-by: Wayne Lin --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 20

[PATCH v2 1/2] drm/display/dsc: Refactor DRM MST DSC Determination Policy

2024-11-01 Thread Fangzhi Zuo
ce types. 2. Synaptics quirk DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD analyzing is no longer needed as long as we determine dsc aux generically by dpcd info. Signed-off-by: Fangzhi Zuo Signed-off-by: Wayne Lin --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 238 -

[PATCH v2 0/2] Refactor MST DSC Determination Policy

2024-11-01 Thread Fangzhi Zuo
. Fangzhi Zuo (2): drm/display/dsc: Refactor DRM MST DSC Determination Policy drm/display/dsc: MST DSC Interface Change .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 20 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 30 +- drivers/gpu

[PATCH v2 2/2] drm/display/dsc: MST DSC Interface Change

2024-11-01 Thread Fangzhi Zuo
dependency changes for each vendor. 2. Rename passthrough_aux with dsc_passthrough_aux to align with the name of dsc_aux. Signed-off-by: Fangzhi Zuo Signed-off-by: Wayne Lin --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 20

[PATCH 13/13] drm/amd/display: 3.2.303

2024-09-27 Thread Fangzhi Zuo
From: Aric Cyr DC 3.2.303 contains some improvements as summarized below: * Improve brightness control * Add support for UHBR10 eDP * OPTC required only for DTBCLK_P for dcn401 * Fix TBT monitor resume issue * Code cleanup Signed-off-by: Aric Cyr Signed-off-by: Fangzhi Zuo --- drivers/gpu

[PATCH 12/13] drm/amd/display: [FW Promotion] Release 0.0.236.0

2024-09-27 Thread Fangzhi Zuo
From: Taimur Hassan Signed-off-by: Taimur Hassan Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 62 +-- 1 file changed, 57 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display

[PATCH 00/13] DC Patches Sept 23, 2024

2024-09-27 Thread Fangzhi Zuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Improve brightness control * Add support for UHBR10 eDP * OPTC required only for DTBCLK_P for dcn401 * Fix TBT monitor resume issue * Code cleanup Cc: Daniel Wheeler Alex Hung (3): drm/amd/display: Remove alwa

[PATCH 04/13] drm/amd/display: add more support for UHBR10 eDP

2024-09-27 Thread Fangzhi Zuo
From: "Liu Xi (Alex)" [Why and how] The current UHBR10 eDP panel has new security feature update. Add support for the new FW Reviewed-by: Wenjing Liu Signed-off-by: Liu Xi (Alex) Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc.h| 1

[PATCH 05/13] drm/amd/display: Change Brightness Control Priority

2024-09-27 Thread Fangzhi Zuo
From: Muyuan Yang Prioritize Aux-based over PWM-based brightness control for more types of panels and introduce a new structure to store and manage the type of brightness control used. Reviewed-by: Anthony Koo Signed-off-by: Muyuan Yang Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd

[PATCH 07/13] drm/amd/display: Remove always-false branches

2024-09-27 Thread Fangzhi Zuo
d by Coverity. Reviewed-by: Rodrigo Siqueira Signed-off-by: Alex Hung Signed-off-by: Fangzhi Zuo --- .../drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 9 - .../drm/amd/display/dc/dml/dml1_display_rq_dlg_calc.c| 3 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --g

[PATCH 03/13] drm/amd/display: Add logs to record register read/write

2024-09-27 Thread Fangzhi Zuo
PP, add it. Reviewed-by: Aric Cyr Signed-off-by: Paul Hsieh Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/include/logger_types.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h b/drivers/gpu/drm/amd/displ

[PATCH 06/13] drm/amd/display: Introduce New ABC Framework for Brightness Control

2024-09-27 Thread Fangzhi Zuo
From: Muyuan Yang Adjust the existing brightness control functions to use the new ABC Framework and prioritize Aux-based brightness control. Reviewed-by: Anthony Koo Signed-off-by: Muyuan Yang Signed-off-by: Fangzhi Zuo --- .../link/protocols/link_edp_panel_control.c | 40

[PATCH 09/13] drm/amd/display: Removed unused assignments and variables

2024-09-27 Thread Fangzhi Zuo
Signed-off-by: Alex Hung Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 -- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 48 --- 2 files changed, 8 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 10/13] drm/amd/display: Add IPS residency capture helpers to dc_dmub_srv

2024-09-27 Thread Fangzhi Zuo
d-by: Aric Cyr Signed-off-by: Ovidiu Bunea Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 78 +++ drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 39 drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 8 ++ .../gpu/drm/amd/display/dmub/inc/dmub_c

[PATCH 00/13] DC Patches Sept 23, 2024

2024-09-27 Thread Fangzhi Zuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Improve brightness control * Add support for UHBR10 eDP * OPTC required only for DTBCLK_P for dcn401 * Fix TBT monitor resume issue * Code cleanup Cc: Daniel Wheeler Alex Hung (3): drm/amd/display: Remove alwa

[PATCH 08/13] drm/amd/display: Eliminate recursive header inclusion

2024-09-27 Thread Fangzhi Zuo
From: Alex Hung [WHAT & HOW] This removes recursive inclusion like dc.h -> dc_state.h -> dc.h and dc.h -> dc_plane.h -> dc.h This fixes 4 PW.INCLUDE_RECURSION issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Signed-off-by: Alex Hung Signed-off-by: Fangzhi Zuo ---

[PATCH 11/13] drm/amd/display: Configure DTBCLK_P with OPTC only for dcn401

2024-09-27 Thread Fangzhi Zuo
pixel rate will then be wrong, causing issues in CRTC. [HOW] Only program the DTBCLK_P when programming CRTC, as its expected it will be enabled prior to HPO, and disabled after HPO in all valid cases. Reviewed-by: Alvin Lee Signed-off-by: Dillon Varone Signed-off-by: Fangzhi Zuo --- .../amd

[PATCH 01/13] drm/amd/display: Adjust PHY FSM transition to TX_EN-to-PLL_ON for TMDS

2024-09-27 Thread Fangzhi Zuo
for TMDS Reviewed-by: Wenjing Liu Signed-off-by: Ryan Seto Signed-off-by: Fangzhi Zuo --- .../amd/display/dc/dccg/dcn401/dcn401_dccg.c | 81 --- .../amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 52 .../amd/display/dc/hwss/dcn401/dcn401_hwseq.h | 4 + .../amd/display

[PATCH 02/13] drm/amd/display: Fix system hang while resume with TBT monitor

2024-09-27 Thread Fangzhi Zuo
l mess up the pipe topology after resume. [How] Skip the TBT monitor HPD during the resume procedure because we currently will probe the connectors after resume by default. Reviewed-by: Wayne Lin Signed-off-by: Tom Chung Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgp

[PATCH 01/13] drm/amd/display: Adjust PHY FSM transition to TX_EN-to-PLL_ON for TMDS

2024-09-27 Thread Fangzhi Zuo
for TMDS Reviewed-by: Wenjing Liu Signed-off-by: Ryan Seto Signed-off-by: Fangzhi Zuo --- .../amd/display/dc/dccg/dcn401/dcn401_dccg.c | 81 --- .../amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 52 .../amd/display/dc/hwss/dcn401/dcn401_hwseq.h | 4 + .../amd/display

[PATCH 03/13] drm/amd/display: Add logs to record register read/write

2024-09-27 Thread Fangzhi Zuo
PP, add it. Reviewed-by: Aric Cyr Signed-off-by: Paul Hsieh Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/include/logger_types.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h b/drivers/gpu/drm/amd/displ

[PATCH 02/13] drm/amd/display: Fix system hang while resume with TBT monitor

2024-09-27 Thread Fangzhi Zuo
l mess up the pipe topology after resume. [How] Skip the TBT monitor HPD during the resume procedure because we currently will probe the connectors after resume by default. Reviewed-by: Wayne Lin Signed-off-by: Tom Chung Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgp

[PATCH] drm/display/dsc: Refactor MST DSC Determination Policy

2024-09-19 Thread Fangzhi Zuo
erating different connection types of the peer device. In addition, we add parsing vendor data 0x50C ~ 0x50F into dpcd quirk routine for expanding the ability to determine specific dock products that shall pick root aux as the dsc decompression point. Signed-off-by: Fangzhi Zuo Signed

[PATCH 1/2] drm/amd/display: Fix a mistake in revert commit

2024-08-22 Thread Fangzhi Zuo
[why] It is to fix in try_disable_dsc() due to misrevert patch of "drm/amd/display: Fix MST BW calculation Regression" [How] Fix restoring minimum compression bw by 'max_kbps', instead of native bw 'stream_kbps' Signed-off-by: Fangzhi Zuo --- drivers

[PATCH 2/2] drm/amd/display: Fix Synaptics Cascaded DSC Determination

2024-08-22 Thread Fangzhi Zuo
Synaptics Cascaded Panamera topology needs to unconditionally acquire root aux for dsc decoding. Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH 0/2] Fix for lightup issue on Lenovo 4k60 HDMI

2024-08-22 Thread Fangzhi Zuo
ascaded DSC Determination" Please apply the two patches on https://gitlab.freedesktop.org/agd5f/linux/-/commits/amd-staging-drm-next, and give a sanity test on 4k60 over Lenovo HDMI output. Fangzhi Zuo (2): drm/amd/display: Fix a mistake in revert commit drm/amd/display: Fix Synaptics Cascad

[PATCH 50/50] drm/amd/display: 3.2.292

2024-07-10 Thread Fangzhi Zuo
From: Aric Cyr * FW Release 0.0.225.0 * DML2 fixes * Re-enable panel replay feature * Allow display DCC for DCN401 * Refactor DWB, OPP, MPC, MMHUBBUB * Fix dscclk Programming issue on DCN401 Acked-by: Rodrigo Siqueira Signed-off-by: Jerry Zuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/d

[PATCH 48/50] drm/amd/display: improve logic for addition of modifers

2024-07-10 Thread Fangzhi Zuo
From: Aurabindo Pillai Use an extra for loop to reduce duplicate code for adding modifiers Reviewed-by: Rodrigo Siqueira Signed-off-by: Jerry Zuo Signed-off-by: Aurabindo Pillai --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 36 +-- 1 file changed, 17 insertions(+), 19 d

[PATCH 49/50] drm/amd/display: Remove unused dml2_core_ip_params struct

2024-07-10 Thread Fangzhi Zuo
From: Rodrigo Siqueira Acked-by: Jerry Zuo Signed-off-by: Rodrigo Siqueira --- .../dml2/dml21/src/dml2_core/dml2_core_dcn4.c | 78 --- 1 file changed, 78 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4.c b/drivers/gpu/drm/amd/

[PATCH 47/50] drm/amd/display: Allow display DCC for DCN401

2024-07-10 Thread Fangzhi Zuo
From: Aurabindo Pillai To enable mesa to use display dcc, DM should expose them in the supported modifiers. Add the best (most efficient) modifiers first. Reviewed-by: Rodrigo Siqueira Signed-off-by: Jerry Zuo Signed-off-by: Aurabindo Pillai --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c

[PATCH 46/50] drm/amd/display: Remove unnecessary DSC power gating for DCN401

2024-07-10 Thread Fangzhi Zuo
From: Joshua Aberback [Why] In some cases during topology changes, a pipe that was used to drive a stream being removed can be re-assigned to drive a different stream. In these cases, DSC power gating is not handled properly, leading to situations where DSC is being setup while power gated. [How

[PATCH 45/50] drm/amd/display: free bo used for dmub bounding box

2024-07-10 Thread Fangzhi Zuo
From: Aurabindo Pillai fix a memleak introduced by not removing the buffer object for use with early dmub bounding box value storage Fixes: 25a40071e ("drm/amd/display: Enable copying of bounding box data from VBIOS DMUB") Reviewed-by: Rodrigo Siqueira Reviewed-by: Alex Hung Signed-off-by: J

[PATCH 43/50] drm/amd/display: Set Cursor Matrix to bypass instead of Input Plane

2024-07-10 Thread Fangzhi Zuo
From: Daniel Sa why: When the cursor disappears/reappears on fullscreen video, there is a short transitional period where the cursor's color matrix is using the same format as the video plane. This sets the cursor to the wrong color momentarily before the UI plane appears, correcting the color.

[PATCH 44/50] drm/amd/display: Add visual confirm for Idle State

2024-07-10 Thread Fangzhi Zuo
From: Duncan Ma [Why] Visual Confirm would tell us if it ever entered idle state. [How] Add debug option for IPS visual confirm Reviewed-by: Ovidiu Bunea Signed-off-by: Jerry Zuo Signed-off-by: Duncan Ma --- drivers/gpu/drm/amd/display/dc/dc.h | 1 + drivers/gpu/drm/amd/display

[PATCH 42/50] drm/amd/display: Check stream pointer is initialized before accessing

2024-07-10 Thread Fangzhi Zuo
From: Sung Joon Kim [why & how] We calculate static screen wait frames based on the current timing info in the active stream. If stream is not initialized, then we should skip the calculation and go with the default values. Reviewed-by: Gabe Teeger Signed-off-by: Jerry Zuo Signed-off-by: Sung

[PATCH 39/50] drm/amd/display: add dmcub support check

2024-07-10 Thread Fangzhi Zuo
From: Fudongwang [Why & How] For DCN harvest case, if there is no dmcub support, we should return false to avoid bugcheck later. Reviewed-by: Aric Cyr Signed-off-by: Jerry Zuo Signed-off-by: Fudongwang --- drivers/gpu/drm/amd/display/dc/core/dc.c | 3 +++ 1 file changed, 3 insertions(+) dif

[PATCH 41/50] drm/amd/display: Export additional FAMS2 global configuration options from DML

2024-07-10 Thread Fangzhi Zuo
From: Dillon Varone [WHY&HOW] Some global configuration options were previously hardcoded in DC, now they are exported by DML and sent to FW. Reviewed-by: Martin Leung Signed-off-by: Jerry Zuo Signed-off-by: Dillon Varone --- .../gpu/drm/amd/display/dc/core/dc_state.c| 4 +- drivers/gp

[PATCH 40/50] drm/amd/display: Refactoring DWB related files from dcn30 Files

2024-07-10 Thread Fangzhi Zuo
From: Mudimela [Why] To refactor DWB related files from dcn30 Files [How] Moved DWB related files from dcn30 to specific DWB folder and updated Makefiles to fix Compilation. Reviewed-by: Martin Leung Signed-off-by: Jerry Zuo Signed-off-by: Mudimela --- drivers/gpu/drm/amd/display/dc/dcn30/M

[PATCH 38/50] drm/amd/display: Increase array size of dummy_boolean

2024-07-10 Thread Fangzhi Zuo
From: Alex Hung [WHY] dml2_core_shared_mode_support and dml_core_mode_support access the third element of dummy_boolean, i.e. hw_debug5 = &s->dummy_boolean[2], when dummy_boolean has size of 2. Any assignment to hw_debug5 causes an OVERRUN. [HOW] Increase dummy_boolean's array size to 3. This f

[PATCH 37/50] drm/amd/display: Check null pointers before multiple uses

2024-07-10 Thread Fangzhi Zuo
From: Alex Hung [WHAT & HOW] Poniters, such as stream_enc and dc->bw_vbios, are null checked previously in the same function, so Coverity warns "implies that stream_enc and dc->bw_vbios might be null". They are used multiple times in the subsequent code and need to be checked. This fixes 10 FORW

[PATCH 36/50] drm/amd/display: Check null pointers before used

2024-07-10 Thread Fangzhi Zuo
From: Alex Hung [WHAT & HOW] Poniters, such as dc->clk_mgr, are null checked previously in the same function, so Coverity warns "implies that "dc->clk_mgr" might be null". As a result, these pointers need to be checked when used again. This fixes 10 FORWARD_NULL issues reported by Coverity. Rev

[PATCH 35/50] drm/amd/display: Check link_res->hpo_dp_link_enc before using it

2024-07-10 Thread Fangzhi Zuo
From: Alex Hung [WHAT & HOW] Functions dp_enable_link_phy and dp_disable_link_phy can pass link_res without initializing hpo_dp_link_enc and it is necessary to check for null before dereferencing. This fixes 2 FORWARD_NULL issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Signed-off-b

[PATCH 33/50] drm/amd/display: remove dc dependencies from SPL library

2024-07-10 Thread Fangzhi Zuo
From: Samson Tam [Why] Make SPL library dc-independent so it can be reused by other components [How] Create separate set of fixed31_32 calls in SPL Make all inputs and outputs to SPL use primitive types For ratios and inits, return as uint32 from SPL. So add conversion from uint32 back to fix

[PATCH 31/50] drm/amd/display: Calculate ODM width using odm slice rect, not recout

2024-07-10 Thread Fangzhi Zuo
From: Alvin Lee [Description] There are scenarios where ODM4:1 is used but the surface is entirely outside of the first and last ODM slice. In this case the recout.width for the first and last slice is 0 because there's no overlap with the surface and that ODM slice, but this causes the x_pos for

[PATCH 32/50] drm/amd/display: Issue with 3 or more mcaches per surface

2024-07-10 Thread Fangzhi Zuo
From: Nevenko Stupar [Why & How] Current logic in mcache admissibility check has flaw if calculated number of maches are 3 or more per surface, so sometimes the check may pass when it should fail, and sometimes may fail when it should pass, fix the issue and also adding additional check to make s

[PATCH 34/50] drm/amd/display: Add P-State Keepout to dcn401 Global Sync

2024-07-10 Thread Fangzhi Zuo
From: Dillon Varone [WHY&HOW] OTG has new functionality to allow P-State relative to VStartup. Keepout region for this should be configured based on DML outputs same as other global sync params. Reviewed-by: Alvin Lee Signed-off-by: Jerry Zuo Signed-off-by: Dillon Varone --- .../dc/dce110/dc

[PATCH 30/50] drm/amd/display: Add blanked streams override to DML2.1

2024-07-10 Thread Fangzhi Zuo
From: Dillon Varone [WHY] DML2.1 currently has no concept of a "blanked" stream. For cases like DPMS off, things like UCLK p-state is always allowed, so PMO is not required to optimize for it. [HOW] Add flag to DML2.1 display configuration to indicate all streams are blanked, so certain operatio

[PATCH 29/50] drm/amd/display: Re-enable panel replay feature

2024-07-10 Thread Fangzhi Zuo
From: Tom Chung [Why & How] Fixed the replay issues and now re-enable the panel replay feature. Reported-by: Arthur Borsboom Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3344 Reviewed-by: Mario Limonciello Reviewed-by: Rodrigo Siqueira Signed-off-by: Jerry Zuo Signed-off-by: Tom

[PATCH 28/50] drm/amd/display: Fix VRR cannot enable

2024-07-10 Thread Fangzhi Zuo
From: Tom Chung [Why] Sometimes the VRR cannot enable after login to the desktop. User space may call the DRM_IOCTL_MODE_GETCONNECTOR right after the DRM_IOCTL_MODE_RMFB. After calling DRM_IOCTL_MODE_RMFB to remove all the frame buffer and it will cause the driver to disable the crtc and disabl

[PATCH 27/50] drm/amd/display: Refactoring MPC

2024-07-10 Thread Fangzhi Zuo
From: Mounika Adhuri [Why] To refactor MPC files [How] Moved MPC files to respective folders and updated makefiles appropriately. Reviewed-by: Martin Leung Signed-off-by: Jerry Zuo Signed-off-by: Mounika Adhuri --- drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 1 - drivers/gpu/drm/amd/di

[PATCH 25/50] drm/amd/display: Do 1-to-1 mapping between OPP and DSC in DML2

2024-07-10 Thread Fangzhi Zuo
From: Sung Joon Kim [why] To determine which block instance to power-gate, we look at the available pipe resource for both plane and stream. On MPO, DSC3 was falsely powered on even though only 1 stream path was enabled because the resource mapping was not done correctly. [how] Acquire the corre

[PATCH 24/50] drm/amd/display: Refactoring MMHUBBUB

2024-07-10 Thread Fangzhi Zuo
From: Revalla Hari Krishna [Why] To refactor MMHUBBUB files [How] Moved mmhubbub files from dcn20 to /mmhubbub/ folder and update makefile to fix compilation. Reviewed-by: Martin Leung Signed-off-by: Jerry Zuo Signed-off-by: Revalla Hari Krishna --- drivers/gpu/drm/amd/display/dc/dcn20/Make

  1   2   3   >